45539 2010-09-10 07:40:39 -0700 [Qt] selected text gets deleted when qgraphicswebview losts focus 2010-09-16 10:26:06 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 0 max.hong.shen webkit-unassigned abarth ademar commit-queue robert suresh.voruganti oldest_to_newest 277183 0 max.hong.shen 2010-09-10 07:40:39 -0700 Precondition: using qgraphicswebview Steps to reproduce: 1. open a page that has a textarea field, and type some characters in that field (e.g. I typed "abcdefg" in the textarea) 2. use your mouse to select (highlight) some words (characters) (e.g. I selected "defg") 3. click on other qgraphics ui component (e.g. url bar) which removes the focus from qgraphicswebview Actual Result: All the selected/highlight words (characters) get deleted (e.g. the "defg" get deleted and only "abcd" left in the textarea) Reason: When focus changed, qgraphicssence sends out an inputmethodevent with empty preedit string and empty QInputMethodEvent::Attribute to qgrapchiswebview, which finally be delivered to the QWebPage::inputMethodEvent(QInputMethodEvent *ev). And eventually, an empty preedit string is passed to WebCore::Editor::setComposition(...) which deletes all the selected text. Fix proposal: Check the preedit string before passing it to the WebCore::Editor::setComposition. 277189 1 67183 max.hong.shen 2010-09-10 08:01:22 -0700 Created attachment 67183 proposal fix 277229 2 67183 kling 2010-09-10 09:01:53 -0700 Comment on attachment 67183 proposal fix > + if (!ev->preeditString().isEmpty()) Should be "if (!preedit.isEmpty())" Change looks reasonable, but it needs an autotest (see WebKit/qt/tests/) 277233 3 max.hong.shen 2010-09-10 09:05:10 -0700 yes, you are right. Thanks for reviewing, I will change it. (In reply to comment #2) > (From update of attachment 67183 [details]) > > + if (!ev->preeditString().isEmpty()) > > Should be "if (!preedit.isEmpty())" > > Change looks reasonable, but it needs an autotest (see WebKit/qt/tests/) 277422 4 67236 max.hong.shen 2010-09-10 14:15:50 -0700 Created attachment 67236 patch with test case 277679 5 67236 commit-queue 2010-09-11 00:07:33 -0700 Comment on attachment 67236 patch with test case Clearing flags on attachment: 67236 Committed r67289: <http://trac.webkit.org/changeset/67289> 277680 6 commit-queue 2010-09-11 00:07:37 -0700 All reviewed patches have been landed. Closing bug. 280152 7 suresh.voruganti 2010-09-16 09:43:32 -0700 Ademar, can you cherry pick the fix for QtWebkit 2.1? This fix is required for implementation of some features from browser team. 280184 8 ademar 2010-09-16 10:20:21 -0700 Revision r67289 cherry-picked into qtwebkit-2.1 with commit 50c6993 <http://gitorious.org/webkit/qtwebkit/commit/50c6993> 280190 9 ademar 2010-09-16 10:26:06 -0700 Actually last comment should be: Revision r67289 cherry-picked into qtwebkit-2.1 with commit b422ce0 <http://gitorious.org/webkit/qtwebkit/commit/b422ce0> 67183 2010-09-10 08:01:22 -0700 2010-09-10 14:15:50 -0700 proposal fix 45539.patch text/plain 1203 max.hong.shen SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNjcxOTkpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDktMTAgIHlpIHNoZW4gIDx5aS40LnNoZW5Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gc2VsZWN0ZWQgdGV4dCBnZXRzIGRlbGV0ZWQgd2hlbiBxZ3JhcGhpY3N3ZWJ2aWV3IGxv c3RzIGZvY3VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00NTUzOQorCisgICAgICAgICogQXBpL3F3ZWJwYWdlLmNwcDoKKyAgICAgICAgKFFXZWJQYWdl UHJpdmF0ZTo6aW5wdXRNZXRob2RFdmVudCk6CisKIDIwMTAtMDktMDggIERhcmluIEFkbGVyICA8 ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4 OiBXZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvQXBp L3F3ZWJwYWdlLmNwcAkocmV2aXNpb24gNjcxOTQpCisrKyBXZWJLaXQvcXQvQXBpL3F3ZWJwYWdl LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTIwMSw3ICsxMjAxLDggQEAgdm9pZCBRV2ViUGFnZVBy aXZhdGU6OmlucHV0TWV0aG9kRXZlbnQoUQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAoc2VsZWN0aW9uLmxlbmd0aCA8IDApID8gc2VsZWN0aW9uLnN0YXJ0IDogc2VsZWN0aW9u LnN0YXJ0ICsgc2VsZWN0aW9uLmxlbmd0aCk7CiAgICAgICAgIH0gZWxzZQogI2VuZGlmCi0gICAg ICAgICAgICBlZGl0b3ItPnNldENvbXBvc2l0aW9uKHByZWVkaXQsIHVuZGVybGluZXMsIHByZWVk aXQubGVuZ3RoKCksIDApOworICAgICAgICAgICAgaWYgKCFldi0+cHJlZWRpdFN0cmluZygpLmlz RW1wdHkoKSkKKyAgICAgICAgICAgICAgICBlZGl0b3ItPnNldENvbXBvc2l0aW9uKHByZWVkaXQs IHVuZGVybGluZXMsIHByZWVkaXQubGVuZ3RoKCksIDApOwogICAgIH0KIAogICAgIGV2LT5hY2Nl cHQoKTsK 67236 2010-09-10 14:15:50 -0700 2010-09-11 00:07:33 -0700 patch with test case 45539.patch text/plain 2454 max.hong.shen SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNjcyMzEpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDktMTAgIHlpIHNoZW4gIDx5aS40LnNoZW5Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gc2VsZWN0ZWQgdGV4dCBnZXRzIGRlbGV0ZWQgd2hlbiBxZ3JhcGhpY3N3ZWJ2aWV3IGxv c3RzIGZvY3VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00NTUzOQorCisgICAgICAgICogQXBpL3F3ZWJwYWdlLmNwcDoKKyAgICAgICAgKFFXZWJQYWdl UHJpdmF0ZTo6aW5wdXRNZXRob2RFdmVudCk6CisgICAgICAgICogdGVzdHMvcXdlYnBhZ2UvdHN0 X3F3ZWJwYWdlLmNwcDoKKyAgICAgICAgKHRzdF9RV2ViUGFnZTo6aW5wdXRNZXRob2RzKToKKwog MjAxMC0wOS0xMCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAJKHJldmlzaW9uIDY3MjIz KQorKysgV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyMDEs NyArMTIwMSw4IEBAIHZvaWQgUVdlYlBhZ2VQcml2YXRlOjppbnB1dE1ldGhvZEV2ZW50KFEKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHNlbGVjdGlvbi5sZW5ndGggPCAwKSA/ IHNlbGVjdGlvbi5zdGFydCA6IHNlbGVjdGlvbi5zdGFydCArIHNlbGVjdGlvbi5sZW5ndGgpOwog ICAgICAgICB9IGVsc2UKICNlbmRpZgotICAgICAgICAgICAgZWRpdG9yLT5zZXRDb21wb3NpdGlv bihwcmVlZGl0LCB1bmRlcmxpbmVzLCBwcmVlZGl0Lmxlbmd0aCgpLCAwKTsKKyAgICAgICAgICAg IGlmICghcHJlZWRpdC5pc0VtcHR5KCkpCisgICAgICAgICAgICAgICAgZWRpdG9yLT5zZXRDb21w b3NpdGlvbihwcmVlZGl0LCB1bmRlcmxpbmVzLCBwcmVlZGl0Lmxlbmd0aCgpLCAwKTsKICAgICB9 CiAKICAgICBldi0+YWNjZXB0KCk7CkluZGV4OiBXZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0 X3F3ZWJwYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0 X3F3ZWJwYWdlLmNwcAkocmV2aXNpb24gNjcyMjMpCisrKyBXZWJLaXQvcXQvdGVzdHMvcXdlYnBh Z2UvdHN0X3F3ZWJwYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTY2MSw2ICsxNjYxLDIyIEBA IHZvaWQgdHN0X1FXZWJQYWdlOjppbnB1dE1ldGhvZHMoKQogICAgIFFWRVJJRlkoIXZpZXdFdmVu dFNweS5jb250YWlucyhRRXZlbnQ6OlJlcXVlc3RTb2Z0d2FyZUlucHV0UGFuZWwpKTsKICNlbmRp ZgogCisjaWYgUVRfVkVSU0lPTiA+PSAweDA0MDYwMAorICAgIC8vU1RBUlQgLSBUZXN0IGZvciBz ZW5kaW5nIGVtcHR5IFFJbnB1dE1ldGhvZEV2ZW50CisgICAgcGFnZS0+bWFpbkZyYW1lKCktPnNl dEh0bWwoIjxodG1sPjxib2R5PiIgXAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAiPGlucHV0IHR5cGU9J3RleHQnIGlkPSdpbnB1dDMnIHZhbHVlPSdRdFdlYktp dDInLz4iIFwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIjwv Ym9keT48L2h0bWw+Iik7CisgICAgcGFnZS0+bWFpbkZyYW1lKCktPmV2YWx1YXRlSmF2YVNjcmlw dCgidmFyIGlucHV0RWxlID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2lucHV0MycpOyBpbnB1 dEVsZS5mb2N1cygpOyBpbnB1dEVsZS5zZWxlY3QoKTsiKTsKKworICAgIC8vU2VuZCBlbXB0eSBR SW5wdXRNZXRob2RFdmVudAorICAgIFFJbnB1dE1ldGhvZEV2ZW50IGVtcHR5RXZlbnQ7CisgICAg cGFnZS0+ZXZlbnQoJmVtcHR5RXZlbnQpOworCisgICAgUVN0cmluZyBpbnB1dFZhbHVlID0gcGFn ZS0+bWFpbkZyYW1lKCktPmV2YWx1YXRlSmF2YVNjcmlwdCgiZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ2lucHV0MycpLnZhbHVlIikudG9TdHJpbmcoKTsKKyAgICBRQ09NUEFSRShpbnB1dFZhbHVl LCBRU3RyaW5nKCJRdFdlYktpdDIiKSk7CisgICAgLy9FTkQgLSBUZXN0IGZvciBzZW5kaW5nIGVt cHR5IFFJbnB1dE1ldGhvZEV2ZW50CisjZW5kaWYKKwogICAgIGRlbGV0ZSBjb250YWluZXI7CiB9 CiAK