45538 2010-09-10 06:35:05 -0700 [GTK] Fix warnings because of bad assignments in testatk.c 2010-09-10 20:17:21 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 mario webkit-unassigned abarth commit-queue eric webkit.review.bot xan.lopez oldest_to_newest 277160 0 mario 2010-09-10 06:35:05 -0700 In testatk.c in testWebkitAtkListsOfItems, there are several places where AtkObject instances are expected and AtkText instances are passed instead, and viceversa, resulting in warning messages during compilation: ../../WebKit/gtk/tests/testatk.c: In function ‘testWebkitAtkListsOfItems’: ../../WebKit/gtk/tests/testatk.c:879: warning: assignment from incompatible pointer type ../../WebKit/gtk/tests/testatk.c:880: warning: assignment from incompatible pointer type ../../WebKit/gtk/tests/testatk.c:881: warning: assignment from incompatible pointer type ../../WebKit/gtk/tests/testatk.c:887: warning: passing argument 1 of ‘atk_text_get_text’ from incompatible pointer type /opt/gnome2/include/atk-1.0/atk/atktext.h:291: note: expected ‘struct AtkText *’ but argument is of type ‘struct AtkObject *’ ../../WebKit/gtk/tests/testatk.c:888: warning: passing argument 1 of ‘atk_text_get_text’ from incompatible pointer type /opt/gnome2/include/atk-1.0/atk/atktext.h:291: note: expected ‘struct AtkText *’ but argument is of type ‘struct AtkObject *’ ../../WebKit/gtk/tests/testatk.c:889: warning: passing argument 1 of ‘atk_text_get_text’ from incompatible pointer type /opt/gnome2/include/atk-1.0/atk/atktext.h:291: note: expected ‘struct AtkText *’ but argument is of type ‘struct AtkObject *’ ../../WebKit/gtk/tests/testatk.c:902: warning: assignment from incompatible pointer type ../../WebKit/gtk/tests/testatk.c:903: warning: assignment from incompatible pointer type ../../WebKit/gtk/tests/testatk.c:904: warning: assignment from incompatible pointer type ../../WebKit/gtk/tests/testatk.c:906: warning: passing argument 1 of ‘atk_text_get_text’ from incompatible pointer type /opt/gnome2/include/atk-1.0/atk/atktext.h:291: note: expected ‘struct AtkText *’ but argument is of type ‘struct AtkObject *’ ../../WebKit/gtk/tests/testatk.c:907: warning: passing argument 1 of ‘atk_text_get_text’ from incompatible pointer type /opt/gnome2/include/atk-1.0/atk/atktext.h:291: note: expected ‘struct AtkText *’ but argument is of type ‘struct AtkObject *’ ../../WebKit/gtk/tests/testatk.c:908: warning: passing argument 1 of ‘atk_text_get_text’ from incompatible pointer type /opt/gnome2/include/atk-1.0/atk/atktext.h:291: note: expected ‘struct AtkText *’ but argument is of type ‘struct AtkObject *’ Attaching a patch to fix all these issues in brief... 277163 1 67177 mario 2010-09-10 06:44:01 -0700 Created attachment 67177 Patch This simple patch will fix those evil warnings 277618 2 67177 commit-queue 2010-09-10 19:48:05 -0700 Comment on attachment 67177 Patch Clearing flags on attachment: 67177 Committed r67270: <http://trac.webkit.org/changeset/67270> 277619 3 commit-queue 2010-09-10 19:48:09 -0700 All reviewed patches have been landed. Closing bug. 277621 4 webkit.review.bot 2010-09-10 20:17:21 -0700 http://trac.webkit.org/changeset/67270 might have broken GTK Linux 32-bit Release 67177 2010-09-10 06:44:01 -0700 2010-09-10 19:48:04 -0700 Patch 0001-2010-09-10-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 4086 mario RnJvbSBkMTVjMmJhY2E2OWQzYjYxNDljNThkMjY2ZWI4ZDU3NWYwY2Q5NjYyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBGcmksIDEwIFNlcCAyMDEwIDE1OjQwOjUwICswMjAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMC0wOS0xMCAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBbR1RLXSBGaXgg d2FybmluZ3MgYmVjYXVzZSBvZiBiYWQgYXNzaWdubWVudHMgaW4gdGVzdGF0ay5jCiAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1NTM4CgogICAgICAgIFVz ZSBBdGtPYmplY3QgYW5kIEF0a1RleHQgaW5zdGFuY2VzIHByb3Blcmx5IGluIHRoZSBjb2RlLgoK ICAgICAgICAqIHRlc3RzL3Rlc3RhdGsuYzoKICAgICAgICAodGVzdFdlYmtpdEF0a0xpc3RzT2ZJ dGVtcyk6Ci0tLQogV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgfCAgIDEyICsrKysrKysrKysr KwogV2ViS2l0L2d0ay90ZXN0cy90ZXN0YXRrLmMgfCAgIDI0ICsrKysrKysrKysrKy0tLS0tLS0t LS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9n CmluZGV4IGM3OThiMDIuLmRmMDBkMWUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDktMTAg IE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEZpeCB3YXJuaW5ncyBi ZWNhdXNlIG9mIGJhZCBhc3NpZ25tZW50cyBpbiB0ZXN0YXRrLmMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1NTM4CisKKyAgICAgICAgVXNlIEF0a09i amVjdCBhbmQgQXRrVGV4dCBpbnN0YW5jZXMgcHJvcGVybHkgaW4gdGhlIGNvZGUuCisKKyAgICAg ICAgKiB0ZXN0cy90ZXN0YXRrLmM6CisgICAgICAgICh0ZXN0V2Via2l0QXRrTGlzdHNPZkl0ZW1z KToKKwogMjAxMC0wOS0wOCAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEv V2ViS2l0L2d0ay90ZXN0cy90ZXN0YXRrLmMgYi9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RhdGsuYwpp bmRleCA5OTMwYmMyLi5kYmU4OGIwIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3Rh dGsuYworKysgYi9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RhdGsuYwpAQCAtODc2LDE3ICs4NzYsMTcg QEAgc3RhdGljIHZvaWQgdGVzdFdlYmtpdEF0a0xpc3RzT2ZJdGVtcyh2b2lkKQogICAgIGdfYXNz ZXJ0KGF0a19vYmplY3RfZ2V0X3JvbGUodUxpc3QpID09IEFUS19ST0xFX0xJU1QpOwogICAgIGdf YXNzZXJ0X2NtcGludChhdGtfb2JqZWN0X2dldF9uX2FjY2Vzc2libGVfY2hpbGRyZW4odUxpc3Qp LCA9PSwgMyk7CiAKLSAgICBpdGVtMSA9IEFUS19URVhUKGF0a19vYmplY3RfcmVmX2FjY2Vzc2li bGVfY2hpbGQodUxpc3QsIDApKTsKLSAgICBpdGVtMiA9IEFUS19URVhUKGF0a19vYmplY3RfcmVm X2FjY2Vzc2libGVfY2hpbGQodUxpc3QsIDEpKTsKLSAgICBpdGVtMyA9IEFUS19URVhUKGF0a19v YmplY3RfcmVmX2FjY2Vzc2libGVfY2hpbGQodUxpc3QsIDIpKTsKKyAgICBpdGVtMSA9IGF0a19v YmplY3RfcmVmX2FjY2Vzc2libGVfY2hpbGQodUxpc3QsIDApOworICAgIGl0ZW0yID0gYXRrX29i amVjdF9yZWZfYWNjZXNzaWJsZV9jaGlsZCh1TGlzdCwgMSk7CisgICAgaXRlbTMgPSBhdGtfb2Jq ZWN0X3JlZl9hY2Nlc3NpYmxlX2NoaWxkKHVMaXN0LCAyKTsKIAogICAgIGdfYXNzZXJ0X2NtcGlu dChhdGtfb2JqZWN0X2dldF9uX2FjY2Vzc2libGVfY2hpbGRyZW4oaXRlbTEpLCA9PSwgMCk7CiAg ICAgZ19hc3NlcnRfY21waW50KGF0a19vYmplY3RfZ2V0X25fYWNjZXNzaWJsZV9jaGlsZHJlbihp dGVtMiksID09LCAxKTsKICAgICBnX2Fzc2VydF9jbXBpbnQoYXRrX29iamVjdF9nZXRfbl9hY2Nl c3NpYmxlX2NoaWxkcmVuKGl0ZW0zKSwgPT0sIDEpOwogCi0gICAgZ19hc3NlcnRfY21wc3RyKGF0 a190ZXh0X2dldF90ZXh0KGl0ZW0xLCAwLCAtMSksID09LCAiXDM0MlwyMDBcMjQyIHRleHQgb25s eSIpOwotICAgIGdfYXNzZXJ0X2NtcHN0cihhdGtfdGV4dF9nZXRfdGV4dChpdGVtMiwgMCwgLTEp LCA9PSwgIlwzNDJcMjAwXDI0MiBsaW5rIG9ubHkiKTsKLSAgICBnX2Fzc2VydF9jbXBzdHIoYXRr X3RleHRfZ2V0X3RleHQoaXRlbTMsIDAsIC0xKSwgPT0sICJcMzQyXDIwMFwyNDIgdGV4dCBhbmQg YSBsaW5rIik7CisgICAgZ19hc3NlcnRfY21wc3RyKGF0a190ZXh0X2dldF90ZXh0KEFUS19URVhU KGl0ZW0xKSwgMCwgLTEpLCA9PSwgIlwzNDJcMjAwXDI0MiB0ZXh0IG9ubHkiKTsKKyAgICBnX2Fz c2VydF9jbXBzdHIoYXRrX3RleHRfZ2V0X3RleHQoQVRLX1RFWFQoaXRlbTIpLCAwLCAtMSksID09 LCAiXDM0MlwyMDBcMjQyIGxpbmsgb25seSIpOworICAgIGdfYXNzZXJ0X2NtcHN0cihhdGtfdGV4 dF9nZXRfdGV4dChBVEtfVEVYVChpdGVtMyksIDAsIC0xKSwgPT0sICJcMzQyXDIwMFwyNDIgdGV4 dCBhbmQgYSBsaW5rIik7CiAKICAgICBnX29iamVjdF91bnJlZihpdGVtMSk7CiAgICAgZ19vYmpl Y3RfdW5yZWYoaXRlbTIpOwpAQCAtODk5LDEzICs4OTksMTMgQEAgc3RhdGljIHZvaWQgdGVzdFdl YmtpdEF0a0xpc3RzT2ZJdGVtcyh2b2lkKQogICAgIGdfYXNzZXJ0KGF0a19vYmplY3RfZ2V0X3Jv bGUob0xpc3QpID09IEFUS19ST0xFX0xJU1QpOwogICAgIGdfYXNzZXJ0X2NtcGludChhdGtfb2Jq ZWN0X2dldF9uX2FjY2Vzc2libGVfY2hpbGRyZW4ob0xpc3QpLCA9PSwgMyk7CiAKLSAgICBpdGVt MSA9IEFUS19URVhUKGF0a19vYmplY3RfcmVmX2FjY2Vzc2libGVfY2hpbGQob0xpc3QsIDApKTsK LSAgICBpdGVtMiA9IEFUS19URVhUKGF0a19vYmplY3RfcmVmX2FjY2Vzc2libGVfY2hpbGQob0xp c3QsIDEpKTsKLSAgICBpdGVtMyA9IEFUS19URVhUKGF0a19vYmplY3RfcmVmX2FjY2Vzc2libGVf Y2hpbGQob0xpc3QsIDIpKTsKKyAgICBpdGVtMSA9IGF0a19vYmplY3RfcmVmX2FjY2Vzc2libGVf Y2hpbGQob0xpc3QsIDApOworICAgIGl0ZW0yID0gYXRrX29iamVjdF9yZWZfYWNjZXNzaWJsZV9j aGlsZChvTGlzdCwgMSk7CisgICAgaXRlbTMgPSBhdGtfb2JqZWN0X3JlZl9hY2Nlc3NpYmxlX2No aWxkKG9MaXN0LCAyKTsKIAotICAgIGdfYXNzZXJ0X2NtcHN0cihhdGtfdGV4dF9nZXRfdGV4dChp dGVtMSwgMCwgLTEpLCA9PSwgIjEgdGV4dCBvbmx5Iik7Ci0gICAgZ19hc3NlcnRfY21wc3RyKGF0 a190ZXh0X2dldF90ZXh0KGl0ZW0yLCAwLCAtMSksID09LCAiMiBsaW5rIG9ubHkiKTsKLSAgICBn X2Fzc2VydF9jbXBzdHIoYXRrX3RleHRfZ2V0X3RleHQoaXRlbTMsIDAsIC0xKSwgPT0sICIzIHRl eHQgYW5kIGEgbGluayIpOworICAgIGdfYXNzZXJ0X2NtcHN0cihhdGtfdGV4dF9nZXRfdGV4dChB VEtfVEVYVChpdGVtMSksIDAsIC0xKSwgPT0sICIxIHRleHQgb25seSIpOworICAgIGdfYXNzZXJ0 X2NtcHN0cihhdGtfdGV4dF9nZXRfdGV4dChBVEtfVEVYVChpdGVtMiksIDAsIC0xKSwgPT0sICIy IGxpbmsgb25seSIpOworICAgIGdfYXNzZXJ0X2NtcHN0cihhdGtfdGV4dF9nZXRfdGV4dChBVEtf VEVYVChpdGVtMyksIDAsIC0xKSwgPT0sICIzIHRleHQgYW5kIGEgbGluayIpOwogCiAgICAgZ19h c3NlcnRfY21waW50KGF0a19vYmplY3RfZ2V0X25fYWNjZXNzaWJsZV9jaGlsZHJlbihpdGVtMSks ID09LCAwKTsKICAgICBnX2Fzc2VydF9jbXBpbnQoYXRrX29iamVjdF9nZXRfbl9hY2Nlc3NpYmxl X2NoaWxkcmVuKGl0ZW0yKSwgPT0sIDEpOwotLSAKMS43LjAuNAoK