45536 2010-09-10 06:00:35 -0700 [Qt] MiniBrowser crashes with multiply windows when closing one of them 2010-09-10 18:57:19 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 kbalazs webkit-unassigned commit-queue oldest_to_newest 277153 0 kbalazs 2010-09-10 06:00:35 -0700 It seems to be that we had taken the wrong assumption that there are only one window with one page, therefore there are two ownership related problem that breaks MiniBrowser when there are multiply windows and the user closing one of them. 277158 1 67175 kbalazs 2010-09-10 06:28:04 -0700 Created attachment 67175 proposed patch 277245 2 67175 kling 2010-09-10 09:24:21 -0700 Comment on attachment 67175 proposed patch LGTM 277597 3 67175 commit-queue 2010-09-10 18:57:14 -0700 Comment on attachment 67175 proposed patch Clearing flags on attachment: 67175 Committed r67266: <http://trac.webkit.org/changeset/67266> 277598 4 commit-queue 2010-09-10 18:57:19 -0700 All reviewed patches have been landed. Closing bug. 67175 2010-09-10 06:28:04 -0700 2010-09-10 18:57:14 -0700 proposed patch land_fix_mult_views.diff text/plain 2442 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg MzJmMzU5OC4uZDBjMTM2ZCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0xMCAgQmFsYXpzIEtlbGVt ZW4gIDxrYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1F0XSBNaW5pQnJvd3NlciBjcmFzaGVzIHdpdGggbXVsdGlwbHkg d2luZG93cyB3aGVuIGNsb3Npbmcgb25lIG9mIHRoZW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1NTM2CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L3F0L3F3a3BhZ2UuY3BwOgorICAgICAgICAoUVdLUGFnZTo6flFXS1BhZ2UpOiBEbyBub3QgY2Fs bCBXS1BhZ2VUZXJtaW5hdGUgc2luY2UgdGhpcyBpcyBkZXNpZ25lZAorICAgICAgICB0byB0ZXJt aW5hdGUgdGhlIHdlYiBwcm9jZXNzLiBXZSBhcmUgY29ycmVjdGx5IGRldGFjaGluZyB0aGUgcGFn ZSB3aXRob3V0CisgICAgICAgIHRoaXMgY2FsbCBhbnl3YXkuCisKIDIwMTAtMDktMDkgIEJhbGF6 cyBLZWxlbWVuICA8a2JAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3Bh Z2UuY3BwIGIvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuY3BwCmluZGV4IDdkN2Rh YmUuLmM3MmMyNjcgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdl LmNwcAorKysgYi9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAKQEAgLTI2Niw3 ICsyNjYsNiBAQCBRV0tQYWdlOjpRV0tQYWdlKFdLUGFnZU5hbWVzcGFjZVJlZiBuYW1lc3BhY2VS ZWYpCiBRV0tQYWdlOjp+UVdLUGFnZSgpCiB7CiAgICAgZGVsZXRlIGQ7Ci0gICAgV0tQYWdlVGVy bWluYXRlKHBhZ2VSZWYoKSk7CiB9CiAKIHZvaWQgUVdLUGFnZTo6dGltZXJFdmVudChRVGltZXJF dmVudCogZXYpCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKaW5kZXggMmM4NmJkOS4uZjhhODQwZiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9v bHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBA CisyMDEwLTA5LTEwICBCYWxhenMgS2VsZW1lbiAgPGtiQGluZi51LXN6ZWdlZC5odT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIE1pbmlCcm93 c2VyIGNyYXNoZXMgd2l0aCBtdWx0aXBseSB3aW5kb3dzIHdoZW4gY2xvc2luZyBvbmUgb2YgdGhl bQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU1MzYK KworICAgICAgICAqIE1pbmlCcm93c2VyL3F0L0Jyb3dzZXJWaWV3LmNwcDoKKyAgICAgICAgKEJy b3dzZXJWaWV3OjpCcm93c2VyVmlldyk6IFJlZmVyZW5jZSB0aGUgY29udGV4dCBpbnN0ZWFkIG9m IGFkb3B0aW5nIGl0CisgICAgICAgIGJlY2F1c2UgaXQgY2FuIGJlIHNoYXJlZCBhY3Jvc3MgZGlm ZmVyZW50IHZpZXdzLgorCiAyMDEwLTA5LTA5ICBCYWxhenMgS2VsZW1lbiAgPGtiQGluZi51LXN6 ZWdlZC5odT4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdp dCBhL1dlYktpdFRvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJWaWV3LmNwcCBiL1dlYktpdFRv b2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJWaWV3LmNwcAppbmRleCBhNWUwNmVjLi5jZTEwMWMy IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyVmlldy5jcHAK KysrIGIvV2ViS2l0VG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlclZpZXcuY3BwCkBAIC0zOSw5 ICszOSw4IEBAIHN0YXRpYyBRV0tQYWdlKiBjcmVhdGVOZXdQYWdlKFFXS1BhZ2UqIHBhZ2UpCiBC cm93c2VyVmlldzo6QnJvd3NlclZpZXcoUVdpZGdldCogcGFyZW50KQogICAgIDogUUdyYXBoaWNz VmlldyhwYXJlbnQpCiAgICAgLCBtX2l0ZW0oMCkKKyAgICAsIG1fY29udGV4dChXS0NvbnRleHRH ZXRTaGFyZWRQcm9jZXNzQ29udGV4dCgpKQogewotICAgIG1fY29udGV4dC5hZG9wdChXS0NvbnRl eHRHZXRTaGFyZWRQcm9jZXNzQ29udGV4dCgpKTsKLQogICAgIFdLUmV0YWluUHRyPFdLUGFnZU5h bWVzcGFjZVJlZj4gcGFnZU5hbWVzcGFjZShBZG9wdFdLLCBXS1BhZ2VOYW1lc3BhY2VDcmVhdGUo bV9jb250ZXh0LmdldCgpKSk7CiAKICAgICBtX2l0ZW0gPSBuZXcgUUdyYXBoaWNzV0tWaWV3KHBh Z2VOYW1lc3BhY2UuZ2V0KCksIFFHcmFwaGljc1dLVmlldzo6U2ltcGxlLCAwKTsK