45517 2010-09-09 20:01:44 -0700 [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h 2010-09-12 21:21:43 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 36641 1 tkent tkent dglazkov tony webkit.review.bot oldest_to_newest 276965 0 tkent 2010-09-09 20:01:44 -0700 [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h 276968 1 67146 tkent 2010-09-09 20:06:14 -0700 Created attachment 67146 Patch 276971 2 webkit.review.bot 2010-09-09 20:09:10 -0700 Attachment 67146 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp:39: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 277263 3 67146 tony 2010-09-10 09:49:55 -0700 Comment on attachment 67146 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67146&action=prettypatch > WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp:40 > +#include "webkit/support/webkit_support_gfx.h" > #include <algorithm> Is the style checker just complaining about not including ImageDiff.h? Seems fine to ignore. 277957 4 tkent 2010-09-12 21:20:22 -0700 (In reply to comment #3) > > WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp:40 > > +#include "webkit/support/webkit_support_gfx.h" > > #include <algorithm> > Is the style checker just complaining about not including ImageDiff.h? Seems fine to ignore. Yes. It's ignorable. 277959 5 67146 tkent 2010-09-12 21:21:35 -0700 Comment on attachment 67146 Patch Clearing flags on attachment: 67146 Committed r67363: <http://trac.webkit.org/changeset/67363> 277960 6 tkent 2010-09-12 21:21:43 -0700 All reviewed patches have been landed. Closing bug. 67146 2010-09-09 20:06:14 -0700 2010-09-12 21:21:35 -0700 Patch bug-45517-20100910120612.patch text/plain 6322 tkent ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGU5ZjYzNTRiOGQ5OGE1ZGJkNTdkOTJmNjA3NWUyYWM2MDQ2MGY4ZjYu LmIxODRkZWU3OWVkNDBiMjZlMGMzYjJiZjJlNGM2YTlmN2Y1NDBjODMgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDEwLTA5LTA5ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb RFJUL0Nocm9taXVtXSBSZW1vdmUgZGVwZW5kZW5jeSB0byBiYXNlL3N0cmluZzE2LmggYW5kIGdm eC9jb2RlYy9wbmdfY29kZWMuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDU1MTcKKworICAgICAgICAqIERFUFM6IFJvbGwgQ2hyb21pdW0gcmV2aXNp b24gdG8gcjU5MDMzIHRvIGhhdmUgd2Via2l0X3N1cHBvcnRfZ2Z4LmguCisgICAgICAgICogV2Vi S2l0Lmd5cDoKKwogMjAxMC0wOS0wOCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJv bWl1bS9ERVBTIGIvV2ViS2l0L2Nocm9taXVtL0RFUFMKaW5kZXggMmZjMjE4YmQ0ZmRkOWI5Nzhl ODc1NjUwYWM5ZWNiMzMyZGM4ZTcwOS4uMzNiYjliMjQwZjcyZjA1ZGU4M2MwOWI4MDg0Y2U2NTA2 YjFhNDI0ZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL0RFUFMKKysrIGIvV2ViS2l0L2No cm9taXVtL0RFUFMKQEAgLTMyLDcgKzMyLDcgQEAKIAogdmFycyA9IHsKICAgJ2Nocm9taXVtX3N2 bic6ICdodHRwOi8vc3JjLmNocm9taXVtLm9yZy9zdm4vdHJ1bmsvc3JjJywKLSAgJ2Nocm9taXVt X3Jldic6ICc1ODI3NycsCisgICdjaHJvbWl1bV9yZXYnOiAnNTkwMzMnLAogfQogCiBkZXBzID0g ewpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAgYi9XZWJLaXQvY2hyb21p dW0vV2ViS2l0Lmd5cAppbmRleCAxMTI0NmZhMTUxZmM4YTc5MWVhYzUwMmUyNTdiNTcxNmU4MTQ0 NjIyLi4wMzJlN2JmNzY5NDMwMDE0MDNkNjdjNGM2ZmRhYTY0Njc1ZWY1ZTc2IDEwMDY0NAotLS0g YS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cAorKysgYi9XZWJLaXQvY2hyb21pdW0vV2ViS2l0 Lmd5cApAQCAtNzgxLDcgKzc4MSw3IEBACiAgICAgICAgICAgICAnZGVwZW5kZW5jaWVzJzogWwog ICAgICAgICAgICAgICAgICd3ZWJraXQnLAogICAgICAgICAgICAgICAgICcuLi8uLi9KYXZhU2Ny aXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5neXAvSmF2YVNjcmlwdENvcmUuZ3lwOnd0ZicsCi0gICAg ICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvZ2Z4L2dmeC5neXA6Z2Z4JywKKyAgICAg ICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS93ZWJraXQvc3VwcG9ydC93ZWJraXRfc3Vw cG9ydC5neXA6d2Via2l0X3N1cHBvcnQnLAogICAgICAgICAgICAgXSwKICAgICAgICAgICAgICdp bmNsdWRlX2RpcnMnOiBbCiAgICAgICAgICAgICAgICAgJy4uLy4uL0phdmFTY3JpcHRDb3JlJywK ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlNGZlODE5ZmQ0OTc2OGNmMGVjZTUzMWVjMjY2NWJhM2M0YTY3OWMzLi44MWNkMTc4 NDU2MGEzYWUxZjc5Zjc5ZTkxZTZiZDQ5YjllMzM5NGY1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTAtMDktMDkgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtEUlQvQ2hyb21pdW1dIFJl bW92ZSBkZXBlbmRlbmN5IHRvIGJhc2Uvc3RyaW5nMTYuaCBhbmQgZ2Z4L2NvZGVjL3BuZ19jb2Rl Yy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTUx NworCisgICAgICAgIFVzZSB3ZWJraXRfc3VwcG9ydF9nZnguaCBmb3IgUE5HIGVuY29kaW5nL2Rl Y29kaW5nIGluc3RlYWQgb2YgcG5nX2NvZGVjLmgKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVl L2Nocm9taXVtL0ltYWdlRGlmZi5jcHA6CisgICAgICAgIChJbWFnZTo6Y3JhZXRlRnJvbVN0ZGlu KToKKyAgICAgICAgKEltYWdlOjpjcmVhdGVGcm9tRmlsZW5hbWUpOgorICAgICAgICAoZGlmZklt YWdlcyk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmNwcDoK KyAgICAgICAgKFRlc3RTaGVsbDo6ZHVtcEltYWdlKToKKwogMjAxMC0wOS0wOSAgU2hlcmlmZiBC b3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg cm9sbGluZyBvdXQgcjY3MTE5LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRy ZWUvY2hyb21pdW0vSW1hZ2VEaWZmLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2No cm9taXVtL0ltYWdlRGlmZi5jcHAKaW5kZXggZDFhZGMzZGVkZGM0YmIxMGE0NDA4ZWJiZDdhNzZh ZWI0ZTllNzZmYi4uZjI4NzVkZDk5YmZmMDE4MTFjYzk4NTIzM2M0OTAzM2ZjNWVkYjk5MiAxMDA2 NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vSW1hZ2VEaWZmLmNw cAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9JbWFnZURpZmYuY3Bw CkBAIC0zNiw3ICszNiw3IEBACiAKICNpbmNsdWRlICJjb25maWcuaCIKIAotI2luY2x1ZGUgImdm eC9jb2RlYy9wbmdfY29kZWMuaCIKKyNpbmNsdWRlICJ3ZWJraXQvc3VwcG9ydC93ZWJraXRfc3Vw cG9ydF9nZnguaCIKICNpbmNsdWRlIDxhbGdvcml0aG0+CiAjaW5jbHVkZSA8c3RkaW8uaD4KICNp bmNsdWRlIDxzdHJpbmcuaD4KQEAgLTQ5LDcgKzQ5LDYgQEAKICNkZWZpbmUgUEFUSF9NQVggTUFY X1BBVEgKICNlbmRpZgogCi11c2luZyBuYW1lc3BhY2UgZ2Z4OwogdXNpbmcgbmFtZXNwYWNlIHN0 ZDsKIAogLy8gQ2F1c2VzIHRoZSBhcHAgdG8gcmVtYWluIG9wZW4sIHdhaXRpbmcgZm9yIHBhaXJz IG9mIGZpbGVuYW1lcyBvbiBzdGRpbi4KQEAgLTkzLDggKzkyLDcgQEAgcHVibGljOgogICAgICAg ICBpZiAoZnJlYWQoc291cmNlLmdldCgpLCAxLCBieXRlTGVuZ3RoLCBzdGRpbikgIT0gYnl0ZUxl bmd0aCkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgICAgICBpZiAoIVBOR0NvZGVj OjpEZWNvZGUoc291cmNlLmdldCgpLCBieXRlTGVuZ3RoLCBQTkdDb2RlYzo6Rk9STUFUX1JHQkEs Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmbV9kYXRhLCAmbV93aWR0aCwgJm1faGVp Z2h0KSkgeworICAgICAgICBpZiAoIXdlYmtpdF9zdXBwb3J0OjpEZWNvZGVQTkcoc291cmNlLmdl dCgpLCBieXRlTGVuZ3RoLCAmbV9kYXRhLCAmbV93aWR0aCwgJm1faGVpZ2h0KSkgewogICAgICAg ICAgICAgY2xlYXIoKTsKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgfQpAQCAt MTE4LDggKzExNiw3IEBAIHB1YmxpYzoKIAogICAgICAgICBmY2xvc2UoZik7CiAKLSAgICAgICAg aWYgKCFQTkdDb2RlYzo6RGVjb2RlKCZjb21wcmVzc2VkWzBdLCBjb21wcmVzc2VkLnNpemUoKSwK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBOR0NvZGVjOjpGT1JNQVRfUkdCQSwgJm1f ZGF0YSwgJm1fd2lkdGgsICZtX2hlaWdodCkpIHsKKyAgICAgICAgaWYgKCF3ZWJraXRfc3VwcG9y dDo6RGVjb2RlUE5HKCZjb21wcmVzc2VkWzBdLCBjb21wcmVzc2VkLnNpemUoKSwgJm1fZGF0YSwg Jm1fd2lkdGgsICZtX2hlaWdodCkpIHsKICAgICAgICAgICAgIGNsZWFyKCk7CiAgICAgICAgICAg ICByZXR1cm4gZmFsc2U7CiAgICAgICAgIH0KQEAgLTM1Myw4ICszNTAsOCBAQCBpbnQgZGlmZklt YWdlcyhjb25zdCBjaGFyKiBmaWxlMSwgY29uc3QgY2hhciogZmlsZTIsIGNvbnN0IGNoYXIqIG91 dEZpbGUpCiAgICAgICAgIHJldHVybiBzdGF0dXNTYW1lOwogCiAgICAgdmVjdG9yPHVuc2lnbmVk IGNoYXI+IHBuZ0RhdGE7Ci0gICAgUE5HQ29kZWM6OkVuY29kZShkaWZmSW1hZ2UuZGF0YSgpLCBQ TkdDb2RlYzo6Rk9STUFUX1JHQkEsIGRpZmZJbWFnZS53aWR0aCgpLAotICAgICAgICAgICAgICAg ICAgICAgZGlmZkltYWdlLmhlaWdodCgpLCBkaWZmSW1hZ2Uud2lkdGgoKSAqIDQsIGZhbHNlLCAm cG5nRGF0YSk7CisgICAgd2Via2l0X3N1cHBvcnQ6OkVuY29kZVJHQkFQTkcoZGlmZkltYWdlLmRh dGEoKSwgZGlmZkltYWdlLndpZHRoKCksIGRpZmZJbWFnZS5oZWlnaHQoKSwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBkaWZmSW1hZ2Uud2lkdGgoKSAqIDQsICZwbmdEYXRhKTsK ICAgICBpZiAoIXdyaXRlRmlsZShvdXRGaWxlLCAmcG5nRGF0YS5mcm9udCgpLCBwbmdEYXRhLnNp emUoKSkpCiAgICAgICAgIHJldHVybiBzdGF0dXNFcnJvcjsKICAgICByZXR1cm4gc3RhdHVzRGlm ZmVyZW50OwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0v VGVzdFNoZWxsLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RT aGVsbC5jcHAKaW5kZXggNDU1NzgwM2I2ODkxNmUyNmYxMTU3NzE1MjBkYjJlODlmNzAyYzc3MS4u ZmQxNjlkMDVjNWM0MTlhODBmYTE3YzkzYThkYzJhOTQ4ZTVmYzJlYyAxMDA2NDQKLS0tIGEvV2Vi S2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmNwcAorKysgYi9XZWJL aXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuY3BwCkBAIC0zNSw4ICsz NSw2IEBACiAjaW5jbHVkZSAiRFJURGV2VG9vbHNDbGllbnQuaCIKICNpbmNsdWRlICJMYXlvdXRU ZXN0Q29udHJvbGxlci5oIgogI2luY2x1ZGUgIldlYlZpZXdIb3N0LmgiCi0jaW5jbHVkZSAiYmFz ZS9zdHJpbmcxNi5oIgotI2luY2x1ZGUgImdmeC9jb2RlYy9wbmdfY29kZWMuaCIgLy8gRklYTUU6 IFJlbW92ZSBkZXBlbmRlY3kuIFdlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZW5jb2RlciBpcyBiZXR0 ZXI/CiAjaW5jbHVkZSAicHVibGljL1dlYkRhdGFTb3VyY2UuaCIKICNpbmNsdWRlICJwdWJsaWMv V2ViRG9jdW1lbnQuaCIKICNpbmNsdWRlICJwdWJsaWMvV2ViRWxlbWVudC5oIgpAQCAtNTUsNiAr NTMsNyBAQAogI2luY2x1ZGUgInNraWEvZXh0L2JpdG1hcF9wbGF0Zm9ybV9kZXZpY2UuaCIKICNp bmNsdWRlICJza2lhL2V4dC9wbGF0Zm9ybV9jYW52YXMuaCIKICNpbmNsdWRlICJ3ZWJraXQvc3Vw cG9ydC93ZWJraXRfc3VwcG9ydC5oIgorI2luY2x1ZGUgIndlYmtpdC9zdXBwb3J0L3dlYmtpdF9z dXBwb3J0X2dmeC5oIgogI2luY2x1ZGUgPGFsZ29yaXRobT4KICNpbmNsdWRlIDxjY3R5cGU+CiAj aW5jbHVkZSA8dmVjdG9yPgpAQCAtNjE5LDEwICs2MTgsOSBAQCB2b2lkIFRlc3RTaGVsbDo6ZHVt cEltYWdlKHNraWE6OlBsYXRmb3JtQ2FudmFzKiBjYW52YXMpIGNvbnN0CiAgICAgLy8gaXMgcmVh bGx5IGV4cGVuc2l2ZS4KICAgICBpZiAobWQ1aGFzaC5jb21wYXJlKG1fcGFyYW1zLnBpeGVsSGFz aCkpIHsKICAgICAgICAgc3RkOjp2ZWN0b3I8dW5zaWduZWQgY2hhcj4gcG5nOwotICAgICAgICBn Zng6OlBOR0NvZGVjOjpDb2xvckZvcm1hdCBjb2xvckZvcm1hdCA9IGdmeDo6UE5HQ29kZWM6OkZP Uk1BVF9CR1JBOwotICAgICAgICBnZng6OlBOR0NvZGVjOjpFbmNvZGUoCisgICAgICAgIHdlYmtp dF9zdXBwb3J0OjpFbmNvZGVCR1JBUE5HKAogICAgICAgICAgICAgcmVpbnRlcnByZXRfY2FzdDxj b25zdCB1bnNpZ25lZCBjaGFyKj4oc291cmNlQml0bWFwLmdldFBpeGVscygpKSwKLSAgICAgICAg ICAgIGNvbG9yRm9ybWF0LCBzb3VyY2VCaXRtYXAud2lkdGgoKSwgc291cmNlQml0bWFwLmhlaWdo dCgpLAorICAgICAgICAgICAgc291cmNlQml0bWFwLndpZHRoKCksIHNvdXJjZUJpdG1hcC5oZWln aHQoKSwKICAgICAgICAgICAgIHN0YXRpY19jYXN0PGludD4oc291cmNlQml0bWFwLnJvd0J5dGVz KCkpLCBkaXNjYXJkVHJhbnNwYXJlbmN5LCAmcG5nKTsKIAogICAgICAgICBtX3ByaW50ZXItPmhh bmRsZUltYWdlKG1kNWhhc2guY19zdHIoKSwgbV9wYXJhbXMucGl4ZWxIYXNoLmNfc3RyKCksICZw bmdbMF0sIHBuZy5zaXplKCksIG1fcGFyYW1zLnBpeGVsRmlsZU5hbWUuY19zdHIoKSk7Cg==