45516 2010-09-09 19:59:25 -0700 [chromium] Chromium mac build should exclude all Skia files in platform/graphics/skia/, not just some 2010-09-09 20:22:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jamesr jamesr amarinichev thakis oldest_to_newest 276962 0 jamesr 2010-09-09 19:59:25 -0700 [chromium] Chromium mac build should exclude all Skia files in platform/graphics/skia/, not just some 276964 1 67144 jamesr 2010-09-09 20:00:39 -0700 Created attachment 67144 Patch 276966 2 jamesr 2010-09-09 20:02:09 -0700 This caused http://trac.webkit.org/changeset/67126 to be reverted since PlatformContextSkia.cpp was being compiled in to chromium mac. I've confirmed locally that this builds chrome.xcodeproj target 'chrome' and all targets in webkit.xcodeproj. 276977 3 67144 kbr 2010-09-09 20:18:57 -0700 Comment on attachment 67144 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67144&action=prettypatch Basically, as long as you've built this locally it seems fine to land. If you haven't built it locally then I wouldn't land it until you've verified the change works. > WebCore/WebCore.gyp/WebCore.gyp:-1248 > - There is another exclusion of ../platform/graphics/skia/FontCustomPlatformData.cpp higher up. Should that be removed as well? 276979 4 67144 jamesr 2010-09-09 20:22:28 -0700 Comment on attachment 67144 Patch Clearing flags on attachment: 67144 Committed r67155: <http://trac.webkit.org/changeset/67155> 276980 5 jamesr 2010-09-09 20:22:32 -0700 All reviewed patches have been landed. Closing bug. 67144 2010-09-09 20:00:39 -0700 2010-09-09 20:22:28 -0700 Patch bug-45516-20100909200036.patch text/plain 2785 jamesr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTA3NDkwMzVmZGMxNmEyNWYxMTVlYTJmNTIyYjg3YTQxODQzMDc1OC4uZjI1ODllOGRmZTI5Y2Vl N2VjYTQ3NDY5MDhjYzk2MDE2YjU0YzhhNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOS0wOSAgSmFt ZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gQ2hyb21pdW0gbWFjIGJ1aWxk IHNob3VsZCBleGNsdWRlIGFsbCBTa2lhIGZpbGVzIGluIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEv LCBub3QganVzdCBzb21lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NTUxNgorCisgICAgICAgIFRoaXMgZXhjbHVkZXMgcGxhdGZvcm0vZ3JhcGhpY3Mv c2tpYS8qU2tpYS4oaHxjcHApIGJ5IHBhdHRlcm4gaW5zdGVhZCBvZiBpbmRpdmlkdWFsIGZpbGVz LgorICAgICAgICBOb25lIG9mIHRoZXNlIGZpbGVzIHNob3VsZCBiZSBjb21waWxlZCBpbnRvIHRo ZSBDaHJvbWl1bSBtYWMgYnVpbGQgYW5kIHRoZSBvbGQgZmlsZSBsaXN0IGhhZAorICAgICAgICBi b3RoIG9taXNzaW9ucyBhbmQgc3RhbGUgZW50cmllcy4KKworICAgICAgICAqIFdlYkNvcmUuZ3lw L1dlYkNvcmUuZ3lwOgorCiAyMDEwLTA5LTA3ICBKYW4gRSBIYW5zc2VuICA8amhhbnNzZW5Ac2Vu Y2hhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cCBiL1dlYkNvcmUvV2ViQ29yZS5neXAv V2ViQ29yZS5neXAKaW5kZXggNTk1MDM0ZTg1ZTUyYjQ4NzQ2MjkyYzAyZmVjYjA4NTQ2ZDc5OWMw ZS4uMzZkZDVjMmE3NDVlN2JkOGI1M2E0NzY3ZmI1ZmYxYmE5YmQ5NGQxNyAxMDA2NDQKLS0tIGEv V2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAorKysgYi9XZWJDb3JlL1dlYkNvcmUuZ3lw L1dlYkNvcmUuZ3lwCkBAIC0xMjEyLDYgKzEyMTIsOSBAQAogICAgICAgICAgICAgWydpbmNsdWRl JywgJ3BsYXRmb3JtL1RoZW1lXFwuY3BwJCddLAogCiAgICAgICAgICAgICBbJ2luY2x1ZGUnLCAn V2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJTeXN0ZW1JbnRlcmZhY2VcXC5tbSQnXSwKKwor ICAgICAgICAgICAgIyBDaHJvbWl1bSBNYWMgZG9lcyBub3QgdXNlIHNraWEuCisgICAgICAgICAg ICBbJ2V4Y2x1ZGUnLCAncGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9bXi9dKlNraWFcXC4oY3BwfGgp JCddLAogICAgICAgICAgIF0sCiAgICAgICAgICAgJ3NvdXJjZXMhJzogWwogICAgICAgICAgICAg IyBUaGUgTWFjIHVzZXMgcGxhdGZvcm0vbWFjL0tpbGxSaW5nTWFjLm1tIGluc3RlYWQgb2YgdGhl IGR1bW15CkBAIC0xMjMwLDIyICsxMjMzLDYgQEAKICAgICAgICAgICAgICMgYnkgcmVnZXggYWJv dmUsIGluc3RlYWQuCiAgICAgICAgICAgICAnLi4vcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VTb3Vy Y2UuY3BwJywKIAotICAgICAgICAgICAgIyBUaGVzZSBTa2lhIGZpbGVzIGFyZW4ndCBjdXJyZW50 bHkgYnVpbHQgb24gdGhlIE1hYywgd2hpY2ggdXNlcwotICAgICAgICAgICAgIyBDb3JlR3JhcGhp Y3MgZGlyZWN0bHkgZm9yIHRoaXMgcG9ydGlvbiBvZiBncmFwaGljcyBoYW5kbGluZy4KLSAgICAg ICAgICAgICcuLi9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0Zsb2F0UG9pbnRTa2lhLmNwcCcsCi0g ICAgICAgICAgICAnLi4vcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9GbG9hdFJlY3RTa2lhLmNwcCcs Ci0gICAgICAgICAgICAnLi4vcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFkaWVudFNraWEuY3Bw JywKLSAgICAgICAgICAgICcuLi9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4 dDNEU2tpYS5jcHAnLAotICAgICAgICAgICAgJy4uL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3Jh cGhpY3NDb250ZXh0U2tpYS5jcHAnLAotICAgICAgICAgICAgJy4uL3BsYXRmb3JtL2dyYXBoaWNz L3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcCcsCi0gICAgICAgICAgICAnLi4vcGxhdGZvcm0vZ3Jh cGhpY3Mvc2tpYS9JbWFnZVNraWEuY3BwJywKLSAgICAgICAgICAgICcuLi9wbGF0Zm9ybS9ncmFw aGljcy9za2lhL0ltYWdlU291cmNlU2tpYS5jcHAnLAotICAgICAgICAgICAgJy4uL3BsYXRmb3Jt L2dyYXBoaWNzL3NraWEvSW50UG9pbnRTa2lhLmNwcCcsCi0gICAgICAgICAgICAnLi4vcGxhdGZv cm0vZ3JhcGhpY3Mvc2tpYS9JbnRSZWN0U2tpYS5jcHAnLAotICAgICAgICAgICAgJy4uL3BsYXRm b3JtL2dyYXBoaWNzL3NraWEvUGF0aFNraWEuY3BwJywKLSAgICAgICAgICAgICcuLi9wbGF0Zm9y bS9ncmFwaGljcy9za2lhL1BhdHRlcm5Ta2lhLmNwcCcsCi0gICAgICAgICAgICAnLi4vcGxhdGZv cm0vZ3JhcGhpY3Mvc2tpYS9UcmFuc2Zvcm1hdGlvbk1hdHJpeFNraWEuY3BwJywKLQogICAgICAg ICAgICAgIyBSZW5kZXJUaGVtZUNocm9taXVtU2tpYSBpcyBub3QgdXNlZCBvbiBtYWMgc2luY2Ug UmVuZGVyVGhlbWVDaHJvbWl1bU1hYwogICAgICAgICAgICAgIyBkb2VzIG5vdCByZWZlcmVuY2Ug dGhlIFNraWEgY29kZSB0aGF0IGlzIHVzZWQgYnkgV2luZG93cyBhbmQgTGludXguCiAgICAgICAg ICAgICAnLi4vcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmNwcCcsCg==