45503 2010-09-09 17:05:56 -0700 [chromium] Clear only the uploaded portion of the software backing store when in mixed mode 2010-09-09 20:10:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth eric kbr scheib senorblanco webkit.review.bot oldest_to_newest 276859 0 jamesr 2010-09-09 17:05:56 -0700 [chromium] Clear only the uploaded portion of the software backing store when in mixed mode 276862 1 67121 jamesr 2010-09-09 17:10:13 -0700 Created attachment 67121 Patch 276867 2 scheib 2010-09-09 17:30:42 -0700 Looks good to me. 276897 3 67121 kbr 2010-09-09 18:06:40 -0700 Comment on attachment 67121 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67121&action=prettypatch Looks good overall with a couple of minor issues that can be fixed upon landing. > WebCore/platform/graphics/gpu/Texture.cpp:129 > + for (int y = 0; y < height; y++) { Apparently WebKit style prefers preincrement (++y rather than y++). Note that changing this wouldn't change the functionality of the loop. > WebCore/platform/graphics/skia/PlatformContextSkia.cpp:734 > // Start compositing into the empty canvas. This comment should probably change. > WebCore/platform/graphics/skia/PlatformContextSkia.cpp:818 > + SkRect bounds = {m_softwareDirtyRect.x(), m_softwareDirtyRect.y(), m_softwareDirtyRect.right(), m_softwareDirtyRect.bottom()}; There's a casting operator SkRect() on FloatRect when compiled against Skia. 276958 4 jamesr 2010-09-09 19:45:15 -0700 Committed r67152: <http://trac.webkit.org/changeset/67152> 276972 5 webkit.review.bot 2010-09-09 20:10:29 -0700 http://trac.webkit.org/changeset/67152 might have broken Chromium Mac Release The following changes are on the blame list: http://trac.webkit.org/changeset/67152 http://trac.webkit.org/changeset/67149 http://trac.webkit.org/changeset/67150 http://trac.webkit.org/changeset/67151 67121 2010-09-09 17:10:13 -0700 2010-09-09 18:06:39 -0700 Patch bug-45503-20100909171012.patch text/plain 4679 jamesr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzdjNDJlNjU1OTMzZGI5MTllZTgyZGU1MDNhNmNiNzRjOTcxZTg1NS4uYTMxOGFkYzExNjlmODg1 YjJhM2ExZTE1NGM0MDA5YWMyMmQxNDdmNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMC0wOS0wOSAgSmFt ZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gQ2xlYXIgb25seSB0aGUgdXBs b2FkZWQgcG9ydGlvbiBvZiB0aGUgc29mdHdhcmUgYmFja2luZyBzdG9yZSB3aGVuIGluIG1peGVk IG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1 NTAzCisKKyAgICAgICAgVGhpcyBjbGVhcnMgb3V0IG9ubHkgdGhlIGRpcnR5IHJlZ2lvbiBvZiB0 aGUgc29mdHdhcmUgYmFja2luZyBzdG9yZSB3aGVuIHVwbG9hZGluZyByZXN1bHRzCisgICAgICAg IHRvIGhhcmR3YXJlIHJhdGhlciB0aGFuIGNsZWFyaW5nIG91dCB0aGUgZW50aXJlIHNvZnR3YXJl IGJhY2tpbmcgc3RvcmUuICBUaGlzIGlzIGEgc2lnbmlmaWNhbnQKKyAgICAgICAgcGVyZm9ybWFu Y2UgaW1wcm92ZW1lbnQgd2hlbiB0aGUgZGlydHkgcmVjdHMgYXJlIHNtYWxsIHJlbGF0aXZlIHRv IHRoZSB3aG9sZSBjYW52YXMuCisKKyAgICAgICAgVGhpcyBhbHNvIGltcGxlbWVudHMgdGhlIG5v bi1zd2l6emxlIHBhdGggb2YgY29weVN1YlJlY3QoKSB1c2luZyBtZW1jcHkoKSB0byBjb3B5IHRo ZSByb3dzLCB3aGljaAorICAgICAgICBpcyBhbm90aGVyIHJlc3BlY3RhYmxlIHBlcmZvcm1hbmNl IGluY3JlYXNlLgorCisgICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4 dDJELmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvVGV4dHVyZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpjb3B5U3ViUmVjdCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsYXRm b3JtQ29udGV4dFNraWE6OnByZXBhcmVGb3JTb2Z0d2FyZURyYXcpOgorICAgICAgICAoV2ViQ29y ZTo6UGxhdGZvcm1Db250ZXh0U2tpYTo6dXBsb2FkU29mdHdhcmVUb0hhcmR3YXJlKToKKyAgICAg ICAgKFdlYkNvcmU6OlBsYXRmb3JtQ29udGV4dFNraWE6OnJlYWRiYWNrSGFyZHdhcmVUb1NvZnR3 YXJlKToKKwogMjAxMC0wOS0wOSAgQWxleGV5IE1hcmluaWNoZXYgIDxhbWFyaW5pY2hldkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmFtZXMgUm9iaW5zb24uCmRpZmYgLS1n aXQgYS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAgYi9X ZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKb2xkIG1vZGUg MTAwNjQ0Cm5ldyBtb2RlIDEwMDc1NQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9ncHUvVGV4dHVyZS5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9UZXh0 dXJlLmNwcAppbmRleCBjMmMzODA0YjZmNTZlNTcxMDliNjNjNDAyMjJiYjM5NGQzYWNlMTMwLi40 NjJkMGRmMjA3MDRlNTU1ZTA2YWI1ZjBhN2I1MmJkNmZjZGMyMTYxIDEwMDY0NAotLS0gYS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9UZXh0dXJlLmNwcAorKysgYi9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dwdS9UZXh0dXJlLmNwcApAQCAtMTI0LDE1ICsxMjQsMTggQEAgc3RhdGlj IHVpbnQzMl90KiBjb3B5U3ViUmVjdCh1aW50MzJfdCogc3JjLCBpbnQgc3JjWCwgaW50IHNyY1ks IHVpbnQzMl90KiBkc3QsIGkKICAgICBpZiAoIXN3aXp6bGUgJiYgd2lkdGggPT0gc3JjU3RyaWRl KQogICAgICAgICByZXR1cm4gc3JjT2Zmc2V0OwogCi0gICAgdWludDMyX3QqIGRzdFBpeGVsID0g ZHN0OwotICAgIGZvciAoaW50IHkgPSAwOyB5IDwgaGVpZ2h0OyB5KyspIHsKLSAgICAgICAgZm9y IChpbnQgeCA9IDA7IHggPCB3aWR0aCA7IHgrKykgewotICAgICAgICAgICAgdWludDMyX3QgcGl4 ZWwgPSBzcmNPZmZzZXRbeCArIHkgKiBzcmNTdHJpZGVdOwotICAgICAgICAgICAgaWYgKHN3aXp6 bGUpCisgICAgaWYgKHN3aXp6bGUpIHsKKyAgICAgICAgdWludDMyX3QqIGRzdFBpeGVsID0gZHN0 OworICAgICAgICBmb3IgKGludCB5ID0gMDsgeSA8IGhlaWdodDsgeSsrKSB7CisgICAgICAgICAg ICBmb3IgKGludCB4ID0gMDsgeCA8IHdpZHRoIDsgeCsrKSB7CisgICAgICAgICAgICAgICAgdWlu dDMyX3QgcGl4ZWwgPSBzcmNPZmZzZXRbeCArIHkgKiBzcmNTdHJpZGVdOwogICAgICAgICAgICAg ICAgICpkc3RQaXhlbCA9IHBpeGVsICYgMHhGRjAwRkYwMCB8ICgocGl4ZWwgJiAweDAwRkYwMDAw KSA+PiAxNikgfCAoKHBpeGVsICYgMHgwMDAwMDBGRikgPDwgMTYpOwotICAgICAgICAgICAgZWxz ZQotICAgICAgICAgICAgICAgICpkc3RQaXhlbCA9IHBpeGVsOwotICAgICAgICAgICAgZHN0UGl4 ZWwrKzsKKyAgICAgICAgICAgICAgICBkc3RQaXhlbCsrOworICAgICAgICAgICAgfQorICAgICAg ICB9CisgICAgfSBlbHNlIHsKKyAgICAgICAgZm9yIChpbnQgeSA9IDA7IHkgPCBoZWlnaHQ7IHkr KykgeworICAgICAgICAgICAgbWVtY3B5KGRzdCArIHkgKiB3aWR0aCwgc3JjT2Zmc2V0ICsgeSAq IHNyY1N0cmlkZSwgNCAqIHdpZHRoKTsKICAgICAgICAgfQogICAgIH0KICAgICByZXR1cm4gZHN0 OwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29u dGV4dFNraWEuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29u dGV4dFNraWEuY3BwCm9sZCBtb2RlIDEwMDY0NApuZXcgbW9kZSAxMDA3NTUKaW5kZXggZjAwNzNl MjNmNTEwNDkwNWU1ZjQ3OTY5MDU5Zjc2ZTA3MGRhMTdlOC4uM2M1ZjE3ZmNiYjgzMzgzZmEyZTEz NTJiNGEzZjA1OWIzMzE4MzlkMQotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEv UGxhdGZvcm1Db250ZXh0U2tpYS5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9z a2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCkBAIC03MzEsOCArNzMxLDYgQEAgdm9pZCBQbGF0 Zm9ybUNvbnRleHRTa2lhOjpwcmVwYXJlRm9yU29mdHdhcmVEcmF3KCkgY29uc3QKICAgICAgICAg Ly8gb2YgYSBjb21wb3NpdGluZyBvcGVyYXRpb24pLgogCiAgICAgICAgIGlmIChtX3N0YXRlLT5t X3hmZXJNb2RlID09IFNrWGZlcm1vZGU6OmtTcmNPdmVyX01vZGUpIHsKLSAgICAgICAgICAgIC8v IExhc3QgZHJhd24gb24gaGFyZHdhcmU7IGNsZWFyIG91dCB0aGUgY2FudmFzLgotICAgICAgICAg ICAgbV9jYW52YXMtPmdldERldmljZSgpLT5lcmFzZUNvbG9yKDApOwogICAgICAgICAgICAgLy8g U3RhcnQgY29tcG9zaXRpbmcgaW50byB0aGUgZW1wdHkgY2FudmFzLgogICAgICAgICAgICAgbV9i YWNraW5nU3RvcmVTdGF0ZSA9IE1peGVkOwogICAgICAgICB9IGVsc2UgewpAQCAtODE0LDYgKzgx MiwxMyBAQCB2b2lkIFBsYXRmb3JtQ29udGV4dFNraWE6OnVwbG9hZFNvZnR3YXJlVG9IYXJkd2Fy ZShDb21wb3NpdGVPcGVyYXRvciBvcCkgY29uc3QKICAgICBtX3VwbG9hZFRleHR1cmUtPnVwZGF0 ZVN1YlJlY3QoYml0bWFwLmdldFBpeGVscygpLCBtX3NvZnR3YXJlRGlydHlSZWN0KTsKICAgICBB ZmZpbmVUcmFuc2Zvcm0gaWRlbnRpdHk7CiAgICAgZ3B1Q2FudmFzKCktPmRyYXdUZXh0dXJlZFJl Y3QobV91cGxvYWRUZXh0dXJlLmdldCgpLCBtX3NvZnR3YXJlRGlydHlSZWN0LCBtX3NvZnR3YXJl RGlydHlSZWN0LCBpZGVudGl0eSwgMS4wLCBEZXZpY2VDb2xvclNwYWNlLCBvcCk7CisgICAgLy8g Q2xlYXIgb3V0IHRoZSByZWdpb24gb2YgdGhlIHNvZnR3YXJlIGNhbnZhcyB3ZSBqdXN0IHVwbG9h ZGVkLgorICAgIG1fY2FudmFzLT5zYXZlKCk7CisgICAgbV9jYW52YXMtPnJlc2V0TWF0cml4KCk7 CisgICAgU2tSZWN0IGJvdW5kcyA9IHttX3NvZnR3YXJlRGlydHlSZWN0LngoKSwgbV9zb2Z0d2Fy ZURpcnR5UmVjdC55KCksIG1fc29mdHdhcmVEaXJ0eVJlY3QucmlnaHQoKSwgbV9zb2Z0d2FyZURp cnR5UmVjdC5ib3R0b20oKX07CisgICAgbV9jYW52YXMtPmNsaXBSZWN0KGJvdW5kcywgU2tSZWdp b246OmtSZXBsYWNlX09wKTsKKyAgICBtX2NhbnZhcy0+ZHJhd0FSR0IoMCwgMCwgMCwgMCwgU2tY ZmVybW9kZTo6a0NsZWFyX01vZGUpOworICAgIG1fY2FudmFzLT5yZXN0b3JlKCk7CiAgICAgbV9z b2Z0d2FyZURpcnR5UmVjdC5zZXRXaWR0aCgwKTsgLy8gQ2xlYXIgZGlydHkgcmVjdC4KIH0KIApA QCAtODM5LDYgKzg0NCw3IEBAIHZvaWQgUGxhdGZvcm1Db250ZXh0U2tpYTo6cmVhZGJhY2tIYXJk d2FyZVRvU29mdHdhcmUoKSBjb25zdAogICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQor ICAgIG1fc29mdHdhcmVEaXJ0eVJlY3QudW5pdGUoSW50UmVjdCgwLCAwLCB3aWR0aCwgaGVpZ2h0 KSk7IC8vIE1hcmsgZXZlcnl0aGluZyBhcyBkaXJ0eS4KIH0KIAogfSAvLyBuYW1lc3BhY2UgV2Vi Q29yZQo=