45488 2010-09-09 13:27:06 -0700 Use String::fromUTF8 instead of UTF8Encoding().decode in the libxml XMLDocumentParser 2010-11-20 09:40:28 -0800 1 1 1 Unclassified WebKit XML 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 43085 49581 1 paroga paroga commit-queue darin oldest_to_newest 276703 0 paroga 2010-09-09 13:27:06 -0700 see patch 276710 1 67087 paroga 2010-09-09 13:31:00 -0700 Created attachment 67087 Patch 276763 2 darin 2010-09-09 14:24:22 -0700 Why? 276771 3 paroga 2010-09-09 14:36:46 -0700 (In reply to comment #2) > Why? bug 43085 IMHO String::fromUTF8 avoids the TextEncoding overhead? I also want to replace most of the toString calls with a new toAtomicString method. QualifiedName (used for elements and attributes) takes AtomicString as arguments. Creating AtomicString instead of String can avoid many memcpy operations IMHO. If we implement a AtomicString::fromUTF8 which works directly with the utf8 data for hash and compare we can avoid many convertUTF8ToUTF16 operations too. 276772 4 darin 2010-09-09 14:39:24 -0700 (In reply to comment #3) > IMHO String::fromUTF8 avoids the TextEncoding overhead? OK. Next time you can just say so in the code or change log, and save a round of questioning ;-) 277289 5 67087 commit-queue 2010-09-10 10:45:18 -0700 Comment on attachment 67087 Patch Clearing flags on attachment: 67087 Committed r67214: <http://trac.webkit.org/changeset/67214> 277290 6 commit-queue 2010-09-10 10:45:23 -0700 All reviewed patches have been landed. Closing bug. 311900 7 74475 paroga 2010-11-20 01:22:07 -0800 Created attachment 74475 Patch #2 Missed the second toString in the first patch. 311944 8 commit-queue 2010-11-20 09:39:11 -0800 The commit-queue encountered the following flaky tests while processing attachment 74475: inspector/styles-source-offsets.html Please file bugs against the tests. These tests were authored by apavlov@chromium.org and pfeldman@chromium.org. The commit-queue is continuing to process your patch. 311948 9 74475 commit-queue 2010-11-20 09:40:23 -0800 Comment on attachment 74475 Patch #2 Clearing flags on attachment: 74475 Committed r72476: <http://trac.webkit.org/changeset/72476> 311949 10 commit-queue 2010-11-20 09:40:28 -0800 All reviewed patches have been landed. Closing bug. 67087 2010-09-09 13:31:00 -0700 2010-09-10 10:45:18 -0700 Patch 0001-XMLDocumentParserToString.patch text/plain 1541 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjMyZmIzOC4uNmJjMTY2OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOS0wOSAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAcGFyb2dhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBVc2UgU3RyaW5nOjpmcm9tVVRGOCBpbnN0ZWFkIG9mIFVURjhF bmNvZGluZygpLmRlY29kZQorICAgICAgICBpbiB0aGUgbGlieG1sIFhNTERvY3VtZW50UGFyc2Vy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTQ4OAor CisgICAgICAgICogZG9tL1hNTERvY3VtZW50UGFyc2VyTGlieG1sMi5jcHA6CisgICAgICAgIChX ZWJDb3JlOjp0b1N0cmluZyk6CisKIDIwMTAtMDktMDkgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFy b2dhQHBhcm9nYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRp ZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9YTUxEb2N1bWVudFBhcnNlckxpYnhtbDIuY3BwIGIvV2Vi Q29yZS9kb20vWE1MRG9jdW1lbnRQYXJzZXJMaWJ4bWwyLmNwcAppbmRleCA5MjdmYmJlLi5lZWU4 ZDk3IDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9YTUxEb2N1bWVudFBhcnNlckxpYnhtbDIuY3Bw CisrKyBiL1dlYkNvcmUvZG9tL1hNTERvY3VtZW50UGFyc2VyTGlieG1sMi5jcHAKQEAgLTY3MSwx NyArNjcxLDE0IEBAIHZvaWQgWE1MRG9jdW1lbnRQYXJzZXI6OmRvV3JpdGUoY29uc3QgU3RyaW5n JiBwYXJzZVN0cmluZykKICAgICB9CiB9CiAKLXN0YXRpYyBpbmxpbmUgU3RyaW5nIHRvU3RyaW5n KGNvbnN0IHhtbENoYXIqIHN0ciwgdW5zaWduZWQgbGVuKQorc3RhdGljIGlubGluZSBTdHJpbmcg dG9TdHJpbmcoY29uc3QgeG1sQ2hhciogc3RyaW5nLCBzaXplX3Qgc2l6ZSkKIHsKLSAgICByZXR1 cm4gVVRGOEVuY29kaW5nKCkuZGVjb2RlKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgY2hhcio+KHN0 ciksIGxlbik7CisgICAgcmV0dXJuIFN0cmluZzo6ZnJvbVVURjgocmVpbnRlcnByZXRfY2FzdDxj b25zdCBjaGFyKj4oc3RyaW5nKSwgc2l6ZSk7CiB9CiAKLXN0YXRpYyBpbmxpbmUgU3RyaW5nIHRv U3RyaW5nKGNvbnN0IHhtbENoYXIqIHN0cikKK3N0YXRpYyBpbmxpbmUgU3RyaW5nIHRvU3RyaW5n KGNvbnN0IHhtbENoYXIqIHN0cmluZykKIHsKLSAgICBpZiAoIXN0cikKLSAgICAgICAgcmV0dXJu IFN0cmluZygpOwotCi0gICAgcmV0dXJuIFVURjhFbmNvZGluZygpLmRlY29kZShyZWludGVycHJl dF9jYXN0PGNvbnN0IGNoYXIqPihzdHIpLCBzdHJsZW4ocmVpbnRlcnByZXRfY2FzdDxjb25zdCBj aGFyKj4oc3RyKSkpOworICAgIHJldHVybiBTdHJpbmc6OmZyb21VVEY4KHJlaW50ZXJwcmV0X2Nh c3Q8Y29uc3QgY2hhcio+KHN0cmluZykpOwogfQogCiBzdHJ1Y3QgX3htbFNBWDJOYW1lc3BhY2Ug ewo= 74475 2010-11-20 01:22:07 -0800 2010-11-20 09:40:23 -0800 Patch #2 bug-45488b.patch text/plain 1150 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDg3NTZlOC4uZGU3ZTg0NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMS0yMCAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBVc2UgU3RyaW5nOjpmcm9tVVRGOCBpbnN0ZWFkIG9mIFVURjhF bmNvZGluZygpLmRlY29kZQorICAgICAgICBpbiB0aGUgbGlieG1sIFhNTERvY3VtZW50UGFyc2Vy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTQ4OAor CisgICAgICAgICogZG9tL1hNTERvY3VtZW50UGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OnRvU3RyaW5nKToKKwogMjAxMC0xMS0xNyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJv dEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjcyMjI4Lgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vWE1MRG9jdW1lbnRQYXJzZXIuY3BwIGIvV2ViQ29yZS9k b20vWE1MRG9jdW1lbnRQYXJzZXIuY3BwCmluZGV4IGI3OTAyMTcuLjJiZmQ5Y2MgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvZG9tL1hNTERvY3VtZW50UGFyc2VyLmNwcAorKysgYi9XZWJDb3JlL2RvbS9Y TUxEb2N1bWVudFBhcnNlci5jcHAKQEAgLTE4MSw5ICsxODEsOSBAQCB2b2lkIFhNTERvY3VtZW50 UGFyc2VyOjplbnRlclRleHQoKQogfQogCiAjaWYgIVVTRShRWE1MU1RSRUFNKQotc3RhdGljIGlu bGluZSBTdHJpbmcgdG9TdHJpbmcoY29uc3QgeG1sQ2hhciogc3RyLCB1bnNpZ25lZCBsZW4pCi17 Ci0gICAgcmV0dXJuIFVURjhFbmNvZGluZygpLmRlY29kZShyZWludGVycHJldF9jYXN0PGNvbnN0 IGNoYXIqPihzdHIpLCBsZW4pOworc3RhdGljIGlubGluZSBTdHJpbmcgdG9TdHJpbmcoY29uc3Qg eG1sQ2hhciogc3RyaW5nLCBzaXplX3Qgc2l6ZSkgCit7IAorICAgIHJldHVybiBTdHJpbmc6OmZy b21VVEY4KHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgY2hhcio+KHN0cmluZyksIHNpemUpOyAKIH0K ICNlbmRpZgogCg==