45481 2010-09-09 11:37:04 -0700 Inline FrameLoader::committedLoad into its one caller 2010-09-10 07:30:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 29947 1 abarth abarth commit-queue eric japhet webkit-ews oldest_to_newest 276626 0 abarth 2010-09-09 11:37:04 -0700 Inline FrameLoader::committedLoad into its one caller 276628 1 67072 abarth 2010-09-09 11:39:04 -0700 Created attachment 67072 Patch 276640 2 webkit-ews 2010-09-09 11:50:28 -0700 Attachment 67072 did not build on qt: Build output: http://queues.webkit.org/results/3943343 276648 3 eric 2010-09-09 12:01:13 -0700 Attachment 67072 did not build on mac: Build output: http://queues.webkit.org/results/3921337 276651 4 67072 eric 2010-09-09 12:11:08 -0700 Comment on attachment 67072 Patch It appears you're missing an include? ../../../WebCore/loader/DocumentLoader.cpp: In member function 'void WebCore::DocumentLoader::commitLoad(const char*, int)': ../../../WebCore/loader/DocumentLoader.cpp:285: error: invalid use of incomplete type 'struct WebCore::FrameLoaderClient' ../../../WebCore/loader/SubframeLoader.h:45: error: forward declaration of 'struct WebCore::FrameLoaderClient' Otherwise seems fine. 276661 5 67077 abarth 2010-09-09 12:18:41 -0700 Created attachment 67077 Patch for landing 276776 6 eric 2010-09-09 14:42:17 -0700 ews hung on this patch: Failed to run "['WebKitTools/Scripts/build-webkit', '--release']" exit_code: 1 Adding comment to bug 45481 277179 7 67077 commit-queue 2010-09-10 07:30:53 -0700 Comment on attachment 67077 Patch for landing Clearing flags on attachment: 67077 Committed r67198: <http://trac.webkit.org/changeset/67198> 277180 8 commit-queue 2010-09-10 07:30:58 -0700 All reviewed patches have been landed. Closing bug. 67072 2010-09-09 11:39:04 -0700 2010-09-09 12:18:32 -0700 Patch bug-45481-20100909113902.patch text/plain 3075 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2QxZmNhYjcwZjQ3MjEyOWQzMGUwZDBjZTc1Zjg1MDQzNmMxODU5YS4uODhlZGIyNzIzMmI4MWNi MGRlMmZiYTM3MTdmN2E5OTlmZDA4MTUyMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wOS0wOSAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIElubGluZSBGcmFtZUxvYWRlcjo6Y29tbWl0dGVkTG9hZCBp bnRvIGl0cyBvbmUgY2FsbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00NTQ4MQorCisgICAgICAgIFRoaXMgc2F2ZXMgb25lIHJvdW5kLXRyaXAgdGhy b3VnaCB0aGUgRnJhbWVMb2FkZXIgd2hlbiBsb2FkaW5nCisgICAgICAgIGRvY3VtZW50cy4KKwor ICAgICAgICAqIGxvYWRlci9Eb2N1bWVudExvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpE b2N1bWVudExvYWRlcjo6Y29tbWl0TG9hZCk6CisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcDoKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuaDoKKwogMjAxMC0wOS0wOSAgUGhp bGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRM b2FkZXIuY3BwIGIvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCmluZGV4IDkxNGQ4 NDhlNTJjN2QwOTQ3MTQ2OWQzYWZjMGJiMzA3NzkwMzZjYTIuLmUyMzgyOTg4YTZhMjc4YWE5MDcx MjljYWU0Zjc0NTM0MWRjOTQ4ZDYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50 TG9hZGVyLmNwcAorKysgYi9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKQEAgLTI3 Nyw4ICsyNzcsMTIgQEAgdm9pZCBEb2N1bWVudExvYWRlcjo6Y29tbWl0TG9hZChjb25zdCBjaGFy KiBkYXRhLCBpbnQgbGVuZ3RoKQogICAgIFJlZlB0cjxEb2N1bWVudExvYWRlcj4gcHJvdGVjdCh0 aGlzKTsKIAogICAgIGNvbW1pdElmUmVhZHkoKTsKLSAgICBpZiAoRnJhbWVMb2FkZXIqIGZyYW1l TG9hZGVyID0gRG9jdW1lbnRMb2FkZXI6OmZyYW1lTG9hZGVyKCkpCi0gICAgICAgIGZyYW1lTG9h ZGVyLT5jb21taXR0ZWRMb2FkKHRoaXMsIGRhdGEsIGxlbmd0aCk7CisgICAgRnJhbWVMb2FkZXIq IGZyYW1lTG9hZGVyID0gRG9jdW1lbnRMb2FkZXI6OmZyYW1lTG9hZGVyKCk7CisgICAgaWYgKCFm cmFtZUxvYWRlcikKKyAgICAgICAgcmV0dXJuOworICAgIGlmIChBcmNoaXZlRmFjdG9yeTo6aXNB cmNoaXZlTWltZVR5cGUocmVzcG9uc2UoKS5taW1lVHlwZSgpKSkKKyAgICAgICAgcmV0dXJuOwor ICAgIGZyYW1lTG9hZGVyLT5jbGllbnQoKS0+Y29tbWl0dGVkTG9hZCh0aGlzLCBkYXRhLCBsZW5n dGgpOwogfQogCiBib29sIERvY3VtZW50TG9hZGVyOjpkb2VzUHJvZ3Jlc3NpdmVMb2FkKGNvbnN0 IFN0cmluZyYgTUlNRVR5cGUpIGNvbnN0CmRpZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRlci9GcmFt ZUxvYWRlci5jcHAgYi9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKaW5kZXggNDVkMzE4 MGE3YjBiMjFjZDg3NTQ5YzM4ZmIxZWMzNzhlNDcyMmY0Yi4uYmYxN2VkOWJhOWVlYjUzNGQyYTdj ZjFhM2VjOTRjMTI3YzcxNDZhZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2Fk ZXIuY3BwCisrKyBiL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcApAQCAtMjcwOCwxMyAr MjcwOCw2IEBAIHZvaWQgRnJhbWVMb2FkZXI6OmFkZEhUVFBPcmlnaW5JZk5lZWRlZChSZXNvdXJj ZVJlcXVlc3QmIHJlcXVlc3QsIFN0cmluZyBvcmlnaW4pCiAgICAgcmVxdWVzdC5zZXRIVFRQT3Jp Z2luKG9yaWdpbik7CiB9CiAKLXZvaWQgRnJhbWVMb2FkZXI6OmNvbW1pdHRlZExvYWQoRG9jdW1l bnRMb2FkZXIqIGxvYWRlciwgY29uc3QgY2hhciogZGF0YSwgaW50IGxlbmd0aCkKLXsKLSAgICBp ZiAoQXJjaGl2ZUZhY3Rvcnk6OmlzQXJjaGl2ZU1pbWVUeXBlKGxvYWRlci0+cmVzcG9uc2UoKS5t aW1lVHlwZSgpKSkKLSAgICAgICAgcmV0dXJuOwotICAgIG1fY2xpZW50LT5jb21taXR0ZWRMb2Fk KGxvYWRlciwgZGF0YSwgbGVuZ3RoKTsKLX0KLQogdm9pZCBGcmFtZUxvYWRlcjo6bG9hZFBvc3RS ZXF1ZXN0KGNvbnN0IFJlc291cmNlUmVxdWVzdCYgaW5SZXF1ZXN0LCBjb25zdCBTdHJpbmcmIHJl ZmVycmVyLCBjb25zdCBTdHJpbmcmIGZyYW1lTmFtZSwgYm9vbCBsb2NrSGlzdG9yeSwgRnJhbWVM b2FkVHlwZSBsb2FkVHlwZSwgUGFzc1JlZlB0cjxFdmVudD4gZXZlbnQsIFBhc3NSZWZQdHI8Rm9y bVN0YXRlPiBwcnBGb3JtU3RhdGUpCiB7CiAgICAgUmVmUHRyPEZvcm1TdGF0ZT4gZm9ybVN0YXRl ID0gcHJwRm9ybVN0YXRlOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIu aCBiL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmgKaW5kZXggZTIzNzc5ZDA3ZTk4OGIzYjNh ZTVmNDg4NTdlZGUyY2YwMjhkZjA5Ny4uYjM4OGQ5ZjAxODkzODA1NWZmNjg5NGFjYWU1YmUzYjcx ODE2NWJlZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaAorKysgYi9X ZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5oCkBAIC0xNzksNyArMTc5LDYgQEAgcHVibGljOgog CiAgICAgdm9pZCBkaWRSZWNlaXZlU2VydmVyUmVkaXJlY3RGb3JQcm92aXNpb25hbExvYWRGb3JG cmFtZSgpOwogICAgIHZvaWQgZmluaXNoZWRMb2FkaW5nRG9jdW1lbnQoRG9jdW1lbnRMb2FkZXIq KTsKLSAgICB2b2lkIGNvbW1pdHRlZExvYWQoRG9jdW1lbnRMb2FkZXIqLCBjb25zdCBjaGFyKiwg aW50KTsKICAgICBib29sIGlzUmVwbGFjaW5nKCkgY29uc3Q7CiAgICAgdm9pZCBzZXRSZXBsYWNp bmcoKTsKICAgICB2b2lkIHJldmVydFRvUHJvdmlzaW9uYWwoRG9jdW1lbnRMb2FkZXIqKTsK 67077 2010-09-09 12:18:41 -0700 2010-09-10 07:30:53 -0700 Patch for landing bug-45481-20100909121839.patch text/plain 3260 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2QxZmNhYjcwZjQ3MjEyOWQzMGUwZDBjZTc1Zjg1MDQzNmMxODU5YS4uY2QxODk5MGM2N2NiZDI4 MDIwYWQxODM1YjViYzkwMGQ3ODNkMmRjMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wOS0wOSAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IEVyaWMg U2VpZGVsLgorCisgICAgICAgIElubGluZSBGcmFtZUxvYWRlcjo6Y29tbWl0dGVkTG9hZCBpbnRv IGl0cyBvbmUgY2FsbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NTQ4MQorCisgICAgICAgIFRoaXMgc2F2ZXMgb25lIHJvdW5kLXRyaXAgdGhyb3Vn aCB0aGUgRnJhbWVMb2FkZXIgd2hlbiBsb2FkaW5nCisgICAgICAgIGRvY3VtZW50cy4KKworICAg ICAgICAqIGxvYWRlci9Eb2N1bWVudExvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1 bWVudExvYWRlcjo6Y29tbWl0TG9hZCk6CisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmNw cDoKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuaDoKKwogMjAxMC0wOS0wOSAgUGhpbGlw cGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg TWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2Fk ZXIuY3BwIGIvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCmluZGV4IDkxNGQ4NDhl NTJjN2QwOTQ3MTQ2OWQzYWZjMGJiMzA3NzkwMzZjYTIuLmIwN2I1MzgxZGVhYTAzM2E5ZDY5ZDI3 MDYyNjkxODYzODA2NzQxZTQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9h ZGVyLmNwcAorKysgYi9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKQEAgLTM5LDYg KzM5LDcgQEAKICNpbmNsdWRlICJFdmVudC5oIgogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5jbHVk ZSAiRnJhbWVMb2FkZXIuaCIKKyNpbmNsdWRlICJGcmFtZUxvYWRlckNsaWVudC5oIgogI2luY2x1 ZGUgIkZyYW1lVHJlZS5oIgogI2luY2x1ZGUgIkhpc3RvcnlJdGVtLmgiCiAjaW5jbHVkZSAiTG9n Z2luZy5oIgpAQCAtMjc3LDggKzI3OCwxMiBAQCB2b2lkIERvY3VtZW50TG9hZGVyOjpjb21taXRM b2FkKGNvbnN0IGNoYXIqIGRhdGEsIGludCBsZW5ndGgpCiAgICAgUmVmUHRyPERvY3VtZW50TG9h ZGVyPiBwcm90ZWN0KHRoaXMpOwogCiAgICAgY29tbWl0SWZSZWFkeSgpOwotICAgIGlmIChGcmFt ZUxvYWRlciogZnJhbWVMb2FkZXIgPSBEb2N1bWVudExvYWRlcjo6ZnJhbWVMb2FkZXIoKSkKLSAg ICAgICAgZnJhbWVMb2FkZXItPmNvbW1pdHRlZExvYWQodGhpcywgZGF0YSwgbGVuZ3RoKTsKKyAg ICBGcmFtZUxvYWRlciogZnJhbWVMb2FkZXIgPSBEb2N1bWVudExvYWRlcjo6ZnJhbWVMb2FkZXIo KTsKKyAgICBpZiAoIWZyYW1lTG9hZGVyKQorICAgICAgICByZXR1cm47CisgICAgaWYgKEFyY2hp dmVGYWN0b3J5Ojppc0FyY2hpdmVNaW1lVHlwZShyZXNwb25zZSgpLm1pbWVUeXBlKCkpKQorICAg ICAgICByZXR1cm47CisgICAgZnJhbWVMb2FkZXItPmNsaWVudCgpLT5jb21taXR0ZWRMb2FkKHRo aXMsIGRhdGEsIGxlbmd0aCk7CiB9CiAKIGJvb2wgRG9jdW1lbnRMb2FkZXI6OmRvZXNQcm9ncmVz c2l2ZUxvYWQoY29uc3QgU3RyaW5nJiBNSU1FVHlwZSkgY29uc3QKZGlmZiAtLWdpdCBhL1dlYkNv cmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBiL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNw cAppbmRleCA0NWQzMTgwYTdiMGIyMWNkODc1NDljMzhmYjFlYzM3OGU0NzIyZjRiLi5iZjE3ZWQ5 YmE5ZWViNTM0ZDJhN2NmMWEzZWM5NGMxMjdjNzE0NmFkIDEwMDY0NAotLS0gYS9XZWJDb3JlL2xv YWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3Bw CkBAIC0yNzA4LDEzICsyNzA4LDYgQEAgdm9pZCBGcmFtZUxvYWRlcjo6YWRkSFRUUE9yaWdpbklm TmVlZGVkKFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwgU3RyaW5nIG9yaWdpbikKICAgICByZXF1 ZXN0LnNldEhUVFBPcmlnaW4ob3JpZ2luKTsKIH0KIAotdm9pZCBGcmFtZUxvYWRlcjo6Y29tbWl0 dGVkTG9hZChEb2N1bWVudExvYWRlciogbG9hZGVyLCBjb25zdCBjaGFyKiBkYXRhLCBpbnQgbGVu Z3RoKQotewotICAgIGlmIChBcmNoaXZlRmFjdG9yeTo6aXNBcmNoaXZlTWltZVR5cGUobG9hZGVy LT5yZXNwb25zZSgpLm1pbWVUeXBlKCkpKQotICAgICAgICByZXR1cm47Ci0gICAgbV9jbGllbnQt PmNvbW1pdHRlZExvYWQobG9hZGVyLCBkYXRhLCBsZW5ndGgpOwotfQotCiB2b2lkIEZyYW1lTG9h ZGVyOjpsb2FkUG9zdFJlcXVlc3QoY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiBpblJlcXVlc3QsIGNv bnN0IFN0cmluZyYgcmVmZXJyZXIsIGNvbnN0IFN0cmluZyYgZnJhbWVOYW1lLCBib29sIGxvY2tI aXN0b3J5LCBGcmFtZUxvYWRUeXBlIGxvYWRUeXBlLCBQYXNzUmVmUHRyPEV2ZW50PiBldmVudCwg UGFzc1JlZlB0cjxGb3JtU3RhdGU+IHBycEZvcm1TdGF0ZSkKIHsKICAgICBSZWZQdHI8Rm9ybVN0 YXRlPiBmb3JtU3RhdGUgPSBwcnBGb3JtU3RhdGU7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRl ci9GcmFtZUxvYWRlci5oIGIvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaAppbmRleCBlMjM3 NzlkMDdlOTg4YjNiM2FlNWY0ODg1N2VkZTJjZjAyOGRmMDk3Li5iMzg4ZDlmMDE4OTM4MDU1ZmY2 ODk0YWNhZTViZTNiNzE4MTY1YmVkIDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9GcmFtZUxv YWRlci5oCisrKyBiL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmgKQEAgLTE3OSw3ICsxNzks NiBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGRpZFJlY2VpdmVTZXJ2ZXJSZWRpcmVjdEZvclByb3Zp c2lvbmFsTG9hZEZvckZyYW1lKCk7CiAgICAgdm9pZCBmaW5pc2hlZExvYWRpbmdEb2N1bWVudChE b2N1bWVudExvYWRlciopOwotICAgIHZvaWQgY29tbWl0dGVkTG9hZChEb2N1bWVudExvYWRlcios IGNvbnN0IGNoYXIqLCBpbnQpOwogICAgIGJvb2wgaXNSZXBsYWNpbmcoKSBjb25zdDsKICAgICB2 b2lkIHNldFJlcGxhY2luZygpOwogICAgIHZvaWQgcmV2ZXJ0VG9Qcm92aXNpb25hbChEb2N1bWVu dExvYWRlciopOwo=