45464 2010-09-09 09:29:44 -0700 Web Inspector: [REGRESSION] "Inspect Element" does not focus the pointed element in a newly opened Inspector 2010-09-13 04:56:26 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED DUPLICATE 45374 P2 Normal --- 1 apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 276510 0 apavlov 2010-09-09 09:29:44 -0700 1. Open any page 2. Right-click on any element, select "Inspect Element" 3. Web Inspector is opened but the <body> element (for HTML) is focused rather than the selected element 4. Inspect the Web Inspector. An error message is logged in the console. The regression was introduced in http://trac.webkit.org/changeset/66012 - focusNode() is invoked in InspectorController::populateScriptObjects() before the main document is set for the InspectorDOMAgent instance (which makes focusNode() bail out prematurely). 276524 1 67048 apavlov 2010-09-09 09:46:33 -0700 Created attachment 67048 [PATCH] Suggested solution 276531 2 loislo 2010-09-09 09:52:46 -0700 *** This bug has been marked as a duplicate of bug 45374 *** 276533 3 joepeck 2010-09-09 09:53:24 -0700 r=me if you put the explanation you just put in comment #1 into the ChangeLog. That is what the ChangeLog is for! Note, you have the exact same patch as Ilya had on: <http://webkit.org/b/45374> Web Inspector: Selecting 'inspect element' always shows body in inspector instead of clicked element He put his patch up a little sooner though. I don't know if there is a policy or if it even matters. I was just looking for an explanation of this solution and you have a very good explanation here. 67048 2010-09-09 09:46:33 -0700 2010-09-13 04:56:26 -0700 [PATCH] Suggested solution inspectregress.patch text/plain 1605 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2QxZmNhYi4uNWMyMzRjZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0wOSAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtSRUdSRVNTSU9OXSAiSW5zcGVj dCBFbGVtZW50IiBkb2VzIG5vdCBmb2N1cyB0aGUgcG9pbnRlZCBlbGVtZW50IGluIGEgbmV3bHkg b3BlbmVkIEluc3BlY3RvcgorCisgICAgICAgIEZvY3VzIHRoZSBlbGVtZW50IGFmdGVyIHRoZSBk b2N1bWVudCBoYXMgYmVlbiBzZXQgZm9yIHRoZSBJbnNwZWN0b3JET01BZ2VudC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1NDY0CisKKyAgICAgICAg KiBpbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJ bnNwZWN0b3JDb250cm9sbGVyOjpwb3B1bGF0ZVNjcmlwdE9iamVjdHMpOgorCiAyMDEwLTA5LTA5 ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JDb250cm9sbGVyLmNwcCBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRy b2xsZXIuY3BwCmluZGV4IDFlMTMxZjcuLjlmMTJmMGQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5z cGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3RvckNvbnRyb2xsZXIuY3BwCkBAIC02MDQsOCArNjA0LDYgQEAgdm9pZCBJbnNwZWN0b3JD b250cm9sbGVyOjpwb3B1bGF0ZVNjcmlwdE9iamVjdHMoKQogCiAgICAgaWYgKG1fc2hvd0FmdGVy VmlzaWJsZSA9PSBsYXN0QWN0aXZlUGFuZWwpCiAgICAgICAgIG1fc2hvd0FmdGVyVmlzaWJsZSA9 IHNldHRpbmcobGFzdEFjdGl2ZVBhbmVsKTsKLSAgICBpZiAobV9ub2RlVG9Gb2N1cykKLSAgICAg ICAgZm9jdXNOb2RlKCk7CiAgICAgc2hvd1BhbmVsKG1fc2hvd0FmdGVyVmlzaWJsZSk7CiAKICAg ICBpZiAobV9yZXNvdXJjZVRyYWNraW5nRW5hYmxlZCkKQEAgLTYyNyw2ICs2MjUsOCBAQCB2b2lk IEluc3BlY3RvckNvbnRyb2xsZXI6OnBvcHVsYXRlU2NyaXB0T2JqZWN0cygpCiAgICAgICAgIGl0 LT5zZWNvbmQtPnVwZGF0ZVNjcmlwdE9iamVjdChtX2Zyb250ZW5kLmdldCgpKTsKIAogICAgIG1f ZG9tQWdlbnQtPnNldERvY3VtZW50KG1faW5zcGVjdGVkUGFnZS0+bWFpbkZyYW1lKCktPmRvY3Vt ZW50KCkpOworICAgIGlmIChtX25vZGVUb0ZvY3VzKQorICAgICAgICBmb2N1c05vZGUoKTsKIAog ICAgIGlmIChtX2V4cGlyZWRDb25zb2xlTWVzc2FnZUNvdW50KQogICAgICAgICBtX2Zyb250ZW5k LT51cGRhdGVDb25zb2xlTWVzc2FnZUV4cGlyZWRDb3VudChtX2V4cGlyZWRDb25zb2xlTWVzc2Fn ZUNvdW50KTsK