45462 2010-09-09 09:16:03 -0700 Application cache directory should be checked before sending to the web process 2010-09-10 22:21:51 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 kbalazs webkit-unassigned andersca commit-queue sam oldest_to_newest 276499 0 kbalazs 2010-09-09 09:16:03 -0700 If the platform does not implements WebContext::applicationCacheDirectory (returns with null string) then the WebProcess asserts in ApplicationCacheStorage::setCacheDirectory. Since this is an optional feature we should check the value before sending it to the WebProcess. 276506 1 67044 kbalazs 2010-09-09 09:25:44 -0700 Created attachment 67044 proposed patch 276522 2 67047 kbalazs 2010-09-09 09:45:14 -0700 Created attachment 67047 proposed patch Check emptiness instead of null value since it makes more sense (and includes the null case). 277258 3 67196 kbalazs 2010-09-10 09:44:54 -0700 Created attachment 67196 proposed patch I am thoughtless. One more typo fix was needed. 277277 4 67196 kling 2010-09-10 10:14:11 -0700 Comment on attachment 67196 proposed patch r=me 277633 5 67196 commit-queue 2010-09-10 22:21:46 -0700 Comment on attachment 67196 proposed patch Clearing flags on attachment: 67196 Committed r67278: <http://trac.webkit.org/changeset/67278> 277634 6 commit-queue 2010-09-10 22:21:51 -0700 All reviewed patches have been landed. Closing bug. 67044 2010-09-09 09:25:44 -0700 2010-09-09 09:45:14 -0700 proposed patch land_check_appcachedir.diff text/plain 1716 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ODU5NDgxYS4uY2Q1NGE2ZiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0wOSAgQmFsYXpzIEtlbGVt ZW4gIDxrYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQXBwbGljYXRpb24gY2FjaGUgZGlyZWN0b3J5IHNob3VsZCBiZSBj aGVja2VkIGJlZm9yZSBzZW5kaW5nIHRvIHRoZSB3ZWIgcHJvY2VzcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU0NjIKKworICAgICAgICAqIFVJUHJv Y2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUHJv eHk6OldlYlByb2Nlc3NQcm94eSk6IENoZWNrIHRoZSByZXR1cm4gdmFsdWUgb2YKKyAgICAgICAg bV9jb250ZXh0LT5hcHBsaWNhdGlvbkNhY2hlRGlyZWN0b3koKSB0byBhdm9pZCBzZW5kaW5nIGEg bnVsbCBzdHJpbmcgdG8KKyAgICAgICAgdGhlIHdlYiBwcm9jZXNzIHdoYXQgbWFrZXMgaXQgYXNz ZXJ0aW5nLgorCiAyMDEwLTA5LTA4ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dlYktpdDIvVUlQ cm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAgYi9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNz UHJveHkuY3BwCmluZGV4IGJmMzY0N2EuLjI0OGU5M2QgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQ cm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAKKysrIGIvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJv Y2Vzc1Byb3h5LmNwcApAQCAtNjYsNyArNjYsOSBAQCBXZWJQcm9jZXNzUHJveHk6OldlYlByb2Nl c3NQcm94eShXZWJDb250ZXh0KiBjb250ZXh0KQogCiAgICAgLy8gRklYTUU6IEluc3RlYWQgb2Yg c2VuZGluZyB0aHJlZSBzZXBhcmF0ZSBpbml0aWFsaXphdGlvbiByZWxhdGVkIG1lc3NhZ2VzIGhl cmUsIHdlIHNob3VsZCBqdXN0IHNlbmQgYQogICAgIC8vIHNpbmdsZSAiSW5pdGlhbGl6ZSIgbWVz c2FnZXMgd2l0aCBhIHN0cnVjdCB0aGF0IGhhcyBhbGwgdGhlIG5lZWRlZCBpbmZvcm1hdGlvbi4K LSAgICBzZW5kKFdlYlByb2Nlc3NNZXNzYWdlOjpTZXRBcHBsaWNhdGlvbkNhY2hlRGlyZWN0b3J5 LCAwLCBDb3JlSVBDOjpJbihtX2NvbnRleHQtPmFwcGxpY2F0aW9uQ2FjaGVEaXJlY3RvcnkoKSkp OworICAgIFN0cmluZyBhcHBsaWNhdGlvbkNhY2hlRGlyZWN0b3J5ID0gbV9jb250ZXh0LT5hcHBs aWNhdGlvbkNhY2hlRGlyZWN0b3J5KCk7CisgICAgaWYgKCFhcHBsaWNhdGlvbkNhY2hlRGlyZWN0 b3J5LmlzTnVsbCgpKQorICAgICAgICBzZW5kKFdlYlByb2Nlc3NNZXNzYWdlOjpTZXRBcHBsaWNh dGlvbkNhY2hlRGlyZWN0b3J5LCAwLCBDb3JlSVBDOjpJbihtX2NvbnRleHQtPmFwcGxpY2F0aW9u Q2FjaGVEaXJlY3RvcnkoKSkpOwogCiAgICAgLy8gRklYTUU6IFdlIGNvdWxkIGluc3RlYWQgc2Vu ZCB0aGUgYnVuZGxlIHBhdGggYXMgcGFydCBvZiB0aGUgYXJndW1lbnRzIHRvIHByb2Nlc3MgY3Jl YXRpb24/CiAgICAgLy8gV291bGQgdGhhdCBiZSBiZXR0ZXIgdGhhbiBzZW5kaW5nIGEgY29ubmVj dGlvbj8K 67047 2010-09-09 09:45:14 -0700 2010-09-10 09:44:54 -0700 proposed patch land_check_appcachedir.diff text/plain 1717 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ODU5NDgxYS4uMzJmMzU5OCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0wOSAgQmFsYXpzIEtlbGVt ZW4gIDxrYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQXBwbGljYXRpb24gY2FjaGUgZGlyZWN0b3J5IHNob3VsZCBiZSBj aGVja2VkIGJlZm9yZSBzZW5kaW5nIHRvIHRoZSB3ZWIgcHJvY2VzcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU0NjIKKworICAgICAgICAqIFVJUHJv Y2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUHJv eHk6OldlYlByb2Nlc3NQcm94eSk6IENoZWNrIHRoZSByZXR1cm4gdmFsdWUgb2YKKyAgICAgICAg bV9jb250ZXh0LT5hcHBsaWNhdGlvbkNhY2hlRGlyZWN0b3koKSB0byBhdm9pZCBzZW5kaW5nIGEg bnVsbCBzdHJpbmcKKyAgICAgICAgdG8gdGhlIHdlYiBwcm9jZXNzIHdoYXQgbWFrZXMgaXQgYXNz ZXJ0aW5nLgorCiAyMDEwLTA5LTA4ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dlYktpdDIvVUlQ cm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAgYi9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNz UHJveHkuY3BwCmluZGV4IGJmMzY0N2EuLmFmZWE5M2YgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQ cm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAKKysrIGIvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJv Y2Vzc1Byb3h5LmNwcApAQCAtNjYsNyArNjYsOSBAQCBXZWJQcm9jZXNzUHJveHk6OldlYlByb2Nl c3NQcm94eShXZWJDb250ZXh0KiBjb250ZXh0KQogCiAgICAgLy8gRklYTUU6IEluc3RlYWQgb2Yg c2VuZGluZyB0aHJlZSBzZXBhcmF0ZSBpbml0aWFsaXphdGlvbiByZWxhdGVkIG1lc3NhZ2VzIGhl cmUsIHdlIHNob3VsZCBqdXN0IHNlbmQgYQogICAgIC8vIHNpbmdsZSAiSW5pdGlhbGl6ZSIgbWVz c2FnZXMgd2l0aCBhIHN0cnVjdCB0aGF0IGhhcyBhbGwgdGhlIG5lZWRlZCBpbmZvcm1hdGlvbi4K LSAgICBzZW5kKFdlYlByb2Nlc3NNZXNzYWdlOjpTZXRBcHBsaWNhdGlvbkNhY2hlRGlyZWN0b3J5 LCAwLCBDb3JlSVBDOjpJbihtX2NvbnRleHQtPmFwcGxpY2F0aW9uQ2FjaGVEaXJlY3RvcnkoKSkp OworICAgIFN0cmluZyBhcHBsaWNhdGlvbkNhY2hlRGlyZWN0b3J5ID0gbV9jb250ZXh0LT5hcHBs aWNhdGlvbkNhY2hlRGlyZWN0b3J5KCk7CisgICAgaWYgKCFhcHBsaWNhdGlvbkNhY2hlRGlyZWN0 b3J5LmlzRW1wdHkoKSkKKyAgICAgICAgc2VuZChXZWJQcm9jZXNzTWVzc2FnZTo6U2V0QXBwbGlj YXRpb25DYWNoZURpcmVjdG9yeSwgMCwgQ29yZUlQQzo6SW4obV9jb250ZXh0LT5hcHBsaWNhdGlv bkNhY2hlRGlyZWN0b3J5KCkpKTsKIAogICAgIC8vIEZJWE1FOiBXZSBjb3VsZCBpbnN0ZWFkIHNl bmQgdGhlIGJ1bmRsZSBwYXRoIGFzIHBhcnQgb2YgdGhlIGFyZ3VtZW50cyB0byBwcm9jZXNzIGNy ZWF0aW9uPwogICAgIC8vIFdvdWxkIHRoYXQgYmUgYmV0dGVyIHRoYW4gc2VuZGluZyBhIGNvbm5l Y3Rpb24/Cg== 67196 2010-09-10 09:44:54 -0700 2010-09-10 22:21:46 -0700 proposed patch reland_appcachedir.diff text/plain 1711 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg Y2Q4YmI3OS4uMjRhMjQ3NCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0wOSAgQmFsYXpzIEtlbGVt ZW4gIDxrYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQXBwbGljYXRpb24gY2FjaGUgZGlyZWN0b3J5IHNob3VsZCBiZSBj aGVja2VkIGJlZm9yZSBzZW5kaW5nIHRvIHRoZSB3ZWIgcHJvY2VzcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU0NjIKKworICAgICAgICAqIFVJUHJv Y2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUHJv eHk6OldlYlByb2Nlc3NQcm94eSk6IENoZWNrIHRoZSByZXR1cm4gdmFsdWUgb2YKKyAgICAgICAg bV9jb250ZXh0LT5hcHBsaWNhdGlvbkNhY2hlRGlyZWN0b3koKSB0byBhdm9pZCBzZW5kaW5nIGEg bnVsbCBzdHJpbmcKKyAgICAgICAgdG8gdGhlIHdlYiBwcm9jZXNzIHdoYXQgbWFrZXMgaXQgYXNz ZXJ0aW5nLgorCiAyMDEwLTA5LTA5ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCmRpZmYgLS1naXQgYS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwIGIvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi UHJvY2Vzc1Byb3h5LmNwcAppbmRleCBiZjM2NDdhLi4yNmQzYWQ5IDEwMDY0NAotLS0gYS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwCisrKyBiL1dlYktpdDIvVUlQcm9jZXNz L1dlYlByb2Nlc3NQcm94eS5jcHAKQEAgLTY2LDcgKzY2LDkgQEAgV2ViUHJvY2Vzc1Byb3h5OjpX ZWJQcm9jZXNzUHJveHkoV2ViQ29udGV4dCogY29udGV4dCkKIAogICAgIC8vIEZJWE1FOiBJbnN0 ZWFkIG9mIHNlbmRpbmcgdGhyZWUgc2VwYXJhdGUgaW5pdGlhbGl6YXRpb24gcmVsYXRlZCBtZXNz YWdlcyBoZXJlLCB3ZSBzaG91bGQganVzdCBzZW5kIGEKICAgICAvLyBzaW5nbGUgIkluaXRpYWxp emUiIG1lc3NhZ2VzIHdpdGggYSBzdHJ1Y3QgdGhhdCBoYXMgYWxsIHRoZSBuZWVkZWQgaW5mb3Jt YXRpb24uCi0gICAgc2VuZChXZWJQcm9jZXNzTWVzc2FnZTo6U2V0QXBwbGljYXRpb25DYWNoZURp cmVjdG9yeSwgMCwgQ29yZUlQQzo6SW4obV9jb250ZXh0LT5hcHBsaWNhdGlvbkNhY2hlRGlyZWN0 b3J5KCkpKTsKKyAgICBTdHJpbmcgYXBwbGljYXRpb25DYWNoZURpcmVjdG9yeSA9IG1fY29udGV4 dC0+YXBwbGljYXRpb25DYWNoZURpcmVjdG9yeSgpOworICAgIGlmICghYXBwbGljYXRpb25DYWNo ZURpcmVjdG9yeS5pc0VtcHR5KCkpCisgICAgICAgIHNlbmQoV2ViUHJvY2Vzc01lc3NhZ2U6OlNl dEFwcGxpY2F0aW9uQ2FjaGVEaXJlY3RvcnksIDAsIENvcmVJUEM6OkluKGFwcGxpY2F0aW9uQ2Fj aGVEaXJlY3RvcnkpKTsKIAogICAgIC8vIEZJWE1FOiBXZSBjb3VsZCBpbnN0ZWFkIHNlbmQgdGhl IGJ1bmRsZSBwYXRoIGFzIHBhcnQgb2YgdGhlIGFyZ3VtZW50cyB0byBwcm9jZXNzIGNyZWF0aW9u PwogICAgIC8vIFdvdWxkIHRoYXQgYmUgYmV0dGVyIHRoYW4gc2VuZGluZyBhIGNvbm5lY3Rpb24/ Cg==