45460 2010-09-09 08:37:45 -0700 Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree. 2010-09-10 00:17:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 30335 0 hans webkit-unassigned commit-queue jorlow satish oldest_to_newest 276480 0 hans 2010-09-09 08:37:45 -0700 Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree. 276482 1 67039 hans 2010-09-09 08:50:09 -0700 Created attachment 67039 Patch 276483 2 hans 2010-09-09 08:51:41 -0700 Satish: feel free to take a look as this follows your speech input code very closely. 276492 3 satish 2010-09-09 09:01:24 -0700 Looks good to me. It would be useful if this patch also contained a layout test using the newly added layoutTestController method to validate that it works as intended. 276494 4 67039 jorlow 2010-09-09 09:04:46 -0700 Comment on attachment 67039 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67039&action=prettypatch > WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1397 > + if (arguments.size() < 6 || !arguments[0].isBool() || !arguments[1].isNumber() not sure this needs to be multiple lines > WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1399 > + || !arguments[4].isBool() || !arguments[5].isNumber()) use {}'s when the if or the subsequent part is more than one line > WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1402 > + WebKit::WebDeviceOrientation orientation(arguments[0].toBoolean(), arguments[1].toDouble(), or this > WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1406 > + ASSERT(m_deviceOrientationClientMock.get()); dont need .get() I'm pretty sure r=me 276502 5 hans 2010-09-09 09:24:12 -0700 (In reply to comment #3) > Looks good to me. > > It would be useful if this patch also contained a layout test using the newly added layoutTestController method to validate that it works as intended. There are tests in LayoutTests/fast/dom/DeviceOrientation already, but they are currently skipped for Chromium. My plan is to enable them when both this patch and the corresponding patch to test_shell in the Chromium repository has landed. (In reply to comment #4) > (From update of attachment 67039 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=67039&action=prettypatch > > > WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1397 > > + if (arguments.size() < 6 || !arguments[0].isBool() || !arguments[1].isNumber() > not sure this needs to be multiple lines Making it one line. > > WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1399 > > + || !arguments[4].isBool() || !arguments[5].isNumber()) > use {}'s when the if or the subsequent part is more than one line Obsolete since it's now one line. > > WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1402 > > + WebKit::WebDeviceOrientation orientation(arguments[0].toBoolean(), arguments[1].toDouble(), > or this Making it one line. > > WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1406 > > + ASSERT(m_deviceOrientationClientMock.get()); > dont need .get() I'm pretty sure You're right. Fixed. Uploading new patch with the fixes mentioned above. 276503 6 67043 hans 2010-09-09 09:24:34 -0700 Created attachment 67043 Patch 277050 7 67043 commit-queue 2010-09-10 00:17:16 -0700 Comment on attachment 67043 Patch Clearing flags on attachment: 67043 Committed r67177: <http://trac.webkit.org/changeset/67177> 277051 8 commit-queue 2010-09-10 00:17:21 -0700 All reviewed patches have been landed. Closing bug. 67039 2010-09-09 08:50:09 -0700 2010-09-09 09:24:29 -0700 Patch bug-45460-20100909165007.patch text/plain 7491 hans ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiOGRiZGFjMDFmY2Y5MGZmMTJiOGMzOWZmNmI5ZGQ1NzYwNjk1N2FiLi43MzY3YWQ0 OTlkYjgwMTc0ZWFkZmZkYzljNzlkMzJhZTA0NTdjNWJkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAK KzIwMTAtMDktMDkgIEhhbnMgV2VubmJvcmcgIDxoYW5zQGNocm9taXVtLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIb29rIHVwIExheW91dFRl c3RDb250cm9sbGVyLnNldE1vY2tEZXZpY2VPcmllbnRhdGlvbigpIGluIENocm9taXVtIER1bXBS ZW5kZXJUcmVlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDU0NjAKKworICAgICAgICBUaGlzIGVuYWJsZXMgRHVtcFJlbmRlclRyZWUgdG8gcnVuIGxh eW91dCB0ZXN0cyBmb3IgRGV2aWNlT3JpZW50YXRpb24uCisKKyAgICAgICAgQWxzbyBkZWNsYXJl IHRoZSBMYXlvdXRUZXN0Q29udHJvbGxlciBkZXN0cnVjdG9yIG91dC1vZi1saW5lLgorICAgICAg ICBPdGhlcndpc2UgdGhlIGltcGxpY2l0IGRlc3RydWN0b3Igd291bGQgY2F1c2UgY29tcGlsZXIg ZXJyb3JzIGJlY2F1c2UKKyAgICAgICAgb2YgdGhlIE93blB0cjxXZWJLaXQ6OldlYkRldmljZU9y aWVudGF0aW9uQ2xpZW50TW9jaz4gbWVtYmVyLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUv Y2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoTGF5b3V0VGVzdENv bnRyb2xsZXI6On5MYXlvdXRUZXN0Q29udHJvbGxlcik6CisgICAgICAgIChMYXlvdXRUZXN0Q29u dHJvbGxlcjo6c2V0TW9ja0RldmljZU9yaWVudGF0aW9uKToKKyAgICAgICAgKExheW91dFRlc3RD b250cm9sbGVyOjpkZXZpY2VPcmllbnRhdGlvbkNsaWVudCk6CisgICAgICAgICogRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuaDoKKyAgICAgICAgKiBEdW1wUmVu ZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHA6CisgICAgICAgIChXZWJWaWV3SG9zdDo6 ZGV2aWNlT3JpZW50YXRpb25DbGllbnQpOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9t aXVtL1dlYlZpZXdIb3N0Lmg6CisKIDIwMTAtMDktMDggIFZpY3RvciBXYW5nICA8dmljdG9yd0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2phbiBWYWZhaS4KZGlmZiAtLWdp dCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9s bGVyLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RD b250cm9sbGVyLmNwcAppbmRleCA4ZTA4YzRjZjllNTRjYTVkYzI4MDYyMDk5NzQ0MGNiOWY3Njcz ZWJmLi44ZWEwYzM5MDJjMjA0MDgyZmM1MDJmMjFlNGE1Y2MwYzMyYjFlODEyIDEwMDY0NAotLS0g YS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxl ci5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVz dENvbnRyb2xsZXIuY3BwCkBAIC0zOCw2ICszOCw4IEBACiAjaW5jbHVkZSAicHVibGljL1dlYkFu aW1hdGlvbkNvbnRyb2xsZXIuaCIKICNpbmNsdWRlICJwdWJsaWMvV2ViQmluZGluZ3MuaCIKICNp bmNsdWRlICJwdWJsaWMvV2ViQ29uc29sZU1lc3NhZ2UuaCIKKyNpbmNsdWRlICJwdWJsaWMvV2Vi RGV2aWNlT3JpZW50YXRpb24uaCIKKyNpbmNsdWRlICJwdWJsaWMvV2ViRGV2aWNlT3JpZW50YXRp b25DbGllbnRNb2NrLmgiCiAjaW5jbHVkZSAicHVibGljL1dlYkRvY3VtZW50LmgiCiAjaW5jbHVk ZSAicHVibGljL1dlYkVsZW1lbnQuaCIKICNpbmNsdWRlICJwdWJsaWMvV2ViRnJhbWUuaCIKQEAg LTE5NCw2ICsxOTYsMTAgQEAgTGF5b3V0VGVzdENvbnRyb2xsZXI6OkxheW91dFRlc3RDb250cm9s bGVyKFRlc3RTaGVsbCogc2hlbGwpCiAgICAgYmluZFByb3BlcnR5KCJ3ZWJIaXN0b3J5SXRlbUNv dW50IiwgJm1fd2ViSGlzdG9yeUl0ZW1Db3VudCk7CiB9CiAKK0xheW91dFRlc3RDb250cm9sbGVy Ojp+TGF5b3V0VGVzdENvbnRyb2xsZXIoKQoreworfQorCiBMYXlvdXRUZXN0Q29udHJvbGxlcjo6 V29ya1F1ZXVlOjp+V29ya1F1ZXVlKCkKIHsKICAgICByZXNldCgpOwpAQCAtMTM4Nyw4ICsxMzkz LDE4IEBAIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldEVkaXRpbmdCZWhhdmlvcihjb25z dCBDcHBBcmd1bWVudExpc3QmIGFyZ3VtZW50cywKIAogdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxl cjo6c2V0TW9ja0RldmljZU9yaWVudGF0aW9uKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXJndW1l bnRzLCBDcHBWYXJpYW50KiByZXN1bHQpCiB7Ci0gICAgLy8gRklYTUU6IEltcGxlbWVudCBmb3Ig RGV2aWNlT3JpZW50YXRpb24gbGF5b3V0IHRlc3RzLgotICAgIC8vIFNlZSBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAzMzUuCisgICAgcmVzdWx0LT5zZXROdWxsKCk7 CisgICAgaWYgKGFyZ3VtZW50cy5zaXplKCkgPCA2IHx8ICFhcmd1bWVudHNbMF0uaXNCb29sKCkg fHwgIWFyZ3VtZW50c1sxXS5pc051bWJlcigpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHx8ICFhcmd1bWVudHNbMl0uaXNCb29sKCkgfHwgIWFyZ3VtZW50c1szXS5pc051bWJlcigpCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHx8ICFhcmd1bWVudHNbNF0uaXNCb29sKCkgfHwg IWFyZ3VtZW50c1s1XS5pc051bWJlcigpKQorICAgICAgICByZXR1cm47CisKKyAgICBXZWJLaXQ6 OldlYkRldmljZU9yaWVudGF0aW9uIG9yaWVudGF0aW9uKGFyZ3VtZW50c1swXS50b0Jvb2xlYW4o KSwgYXJndW1lbnRzWzFdLnRvRG91YmxlKCksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBhcmd1bWVudHNbMl0udG9Cb29sZWFuKCksIGFyZ3VtZW50c1szXS50 b0RvdWJsZSgpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg YXJndW1lbnRzWzRdLnRvQm9vbGVhbigpLCBhcmd1bWVudHNbNV0udG9Eb3VibGUoKSk7CisKKyAg ICBBU1NFUlQobV9kZXZpY2VPcmllbnRhdGlvbkNsaWVudE1vY2suZ2V0KCkpOworICAgIG1fZGV2 aWNlT3JpZW50YXRpb25DbGllbnRNb2NrLT5zZXRPcmllbnRhdGlvbihvcmllbnRhdGlvbik7CiB9 CiAKIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldEdlb2xvY2F0aW9uUGVybWlzc2lvbihj b25zdCBDcHBBcmd1bWVudExpc3QmIGFyZ3VtZW50cywgQ3BwVmFyaWFudCogcmVzdWx0KQpAQCAt MTQ0NCwzICsxNDYwLDEwIEBAIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6Om1hcmtlclRleHRG b3JMaXN0SXRlbShjb25zdCBDcHBBcmd1bWVudExpc3QmIGFyZ3MsIENwCiAgICAgZWxzZQogICAg ICAgICByZXN1bHQtPnNldChlbGVtZW50LmRvY3VtZW50KCkuZnJhbWUoKS0+bWFya2VyVGV4dEZv ckxpc3RJdGVtKGVsZW1lbnQpLnV0ZjgoKSk7CiB9CisKK1dlYktpdDo6V2ViRGV2aWNlT3JpZW50 YXRpb25DbGllbnQqIExheW91dFRlc3RDb250cm9sbGVyOjpkZXZpY2VPcmllbnRhdGlvbkNsaWVu dCgpCit7CisgICAgaWYgKCFtX2RldmljZU9yaWVudGF0aW9uQ2xpZW50TW9jay5nZXQoKSkKKyAg ICAgICAgbV9kZXZpY2VPcmllbnRhdGlvbkNsaWVudE1vY2suc2V0KG5ldyBXZWJLaXQ6OldlYkRl dmljZU9yaWVudGF0aW9uQ2xpZW50TW9jaygpKTsKKyAgICByZXR1cm4gbV9kZXZpY2VPcmllbnRh dGlvbkNsaWVudE1vY2suZ2V0KCk7Cit9CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVu ZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxlci5oIGIvV2ViS2l0VG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuaAppbmRleCA1NWM4Yzhi YjIzODI2NGMwMjNlZDY5MmI0NGQ0YWI5OWU0ZjVjNjBlLi43YmIyMmNhNjhjOGU2ZGI3YjdjNmMz YmJmMjFiZDQ4MWJkZGEzOWFlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJl ZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxlci5oCisrKyBiL1dlYktpdFRvb2xzL0R1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmgKQEAgLTQ5LDYgKzQ5LDgg QEAKICNpbmNsdWRlIDx3dGYvT3duUHRyLmg+CiAKIG5hbWVzcGFjZSBXZWJLaXQgeworY2xhc3Mg V2ViRGV2aWNlT3JpZW50YXRpb25DbGllbnQ7CitjbGFzcyBXZWJEZXZpY2VPcmllbnRhdGlvbkNs aWVudE1vY2s7CiBjbGFzcyBXZWJTcGVlY2hJbnB1dENvbnRyb2xsZXI7CiBjbGFzcyBXZWJTcGVl Y2hJbnB1dENvbnRyb2xsZXJNb2NrOwogY2xhc3MgV2ViU3BlZWNoSW5wdXRMaXN0ZW5lcjsKQEAg LTYyLDYgKzY0LDggQEAgcHVibGljOgogICAgIC8vIG9iamVjdC4KICAgICBMYXlvdXRUZXN0Q29u dHJvbGxlcihUZXN0U2hlbGwqKTsKIAorICAgIH5MYXlvdXRUZXN0Q29udHJvbGxlcigpOworCiAg ICAgLy8gVGhpcyBmdW5jdGlvbiBzZXRzIGEgZmxhZyB0aGF0IHRlbGxzIHRoZSB0ZXN0X3NoZWxs IHRvIGR1bXAgcGFnZXMgYXMKICAgICAvLyBwbGFpbiB0ZXh0LCByYXRoZXIgdGhhbiBhcyBhIHRl eHQgcmVwcmVzZW50YXRpb24gb2YgdGhlIHJlbmRlcmVyJ3Mgc3RhdGUuCiAgICAgLy8gSXQgdGFr ZXMgYW4gb3B0aW9uYWwgYXJndW1lbnQsIHdoZXRoZXIgdG8gZHVtcCBwaXhlbHMgcmVzdWx0cyBv ciBub3QuCkBAIC0zMTgsNiArMzIyLDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0V29ya1F1ZXVl RnJvemVuKGJvb2wgZnJvemVuKSB7IG1fd29ya1F1ZXVlLnNldEZyb3plbihmcm96ZW4pOyB9CiAK ICAgICBXZWJLaXQ6OldlYlNwZWVjaElucHV0Q29udHJvbGxlciogc3BlZWNoSW5wdXRDb250cm9s bGVyKFdlYktpdDo6V2ViU3BlZWNoSW5wdXRMaXN0ZW5lciopOworICAgIFdlYktpdDo6V2ViRGV2 aWNlT3JpZW50YXRpb25DbGllbnQqIGRldmljZU9yaWVudGF0aW9uQ2xpZW50KCk7CiAgICAgYm9v bCBzaG91bGREdW1wQXNUZXh0KCkgeyByZXR1cm4gbV9kdW1wQXNUZXh0OyB9CiAgICAgYm9vbCBz aG91bGREdW1wRWRpdGluZ0NhbGxiYWNrcygpIHsgcmV0dXJuIG1fZHVtcEVkaXRpbmdDYWxsYmFj a3M7IH0KICAgICBib29sIHNob3VsZER1bXBGcmFtZUxvYWRDYWxsYmFja3MoKSB7IHJldHVybiBt X2R1bXBGcmFtZUxvYWRDYWxsYmFja3M7IH0KQEAgLTUwNiw2ICs1MTEsOCBAQCBwcml2YXRlOgog ICAgIFdlYktpdDo6V2ViVVJMIG1fdXNlclN0eWxlU2hlZXRMb2NhdGlvbjsKIAogICAgIE93blB0 cjxXZWJLaXQ6OldlYlNwZWVjaElucHV0Q29udHJvbGxlck1vY2s+IG1fc3BlZWNoSW5wdXRDb250 cm9sbGVyTW9jazsKKworICAgIE93blB0cjxXZWJLaXQ6OldlYkRldmljZU9yaWVudGF0aW9uQ2xp ZW50TW9jaz4gbV9kZXZpY2VPcmllbnRhdGlvbkNsaWVudE1vY2s7CiB9OwogCiAjZW5kaWYgLy8g TGF5b3V0VGVzdENvbnRyb2xsZXJfaApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRy ZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwCmluZGV4IGZhZTNmNTYyMjAzNDIyNTI1MTdlNWZj ZWZjNjVmOWExNzNjMjhmOWUuLjFlM2E0ZDY1MmFmZDRlZDk0ODE0MTY1MDU2ZjgxNjAwYTk0ZTU1 M2EgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZp ZXdIb3N0LmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJW aWV3SG9zdC5jcHAKQEAgLTUxMiw2ICs1MTIsMTEgQEAgV2ViU3BlZWNoSW5wdXRDb250cm9sbGVy KiBXZWJWaWV3SG9zdDo6c3BlZWNoSW5wdXRDb250cm9sbGVyKFdlYktpdDo6V2ViU3BlZWNoSW4K ICAgICByZXR1cm4gbV9zaGVsbC0+bGF5b3V0VGVzdENvbnRyb2xsZXIoKS0+c3BlZWNoSW5wdXRD b250cm9sbGVyKGxpc3RlbmVyKTsKIH0KIAorV2ViS2l0OjpXZWJEZXZpY2VPcmllbnRhdGlvbkNs aWVudCogV2ViVmlld0hvc3Q6OmRldmljZU9yaWVudGF0aW9uQ2xpZW50KCkKK3sKKyAgICByZXR1 cm4gbV9zaGVsbC0+bGF5b3V0VGVzdENvbnRyb2xsZXIoKS0+ZGV2aWNlT3JpZW50YXRpb25DbGll bnQoKTsKK30KKwogLy8gV2ViV2lkZ2V0Q2xpZW50IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAKIHZvaWQgV2ViVmlld0hvc3Q6OmRp ZEludmFsaWRhdGVSZWN0KGNvbnN0IFdlYlJlY3QmIHJlY3QpCmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5oIGIvV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuaAppbmRleCA1MDY3MzQyZmMyMGNk YjdmNzc3OTI5ZjQ0ZDgzZmQ0NzU3Yzg3ZjA5Li4zYTg0ZWJkODgzMTlkM2I2ZDg5NTkxMjUyODgy MjM3NmQ3YjRkYzllIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJv bWl1bS9XZWJWaWV3SG9zdC5oCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9t aXVtL1dlYlZpZXdIb3N0LmgKQEAgLTQ1LDYgKzQ1LDcgQEAgY2xhc3MgTGF5b3V0VGVzdENvbnRy b2xsZXI7CiBjbGFzcyBUZXN0U2hlbGw7CiBuYW1lc3BhY2UgV2ViS2l0IHsKIGNsYXNzIFdlYkZy YW1lOworY2xhc3MgV2ViRGV2aWNlT3JpZW50YXRpb25DbGllbnQ7CiBjbGFzcyBXZWJHZW9sb2Nh dGlvblNlcnZpY2VNb2NrOwogY2xhc3MgV2ViU3BlZWNoSW5wdXRDb250cm9sbGVyOwogY2xhc3Mg V2ViU3BlZWNoSW5wdXRMaXN0ZW5lcjsKQEAgLTEzMCw2ICsxMzEsNyBAQCBjbGFzcyBXZWJWaWV3 SG9zdCA6IHB1YmxpYyBXZWJLaXQ6OldlYlZpZXdDbGllbnQsIHB1YmxpYyBXZWJLaXQ6OldlYkZy YW1lQ2xpZW50LAogICAgIHZpcnR1YWwgV2ViS2l0OjpXZWJOb3RpZmljYXRpb25QcmVzZW50ZXIq IG5vdGlmaWNhdGlvblByZXNlbnRlcigpOwogICAgIHZpcnR1YWwgV2ViS2l0OjpXZWJHZW9sb2Nh dGlvblNlcnZpY2UqIGdlb2xvY2F0aW9uU2VydmljZSgpOwogICAgIHZpcnR1YWwgV2ViS2l0OjpX ZWJTcGVlY2hJbnB1dENvbnRyb2xsZXIqIHNwZWVjaElucHV0Q29udHJvbGxlcihXZWJLaXQ6Oldl YlNwZWVjaElucHV0TGlzdGVuZXIqKTsKKyAgICB2aXJ0dWFsIFdlYktpdDo6V2ViRGV2aWNlT3Jp ZW50YXRpb25DbGllbnQqIGRldmljZU9yaWVudGF0aW9uQ2xpZW50KCk7CiAKICAgICAvLyBXZWJL aXQ6OldlYldpZGdldENsaWVudAogICAgIHZpcnR1YWwgdm9pZCBkaWRJbnZhbGlkYXRlUmVjdChj b25zdCBXZWJLaXQ6OldlYlJlY3QmKTsK 67043 2010-09-09 09:24:34 -0700 2010-09-10 00:17:16 -0700 Patch bug-45460-20100909172432.patch text/plain 7333 hans ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiOGRiZGFjMDFmY2Y5MGZmMTJiOGMzOWZmNmI5ZGQ1NzYwNjk1N2FiLi43MzY3YWQ0 OTlkYjgwMTc0ZWFkZmZkYzljNzlkMzJhZTA0NTdjNWJkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAK KzIwMTAtMDktMDkgIEhhbnMgV2VubmJvcmcgIDxoYW5zQGNocm9taXVtLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIb29rIHVwIExheW91dFRl c3RDb250cm9sbGVyLnNldE1vY2tEZXZpY2VPcmllbnRhdGlvbigpIGluIENocm9taXVtIER1bXBS ZW5kZXJUcmVlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDU0NjAKKworICAgICAgICBUaGlzIGVuYWJsZXMgRHVtcFJlbmRlclRyZWUgdG8gcnVuIGxh eW91dCB0ZXN0cyBmb3IgRGV2aWNlT3JpZW50YXRpb24uCisKKyAgICAgICAgQWxzbyBkZWNsYXJl IHRoZSBMYXlvdXRUZXN0Q29udHJvbGxlciBkZXN0cnVjdG9yIG91dC1vZi1saW5lLgorICAgICAg ICBPdGhlcndpc2UgdGhlIGltcGxpY2l0IGRlc3RydWN0b3Igd291bGQgY2F1c2UgY29tcGlsZXIg ZXJyb3JzIGJlY2F1c2UKKyAgICAgICAgb2YgdGhlIE93blB0cjxXZWJLaXQ6OldlYkRldmljZU9y aWVudGF0aW9uQ2xpZW50TW9jaz4gbWVtYmVyLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUv Y2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoTGF5b3V0VGVzdENv bnRyb2xsZXI6On5MYXlvdXRUZXN0Q29udHJvbGxlcik6CisgICAgICAgIChMYXlvdXRUZXN0Q29u dHJvbGxlcjo6c2V0TW9ja0RldmljZU9yaWVudGF0aW9uKToKKyAgICAgICAgKExheW91dFRlc3RD b250cm9sbGVyOjpkZXZpY2VPcmllbnRhdGlvbkNsaWVudCk6CisgICAgICAgICogRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuaDoKKyAgICAgICAgKiBEdW1wUmVu ZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHA6CisgICAgICAgIChXZWJWaWV3SG9zdDo6 ZGV2aWNlT3JpZW50YXRpb25DbGllbnQpOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9t aXVtL1dlYlZpZXdIb3N0Lmg6CisKIDIwMTAtMDktMDggIFZpY3RvciBXYW5nICA8dmljdG9yd0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2phbiBWYWZhaS4KZGlmZiAtLWdp dCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9s bGVyLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RD b250cm9sbGVyLmNwcAppbmRleCA4ZTA4YzRjZjllNTRjYTVkYzI4MDYyMDk5NzQ0MGNiOWY3Njcz ZWJmLi42Zjk2MmJmOTRjNTZiYmNmZTgwOTRmYmIxNzYxNDQ0NjAwZjM2YjZlIDEwMDY0NAotLS0g YS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxl ci5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVz dENvbnRyb2xsZXIuY3BwCkBAIC0zOCw2ICszOCw4IEBACiAjaW5jbHVkZSAicHVibGljL1dlYkFu aW1hdGlvbkNvbnRyb2xsZXIuaCIKICNpbmNsdWRlICJwdWJsaWMvV2ViQmluZGluZ3MuaCIKICNp bmNsdWRlICJwdWJsaWMvV2ViQ29uc29sZU1lc3NhZ2UuaCIKKyNpbmNsdWRlICJwdWJsaWMvV2Vi RGV2aWNlT3JpZW50YXRpb24uaCIKKyNpbmNsdWRlICJwdWJsaWMvV2ViRGV2aWNlT3JpZW50YXRp b25DbGllbnRNb2NrLmgiCiAjaW5jbHVkZSAicHVibGljL1dlYkRvY3VtZW50LmgiCiAjaW5jbHVk ZSAicHVibGljL1dlYkVsZW1lbnQuaCIKICNpbmNsdWRlICJwdWJsaWMvV2ViRnJhbWUuaCIKQEAg LTE5NCw2ICsxOTYsMTAgQEAgTGF5b3V0VGVzdENvbnRyb2xsZXI6OkxheW91dFRlc3RDb250cm9s bGVyKFRlc3RTaGVsbCogc2hlbGwpCiAgICAgYmluZFByb3BlcnR5KCJ3ZWJIaXN0b3J5SXRlbUNv dW50IiwgJm1fd2ViSGlzdG9yeUl0ZW1Db3VudCk7CiB9CiAKK0xheW91dFRlc3RDb250cm9sbGVy Ojp+TGF5b3V0VGVzdENvbnRyb2xsZXIoKQoreworfQorCiBMYXlvdXRUZXN0Q29udHJvbGxlcjo6 V29ya1F1ZXVlOjp+V29ya1F1ZXVlKCkKIHsKICAgICByZXNldCgpOwpAQCAtMTM4Nyw4ICsxMzkz LDE0IEBAIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldEVkaXRpbmdCZWhhdmlvcihjb25z dCBDcHBBcmd1bWVudExpc3QmIGFyZ3VtZW50cywKIAogdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxl cjo6c2V0TW9ja0RldmljZU9yaWVudGF0aW9uKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXJndW1l bnRzLCBDcHBWYXJpYW50KiByZXN1bHQpCiB7Ci0gICAgLy8gRklYTUU6IEltcGxlbWVudCBmb3Ig RGV2aWNlT3JpZW50YXRpb24gbGF5b3V0IHRlc3RzLgotICAgIC8vIFNlZSBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAzMzUuCisgICAgcmVzdWx0LT5zZXROdWxsKCk7 CisgICAgaWYgKGFyZ3VtZW50cy5zaXplKCkgPCA2IHx8ICFhcmd1bWVudHNbMF0uaXNCb29sKCkg fHwgIWFyZ3VtZW50c1sxXS5pc051bWJlcigpIHx8ICFhcmd1bWVudHNbMl0uaXNCb29sKCkgfHwg IWFyZ3VtZW50c1szXS5pc051bWJlcigpIHx8ICFhcmd1bWVudHNbNF0uaXNCb29sKCkgfHwgIWFy Z3VtZW50c1s1XS5pc051bWJlcigpKQorICAgICAgICByZXR1cm47CisKKyAgICBXZWJLaXQ6Oldl YkRldmljZU9yaWVudGF0aW9uIG9yaWVudGF0aW9uKGFyZ3VtZW50c1swXS50b0Jvb2xlYW4oKSwg YXJndW1lbnRzWzFdLnRvRG91YmxlKCksIGFyZ3VtZW50c1syXS50b0Jvb2xlYW4oKSwgYXJndW1l bnRzWzNdLnRvRG91YmxlKCksIGFyZ3VtZW50c1s0XS50b0Jvb2xlYW4oKSwgYXJndW1lbnRzWzVd LnRvRG91YmxlKCkpOworCisgICAgQVNTRVJUKG1fZGV2aWNlT3JpZW50YXRpb25DbGllbnRNb2Nr KTsKKyAgICBtX2RldmljZU9yaWVudGF0aW9uQ2xpZW50TW9jay0+c2V0T3JpZW50YXRpb24ob3Jp ZW50YXRpb24pOwogfQogCiB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzZXRHZW9sb2NhdGlv blBlcm1pc3Npb24oY29uc3QgQ3BwQXJndW1lbnRMaXN0JiBhcmd1bWVudHMsIENwcFZhcmlhbnQq IHJlc3VsdCkKQEAgLTE0NDQsMyArMTQ1NiwxMCBAQCB2b2lkIExheW91dFRlc3RDb250cm9sbGVy OjptYXJrZXJUZXh0Rm9yTGlzdEl0ZW0oY29uc3QgQ3BwQXJndW1lbnRMaXN0JiBhcmdzLCBDcAog ICAgIGVsc2UKICAgICAgICAgcmVzdWx0LT5zZXQoZWxlbWVudC5kb2N1bWVudCgpLmZyYW1lKCkt Pm1hcmtlclRleHRGb3JMaXN0SXRlbShlbGVtZW50KS51dGY4KCkpOwogfQorCitXZWJLaXQ6Oldl YkRldmljZU9yaWVudGF0aW9uQ2xpZW50KiBMYXlvdXRUZXN0Q29udHJvbGxlcjo6ZGV2aWNlT3Jp ZW50YXRpb25DbGllbnQoKQoreworICAgIGlmICghbV9kZXZpY2VPcmllbnRhdGlvbkNsaWVudE1v Y2suZ2V0KCkpCisgICAgICAgIG1fZGV2aWNlT3JpZW50YXRpb25DbGllbnRNb2NrLnNldChuZXcg V2ViS2l0OjpXZWJEZXZpY2VPcmllbnRhdGlvbkNsaWVudE1vY2soKSk7CisgICAgcmV0dXJuIG1f ZGV2aWNlT3JpZW50YXRpb25DbGllbnRNb2NrLmdldCgpOworfQpkaWZmIC0tZ2l0IGEvV2ViS2l0 VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuaCBiL1dl YktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmgK aW5kZXggNTVjOGM4YmIyMzgyNjRjMDIzZWQ2OTJiNDRkNGFiOTllNGY1YzYwZS4uN2JiMjJjYTY4 YzhlNmRiN2I3YzZjM2JiZjIxYmQ0ODFiZGRhMzlhZSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuaAorKysgYi9XZWJL aXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxlci5oCkBA IC00OSw2ICs0OSw4IEBACiAjaW5jbHVkZSA8d3RmL093blB0ci5oPgogCiBuYW1lc3BhY2UgV2Vi S2l0IHsKK2NsYXNzIFdlYkRldmljZU9yaWVudGF0aW9uQ2xpZW50OworY2xhc3MgV2ViRGV2aWNl T3JpZW50YXRpb25DbGllbnRNb2NrOwogY2xhc3MgV2ViU3BlZWNoSW5wdXRDb250cm9sbGVyOwog Y2xhc3MgV2ViU3BlZWNoSW5wdXRDb250cm9sbGVyTW9jazsKIGNsYXNzIFdlYlNwZWVjaElucHV0 TGlzdGVuZXI7CkBAIC02Miw2ICs2NCw4IEBAIHB1YmxpYzoKICAgICAvLyBvYmplY3QuCiAgICAg TGF5b3V0VGVzdENvbnRyb2xsZXIoVGVzdFNoZWxsKik7CiAKKyAgICB+TGF5b3V0VGVzdENvbnRy b2xsZXIoKTsKKwogICAgIC8vIFRoaXMgZnVuY3Rpb24gc2V0cyBhIGZsYWcgdGhhdCB0ZWxscyB0 aGUgdGVzdF9zaGVsbCB0byBkdW1wIHBhZ2VzIGFzCiAgICAgLy8gcGxhaW4gdGV4dCwgcmF0aGVy IHRoYW4gYXMgYSB0ZXh0IHJlcHJlc2VudGF0aW9uIG9mIHRoZSByZW5kZXJlcidzIHN0YXRlLgog ICAgIC8vIEl0IHRha2VzIGFuIG9wdGlvbmFsIGFyZ3VtZW50LCB3aGV0aGVyIHRvIGR1bXAgcGl4 ZWxzIHJlc3VsdHMgb3Igbm90LgpAQCAtMzE4LDYgKzMyMiw3IEBAIHB1YmxpYzoKICAgICB2b2lk IHNldFdvcmtRdWV1ZUZyb3plbihib29sIGZyb3plbikgeyBtX3dvcmtRdWV1ZS5zZXRGcm96ZW4o ZnJvemVuKTsgfQogCiAgICAgV2ViS2l0OjpXZWJTcGVlY2hJbnB1dENvbnRyb2xsZXIqIHNwZWVj aElucHV0Q29udHJvbGxlcihXZWJLaXQ6OldlYlNwZWVjaElucHV0TGlzdGVuZXIqKTsKKyAgICBX ZWJLaXQ6OldlYkRldmljZU9yaWVudGF0aW9uQ2xpZW50KiBkZXZpY2VPcmllbnRhdGlvbkNsaWVu dCgpOwogICAgIGJvb2wgc2hvdWxkRHVtcEFzVGV4dCgpIHsgcmV0dXJuIG1fZHVtcEFzVGV4dDsg fQogICAgIGJvb2wgc2hvdWxkRHVtcEVkaXRpbmdDYWxsYmFja3MoKSB7IHJldHVybiBtX2R1bXBF ZGl0aW5nQ2FsbGJhY2tzOyB9CiAgICAgYm9vbCBzaG91bGREdW1wRnJhbWVMb2FkQ2FsbGJhY2tz KCkgeyByZXR1cm4gbV9kdW1wRnJhbWVMb2FkQ2FsbGJhY2tzOyB9CkBAIC01MDYsNiArNTExLDgg QEAgcHJpdmF0ZToKICAgICBXZWJLaXQ6OldlYlVSTCBtX3VzZXJTdHlsZVNoZWV0TG9jYXRpb247 CiAKICAgICBPd25QdHI8V2ViS2l0OjpXZWJTcGVlY2hJbnB1dENvbnRyb2xsZXJNb2NrPiBtX3Nw ZWVjaElucHV0Q29udHJvbGxlck1vY2s7CisKKyAgICBPd25QdHI8V2ViS2l0OjpXZWJEZXZpY2VP cmllbnRhdGlvbkNsaWVudE1vY2s+IG1fZGV2aWNlT3JpZW50YXRpb25DbGllbnRNb2NrOwogfTsK IAogI2VuZGlmIC8vIExheW91dFRlc3RDb250cm9sbGVyX2gKZGlmZiAtLWdpdCBhL1dlYktpdFRv b2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcCBiL1dlYktpdFRvb2xz L0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcAppbmRleCBmYWUzZjU2MjIw MzQyMjUyNTE3ZTVmY2VmYzY1ZjlhMTczYzI4ZjllLi4xZTNhNGQ2NTJhZmQ0ZWQ5NDgxNDE2NTA1 NmY4MTYwMGE5NGU1NTNhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9j aHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUv Y2hyb21pdW0vV2ViVmlld0hvc3QuY3BwCkBAIC01MTIsNiArNTEyLDExIEBAIFdlYlNwZWVjaElu cHV0Q29udHJvbGxlciogV2ViVmlld0hvc3Q6OnNwZWVjaElucHV0Q29udHJvbGxlcihXZWJLaXQ6 OldlYlNwZWVjaEluCiAgICAgcmV0dXJuIG1fc2hlbGwtPmxheW91dFRlc3RDb250cm9sbGVyKCkt PnNwZWVjaElucHV0Q29udHJvbGxlcihsaXN0ZW5lcik7CiB9CiAKK1dlYktpdDo6V2ViRGV2aWNl T3JpZW50YXRpb25DbGllbnQqIFdlYlZpZXdIb3N0OjpkZXZpY2VPcmllbnRhdGlvbkNsaWVudCgp Cit7CisgICAgcmV0dXJuIG1fc2hlbGwtPmxheW91dFRlc3RDb250cm9sbGVyKCktPmRldmljZU9y aWVudGF0aW9uQ2xpZW50KCk7Cit9CisKIC8vIFdlYldpZGdldENsaWVudCAtLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCiB2b2lkIFdl YlZpZXdIb3N0OjpkaWRJbnZhbGlkYXRlUmVjdChjb25zdCBXZWJSZWN0JiByZWN0KQpkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuaCBi L1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmgKaW5kZXgg NTA2NzM0MmZjMjBjZGI3Zjc3NzkyOWY0NGQ4M2ZkNDc1N2M4N2YwOS4uM2E4NGViZDg4MzE5ZDNi NmQ4OTU5MTI1Mjg4MjIzNzZkN2I0ZGM5ZSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuaAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVu ZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5oCkBAIC00NSw2ICs0NSw3IEBAIGNsYXNzIExh eW91dFRlc3RDb250cm9sbGVyOwogY2xhc3MgVGVzdFNoZWxsOwogbmFtZXNwYWNlIFdlYktpdCB7 CiBjbGFzcyBXZWJGcmFtZTsKK2NsYXNzIFdlYkRldmljZU9yaWVudGF0aW9uQ2xpZW50OwogY2xh c3MgV2ViR2VvbG9jYXRpb25TZXJ2aWNlTW9jazsKIGNsYXNzIFdlYlNwZWVjaElucHV0Q29udHJv bGxlcjsKIGNsYXNzIFdlYlNwZWVjaElucHV0TGlzdGVuZXI7CkBAIC0xMzAsNiArMTMxLDcgQEAg Y2xhc3MgV2ViVmlld0hvc3QgOiBwdWJsaWMgV2ViS2l0OjpXZWJWaWV3Q2xpZW50LCBwdWJsaWMg V2ViS2l0OjpXZWJGcmFtZUNsaWVudCwKICAgICB2aXJ0dWFsIFdlYktpdDo6V2ViTm90aWZpY2F0 aW9uUHJlc2VudGVyKiBub3RpZmljYXRpb25QcmVzZW50ZXIoKTsKICAgICB2aXJ0dWFsIFdlYktp dDo6V2ViR2VvbG9jYXRpb25TZXJ2aWNlKiBnZW9sb2NhdGlvblNlcnZpY2UoKTsKICAgICB2aXJ0 dWFsIFdlYktpdDo6V2ViU3BlZWNoSW5wdXRDb250cm9sbGVyKiBzcGVlY2hJbnB1dENvbnRyb2xs ZXIoV2ViS2l0OjpXZWJTcGVlY2hJbnB1dExpc3RlbmVyKik7CisgICAgdmlydHVhbCBXZWJLaXQ6 OldlYkRldmljZU9yaWVudGF0aW9uQ2xpZW50KiBkZXZpY2VPcmllbnRhdGlvbkNsaWVudCgpOwog CiAgICAgLy8gV2ViS2l0OjpXZWJXaWRnZXRDbGllbnQKICAgICB2aXJ0dWFsIHZvaWQgZGlkSW52 YWxpZGF0ZVJlY3QoY29uc3QgV2ViS2l0OjpXZWJSZWN0Jik7Cg==