45459 2010-09-09 08:07:37 -0700 [Qt] MiniBrowser does not starts properly 2010-09-09 09:02:57 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 kbalazs webkit-unassigned ossy oldest_to_newest 276464 0 kbalazs 2010-09-09 08:07:37 -0700 The faulty code is in main.cpp: BrowserWindow* window = 0; foreach (QString url, urls) { window = new BrowserWindow(); window->newWindow(url); The firstly created BrowserWindow is never shown so it just leaves in the memory and feel boring. 276467 1 67033 kbalazs 2010-09-09 08:11:20 -0700 Created attachment 67033 proposed patch 276478 2 67038 kbalazs 2010-09-09 08:28:03 -0700 Created attachment 67038 proposed patch Removed unnecessary newWindow->show() call. 276486 3 67038 kling 2010-09-09 08:56:01 -0700 Comment on attachment 67038 proposed patch > + resize(960, 640); This is now done both in the constructor and newWindow(). You can remove it from newWindow(). r=me with that changed 276493 4 ossy 2010-09-09 09:02:37 -0700 (In reply to comment #3) > (From update of attachment 67038 [details]) > > + resize(960, 640); > > This is now done both in the constructor and newWindow(). You can remove it from newWindow(). > > r=me with that changed Manually landed in http://trac.webkit.org/changeset/67089 with this change. 67033 2010-09-09 08:11:20 -0700 2010-09-09 08:28:03 -0700 proposed patch land_mbfix.diff text/plain 1889 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlMjMyY2U2Li4yYzg2YmQ5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDkt MDkgIEJhbGF6cyBLZWxlbWVuICA8a2JAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTWluaUJyb3dzZXIgZG9lcyBu b3Qgc3RhcnRzIHByb3Blcmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00NTQ1OQorCisgICAgICAgIERvIG5vdCB0cnkgc2V0IHVwIHRoZSBmaXJzdCB3 aW5kb3cgYnkgY2FsbGluZyBuZXdXaW5kb3cgb24gYQorICAgICAgICBuZXdseSBjcmVhdGVkIEJy b3dzZXJXaW5kb3cgc2luY2UgaXQgY3JlYXRlcyBhIG5ldyBvYmplY3QuCisgICAgICAgICogTWlu aUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5jcHA6CisgICAgICAgIChCcm93c2VyV2luZG93OjpC cm93c2VyV2luZG93KToKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9xdC9tYWluLmNwcDoKKyAgICAg ICAgKG1haW4pOgorCiAyMDEwLTA5LTA5ICBab2x0YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRpZmYgLS1naXQgYS9X ZWJLaXRUb29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93LmNwcCBiL1dlYktpdFRvb2xz L01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuY3BwCmluZGV4IGQ4MjBmZjYuLjlkMjhlMDIg MTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuY3Bw CisrKyBiL1dlYktpdFRvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuY3BwCkBAIC01 OSw2ICs1OSw5IEBAIEJyb3dzZXJXaW5kb3c6OkJyb3dzZXJXaW5kb3coKQogICAgIHRoaXMtPnNl dENlbnRyYWxXaWRnZXQobV9icm93c2VyKTsKIAogICAgIG1fYnJvd3Nlci0+c2V0Rm9jdXMoUXQ6 Ok90aGVyRm9jdXNSZWFzb24pOworCisgICAgcmVzaXplKDk2MCwgNjQwKTsKKyAgICBzaG93KCk7 CiB9CiAKIHZvaWQgQnJvd3NlcldpbmRvdzo6bG9hZChjb25zdCBRU3RyaW5nJiB1cmwpCmRpZmYg LS1naXQgYS9XZWJLaXRUb29scy9NaW5pQnJvd3Nlci9xdC9tYWluLmNwcCBiL1dlYktpdFRvb2xz L01pbmlCcm93c2VyL3F0L21haW4uY3BwCmluZGV4IGU3M2JmN2IuLjc5MTM3NWQgMTAwNjQ0Ci0t LSBhL1dlYktpdFRvb2xzL01pbmlCcm93c2VyL3F0L21haW4uY3BwCisrKyBiL1dlYktpdFRvb2xz L01pbmlCcm93c2VyL3F0L21haW4uY3BwCkBAIC00NCwxMCArNDQsMTIgQEAgaW50IG1haW4oaW50 IGFyZ2MsIGNoYXIqKiBhcmd2KSB7CiAgICAgICAgICAgICB1cmxzLmFwcGVuZCgiaHR0cDovL3d3 dy5nb29nbGUuY29tIik7CiAgICAgfQogCi0gICAgQnJvd3NlcldpbmRvdyogd2luZG93ID0gMDsK LSAgICBmb3JlYWNoIChRU3RyaW5nIHVybCwgdXJscykgewotICAgICAgICB3aW5kb3cgPSBuZXcg QnJvd3NlcldpbmRvdygpOwotICAgICAgICB3aW5kb3ctPm5ld1dpbmRvdyh1cmwpOworICAgIEJy b3dzZXJXaW5kb3cqIHdpbmRvdyA9IG5ldyBCcm93c2VyV2luZG93KCk7CisgICAgd2luZG93LT5s b2FkKHVybHNbMF0pOworCisgICAgZm9yIChpbnQgaSA9IDE7IGkgPCB1cmxzLnNpemUoKTsgKytp KSB7CisgICAgICAgIEJyb3dzZXJXaW5kb3cqIG5ld1dpbmRvdyA9IHdpbmRvdy0+bmV3V2luZG93 KHVybHNbaV0pOworICAgICAgICBuZXdXaW5kb3ctPnNob3coKTsKICAgICB9CiAKICAgICBhcHAu ZXhlYygpOwo= 67038 2010-09-09 08:28:03 -0700 2010-09-09 09:02:57 -0700 proposed patch land_mbfix.diff text/plain 1834 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlMjMyY2U2Li4yYzg2YmQ5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDkt MDkgIEJhbGF6cyBLZWxlbWVuICA8a2JAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTWluaUJyb3dzZXIgZG9lcyBu b3Qgc3RhcnRzIHByb3Blcmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00NTQ1OQorCisgICAgICAgIERvIG5vdCB0cnkgc2V0IHVwIHRoZSBmaXJzdCB3 aW5kb3cgYnkgY2FsbGluZyBuZXdXaW5kb3cgb24gYQorICAgICAgICBuZXdseSBjcmVhdGVkIEJy b3dzZXJXaW5kb3cgc2luY2UgaXQgY3JlYXRlcyBhIG5ldyBvYmplY3QuCisgICAgICAgICogTWlu aUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5jcHA6CisgICAgICAgIChCcm93c2VyV2luZG93OjpC cm93c2VyV2luZG93KToKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9xdC9tYWluLmNwcDoKKyAgICAg ICAgKG1haW4pOgorCiAyMDEwLTA5LTA5ICBab2x0YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRpZmYgLS1naXQgYS9X ZWJLaXRUb29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93LmNwcCBiL1dlYktpdFRvb2xz L01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuY3BwCmluZGV4IGQ4MjBmZjYuLjlkMjhlMDIg MTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuY3Bw CisrKyBiL1dlYktpdFRvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuY3BwCkBAIC01 OSw2ICs1OSw5IEBAIEJyb3dzZXJXaW5kb3c6OkJyb3dzZXJXaW5kb3coKQogICAgIHRoaXMtPnNl dENlbnRyYWxXaWRnZXQobV9icm93c2VyKTsKIAogICAgIG1fYnJvd3Nlci0+c2V0Rm9jdXMoUXQ6 Ok90aGVyRm9jdXNSZWFzb24pOworCisgICAgcmVzaXplKDk2MCwgNjQwKTsKKyAgICBzaG93KCk7 CiB9CiAKIHZvaWQgQnJvd3NlcldpbmRvdzo6bG9hZChjb25zdCBRU3RyaW5nJiB1cmwpCmRpZmYg LS1naXQgYS9XZWJLaXRUb29scy9NaW5pQnJvd3Nlci9xdC9tYWluLmNwcCBiL1dlYktpdFRvb2xz L01pbmlCcm93c2VyL3F0L21haW4uY3BwCmluZGV4IGU3M2JmN2IuLjhmZjNkZTggMTAwNjQ0Ci0t LSBhL1dlYktpdFRvb2xzL01pbmlCcm93c2VyL3F0L21haW4uY3BwCisrKyBiL1dlYktpdFRvb2xz L01pbmlCcm93c2VyL3F0L21haW4uY3BwCkBAIC00NCwxMSArNDQsMTEgQEAgaW50IG1haW4oaW50 IGFyZ2MsIGNoYXIqKiBhcmd2KSB7CiAgICAgICAgICAgICB1cmxzLmFwcGVuZCgiaHR0cDovL3d3 dy5nb29nbGUuY29tIik7CiAgICAgfQogCi0gICAgQnJvd3NlcldpbmRvdyogd2luZG93ID0gMDsK LSAgICBmb3JlYWNoIChRU3RyaW5nIHVybCwgdXJscykgewotICAgICAgICB3aW5kb3cgPSBuZXcg QnJvd3NlcldpbmRvdygpOwotICAgICAgICB3aW5kb3ctPm5ld1dpbmRvdyh1cmwpOwotICAgIH0K KyAgICBCcm93c2VyV2luZG93KiB3aW5kb3cgPSBuZXcgQnJvd3NlcldpbmRvdygpOworICAgIHdp bmRvdy0+bG9hZCh1cmxzWzBdKTsKKworICAgIGZvciAoaW50IGkgPSAxOyBpIDwgdXJscy5zaXpl KCk7ICsraSkKKyAgICAgICAgd2luZG93LT5uZXdXaW5kb3codXJsc1tpXSk7CiAKICAgICBhcHAu ZXhlYygpOwogCg==