45458 2010-09-09 08:05:44 -0700 [Qt] always send an Accept header 2010-09-09 14:39:39 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 robert webkit-unassigned commit-queue oldest_to_newest 276463 0 robert 2010-09-09 08:05:44 -0700 See https://bugs.webkit.org/show_bug.cgi?id=33242 Ensure QtWebKit always sends an Accept header. This is required for compatibility with sites that expect the header in requests for subresources. When loading subresources, kov reports that "Safari seems to send an Accept header; Chromium sends Accept: */*, and works. Firefox sends a more specific header saying it prefers image/png, but accepts any image/* type. I guess it decided that because the resource is being loaded from an <img> tag." 276471 1 67036 robert 2010-09-09 08:13:15 -0700 Created attachment 67036 Patch 276479 2 67036 kling 2010-09-09 08:30:02 -0700 Comment on attachment 67036 Patch Nice! r=me 276773 3 67036 commit-queue 2010-09-09 14:39:34 -0700 Comment on attachment 67036 Patch Clearing flags on attachment: 67036 Committed r67118: <http://trac.webkit.org/changeset/67118> 276774 4 commit-queue 2010-09-09 14:39:39 -0700 All reviewed patches have been landed. Closing bug. 67036 2010-09-09 08:13:15 -0700 2010-09-09 14:39:34 -0700 Patch bug-45458-20100909161310.patch text/plain 3280 robert ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkMDM4NDExNWE1ZmZiOWExNjU0NjZmZjc4MDFkMjJlM2Y2YzRmZDJhLi44MDQ5Yjcx ZjY3NjM4ZjY5ZDJhMWZiNzFhNjMyOTI1YjgxNmQzMDc3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTAtMDktMDkgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gYWx3YXlzIHNlbmQg YW4gQWNjZXB0IGhlYWRlcgorCisgICAgICAgIEVuc3VyZSBRdFdlYktpdCBhbHdheXMgc2VuZHMg YW4gQWNjZXB0IGhlYWRlci4gVGhpcyBpcyByZXF1aXJlZAorICAgICAgICBmb3IgY29tcGF0aWJp bGl0eSB3aXRoIHNpdGVzIHRoYXQgZXhwZWN0IHRoZSBoZWFkZXIgaW4gcmVxdWVzdHMKKyAgICAg ICAgZm9yIHN1YnJlc291cmNlcy4KKworICAgICAgICBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTMzMjQyIGZvciBtb3JlLgorCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTQ1OAorCisgICAgICAgICogcGxhdGZvcm0v cXQvU2tpcHBlZDoKKwogMjAxMC0wOS0wOSAgQW5kcmV5IEtvc3lha292ICA8Y2FzZXFAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vcXQvU2tpcHBlZAppbmRleCA5NmQ3OTNlYmM2YmU3MjdhMDE1ZmMxYjA1MGM3NTFiMDNhMzcz YmJiLi40MzNhMjU0ZjdhMTBhNzFiNjE2YTY1YTNlMGEzMmUyMjA3NWU0NWQ0IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL3F0L1NraXBwZWQKQEAgLTE0NCwxMCArMTQ0LDYgQEAgaHR0cC90ZXN0cy9taXNjL2J1YmJs ZS1kcmFnLWV2ZW50cy5odG1sCiAjIFtRdF0gaHR0cC90ZXN0cy9taXNjL3Nsb3ctbG9hZGluZy1t YXNrLmh0bWwgdGltZWQgb3V0LgogaHR0cC90ZXN0cy9taXNjL3Nsb3ctbG9hZGluZy1tYXNrLmh0 bWwKIAotIyBRdCBtYXkgd2FudCB0byBmb2xsb3cgR1RLKyBpbiBhZGRpbmcgYSBkZWZhdWx0IEFj Y2VwdCBoZWFkZXIgZm9yCi0jIHN1YnJlc291cmNlcy4gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMzI0Mi4KLWh0dHAvdGVzdHMvbWlzYy9pbWFnZS1jaGVja3Mt Zm9yLWFjY2VwdC5odG1sCi0KICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM1ODI0IC0gRG9lc24ndCBhcHBseSB0byBwbGF0Zm9ybXMgdGhhdCBkb24ndCBlbmZvcmNl IHRoZSBDRk5ldHdvcmstc3R5bGUgM3JkIHBhcnR5IGNvb2tpZSBwb2xpY3kKIGh0dHAvdGVzdHMv Y29va2llcy90aGlyZC1wYXJ0eS1jb29raWUtcmVsYXhpbmcuaHRtbAogCmRpZmYgLS1naXQgYS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDNkMWZjYWI3MGY0NzIx MjlkMzBlMGQwY2U3NWY4NTA0MzZjMTg1OWEuLmMxNDA2ODFiNTIwZTViYjhkMzhiNDA2ODIzMDc4 ZjlhZmM1NGEyZDMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMDktMDkgIFJvYmVydCBIb2dhbiAgPHJv YmVydEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtRdF0gYWx3YXlzIHNlbmQgYW4gQWNjZXB0IGhlYWRlcgorCisgICAgICAgIEVu c3VyZSBRdFdlYktpdCBhbHdheXMgc2VuZHMgYW4gQWNjZXB0IGhlYWRlci4gVGhpcyBpcyByZXF1 aXJlZAorICAgICAgICBmb3IgY29tcGF0aWJpbGl0eSB3aXRoIHNpdGVzIHRoYXQgZXhwZWN0IHRo ZSBoZWFkZXIgaW4gcmVxdWVzdHMKKyAgICAgICAgZm9yIHN1YnJlc291cmNlcy4KKworICAgICAg ICBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzMjQyIGZvciBt b3JlLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 NTQ1OAorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9xdC9SZXNvdXJjZVJlcXVlc3RRdC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3Q6OnRvTmV0d29ya1JlcXVlc3Qp OgorCiAyMDEwLTA5LTA5ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCmRpZmYgLS1naXQgYS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUmVzb3VyY2VSZXF1ZXN0UXQuY3BwIGIvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlUmVxdWVzdFF0LmNwcAppbmRleCA2MzdjNzFmMTAx ZTZhNzI2MmNjN2VjNGFiOWZkZjI1MzdkNWY2NzcxLi40ZDU3NmM3MjFhM2RhMjQwODg5ZmQ2MmU2 MWZlM2U3OTc5N2IzMWI1IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQv UmVzb3VyY2VSZXF1ZXN0UXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9S ZXNvdXJjZVJlcXVlc3RRdC5jcHAKQEAgLTY0LDYgKzY0LDExIEBAIFFOZXR3b3JrUmVxdWVzdCBS ZXNvdXJjZVJlcXVlc3Q6OnRvTmV0d29ya1JlcXVlc3QoUU9iamVjdCogb3JpZ2luYXRpbmdGcmFt ZSkgY29uCiAgICAgICAgICAgICByZXF1ZXN0LnNldFJhd0hlYWRlcihuYW1lLCAiIik7CiAgICAg fQogCisgICAgLy8gTWFrZSBzdXJlIHdlIGFsd2F5cyBoYXZlIGFuIEFjY2VwdCBoZWFkZXI7IHNv bWUgc2l0ZXMgcmVxdWlyZSB0aGlzIHRvCisgICAgLy8gc2VydmUgc3VicmVzb3VyY2VzCisgICAg aWYgKCFyZXF1ZXN0Lmhhc1Jhd0hlYWRlcigiQWNjZXB0IikpCisgICAgICAgIHJlcXVlc3Quc2V0 UmF3SGVhZGVyKCJBY2NlcHQiLCAiKi8qIik7CisKICAgICBzd2l0Y2ggKGNhY2hlUG9saWN5KCkp IHsKICAgICBjYXNlIFJlbG9hZElnbm9yaW5nQ2FjaGVEYXRhOgogICAgICAgICByZXF1ZXN0LnNl dEF0dHJpYnV0ZShRTmV0d29ya1JlcXVlc3Q6OkNhY2hlTG9hZENvbnRyb2xBdHRyaWJ1dGUsIFFO ZXR3b3JrUmVxdWVzdDo6QWx3YXlzTmV0d29yayk7Cg==