45442 2010-09-09 00:14:01 -0700 [Qt] Modify load method of MiniBrowser's BrowserView class 2010-09-09 06:50:43 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 zoltan zoltan oldest_to_newest 276340 0 zoltan 2010-09-09 00:14:01 -0700 Based on discussion of bug #45173 : Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK. 276341 1 67002 zoltan 2010-09-09 00:15:09 -0700 Created attachment 67002 proposed patch 276433 2 67002 kling 2010-09-09 06:34:51 -0700 Comment on attachment 67002 proposed patch r=me 276438 3 67002 zoltan 2010-09-09 06:50:35 -0700 Comment on attachment 67002 proposed patch Clearing flags on attachment: 67002 Committed r67082: <http://trac.webkit.org/changeset/67082> 276439 4 zoltan 2010-09-09 06:50:43 -0700 All reviewed patches have been landed. Closing bug. 67002 2010-09-09 00:15:09 -0700 2010-09-09 06:50:34 -0700 proposed patch load.patch text/plain 2373 zoltan ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiOGRiZGFjLi5lMGZlNmIyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDkt MDkgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBNb2RpZnkgbG9hZCBtZXRob2Qg b2YgTWluaUJyb3dzZXIncyBCcm93c2VyVmlldyBjbGFzcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU0NDIKKworICAgICAgICBNb2RpZnkgbG9hZCBt ZXRob2QgdG8gdGFrZSBhIFFTdHJpbmcgYXMgYXJndW1lbnQsIHJlbW92ZSB1bm5lY2Vzc2FyeSBR VF9WRVJTSU9OX0NIRUNLLgorCisgICAgICAgICogTWluaUJyb3dzZXIvcXQvQnJvd3NlclZpZXcu Y3BwOgorICAgICAgICAoQnJvd3NlclZpZXc6OmxvYWQpOgorICAgICAgICAqIE1pbmlCcm93c2Vy L3F0L0Jyb3dzZXJWaWV3Lmg6CisgICAgICAgICogTWluaUJyb3dzZXIvcXQvQnJvd3NlcldpbmRv dy5jcHA6CisgICAgICAgIChCcm93c2VyV2luZG93Ojpsb2FkKToKKwogMjAxMC0wOS0wOCAgVmlj dG9yIFdhbmcgIDx2aWN0b3J3QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBP amFuIFZhZmFpLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3Nl clZpZXcuY3BwIGIvV2ViS2l0VG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlclZpZXcuY3BwCmlu ZGV4IDMxNDYzYWUuLmE1ZTA2ZWMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL01pbmlCcm93c2Vy L3F0L0Jyb3dzZXJWaWV3LmNwcAorKysgYi9XZWJLaXRUb29scy9NaW5pQnJvd3Nlci9xdC9Ccm93 c2VyVmlldy5jcHAKQEAgLTY0LDEzICs2NCw5IEBAIHZvaWQgQnJvd3NlclZpZXc6OnJlc2l6ZUV2 ZW50KFFSZXNpemVFdmVudCogZXZlbnQpCiAgICAgc2NlbmUoKS0+c2V0U2NlbmVSZWN0KHJlY3Qp OwogfQogCi12b2lkIEJyb3dzZXJWaWV3Ojpsb2FkKGNvbnN0IFFVcmwmIHVybCkKK3ZvaWQgQnJv d3NlclZpZXc6OmxvYWQoY29uc3QgUVN0cmluZyYgdXJsKQogewotI2lmIFFUX1ZFUlNJT04gPj0g UVRfVkVSU0lPTl9DSEVDSyg0LCA2LCAwKQotICAgIHJldHVybiBtX2l0ZW0tPmxvYWQoUVVybDo6 ZnJvbVVzZXJJbnB1dCh1cmwudG9TdHJpbmcoKSkpOwotI2Vsc2UKLSAgICByZXR1cm4gbV9pdGVt LT5sb2FkKHVybCk7Ci0jZW5kaWYKKyAgICByZXR1cm4gbV9pdGVtLT5sb2FkKFFVcmw6OmZyb21V c2VySW5wdXQodXJsKSk7CiB9CiAKIFFHcmFwaGljc1dLVmlldyogQnJvd3NlclZpZXc6OnZpZXco KSBjb25zdApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlclZp ZXcuaCBiL1dlYktpdFRvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJWaWV3LmgKaW5kZXggZTI2 NTk1OS4uNDJiNzY1OCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvTWluaUJyb3dzZXIvcXQvQnJv d3NlclZpZXcuaAorKysgYi9XZWJLaXRUb29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyVmlldy5o CkBAIC00MCw3ICs0MCw3IEBAIHB1YmxpYzoKICAgICBCcm93c2VyVmlldyhRV2lkZ2V0KiBwYXJl bnQgPSAwKTsKICAgICB2aXJ0dWFsIH5Ccm93c2VyVmlldygpIHsgZGVsZXRlIG1faXRlbTsgfQog Ci0gICAgdm9pZCBsb2FkKGNvbnN0IFFVcmwmKTsKKyAgICB2b2lkIGxvYWQoY29uc3QgUVN0cmlu ZyYpOwogICAgIFFHcmFwaGljc1dLVmlldyogdmlldygpIGNvbnN0OwogCiBwcm90ZWN0ZWQ6CmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93LmNwcCBi L1dlYktpdFRvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuY3BwCmluZGV4IDA4ZjAx NTUuLmQ4MjBmZjYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dz ZXJXaW5kb3cuY3BwCisrKyBiL1dlYktpdFRvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5k b3cuY3BwCkBAIC02NCw3ICs2NCw3IEBAIEJyb3dzZXJXaW5kb3c6OkJyb3dzZXJXaW5kb3coKQog dm9pZCBCcm93c2VyV2luZG93Ojpsb2FkKGNvbnN0IFFTdHJpbmcmIHVybCkKIHsKICAgICBtX2Fk ZHJlc3NCYXItPnNldFRleHQodXJsKTsKLSAgICBtX2Jyb3dzZXItPmxvYWQoUVVybCh1cmwpKTsK KyAgICBtX2Jyb3dzZXItPmxvYWQodXJsKTsKIH0KIAogQnJvd3NlcldpbmRvdyogQnJvd3Nlcldp bmRvdzo6bmV3V2luZG93KGNvbnN0IFFTdHJpbmcmIHVybCkK