45437 2010-09-08 21:17:45 -0700 [WML] Add a parameter to fix build break. 2010-09-09 02:25:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gyuyoung.kim webkit-unassigned commit-queue krit oldest_to_newest 276304 0 gyuyoung.kim 2010-09-08 21:17:45 -0700 In WMLSelectElement.h, the setSelectedIndexByUser() needs to have one more parameter. Because, parent class's setSelectedIndexByUser() has one more param. In SelectElement.h, => virtual void setSelectedIndexByUser(int index, bool deselect = true, bool fireOnChangeNow = false, bool allowMultipleSelection = false) = 0; In WMLSelectElement.h, => virtual void setSelectedIndexByUser(int index, bool deselect = true, bool fireOnChangeNow = false); However, the setSelectedIndexByUser's implementation has the param. It seems to me that he didn't consider wml header file when the patch owner make his patch. 276305 1 66995 gyuyoung.kim 2010-09-08 21:20:18 -0700 Created attachment 66995 Patch 276335 2 66995 krit 2010-09-08 23:55:50 -0700 Comment on attachment 66995 Patch r=me 276379 3 66995 commit-queue 2010-09-09 02:25:15 -0700 Comment on attachment 66995 Patch Clearing flags on attachment: 66995 Committed r67072: <http://trac.webkit.org/changeset/67072> 276380 4 commit-queue 2010-09-09 02:25:19 -0700 All reviewed patches have been landed. Closing bug. 66995 2010-09-08 21:20:18 -0700 2010-09-09 02:25:15 -0700 Patch patch-wml-select.txt text/plain 1331 gyuyoung.kim ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDZlNjU3ZS4uNzllYjhmZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0wOCAgR3l1eW91bmcgS2lt ICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtXTUxdIEFkZCBhIHBhcmFtZXRlciB0byBmaXggYnVpbGQg YnJlYWsuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 NTQzNworCisgICAgICAgIEluIFdNTFNlbGVjdEVsZW1lbnQuaCwgdGhlIHNldFNlbGVjdGVkSW5k ZXhCeVVzZXIoKSBuZWVkcyB0byBoYXZlIG9uZSBtb3JlIHBhcmFtZXRlci4gCisgICAgICAgIEJl Y2F1c2UsIHBhcmVudCBjbGFzcydzIHNldFNlbGVjdGVkSW5kZXhCeVVzZXIoKSBoYXMgb25lIG1v cmUgcGFyYW0uCisKKyAgICAgICAgKiB3bWwvV01MU2VsZWN0RWxlbWVudC5oOgorCiAyMDEwLTA5 LTA4ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3dtbC9XTUxTZWxlY3RFbGVtZW50 LmggYi9XZWJDb3JlL3dtbC9XTUxTZWxlY3RFbGVtZW50LmgKaW5kZXggMDBiNDY0OS4uMTZiYjM4 MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS93bWwvV01MU2VsZWN0RWxlbWVudC5oCisrKyBiL1dlYkNv cmUvd21sL1dNTFNlbGVjdEVsZW1lbnQuaApAQCAtNTEsNyArNTEsNyBAQCBwdWJsaWM6CiAKICAg ICB2aXJ0dWFsIGludCBzZWxlY3RlZEluZGV4KCkgY29uc3Q7CiAgICAgdmlydHVhbCB2b2lkIHNl dFNlbGVjdGVkSW5kZXgoaW50IGluZGV4LCBib29sIGRlc2VsZWN0ID0gdHJ1ZSk7Ci0gICAgdmly dHVhbCB2b2lkIHNldFNlbGVjdGVkSW5kZXhCeVVzZXIoaW50IGluZGV4LCBib29sIGRlc2VsZWN0 ID0gdHJ1ZSwgYm9vbCBmaXJlT25DaGFuZ2VOb3cgPSBmYWxzZSk7CisgICAgdmlydHVhbCB2b2lk IHNldFNlbGVjdGVkSW5kZXhCeVVzZXIoaW50IGluZGV4LCBib29sIGRlc2VsZWN0ID0gdHJ1ZSwg Ym9vbCBmaXJlT25DaGFuZ2VOb3cgPSBmYWxzZSwgYm9vbCBhbGxvd011bHRpcGxlU2VsZWN0aW9u ID0gZmFsc2UpOwogCiAgICAgdmlydHVhbCBpbnQgc2l6ZSgpIGNvbnN0IHsgcmV0dXJuIG1fZGF0 YS5zaXplKCk7IH0KICAgICB2aXJ0dWFsIGJvb2wgbXVsdGlwbGUoKSBjb25zdCB7IHJldHVybiBt X2RhdGEubXVsdGlwbGUoKTsgfQo=