4542 2005-08-20 14:37:40 -0700 run-webkit-tests should have --leaks option 2005-08-20 17:23:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 420+ Mac OS X 10.4 RESOLVED FIXED P4 Normal --- 1 eric eric oldest_to_newest 17019 0 eric 2005-08-20 14:37:40 -0700 run-webkit-tests should have --leaks option The attached patch adds such an option and fixes a couple leaks in DumpRenderTree (thus making this usable). 17020 1 3482 eric 2005-08-20 14:41:26 -0700 Created attachment 3482 run-webkit-tests --leaks patch 17024 2 3482 darin 2005-08-20 16:49:43 -0700 Comment on attachment 3482 run-webkit-tests --leaks patch Looks great to me. Could be quite useful. Ideally it would be silent if no leaks were found. 3482 2005-08-20 14:41:26 -0700 2005-08-20 16:49:43 -0700 run-webkit-tests --leaks patch leaks.patch text/plain 4344 eric SW5kZXg6IER1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLm0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls ZTogL2N2cy9yb290L1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLm0s dgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuOApkaWZmIC1wIC11IC1yMS44IER1bXBSZW5kZXJUcmVl L0R1bXBSZW5kZXJUcmVlLm0KLS0tIER1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLm0JMTgg QXVnIDIwMDUgMDU6NTk6MDcgLTAwMDAJMS44CisrKyBEdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVy VHJlZS5tCTIwIEF1ZyAyMDA1IDIxOjQyOjM0IC0wMDAwCkBAIC0xNzEsNiArMTcxLDEwIEBAIGlu dCBtYWluKGludCBhcmdjLCBjb25zdCBjaGFyICphcmd2W10pCiAgICAgW3ByZWZlcmVuY2VzIHNl dERlZmF1bHRGb250U2l6ZTpkZWZhdWx0Rm9udFNpemVdOwogICAgIFtwcmVmZXJlbmNlcyBzZXRE ZWZhdWx0Rml4ZWRGb250U2l6ZTpkZWZhdWx0Rml4ZWRGb250U2l6ZV07CiAgICAgW3ByZWZlcmVu Y2VzIHNldE1pbmltdW1Gb250U2l6ZTptaW5pbXVtRm9udFNpemVdOworICAgIAorICAgIFt3ZWJW aWV3IHJlbGVhc2VdOworICAgIFtkZWxlZ2F0ZSByZWxlYXNlXTsKKyAgICBbZWRpdGluZ0RlbGVn YXRlIHJlbGVhc2VdOwogCiAgICAgW3Bvb2wgcmVsZWFzZV07CiAgICAgcmV0dXJuIDA7CkBAIC00 NDYsNyArNDUwLDYgQEAgc3RhdGljIHZvaWQgZHVtcCh2b2lkKQogCiBzdGF0aWMgdm9pZCBkdW1w UmVuZGVyVHJlZShjb25zdCBjaGFyICpmaWxlbmFtZSkKIHsKLQogICAgIENGU3RyaW5nUmVmIGZp bGVuYW1lU3RyaW5nID0gQ0ZTdHJpbmdDcmVhdGVXaXRoQ1N0cmluZyhOVUxMLCBmaWxlbmFtZSwg a0NGU3RyaW5nRW5jb2RpbmdVVEY4KTsKICAgICBpZiAoZmlsZW5hbWVTdHJpbmcgPT0gTlVMTCkg ewogICAgICAgICBmcHJpbnRmKHN0ZGVyciwgImNhbid0IHBhcnNlIGZpbGVuYW1lIGFzIFVURi04 XG4iKTsKQEAgLTQ1NCw2ICs0NTcsNyBAQCBzdGF0aWMgdm9pZCBkdW1wUmVuZGVyVHJlZShjb25z dCBjaGFyICpmCiAgICAgfQogCiAgICAgQ0ZVUkxSZWYgVVJMID0gQ0ZVUkxDcmVhdGVXaXRoRmls ZVN5c3RlbVBhdGgoTlVMTCwgZmlsZW5hbWVTdHJpbmcsIGtDRlVSTFBPU0lYUGF0aFN0eWxlLCBG QUxTRSk7CisgICAgQ0ZSZWxlYXNlKGZpbGVuYW1lU3RyaW5nKTsKICAgICBpZiAoVVJMID09IE5V TEwpIHsKICAgICAgICAgZnByaW50ZihzdGRlcnIsICJjYW4ndCB0dXJuICVzIGludG8gYSBDRlVS TFxuIiwgZmlsZW5hbWUpOwogICAgICAgICByZXR1cm47CkBAIC00NjgsNiArNDcyLDcgQEAgc3Rh dGljIHZvaWQgZHVtcFJlbmRlclRyZWUoY29uc3QgY2hhciAqZgogCiAgICAgTlNBdXRvcmVsZWFz ZVBvb2wgKnBvb2wgPSBbW05TQXV0b3JlbGVhc2VQb29sIGFsbG9jXSBpbml0XTsKICAgICBbZnJh bWUgbG9hZFJlcXVlc3Q6W05TVVJMUmVxdWVzdCByZXF1ZXN0V2l0aFVSTDooTlNVUkwgKilVUkxd XTsKKyAgICBDRlJlbGVhc2UoVVJMKTsKICAgICBbcG9vbCByZWxlYXNlXTsKICAgICB3aGlsZSAo IWRvbmUpIHsKICAgICAgICAgcG9vbCA9IFtbTlNBdXRvcmVsZWFzZVBvb2wgYWxsb2NdIGluaXRd OwpJbmRleDogU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9j dnMvcm9vdC9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMsdgpyZXRyaWV2aW5n IHJldmlzaW9uIDEuMTMKZGlmZiAtcCAtdSAtcjEuMTMgU2NyaXB0cy9ydW4td2Via2l0LXRlc3Rz Ci0tLSBTY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMJMTggQXVnIDIwMDUgMDg6MzM6NDkgLTAwMDAJ MS4xMworKysgU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCTIwIEF1ZyAyMDA1IDIxOjQyOjM0IC0w MDAwCkBAIC0zMSw2ICszMSw3IEBACiB1c2Ugc3RyaWN0OwogdXNlIElQQzo6T3BlbjI7CiB1c2Ug R2V0b3B0OjpMb25nOwordXNlIEZpbGU6OlBhdGg7CiB1c2UgRmluZEJpbjsKIHVzZSBDd2Q7CiB1 c2UgbGliICRGaW5kQmluOjpCaW47CkBAIC01Nyw2ICs1OCw3IEBAIGNoZGlyV2ViS2l0KCk7CiAj IEFyZ3VtZW50IGhhbmRsaW5nCiBteSAkdGVzdFNWR3MgPSAnJzsKIG15ICRwaXhlbFRlc3RzID0g Jyc7CitteSAkY2hlY2tMZWFrcyA9ICcnOwogbXkgJG1heFdpZHRoID0gJyc7CiBteSAkbWF4SGVp Z2h0ID0gJyc7CiBteSAkdmVyYm9zZSA9ICcnOwpAQCAtNjQsNiArNjYsNyBAQCBteSAkcXVpZXQg PSAnJzsKIAogR2V0T3B0aW9ucygnc3ZnJyA9PiBcJHRlc3RTVkdzLCAKICAgICAncGl4ZWwtdGVz dHMnID0+IFwkcGl4ZWxUZXN0cywKKyAgICAnbGVha3MnID0+IFwkY2hlY2tMZWFrcywKICAgICAn bWF4LXdpZHRoJyA9PiBcJG1heFdpZHRoLAogICAgICdtYXgtaGVpZ2h0JyA9PiBcJG1heEhlaWdo dCwgCiAgICAgJ3ZlcmJvc2UnID0+IFwkdmVyYm9zZSwKQEAgLTEwMyw2ICsxMDYsOSBAQCBteSAk dGVzdFJlc3VsdHNEaXJlY3RvcnkgPSAiL3RtcC9sYXlvdXQtCiBteSAkdGVzdFJlc3VsdHMgPSAi JHRlc3RSZXN1bHRzRGlyZWN0b3J5L3Jlc3VsdHMuaHRtbCI7CiAKICRFTlZ7RFlMRF9GUkFNRVdP UktfUEFUSH0gPSAkcHJvZHVjdERpcjsKK2lmICgkY2hlY2tMZWFrcykgeworICAgICRFTlZ7TWFs bG9jU3RhY2tMb2dnaW5nfSA9IDE7Cit9CiAKIG15IEB0ZXN0czsKIApAQCAtMTU2LDEwICsxNjIs MTMgQEAgcHVzaCAgQHRvb2xBcmdzLCAiLSI7CiAKICR8ID0gMTsKIAotb3BlbjIoXCpJTiwgXCpP VVQsICR0b29sLCBAdG9vbEFyZ3MpIG9yIGRpZTsKK215ICR0b29sUElEOworbXkgJGltYWdlRGlm ZlRvb2xQSUQ7CisKKyR0b29sUElEID0gb3BlbjIoXCpJTiwgXCpPVVQsICR0b29sLCBAdG9vbEFy Z3MpIG9yIGRpZTsKIAogaWYgKCRwaXhlbFRlc3RzKSB7Ci0gICAgb3BlbjIoXCpESUZGSU4sIFwq RElGRk9VVCwgJGltYWdlRGlmZlRvb2wsICIiKSBvciBkaWUgInVuYWJsZSB0byBvcGVuICRpbWFn ZURpZmZUb29sXG4iOworICAgICRpbWFnZURpZmZUb29sUElEID0gb3BlbjIoXCpESUZGSU4sIFwq RElGRk9VVCwgJGltYWdlRGlmZlRvb2wsICIiKSBvciBkaWUgInVuYWJsZSB0byBvcGVuICRpbWFn ZURpZmZUb29sXG4iOwogfQogCiBteSAkY29sdW1uID0gMDsKQEAgLTMwMiw3ICszMTEsNyBAQCBm b3IgbXkgJHRlc3QgKEB0ZXN0cykgewogCiAgICAgICAgIG15ICRkaXIgPSAiJHRlc3RSZXN1bHRz RGlyZWN0b3J5LyRiYXNlIjsKICAgICAgICAgJGRpciA9fiBzfC9bXi9dKyR8fDsKLSAgICAgICAg c3lzdGVtICJta2RpciIsICItcCIsICRkaXI7CisgICAgICAgIG1rcGF0aCAkZGlyOwogCiAgICAg ICAgIG9wZW4gQUNUVUFMLCAiPiIsICIkdGVzdFJlc3VsdHNEaXJlY3RvcnkvJGJhc2UtYWN0dWFs LnR4dCIgb3IgZGllOwogICAgICAgICBwcmludCBBQ1RVQUwgJGFjdHVhbDsKQEAgLTM2OCw3ICsz NzcsNyBAQCBmb3IgbXkgJHRlc3QgKEB0ZXN0cykgewogCiAgICAgICAgIGNsb3NlIElOOwogICAg ICAgICBjbG9zZSBPVVQ7Ci0gICAgICAgIG9wZW4yKFwqSU4sIFwqT1VULCAkdG9vbCwgQHRvb2xB cmdzKSBvciBkaWU7CisgICAgICAgICR0b29sUElEID0gb3BlbjIoXCpJTiwgXCpPVVQsICR0b29s LCBAdG9vbEFyZ3MpIG9yIGRpZTsKICAgICB9CiAgICAgCiAgICAgJGNvdW50ICs9IDE7CkBAIC0z NzYsNiArMzg1LDE1IEBAIGZvciBteSAkdGVzdCAoQHRlc3RzKSB7CiAgICAgcHVzaCBAeyR0ZXN0 c3skcmVzdWx0fX0sICR0ZXN0OwogfQogCitpZiAoJGNoZWNrTGVha3MpIHsKKyAgICBwcmludCAi Q2hlY2tpbmcgZm9yIGxlYWtzIGluICR0b29sbmFtZTpcbiI7CisgICAgc3lzdGVtICJsZWFrcyIs ICR0b29sUElEOworICAgIGlmICgkcGl4ZWxUZXN0cykgeworICAgICAgICBwcmludCAiQ2hlY2tp bmcgZm9yIGxlYWtzIGluIEltYWdlRGlmZjpcbiI7CisgICAgICAgIHN5c3RlbSAibGVha3MiLCAk aW1hZ2VEaWZmVG9vbFBJRDsKKyAgICB9Cit9CisKIGNsb3NlIElOOwogY2xvc2UgT1VUOwogCkBA IC00MDgsNyArNDI2LDcgQEAgaWYgKCRjb3VudHN7bWF0Y2h9ICYmICRjb3VudHN7bWF0Y2h9ID09 IAogICAgICAgICB9CiAgICAgfQogICAgIAotICAgIHN5c3RlbSAibWtkaXIiLCAiLXAiLCAkdGVz dFJlc3VsdHNEaXJlY3Rvcnk7CisgICAgbWtwYXRoICR0ZXN0UmVzdWx0c0RpcmVjdG9yeTsKIAog ICAgIG9wZW4gSFRNTCwgIj4iLCAkdGVzdFJlc3VsdHMgb3IgZGllOwogICAgIHByaW50IEhUTUwg IjxodG1sPlxuIjsK