45418 2010-09-08 15:58:45 -0700 Improve CoreIPC encoding of strings 2010-09-08 18:48:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca abarth eric webkit.review.bot oldest_to_newest 276141 0 andersca 2010-09-08 15:58:45 -0700 Improve CoreIPC encoding of strings 276145 1 66954 andersca 2010-09-08 16:02:28 -0700 Created attachment 66954 Patch 276156 2 66954 darin 2010-09-08 16:17:10 -0700 Comment on attachment 66954 Patch > + // Before allocating the string, make sure that the decoder buffer is big enough. > + if (!decoder->bufferIsLargeEnoughtToContain<UChar>(length)) { This function name has a typo: "Enought". 276160 3 andersca 2010-09-08 16:29:06 -0700 Committed r67034: <http://trac.webkit.org/changeset/67034> 276262 4 webkit.review.bot 2010-09-08 18:48:55 -0700 http://trac.webkit.org/changeset/67034 might have broken SnowLeopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/67033 http://trac.webkit.org/changeset/67034 http://trac.webkit.org/changeset/67035 http://trac.webkit.org/changeset/67036 http://trac.webkit.org/changeset/67037 http://trac.webkit.org/changeset/67038 http://trac.webkit.org/changeset/67039 66954 2010-09-08 16:02:28 -0700 2010-09-08 16:17:10 -0700 Patch bug-45418-20100908160227.patch text/plain 2523 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg MjNkM2VlZGNmMThmOGU3NjI0ZmM5YTVkYzkzYmQ5YWMwMTBlNzU0Ni4uZjAwZmNmYjA0ZWY5MTky NjY3NTA3NWNkOWQ3NDE0NWVkN2E2MzBjZCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOS0wOCAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcHJvdmUgQ29yZUlQQyBlbmNvZGluZyBvZiBz dHJpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 NTQxOAorCisgICAgICAgIEVuY29kZSBhbmQgZGVjb2RlIG51bGwgU3RyaW5ncy4gQ2hlY2sgdGhh dCB0aGUgc3RyaW5nIGxlbmd0aCBpc24ndCBib2d1cy4KKworICAgICAgICAqIFNoYXJlZC9XZWJD b3JlQXJndW1lbnRDb2RlcnMuaDoKKwogMjAxMC0wOS0wOCAgQWRhbSBSb2JlbiAgPGFyb2JlbkBh cHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgd2F5IHRvIGNhdXNlIHRoZSB3ZWIgcHJvY2VzcyB0 byBjcmFzaCBhdCBhIHJhbmRvbSB0aW1lCmRpZmYgLS1naXQgYS9XZWJLaXQyL1NoYXJlZC9XZWJD b3JlQXJndW1lbnRDb2RlcnMuaCBiL1dlYktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVy cy5oCmluZGV4IGQ5NmE0YTI5OWYxN2YyODBjYWIzODgzMTliZjRhYWU3NmQ5ODcyYjIuLmY0MzNl ZjhlZmJlMWQ2ZmNmN2RmYTc0Njk1YmM1YzBlNTgyYzg2YjUgMTAwNjQ0Ci0tLSBhL1dlYktpdDIv U2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5oCisrKyBiL1dlYktpdDIvU2hhcmVkL1dlYkNv cmVBcmd1bWVudENvZGVycy5oCkBAIC0zNSw4ICszNSwxMSBAQAogI2luY2x1ZGUgPFdlYkNvcmUv SW50UmVjdC5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUGx1Z2luRGF0YS5oPgogI2luY2x1ZGUgPFdl YkNvcmUvUmVzb3VyY2VSZXF1ZXN0Lmg+CisjaW5jbHVkZSA8bGltaXRzPgogI2luY2x1ZGUgPHd0 Zi90ZXh0L1dURlN0cmluZy5oPgogCit1c2luZyBuYW1lc3BhY2Ugc3RkOworCiBuYW1lc3BhY2Ug Q29yZUlQQyB7CiAKIHRlbXBsYXRlPD4gc3RydWN0IEFyZ3VtZW50Q29kZXI8V2ViQ29yZTo6SW50 UG9pbnQ+IDogU2ltcGxlQXJndW1lbnRDb2RlcjxXZWJDb3JlOjpJbnRQb2ludD4geyB9OwpAQCAt NDYsNiArNDksMTIgQEAgdGVtcGxhdGU8PiBzdHJ1Y3QgQXJndW1lbnRDb2RlcjxXZWJDb3JlOjpJ bnRSZWN0PiA6IFNpbXBsZUFyZ3VtZW50Q29kZXI8V2ViQ29yZToKIHRlbXBsYXRlPD4gc3RydWN0 IEFyZ3VtZW50Q29kZXI8V1RGOjpTdHJpbmc+IHsKICAgICBzdGF0aWMgdm9pZCBlbmNvZGUoQXJn dW1lbnRFbmNvZGVyKiBlbmNvZGVyLCBjb25zdCBXVEY6OlN0cmluZyYgc3RyaW5nKQogICAgIHsK KyAgICAgICAgLy8gU3BlY2lhbCBjYXNlIHRoZSBudWxsIHN0cmluZy4KKyAgICAgICAgaWYgKHN0 cmluZy5pc051bGwoKSkgeworICAgICAgICAgICAgZW5jb2Rlci0+ZW5jb2RlVUludDMyKG51bWVy aWNfbGltaXRzPHVpbnQzMl90Pjo6bWF4KCkpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAg ICB9CisKICAgICAgICAgdWludDMyX3QgbGVuZ3RoID0gc3RyaW5nLmxlbmd0aCgpOwogICAgICAg ICBlbmNvZGVyLT5lbmNvZGUobGVuZ3RoKTsKICAgICAgICAgZW5jb2Rlci0+ZW5jb2RlQnl0ZXMo cmVpbnRlcnByZXRfY2FzdDxjb25zdCB1aW50OF90Kj4oc3RyaW5nLmNoYXJhY3RlcnMoKSksIGxl bmd0aCAqIHNpemVvZihVQ2hhcikpOwpAQCAtNTYsNiArNjUsMTggQEAgdGVtcGxhdGU8PiBzdHJ1 Y3QgQXJndW1lbnRDb2RlcjxXVEY6OlN0cmluZz4gewogICAgICAgICB1aW50MzJfdCBsZW5ndGg7 CiAgICAgICAgIGlmICghZGVjb2Rlci0+ZGVjb2RlKGxlbmd0aCkpCiAgICAgICAgICAgICByZXR1 cm4gZmFsc2U7CisKKyAgICAgICAgaWYgKGxlbmd0aCA9PSBudW1lcmljX2xpbWl0czx1aW50MzJf dD46Om1heCgpKSB7CisgICAgICAgICAgICAvLyBUaGlzIGlzIHRoZSBudWxsIHN0cmluZy4KKyAg ICAgICAgICAgIHMgPSBTdHJpbmcoKTsKKyAgICAgICAgICAgIHJldHVybiB0cnVlOworICAgICAg ICB9CisKKyAgICAgICAgLy8gQmVmb3JlIGFsbG9jYXRpbmcgdGhlIHN0cmluZywgbWFrZSBzdXJl IHRoYXQgdGhlIGRlY29kZXIgYnVmZmVyIGlzIGJpZyBlbm91Z2guCisgICAgICAgIGlmICghZGVj b2Rlci0+YnVmZmVySXNMYXJnZUVub3VnaHRUb0NvbnRhaW48VUNoYXI+KGxlbmd0aCkpIHsKKyAg ICAgICAgICAgIGRlY29kZXItPm1hcmtJbnZhbGlkKCk7CisgICAgICAgICAgICByZXR1cm4gZmFs c2U7CisgICAgICAgIH0KICAgICAgICAgCiAgICAgICAgIFVDaGFyKiBidWZmZXI7CiAgICAgICAg IFdURjo6U3RyaW5nIHN0cmluZyA9IFdURjo6U3RyaW5nOjpjcmVhdGVVbmluaXRpYWxpemVkKGxl bmd0aCwgYnVmZmVyKTsK