45415 2010-09-08 14:51:19 -0700 [chromium] Always do 2d canvas clearRect() in hardware 2010-09-08 18:49:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth eric kbr senorblanco webkit.review.bot oldest_to_newest 276089 0 jamesr 2010-09-08 14:51:19 -0700 [chromium] Always do 2d canvas clearRect() in hardware 276094 1 66946 jamesr 2010-09-08 14:57:50 -0700 Created attachment 66946 Patch 276096 2 jamesr 2010-09-08 14:58:46 -0700 This patch fixes fuzz on the edge of the FPS meter of the IE test drive pages caused by the end of the white FPS bar extending past the edge of the gradient. 276167 3 jamesr 2010-09-08 16:39:58 -0700 kling in IRC pointed out that we should _not_ apply a shadow to clearRect(), even though CoreGraphics does. There's still the issue that clearRect() is supposed to only clear within the active clipping region (this overclears), so this isn't patch isn't perfect, but it's better than what we do currently. 276174 4 66946 kbr 2010-09-08 16:49:26 -0700 Comment on attachment 66946 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66946&action=prettypatch Looks OK. 276178 5 jamesr 2010-09-08 16:54:56 -0700 Committed r67039: <http://trac.webkit.org/changeset/67039> 276263 6 webkit.review.bot 2010-09-08 18:49:09 -0700 http://trac.webkit.org/changeset/67039 might have broken SnowLeopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/67033 http://trac.webkit.org/changeset/67034 http://trac.webkit.org/changeset/67035 http://trac.webkit.org/changeset/67036 http://trac.webkit.org/changeset/67037 http://trac.webkit.org/changeset/67038 http://trac.webkit.org/changeset/67039 66946 2010-09-08 14:57:50 -0700 2010-09-08 16:49:26 -0700 Patch bug-45415-20100908145748.patch text/plain 2075 jamesr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzNkZDEzZGU3ZGUxMmVkNWYyYWNiNjkxNzc0YmIyMmI0NzlkNzk0MC4uMTI2MjE3Y2NiOWU5ZGUw ZDdlNjQxMTc0NmE4YTRkMmE1NzhmZDk1NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNCBAQAogMjAxMC0wOS0wOCAgSmFt ZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gQWx3YXlzIGRvIDJkIGNhbnZh cyBjbGVhclJlY3QoKSBpbiBoYXJkd2FyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDU0MTUKKworICAgICAgICByNjcwMDMgZm9yY2VkIENhbnZhcyAy ZCdzIGNsZWFyUmVjdCgpIHRvIGhhcHBlbiBpbiBzb2Z0d2FyZSBpZiBhIGdyYWRpZW50L3NoYWRv dy9ldGMgd2FzCisgICAgICAgIGFjdGl2ZS4gIFRoaXMgaXMgc3VidGx5IHdyb25nIGZvciBtaXhl ZCBtb2RlIHJlbmRlcmluZyBzaW5jZSBpdCByZXN1bHRzIGluIG9ubHkgdGhlCisgICAgICAgIHNv ZnR3YXJlIGJhY2tpbmcgc3RvcmUgYmVpbmcgY2xlYXJlZCBhbmQgbm90IHRoZSBoYXJkd2FyZS4g IFRoaXMgZm9yY2VzIGNsZWFyUmVjdCgpIHRvCisgICAgICAgIGhhcHBlbiBpbiBoYXJkd2FyZS4g IFNpbmNlIHdlIHVwbG9hZCBtaXhlZCBtb2RlIHJlc3VsdHMgYmVmb3JlIGRvaW5nIGFueSBoYXJk d2FyZSBkcmF3CisgICAgICAgIHRoaXMgbWVhbnMgd2UgYWx3YXlzIGNsZWFyIGV2ZXJ5dGhpbmcu CisKKyAgICAgICAgVGVjaG5pY2FsbHksIHNoYWRvd3MgYXJlIHN1cHBvc2VkIHRvIGFwcGx5IHRv IGNsZWFyUmVjdCgpLiAgSG93ZXZlciB3ZSBkb24ndCByZXNwZWN0IHRoaXMKKyAgICAgICAgaW4g U2tpYSBjdXJyZW50bHkgKGFuZCBuZXZlciBoYXZlKSBzbyB0aGlzIGlzIG5vdCBhIGNoYW5nZSBp biBiZWhhdmlvci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3ND b250ZXh0U2tpYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OmNsZWFy UmVjdCk6CisKKzIwMTAtMDktMDggIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9y Zz4KKwogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJ1c3NlbGwuCiAKICAgICAgICAgW2No cm9taXVtXSBGb3JjZSBjYW52YXMgMmQgZHJhdyBjYWxscyB0byBoYXBwZW4gaW4gc29mdHdhcmUg aWYgYSBncmFkaWVudCwgcGF0dGVybiwgc2hhZG93LCBvciBjbGlwIGFyZSBhY3RpdmUKZGlmZiAt LWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lh LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lh LmNwcAppbmRleCAxZjkzODFkZTBlYmMxMmU4YWU4NjNmNTdmZmEyMzdkNDI2YTlhZGZjLi40ZWI4 MGFhZmRmNWU5MTBhODQ3NmQ3MzI2Yzg5ZGZlZDkzNDQ1YzMwIDEwMDY0NAotLS0gYS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5jcHAKKysrIGIvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFNraWEuY3BwCkBAIC0z MzgsNyArMzM4LDcgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OmNsZWFyUmVjdChjb25zdCBGbG9h dFJlY3QmIHJlY3QpCiAgICAgaWYgKHBhaW50aW5nRGlzYWJsZWQoKSkKICAgICAgICAgcmV0dXJu OwogCi0gICAgaWYgKHBsYXRmb3JtQ29udGV4dCgpLT51c2VHUFUoKSAmJiBwbGF0Zm9ybUNvbnRl eHQoKS0+Y2FuQWNjZWxlcmF0ZSgpKSB7CisgICAgaWYgKHBsYXRmb3JtQ29udGV4dCgpLT51c2VH UFUoKSkgewogICAgICAgICBwbGF0Zm9ybUNvbnRleHQoKS0+cHJlcGFyZUZvckhhcmR3YXJlRHJh dygpOwogICAgICAgICBwbGF0Zm9ybUNvbnRleHQoKS0+Z3B1Q2FudmFzKCktPmNsZWFyUmVjdChy ZWN0KTsKICAgICAgICAgcmV0dXJuOwo=