45413 2010-09-08 14:10:51 -0700 fix show_results in new-run-webkit-tests 2010-09-09 01:30:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony commit-queue dpranke eric ojan oldest_to_newest 276054 0 tony 2010-09-08 14:10:51 -0700 fix show_results in new-run-webkit-tests 276055 1 66939 tony 2010-09-08 14:11:20 -0700 Created attachment 66939 Patch 276058 2 tony 2010-09-08 14:12:58 -0700 In bug 45090, an assert was added that ensures filename_to_uri is only called on layout test files. This broke a caller in show_results_html_file, so fix the caller to not use filename_to_uri. 276059 3 tony 2010-09-08 14:13:29 -0700 I meant dpranke, not dglazkov. 276091 4 66939 dpranke 2010-09-08 14:54:19 -0700 Comment on attachment 66939 Patch LGTM. I waffled on removing the assertion instead, but I think that this is probably better. 276135 5 66939 eric 2010-09-08 15:51:14 -0700 Comment on attachment 66939 Patch um, just make filename_to_uri add an extra /, no? It will be ignored on platforms which dont' care. // is the same as / 276143 6 66953 tony 2010-09-08 15:59:37 -0700 Created attachment 66953 Patch 276144 7 66953 tony 2010-09-08 16:00:22 -0700 Comment on attachment 66953 Patch Actually, let's not even bother with file:/// since we're just passing the filename on the command line. 276363 8 66953 commit-queue 2010-09-09 01:30:51 -0700 Comment on attachment 66953 Patch Clearing flags on attachment: 66953 Committed r67069: <http://trac.webkit.org/changeset/67069> 276364 9 commit-queue 2010-09-09 01:30:56 -0700 All reviewed patches have been landed. Closing bug. 66939 2010-09-08 14:11:20 -0700 2010-09-08 15:59:33 -0700 Patch bug-45413-20100908140927.patch text/plain 1464 tony ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhZDlkYjYwN2NhZmQ0MzEyM2FlMmM3YWE4OGQ0Nzk5ZjhlNThiMmNmLi41YjRkNmYw OGViNTU2ZDNkNWI3MTdiZmJkYTJhNTA1MjExODQ4YzExIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMDktMDggIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBmaXggc2hvd19yZXN1bHRzIGlu IG5ldy1ydW4td2Via2l0LXRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00NTQxMworCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9jaHJvbWl1bS5weToKKwogMjAxMC0wOS0wOCAgUGV0ZXIgVmFyZ2EgIDxwdmFy Z2FAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUg Q2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkKaW5kZXggODExMDU2OGYxNDdiZjQ5YzJi NTcxODM2MTE0ODQ2NjYwMzlhYTk1Yi4uYWZlMmYxMWYzYmNmMzljZWFjMWJmZGJlNGEzOGFlZDhi NGFkNTQ0OCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9jaHJvbWl1bS5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CkBAIC0xODQsNyArMTg0LDExIEBAIGNsYXNz IENocm9taXVtUG9ydChiYXNlLlBvcnQpOgogICAgICAgICAgICAgc2h1dGlsLnJtdHJlZShjYWNo ZWRpcikKIAogICAgIGRlZiBzaG93X3Jlc3VsdHNfaHRtbF9maWxlKHNlbGYsIHJlc3VsdHNfZmls ZW5hbWUpOgotICAgICAgICB1cmkgPSBzZWxmLmZpbGVuYW1lX3RvX3VyaShyZXN1bHRzX2ZpbGVu YW1lKQorICAgICAgICB1cmkgPSBzZWxmLmdldF9hYnNvbHV0ZV9wYXRoKHJlc3VsdHNfZmlsZW5h bWUpCisgICAgICAgIGlmIHN5cy5wbGF0Zm9ybSBpbiAoJ2N5Z3dpbicsICd3aW4zMicpOgorICAg ICAgICAgICAgdXJpID0gImZpbGU6Ly8vIiArIHVyaQorICAgICAgICBlbHNlOgorICAgICAgICAg ICAgdXJpID0gImZpbGU6Ly8iICsgdXJpCiAgICAgICAgIGlmIHNlbGYuX29wdGlvbnMudXNlX2Ry dDoKICAgICAgICAgICAgICMgRklYTUU6IFRoaXMgc2hvdWxkIHVzZSBVc2VyLm9wZW5fdXJsCiAg ICAgICAgICAgICB3ZWJicm93c2VyLm9wZW4odXJpLCBuZXc9MSkK 66953 2010-09-08 15:59:37 -0700 2010-09-09 01:30:50 -0700 Patch bug-45413-20100908155743.patch text/plain 1213 tony SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY3MDMwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDktMDggIFRvbnkgQ2hhbmcgIDx0b255 QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBmaXggc2hvd19yZXN1bHRzIGluIG5ldy1ydW4td2Via2l0LXRlc3RzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTQxMworCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weToKKwogMjAx MC0wOS0wOCAgVmljdG9yIFdhbmcgIDx2aWN0b3J3QGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBPamFuIFZhZmFpLgpJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CShyZXZpc2lv biA2NzAzMCkKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvY2hyb21pdW0ucHkJKHdvcmtpbmcgY29weSkKQEAgLTE4NCw3ICsxODQsNyBAQCBjbGFzcyBD aHJvbWl1bVBvcnQoYmFzZS5Qb3J0KToKICAgICAgICAgICAgIHNodXRpbC5ybXRyZWUoY2FjaGVk aXIpCiAKICAgICBkZWYgc2hvd19yZXN1bHRzX2h0bWxfZmlsZShzZWxmLCByZXN1bHRzX2ZpbGVu YW1lKToKLSAgICAgICAgdXJpID0gc2VsZi5maWxlbmFtZV90b191cmkocmVzdWx0c19maWxlbmFt ZSkKKyAgICAgICAgdXJpID0gc2VsZi5nZXRfYWJzb2x1dGVfcGF0aChyZXN1bHRzX2ZpbGVuYW1l KQogICAgICAgICBpZiBzZWxmLl9vcHRpb25zLnVzZV9kcnQ6CiAgICAgICAgICAgICAjIEZJWE1F OiBUaGlzIHNob3VsZCB1c2UgVXNlci5vcGVuX3VybAogICAgICAgICAgICAgd2ViYnJvd3Nlci5v cGVuKHVyaSwgbmV3PTEpCg==