45412 2010-09-08 14:05:25 -0700 Fix a problem in createCanonicalUUIDString that causes the last digit missing on Linux 2010-09-08 20:11:26 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 1 jianli jianli abarth dimich eric levin webkit.review.bot oldest_to_newest 276051 0 jianli 2010-09-08 14:05:25 -0700 Fix a problem in createCanonicalUUIDString that causes the last digit missing on Linux 276057 1 66940 jianli 2010-09-08 14:11:38 -0700 Created attachment 66940 Proposed Patch 276060 2 66940 darin 2010-09-08 14:15:21 -0700 Comment on attachment 66940 Proposed Patch > char uuidStr[37] = {0}; There's no reason to initialize this. The fgets function will fill in the array including adding the '\0' terminator if it succeeds. And if it fails we don’t look at the array in our code. 276061 3 66940 darin 2010-09-08 14:15:52 -0700 Comment on attachment 66940 Proposed Patch > char uuidStr[37] = {0}; > - if (!fgets(uuidStr, sizeof(uuidStr) - 1, fptr)) > + if (!fgets(uuidStr, sizeof(uuidStr), fptr)) > return String(); > fclose(fptr); This code leaks a file descriptor if fgets fails. We still need to call fclose, even if fgets failed. 276080 4 jianli 2010-09-08 14:41:24 -0700 All fixed. Committed as http://trac.webkit.org/changeset/67017. 276287 5 webkit.review.bot 2010-09-08 20:11:26 -0700 http://trac.webkit.org/changeset/67017 might have broken Leopard Intel Debug (Tests) 66940 2010-09-08 14:11:38 -0700 2010-09-08 14:15:52 -0700 Proposed Patch 45412 text/plain 2573 jianli ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmMzkxZDMxLi40YjYwZWYyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDkt MDggIEppYW4gTGkgIDxqaWFubGlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhIHByb2JsZW0gaW4gY3JlYXRlQ2Fub25p Y2FsVVVJRFN0cmluZyB0aGF0IGNhdXNlcyB0aGUgbGFzdCBkaWdpdAorICAgICAgICBtaXNzaW5n IG9uIExpbnV4LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDU0MTIKKworICAgICAgICBSZW1vdmUgdGhlIHRlc3QgdGhhdCBpcyBub3cgcGFzc2luZyBv biBMaW51eCBmb3IgY2hyb21pdW0uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0 X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTAtMDktMDggIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgQ2FybHNvbi4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCBm OTBhZDIwLi44MGIzZWJjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1 bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21p dW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CkBAIC0yNTUzLDkgKzI1NTMsNiBAQCBCVUc0MTIwNiA6 IGZhc3QvaGlzdG9yeS9tdWx0aXBsZS1jbGFzc2VzLXZpc2l0ZWQuaHRtbCA9IFRFWFQgVElNRU9V VAogQlVHNDEyOTIgOiBmYXN0L3VybC9pcHY0Lmh0bWwgPSBURVhUIFRJTUVPVVQKIEJVRzQxMjky IDogZmFzdC91cmwvYW5jaG9yLmh0bWwgPSBURVhUIFRJTUVPVVQKIAotLy8gQ2F1c2VkIGJ5IHI1 NzY5NS4gV2lsbCBpbnZlc3RpZ2F0ZS4KLUJVR19KSUFOTEkgTElOVVggOiBodHRwL3Rlc3RzL2xv Y2FsL2Zvcm1kYXRhL3NlbmQtZm9ybS1kYXRhLXdpdGgtc2xpY2VkLWZpbGUuaHRtbCA9IFRFWFQK LQogQlVHMzM4MTIgU0tJUCA6IGZhc3QvZG9tL2ljb24tdXJsLXByb3BlcnR5Lmh0bWwgPSBGQUlM CiAKIC8vIEZhaWxpbmcgd2l0aCB3ZWJraXQgcm9sbCA1NzY1OSAtPiA1NzY3Ny4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2I0MTM4Ny4u YmU1NTIyMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wOS0wOCAgSmlhbiBMaSAgPGppYW5saUBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRml4IGEgcHJvYmxlbSBpbiBjcmVhdGVDYW5vbmljYWxVVUlEU3RyaW5nIHRoYXQgY2F1c2Vz IHRoZSBsYXN0IGRpZ2l0CisgICAgICAgIG1pc3Npbmcgb24gTGludXguCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTQxMgorCisgICAgICAgIFRoaXMg aXMgY2F1c2VkIGJ5IG5vdCBpbmNsdWRpbmcgdGhlIGZpbmFsIG51bGwgY2hhcmFjdGVyIGludG8g dGhlIGNvdW50CisgICAgICAgIHRoYXQgaXMgcHJvdmlkZWQgdG8gZmdldHMuCisKKyAgICAgICAg VGhpcyBpcyBjb3ZlcmVkIGJ5IHRoZSBleGlzdGluZyB0ZXN0OiBzZW5kLWZvcm0tZGF0YS13aXRo LXNsaWNlZC1maWxlLmh0bWwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9VVUlELmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OmNyZWF0ZUNhbm9uaWNhbFVVSURTdHJpbmcpOgorCiAyMDEwLTA5LTA4ICBB bmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBi eSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vVVVJRC5jcHAgYi9X ZWJDb3JlL3BsYXRmb3JtL1VVSUQuY3BwCmluZGV4IDg1MmUzYWUuLjk4YTRhMDggMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGxhdGZvcm0vVVVJRC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9VVUlE LmNwcApAQCAtODUsNyArODUsNyBAQCBTdHJpbmcgY3JlYXRlQ2Fub25pY2FsVVVJRFN0cmluZygp CiAgICAgaWYgKCFmcHRyKQogICAgICAgICByZXR1cm4gU3RyaW5nKCk7CiAgICAgY2hhciB1dWlk U3RyWzM3XSA9IHswfTsKLSAgICBpZiAoIWZnZXRzKHV1aWRTdHIsIHNpemVvZih1dWlkU3RyKSAt IDEsIGZwdHIpKQorICAgIGlmICghZmdldHModXVpZFN0ciwgc2l6ZW9mKHV1aWRTdHIpLCBmcHRy KSkKICAgICAgICAgcmV0dXJuIFN0cmluZygpOwogICAgIGZjbG9zZShmcHRyKTsKICAgICBTdHJp bmcgY2Fub25pY2FsVXVpZFN0ciA9IFN0cmluZyh1dWlkU3RyKS5sb3dlcigpOyAvLyBtYWtlIGl0 IGxvd2VyLgo=