45404 2010-09-08 11:43:02 -0700 Null deref in RenderBlock::updateFirstLetter() 2010-09-10 03:04:55 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 cdn webkit-unassigned cdn commit-queue oldest_to_newest 275963 0 cdn 2010-09-08 11:43:02 -0700 With first-letter style there is a null deref when getCachedPseudoStyle() returns a null RenderStyle. The attached repro will trigger it. Patch to follow shortly. 275964 1 66919 cdn 2010-09-08 11:43:28 -0700 Created attachment 66919 repro 275966 2 66920 cdn 2010-09-08 11:50:53 -0700 Created attachment 66920 Patch 277077 3 66920 cfleizach 2010-09-10 01:59:45 -0700 Comment on attachment 66920 Patch r=me 277092 4 66920 commit-queue 2010-09-10 03:04:51 -0700 Comment on attachment 66920 Patch Clearing flags on attachment: 66920 Committed r67184: <http://trac.webkit.org/changeset/67184> 277093 5 commit-queue 2010-09-10 03:04:55 -0700 All reviewed patches have been landed. Closing bug. 66919 2010-09-08 11:43:28 -0700 2010-09-08 11:43:28 -0700 repro first-letter-null.html text/html 258 cdn PHNjcmlwdD4KICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICAgICAgbGF5 b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwo8L3NjcmlwdD4KPHN0eWxlPio6bnRoLWNo aWxkKDIpOmZpcnN0LWxldHRlciB7IHZlcnRpY2FsLWFsaWduOiBzdXBlcjsgfTwvc3R5bGU+Cjxh Pi4uLjwvYT48ZGVsIHN0eWxlPSJkaXNwbGF5OnRhYmxlLWNlbGw7Ij5UaGlzIHRleHQgc2hvdWxk IGJlIGRpc3BsYXllZCB3aXRob3V0IGNyYXNoaW5n 66920 2010-09-08 11:50:53 -0700 2010-09-10 03:04:51 -0700 Patch bug-45404-20100908115052.patch text/plain 3119 cdn SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Njk5OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDktMDggIENyaXMgTmVja2FyICA8Y2RuQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOdWxs IGRlcmVmIGluIFJlbmRlckJsb2NrOjp1cGRhdGVGaXJzdExldHRlcigpLiBDaGVjayBmb3IgbnVs bCBwc3VlZG8gc3R5bGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NTQwNAorCisgICAgICAgIFRlc3Q6IGZhc3QvZG9tL2ZpcnN0bGV0dGVyLXRhYmxl Y2VsbC1jcmFzaC5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OnVwZGF0ZUZpcnN0TGV0dGVyKToKKwogMjAx MC0wOS0wOCAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgUnViYmVy LXN0YW1wZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJC bG9jay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3Bw CShyZXZpc2lvbiA2Njk5NikKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNTE2OCw3ICs1MTY4LDExIEBAIHZvaWQgUmVuZGVyQmxvY2s6OnVw ZGF0ZUZpcnN0TGV0dGVyKCkKICAgICAgICAgLy8gQ3JlYXRlIG91ciBwc2V1ZG8gc3R5bGUgbm93 IHRoYXQgd2UgaGF2ZSBvdXIgZmlyc3RMZXR0ZXJDb250YWluZXIgZGV0ZXJtaW5lZC4KICAgICAg ICAgUmVuZGVyU3R5bGUqIHBzZXVkb1N0eWxlID0gZmlyc3RMZXR0ZXJCbG9jay0+Z2V0Q2FjaGVk UHNldWRvU3R5bGUoRklSU1RfTEVUVEVSLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmaXJzdExldHRlckNv bnRhaW5lci0+Zmlyc3RMaW5lU3R5bGUoKSk7Ci0gICAgICAgIAorICAgICAgICBpZiAoIXBzZXVk b1N0eWxlKSB7CisgICAgICAgICAgICB2aWV3KCktPmVuYWJsZUxheW91dFN0YXRlKCk7CisgICAg ICAgICAgICByZXR1cm47CisgICAgICAgIH0gICAgICAgIAorCiAgICAgICAgIC8vIEZvcmNlIGlu bGluZSBkaXNwbGF5IChleGNlcHQgZm9yIGZsb2F0aW5nIGZpcnN0LWxldHRlcnMpCiAgICAgICAg IHBzZXVkb1N0eWxlLT5zZXREaXNwbGF5KHBzZXVkb1N0eWxlLT5pc0Zsb2F0aW5nKCkgPyBCTE9D SyA6IElOTElORSk7CiAgICAgICAgIHBzZXVkb1N0eWxlLT5zZXRQb3NpdGlvbihTdGF0aWNQb3Np dGlvbik7IC8vIENTUzIgc2F5cyBmaXJzdC1sZXR0ZXIgY2FuJ3QgYmUgcG9zaXRpb25lZC4KSW5k ZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHJldmlzaW9uIDY2OTk4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDktMDggIENyaXMgTmVja2FyICA8Y2RuQGNo cm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUZXN0IGZvciBudWxsIGRlcmVmIGluIFJlbmRlckJsb2NrOjp1cGRhdGVGaXJzdExldHRl cigpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU0 MDQKKworICAgICAgICAqIGZhc3QvZG9tL2ZpcnN0bGV0dGVyLXRhYmxlY2VsbC1jcmFzaC1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL2ZpcnN0bGV0dGVyLXRhYmxlY2Vs bC1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAxMC0wOS0wOCAgQW5keSBFc3RlcyAgPGFlc3Rlc0Bh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBDYXJsc29uLgpJbmRleDogTGF5 b3V0VGVzdHMvZmFzdC9kb20vZmlyc3RsZXR0ZXItdGFibGVjZWxsLWNyYXNoLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9maXJzdGxldHRlci10YWJsZWNl bGwtY3Jhc2gtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9k b20vZmlyc3RsZXR0ZXItdGFibGVjZWxsLWNyYXNoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSBAQAorLi4uVGhpcyB0ZXh0IHNob3VsZCBiZSBkaXNwbGF5ZWQgd2l0aG91dCBj cmFzaGluZwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vZmlyc3RsZXR0ZXItdGFibGVjZWxs LWNyYXNoLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vZmlyc3RsZXR0 ZXItdGFibGVjZWxsLWNyYXNoLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0 L2RvbS9maXJzdGxldHRlci10YWJsZWNlbGwtY3Jhc2guaHRtbAkocmV2aXNpb24gMCkKQEAgLTAs MCArMSw3IEBACis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cis8L3NjcmlwdD4KKzxzdHlsZT4q Om50aC1jaGlsZCgyKTpmaXJzdC1sZXR0ZXIgeyB2ZXJ0aWNhbC1hbGlnbjogc3VwZXI7IH08L3N0 eWxlPgorPGE+Li4uPC9hPjxkZWwgc3R5bGU9ImRpc3BsYXk6dGFibGUtY2VsbDsiPlRoaXMgdGV4 dCBzaG91bGQgYmUgZGlzcGxheWVkIHdpdGhvdXQgY3Jhc2hpbmcKKwo=