45394 2010-09-08 08:53:03 -0700 Canvas: Remove unnecessary null-check of canvas() in getImageData() 2010-09-08 09:07:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kling webkit-unassigned oldest_to_newest 275861 0 kling 2010-09-08 08:53:03 -0700 We do... ImageBuffer* buffer = canvas() ? canvas()->buffer() : 0; ...but canvas() is already dereferenced earlier in the function so there is no use in checking it for null here. 275862 1 66901 kling 2010-09-08 08:54:11 -0700 Created attachment 66901 Proposed patch 275867 2 66901 kling 2010-09-08 09:07:08 -0700 Comment on attachment 66901 Proposed patch Clearing flags on attachment: 66901 Committed r66988: <http://trac.webkit.org/changeset/66988> 275868 3 kling 2010-09-08 09:07:18 -0700 All reviewed patches have been landed. Closing bug. 66901 2010-09-08 08:54:11 -0700 2010-09-08 09:07:08 -0700 Proposed patch bug-45394.diff text/plain 1410 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTczMjE3Yi4uMjlhMDIwNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOS0wOCAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENhbnZhczogUmVtb3ZlIHVubmVjZXNzYXJ5IG51bGwtY2hl Y2sgb2YgY2FudmFzKCkgaW4gZ2V0SW1hZ2VEYXRhKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1Mzk0CisKKyAgICAgICAgY2FudmFzKCkgaXMgYWxy ZWFkeSBkZXJlZmVyZW5jZWQgZWFybGllciBpbiB0aGUgZnVuY3Rpb24gc28gdGhlcmUgaXMKKyAg ICAgICAgbm8gdXNlIGluIGNoZWNraW5nIGl0IGZvciBudWxsIGxhdGVyLgorCisgICAgICAgICog aHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6Z2V0SW1hZ2VEYXRhKToKKwogMjAxMC0wOS0w MyAgVmxhZCBCdXJsaWsgIDx2b2xvZGltaXIuYnVybGlrQG5va2lhLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9jYW52 YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcCBiL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2Fu dmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAppbmRleCA1MTAwOTUwLi43OTFhZDA0IDEwMDY0NAot LS0gYS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKKysr IGIvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCkBAIC0x NjA1LDcgKzE2MDUsNyBAQCBQYXNzUmVmUHRyPEltYWdlRGF0YT4gQ2FudmFzUmVuZGVyaW5nQ29u dGV4dDJEOjpnZXRJbWFnZURhdGEoZmxvYXQgc3gsIGZsb2F0IHN5LAogICAgICAgICBzY2FsZWRS ZWN0LnNldFdpZHRoKDEpOwogICAgIGlmIChzY2FsZWRSZWN0LmhlaWdodCgpIDwgMSkKICAgICAg ICAgc2NhbGVkUmVjdC5zZXRIZWlnaHQoMSk7Ci0gICAgSW1hZ2VCdWZmZXIqIGJ1ZmZlciA9IGNh bnZhcygpID8gY2FudmFzKCktPmJ1ZmZlcigpIDogMDsKKyAgICBJbWFnZUJ1ZmZlciogYnVmZmVy ID0gY2FudmFzKCktPmJ1ZmZlcigpOwogICAgIGlmICghYnVmZmVyKQogICAgICAgICByZXR1cm4g Y3JlYXRlRW1wdHlJbWFnZURhdGEoc2NhbGVkUmVjdC5zaXplKCkpOwogICAgIHJldHVybiBidWZm ZXItPmdldFVubXVsdGlwbGllZEltYWdlRGF0YShzY2FsZWRSZWN0KTsK