45374 2010-09-08 02:06:15 -0700 Web Inspector: Selecting "Inspect Element" always shows <body> instead of the inspected element 2010-09-10 09:47:32 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 spamfaenger loislo apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 275687 0 spamfaenger 2010-09-08 02:06:15 -0700 Hi there, if I have the inspector set to open at the bottom of the window and it is closed when I choose 'Inspect element' from the context menu after it is opened it always selects the body tag in the 'elements' pane instead of what was clicked. Workaround for now is to do the right click dance again as the second time seems to work more reliably. Still it is quite annoying and always takes some time to figure it out and gather that not the right thing was selected. 275705 1 loislo 2010-09-08 02:48:40 -0700 (In reply to comment #0) > Hi there, Could you please specify the browser name and version? 276475 2 67037 loislo 2010-09-09 08:20:45 -0700 Created attachment 67037 [patch] First iteration. 276507 3 joepeck 2010-09-09 09:26:18 -0700 Ilya, is there an explanation to go with this patch? 276529 4 loislo 2010-09-09 09:52:18 -0700 1. Open any page 2. Right-click on any element, select "Inspect Element" 3. Web Inspector is opened but the <body> element (for HTML) is focused rather than the selected element 4. Inspect the Web Inspector. An error message is logged in the console. The regression was introduced in http://trac.webkit.org/changeset/66012 - focusNode() is invoked in InspectorController::populateScriptObjects() before the main document is set for the InspectorDOMAgent instance (which makes focusNode() bail out prematurely). 276532 5 loislo 2010-09-09 09:52:46 -0700 *** Bug 45464 has been marked as a duplicate of this bug. *** 276535 6 joepeck 2010-09-09 09:55:00 -0700 As I wrote in the other bug. r=me if the explanation goes into the ChangeLog! =) 277120 7 loislo 2010-09-10 04:40:59 -0700 Committed r67185 M WebCore/ChangeLog M WebCore/inspector/InspectorController.cpp r67185 = 0e881294fa1aba4a75ffe861696dd21fa46f54a6 (refs/remotes/trunk) 277261 8 joepeck 2010-09-10 09:47:32 -0700 http://trac.webkit.org/changeset/67185 67037 2010-09-09 08:20:45 -0700 2010-09-09 09:56:42 -0700 [patch] First iteration. patch text/plain 1554 loislo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmZhMzYzMi4uMjUyYzhiNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOS0wOSAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViSW5zcGVjdG9yOiBTZWxlY3RpbmcgJ2luc3BlY3QgZWxl bWVudCcgYWx3YXlzIHNob3dzIGJvZHkgaW4gaW5zcGVjdG9yIGluc3RlYWQgb2YgY2xpY2tlZCBl bGVtZW50LgorICAgICAgICBJdCBpcyBoYXBwZW4gaWYgdGhlIGluc3BlY3RvciBpcyBub3Qgb3Bl bmVkIHlldC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ1Mzc0CisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVyOjpwb3B1bGF0ZVNjcmlwdE9iamVj dHMpOgorCiAyMDEwLTA5LTA4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcCBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckNvbnRyb2xsZXIuY3BwCmluZGV4IDFlMTMxZjcuLjg2OTU3NTggMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCisrKyBiL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCkBAIC02MDQsOCArNjA0LDcgQEAgdm9pZCBJbnNw ZWN0b3JDb250cm9sbGVyOjpwb3B1bGF0ZVNjcmlwdE9iamVjdHMoKQogCiAgICAgaWYgKG1fc2hv d0FmdGVyVmlzaWJsZSA9PSBsYXN0QWN0aXZlUGFuZWwpCiAgICAgICAgIG1fc2hvd0FmdGVyVmlz aWJsZSA9IHNldHRpbmcobGFzdEFjdGl2ZVBhbmVsKTsKLSAgICBpZiAobV9ub2RlVG9Gb2N1cykK LSAgICAgICAgZm9jdXNOb2RlKCk7CisKICAgICBzaG93UGFuZWwobV9zaG93QWZ0ZXJWaXNpYmxl KTsKIAogICAgIGlmIChtX3Jlc291cmNlVHJhY2tpbmdFbmFibGVkKQpAQCAtNjI4LDYgKzYyNyw5 IEBAIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6cG9wdWxhdGVTY3JpcHRPYmplY3RzKCkKIAog ICAgIG1fZG9tQWdlbnQtPnNldERvY3VtZW50KG1faW5zcGVjdGVkUGFnZS0+bWFpbkZyYW1lKCkt PmRvY3VtZW50KCkpOwogCisgICAgaWYgKG1fbm9kZVRvRm9jdXMpCisgICAgICAgIGZvY3VzTm9k ZSgpOworCiAgICAgaWYgKG1fZXhwaXJlZENvbnNvbGVNZXNzYWdlQ291bnQpCiAgICAgICAgIG1f ZnJvbnRlbmQtPnVwZGF0ZUNvbnNvbGVNZXNzYWdlRXhwaXJlZENvdW50KG1fZXhwaXJlZENvbnNv bGVNZXNzYWdlQ291bnQpOwogICAgIHVuc2lnbmVkIG1lc3NhZ2VDb3VudCA9IG1fY29uc29sZU1l c3NhZ2VzLnNpemUoKTsK