45373 2010-09-08 01:11:00 -0700 Fix warning in rendering/RenderBlock.cpp 2010-09-08 03:49:03 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 43191 1 ossy webkit-unassigned hyatt mitz oldest_to_newest 275666 0 ossy 2010-09-08 01:11:00 -0700 gcc warning introduced in http://trac.webkit.org/changeset/66900 ../../../WebCore/rendering/RenderBlock.cpp:3873: warning: suggest parentheses around && within || 275668 1 66855 ossy 2010-09-08 01:12:17 -0700 Created attachment 66855 proposed fix 275719 2 66855 kling 2010-09-08 03:37:37 -0700 Comment on attachment 66855 proposed fix r=me 275726 3 66855 ossy 2010-09-08 03:48:55 -0700 Comment on attachment 66855 proposed fix Clearing flags on attachment: 66855 Committed r66965: <http://trac.webkit.org/changeset/66965> 275727 4 ossy 2010-09-08 03:49:03 -0700 All reviewed patches have been landed. Closing bug. 66855 2010-09-08 01:12:17 -0700 2010-09-08 03:48:55 -0700 proposed fix 1.patch text/plain 1438 ossy SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Njk1NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDktMDggIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Vi a2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGaXggd2FybmluZyBpbiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDUzNzMKKworICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6 aGl0VGVzdENvbHVtbnMpOiBTdWdnZXN0ZWQgcGFyZW50aGVzZXMgYWRkZWQgYXJvdW5kICYmIHdp dGhpbiB8fAorCiAyMDEwLTA5LTA4ICBab2x0YW4gSGVyY3plZyAgPHpoZXJjemVnQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGlyayBTY2h1bHplLgpJbmRleDogV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJsb2NrLmNwcAkocmV2aXNpb24gNjY5NTUpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9jay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM4NzAsNyArMzg3MCw3IEBACiAgICAg ICAgICAgICBpZiAocmVzdWx0LmlzUmVjdEJhc2VkVGVzdCgpICYmICFjb2xSZWN0LmNvbnRhaW5z KHJlc3VsdC5yZWN0RnJvbVBvaW50KHgsIHkpKSkKICAgICAgICAgICAgICAgICBoaXRUZXN0Q29u dGVudHMocmVxdWVzdCwgcmVzdWx0LCB4LCB5LCBmaW5hbFgsIGZpbmFsWSwgaGl0VGVzdEFjdGlv bik7CiAgICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgcmV0dXJuIGhpdFRlc3RDb250 ZW50cyhyZXF1ZXN0LCByZXN1bHQsIHgsIHksIGZpbmFsWCwgZmluYWxZLCBoaXRUZXN0QWN0aW9u KSB8fCBoaXRUZXN0QWN0aW9uID09IEhpdFRlc3RGbG9hdCAmJiBoaXRUZXN0RmxvYXRzKHJlcXVl c3QsIHJlc3VsdCwgeCwgeSwgZmluYWxYLCBmaW5hbFkpOworICAgICAgICAgICAgICAgIHJldHVy biBoaXRUZXN0Q29udGVudHMocmVxdWVzdCwgcmVzdWx0LCB4LCB5LCBmaW5hbFgsIGZpbmFsWSwg aGl0VGVzdEFjdGlvbikgfHwgKGhpdFRlc3RBY3Rpb24gPT0gSGl0VGVzdEZsb2F0ICYmIGhpdFRl c3RGbG9hdHMocmVxdWVzdCwgcmVzdWx0LCB4LCB5LCBmaW5hbFgsIGZpbmFsWSkpOwogICAgICAg ICB9CiAgICAgfQogCg==