45370 2010-09-07 23:23:48 -0700 Would like WKBundleFrameRef to turn into WKFrameRef across postMessage boundary, a la PageRef 2010-09-08 07:38:01 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 sam webkit-unassigned webkit.review.bot oldest_to_newest 275630 0 sam 2010-09-07 23:23:48 -0700 We should have a way to transfer frame references across postMessage like we have for pages. 275631 1 sam 2010-09-07 23:24:00 -0700 <rdar://problem/8402804> 275633 2 66848 sam 2010-09-07 23:25:32 -0700 Created attachment 66848 Patch 275634 3 webkit.review.bot 2010-09-07 23:29:40 -0700 Attachment 66848 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/WebContextUserMessageCoders.h:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 275658 4 66848 jhoneycutt 2010-09-08 00:37:20 -0700 Comment on attachment 66848 Patch r=me 275829 5 sam 2010-09-08 07:38:01 -0700 Landed in r66981. 66848 2010-09-07 23:25:32 -0700 2010-09-08 00:37:20 -0700 Patch frameViaPM.diff text/plain 3980 sam SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Njk1NCkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDktMDcgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXb3VsZCBs aWtlIFdLQnVuZGxlRnJhbWVSZWYgdG8gdHVybiBpbnRvIFdLRnJhbWVSZWYgYWNyb3NzIHBvc3RN ZXNzYWdlIGJvdW5kYXJ5LCBhIGxhIFBhZ2VSZWYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg0 MDI4MDQ+CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 NTM3MAorCisgICAgICAgICogVUlQcm9jZXNzL1dlYkNvbnRleHRVc2VyTWVzc2FnZUNvZGVycy5o OgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0VXNlck1lc3NhZ2VFbmNvZGVyOjplbmNvZGUp OgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0VXNlck1lc3NhZ2VEZWNvZGVyOjpkZWNvZGUp OgorICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVVc2Vy TWVzc2FnZUNvZGVycy5oOgorICAgICAgICAoV2ViS2l0OjpJbmplY3RlZEJ1bmRsZVVzZXJNZXNz YWdlRW5jb2Rlcjo6ZW5jb2RlKToKKyAgICAgICAgKFdlYktpdDo6SW5qZWN0ZWRCdW5kbGVVc2Vy TWVzc2FnZURlY29kZXI6OmRlY29kZSk6CisKIDIwMTAtMDktMDcgIEtpbnVrbyBZYXN1ZGEgIDxr aW51a29AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGFub3RoZXIgUXQgcmVs ZWFzZSBidWlsZCBmaXggYXR0ZW1wdC4KSW5kZXg6IFdlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRl eHRVc2VyTWVzc2FnZUNvZGVycy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvVUlQcm9jZXNzL1dl YkNvbnRleHRVc2VyTWVzc2FnZUNvZGVycy5oCShyZXZpc2lvbiA2NjkzNikKKysrIFdlYktpdDIv VUlQcm9jZXNzL1dlYkNvbnRleHRVc2VyTWVzc2FnZUNvZGVycy5oCSh3b3JraW5nIGNvcHkpCkBA IC0yNiwxMSArMjYsMTMgQEAKICNpbmNsdWRlICJVc2VyTWVzc2FnZUNvZGVycy5oIgogI2luY2x1 ZGUgIldlYkNvbnRleHQuaCIKICNpbmNsdWRlICJXZWJQYWdlUHJveHkuaCIKKyNpbmNsdWRlICJX ZWJGcmFtZVByb3h5LmgiCiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCiAvLyBBZGRzCiAvLyAtIFBh Z2UgLT4gQnVuZGxlUGFnZQorLy8gLSBGcmFtZSAtPiBCdW5kbGVGcmFtZQogCiBjbGFzcyBXZWJD b250ZXh0VXNlck1lc3NhZ2VFbmNvZGVyIDogcHVibGljIFVzZXJNZXNzYWdlRW5jb2RlcjxXZWJD b250ZXh0VXNlck1lc3NhZ2VFbmNvZGVyPiB7CiBwdWJsaWM6CkBAIC01Myw2ICs1NSwxMSBAQCBw dWJsaWM6CiAgICAgICAgICAgICBlbmNvZGVyLT5lbmNvZGUocGFnZS0+cGFnZUlEKCkpOwogICAg ICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KKyAgICAgICAgY2FzZSBBUElPYmplY3Q6OlR5cGVG cmFtZTogeworICAgICAgICAgICAgV2ViRnJhbWVQcm94eSogZnJhbWUgPSBzdGF0aWNfY2FzdDxX ZWJGcmFtZVByb3h5Kj4obV9yb290KTsKKyAgICAgICAgICAgIGVuY29kZXItPmVuY29kZShmcmFt ZS0+ZnJhbWVJRCgpKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9CiAgICAgICAgIGRl ZmF1bHQ6CiAgICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICAgICAgICAgIGJy ZWFrOwpAQCAtNjIsNiArNjksNyBAQCBwdWJsaWM6CiAKIC8vIEFkZHMKIC8vICAgLSBQYWdlIC0+ IEJ1bmRsZVBhZ2UKKy8vICAgLSBGcmFtZSAtPiBCdW5kbGVGcmFtZQogCiBjbGFzcyBXZWJDb250 ZXh0VXNlck1lc3NhZ2VEZWNvZGVyIDogcHVibGljIFVzZXJNZXNzYWdlRGVjb2RlcjxXZWJDb250 ZXh0VXNlck1lc3NhZ2VEZWNvZGVyPiB7CiBwdWJsaWM6CkBAIC05Niw2ICsxMDQsMTMgQEAgcHVi bGljOgogICAgICAgICAgICAgY29kZXIubV9yb290ID0gY29kZXIubV9jb250ZXh0LT5wcm9jZXNz KCktPndlYlBhZ2UocGFnZUlEKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CisgICAg ICAgIGNhc2UgQVBJT2JqZWN0OjpUeXBlQnVuZGxlRnJhbWU6IHsKKyAgICAgICAgICAgIHVpbnQ2 NF90IGZyYW1lSUQ7CisgICAgICAgICAgICBpZiAoIWRlY29kZXItPmRlY29kZShmcmFtZUlEKSkK KyAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgICAgICBjb2Rlci5tX3Jvb3Qg PSBjb2Rlci5tX2NvbnRleHQtPnByb2Nlc3MoKS0+d2ViRnJhbWUoZnJhbWVJRCk7CisgICAgICAg ICAgICBicmVhazsKKyAgICAgICAgfQogICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOwogICAgICAgICB9CkluZGV4OiBXZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRC dW5kbGUvSW5qZWN0ZWRCdW5kbGVVc2VyTWVzc2FnZUNvZGVycy5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZVVzZXJNZXNzYWdl Q29kZXJzLmgJKHJldmlzaW9uIDY2OTM2KQorKysgV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVk QnVuZGxlL0luamVjdGVkQnVuZGxlVXNlck1lc3NhZ2VDb2RlcnMuaAkod29ya2luZyBjb3B5KQpA QCAtMjQsNiArMjQsNyBAQAogICovCiAKICNpbmNsdWRlICJVc2VyTWVzc2FnZUNvZGVycy5oIgor I2luY2x1ZGUgIldlYkZyYW1lLmgiCiAjaW5jbHVkZSAiV2ViUGFnZS5oIgogI2luY2x1ZGUgIldl YlByb2Nlc3MuaCIKIApAQCAtMzEsNiArMzIsNyBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKIAogLy8g QWRkcwogLy8gLSBCdW5kbGVQYWdlIC0+IFBhZ2UKKy8vIC0gQnVuZGxlRnJhbWUgLT4gRnJhbWUK IAogY2xhc3MgSW5qZWN0ZWRCdW5kbGVVc2VyTWVzc2FnZUVuY29kZXIgOiBwdWJsaWMgVXNlck1l c3NhZ2VFbmNvZGVyPEluamVjdGVkQnVuZGxlVXNlck1lc3NhZ2VFbmNvZGVyPiB7CiBwdWJsaWM6 CkBAIC01Myw2ICs1NSwxMSBAQCBwdWJsaWM6CiAgICAgICAgICAgICBlbmNvZGVyLT5lbmNvZGUo cGFnZS0+cGFnZUlEKCkpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KKyAgICAgICAg Y2FzZSBBUElPYmplY3Q6OlR5cGVCdW5kbGVGcmFtZTogeworICAgICAgICAgICAgV2ViRnJhbWUq IGZyYW1lID0gc3RhdGljX2Nhc3Q8V2ViRnJhbWUqPihtX3Jvb3QpOworICAgICAgICAgICAgZW5j b2Rlci0+ZW5jb2RlKGZyYW1lLT5mcmFtZUlEKCkpOworICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgIH0KICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgp OwogICAgICAgICAgICAgYnJlYWs7CkBAIC05NCw2ICsxMDEsMTMgQEAgcHVibGljOgogICAgICAg ICAgICAgY29kZXIubV9yb290ID0gV2ViUHJvY2Vzczo6c2hhcmVkKCkud2ViUGFnZShwYWdlSUQp OwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KKyAgICAgICAgY2FzZSBBUElPYmplY3Q6 OlR5cGVGcmFtZTogeworICAgICAgICAgICAgdWludDY0X3QgZnJhbWVJRDsKKyAgICAgICAgICAg IGlmICghZGVjb2Rlci0+ZGVjb2RlKGZyYW1lSUQpKQorICAgICAgICAgICAgICAgIHJldHVybiBm YWxzZTsKKyAgICAgICAgICAgIGNvZGVyLm1fcm9vdCA9IFdlYlByb2Nlc3M6OnNoYXJlZCgpLndl YkZyYW1lKGZyYW1lSUQpOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KICAgICAgICAg ZGVmYXVsdDoKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgfQo=