45360 2010-09-07 19:42:24 -0700 chromium/mac: Fix overrelease in ImageLayerChromium 2010-09-08 14:26:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 thakis thakis commit-queue dglazkov kbr vangelis oldest_to_newest 275554 0 thakis 2010-09-07 19:42:24 -0700 chromium/mac: Fix overrelease in ImageLayerChromium 275555 1 66831 thakis 2010-09-07 19:43:40 -0700 Created attachment 66831 Patch 275564 2 66831 kbr 2010-09-07 19:51:50 -0700 Comment on attachment 66831 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66831&action=prettypatch > WebCore/platform/graphics/chromium/ImageLayerChromium.cpp:112 > + CGColorSpaceRef> colorSpace = CGImageGetColorSpace(cgImage); Um, does this compile? If not, how was this fix tested? 275572 3 66835 thakis 2010-09-07 19:59:30 -0700 Created attachment 66835 Patch 275574 4 thakis 2010-09-07 20:01:15 -0700 (In reply to comment #2) > (From update of attachment 66831 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=66831&action=prettypatch > > > WebCore/platform/graphics/chromium/ImageLayerChromium.cpp:112 > > + CGColorSpaceRef> colorSpace = CGImageGetColorSpace(cgImage); > Um, does this compile? If not, how was this fix tested? Oops :-) I have a very sophisticated system where I do my changes in third_party/WebKit/WebCore for developing / testing and then I have a separate git WebKit checkout I upload my patches from. I copied the patch over to early and then tried to manually redo what I changed to get this to compile. Looks like I missed one place. Fixed. 275935 5 66835 dglazkov 2010-09-08 10:57:41 -0700 Comment on attachment 66835 Patch I _think_ I understand what you're doing here. 276068 6 66835 commit-queue 2010-09-08 14:26:27 -0700 Comment on attachment 66835 Patch Clearing flags on attachment: 66835 Committed r67015: <http://trac.webkit.org/changeset/67015> 276069 7 commit-queue 2010-09-08 14:26:31 -0700 All reviewed patches have been landed. Closing bug. 66831 2010-09-07 19:43:40 -0700 2010-09-07 19:59:27 -0700 Patch bug-45360-20100907194339.patch text/plain 2704 thakis ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWY3NGE5MTVkYTgxZGI0NjJiYjllNTE2MTFmZTY0OGU2MTMzMmZmNy4uMzM1N2NiZTkwZjc5NjVi YjcyNzAxMmNjNWJkY2NjMGJjOWMzYzEzNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0wNyAgTmlj byBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgY2hyb21pdW0vbWFjOiBGaXggb3ZlcnJlbGVhc2UgaW4g SW1hZ2VMYXllckNocm9taXVtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00NTM2MAorCisgICAgICAgIE9ubHkgcmVsZWFzZSBjb2xvclNwYWNlIGlmIHdl IGNyZWF0ZWQgaXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFn ZUxheWVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VMYXllckNocm9taXVt Ojp1cGRhdGVDb250ZW50cyk6CisKIDIwMTAtMDktMDcgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZy YXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQ2hyaXMgTWFycmluLgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFnZUxheWVyQ2hy b21pdW0uY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFnZUxheWVy Q2hyb21pdW0uY3BwCmluZGV4IDA5YjM4OGQ5ZjlkYjQ1YzI3ZDFjMjg3MWExOGMyNWFkZGIzMTg3 ZTYuLmMyYjE2YWY5NWMxY2RhZTE1Mzg5ODM5ZmYzMzczNzdkNTNjMjA2OGQgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vSW1hZ2VMYXllckNocm9taXVtLmNw cAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ltYWdlTGF5ZXJDaHJv bWl1bS5jcHAKQEAgLTEwOCw4ICsxMDgsOSBAQCB2b2lkIEltYWdlTGF5ZXJDaHJvbWl1bTo6dXBk YXRlQ29udGVudHMoKQogICAgIC8vIGNvbXBsZXRlbHkgb3ZlcndyaXRlIGl0cyBjb250ZW50cyB3 aXRoIHRoZSBpbWFnZSBiZWxvdy4KICAgICAvLyBUcnkgdG8gcmV1c2UgdGhlIGNvbG9yIHNwYWNl IGZyb20gdGhlIGltYWdlIHRvIHByZXNlcnZlIGl0cyBjb2xvcnMuCiAgICAgLy8gU29tZSBpbWFn ZXMgdXNlIGEgY29sb3Igc3BhY2UgKHN1Y2ggYXMgaW5kZXhlZCkgdW5zdXBwb3J0ZWQgYnkgdGhl IGJpdG1hcCBjb250ZXh0LgotICAgIFJldGFpblB0cjxDR0NvbG9yU3BhY2VSZWY+IGNvbG9yU3Bh Y2UoQWRvcHRDRiwgQ0dJbWFnZUdldENvbG9yU3BhY2UoY2dJbWFnZSkpOwotICAgIENHQ29sb3JT cGFjZU1vZGVsIGNvbG9yU3BhY2VNb2RlbCA9IENHQ29sb3JTcGFjZUdldE1vZGVsKGNvbG9yU3Bh Y2UuZ2V0KCkpOworICAgIFJldGFpblB0cjxDR0NvbG9yU3BhY2VSZWY+IGNvbG9yU3BhY2VSZWxl YXNlcjsKKyAgICBDR0NvbG9yU3BhY2VSZWY+IGNvbG9yU3BhY2UgPSBDR0ltYWdlR2V0Q29sb3JT cGFjZShjZ0ltYWdlKTsKKyAgICBDR0NvbG9yU3BhY2VNb2RlbCBjb2xvclNwYWNlTW9kZWwgPSBD R0NvbG9yU3BhY2VHZXRNb2RlbChjb2xvclNwYWNlKTsKICAgICBzd2l0Y2ggKGNvbG9yU3BhY2VN b2RlbCkgewogICAgIGNhc2Uga0NHQ29sb3JTcGFjZU1vZGVsTW9ub2Nocm9tZToKICAgICBjYXNl IGtDR0NvbG9yU3BhY2VNb2RlbFJHQjoKQEAgLTExOCwxMiArMTE5LDEzIEBAIHZvaWQgSW1hZ2VM YXllckNocm9taXVtOjp1cGRhdGVDb250ZW50cygpCiAgICAgY2FzZSBrQ0dDb2xvclNwYWNlTW9k ZWxEZXZpY2VOOgogICAgICAgICBicmVhazsKICAgICBkZWZhdWx0OgotICAgICAgICBjb2xvclNw YWNlLmFkb3B0Q0YoQ0dDb2xvclNwYWNlQ3JlYXRlRGV2aWNlUkdCKCkpOworICAgICAgICBjb2xv clNwYWNlUmVsZWFzZXIuYWRvcHRDRihDR0NvbG9yU3BhY2VDcmVhdGVEZXZpY2VSR0IoKSk7Cisg ICAgICAgIGNvbG9yU3BhY2UgPSBjb2xvclNwYWNlUmVsZWFzZXIuZ2V0KCk7CiAgICAgICAgIGJy ZWFrOwogICAgIH0KICAgICBSZXRhaW5QdHI8Q0dDb250ZXh0UmVmPiB0ZW1wQ29udGV4dChBZG9w dENGLCBDR0JpdG1hcENvbnRleHRDcmVhdGUodGVtcFZlY3Rvci5kYXRhKCksCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHdpZHRoLCBoZWlnaHQsIDgsIHRlbXBSb3dCeXRlcywKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29sb3JT cGFjZS5nZXQoKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgY29sb3JTcGFjZSwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAga0NH SW1hZ2VBbHBoYVByZW11bHRpcGxpZWRMYXN0KSk7CiAgICAgQ0dDb250ZXh0U2V0QmxlbmRNb2Rl KHRlbXBDb250ZXh0LmdldCgpLCBrQ0dCbGVuZE1vZGVDb3B5KTsKICAgICBDR0NvbnRleHREcmF3 SW1hZ2UodGVtcENvbnRleHQuZ2V0KCksCg== 66835 2010-09-07 19:59:30 -0700 2010-09-08 14:26:27 -0700 Patch bug-45360-20100907195929.patch text/plain 2703 thakis ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWY3NGE5MTVkYTgxZGI0NjJiYjllNTE2MTFmZTY0OGU2MTMzMmZmNy4uMzM1N2NiZTkwZjc5NjVi YjcyNzAxMmNjNWJkY2NjMGJjOWMzYzEzNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0wNyAgTmlj byBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgY2hyb21pdW0vbWFjOiBGaXggb3ZlcnJlbGVhc2UgaW4g SW1hZ2VMYXllckNocm9taXVtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00NTM2MAorCisgICAgICAgIE9ubHkgcmVsZWFzZSBjb2xvclNwYWNlIGlmIHdl IGNyZWF0ZWQgaXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFn ZUxheWVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VMYXllckNocm9taXVt Ojp1cGRhdGVDb250ZW50cyk6CisKIDIwMTAtMDktMDcgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZy YXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQ2hyaXMgTWFycmluLgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFnZUxheWVyQ2hy b21pdW0uY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFnZUxheWVy Q2hyb21pdW0uY3BwCmluZGV4IDA5YjM4OGQ5ZjlkYjQ1YzI3ZDFjMjg3MWExOGMyNWFkZGIzMTg3 ZTYuLjA2MGJiNDZiZDQ4ZjlhZjBiNGFhYWNjYzVjODE3MTBjN2YxYWNlYzEgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vSW1hZ2VMYXllckNocm9taXVtLmNw cAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ltYWdlTGF5ZXJDaHJv bWl1bS5jcHAKQEAgLTEwOCw4ICsxMDgsOSBAQCB2b2lkIEltYWdlTGF5ZXJDaHJvbWl1bTo6dXBk YXRlQ29udGVudHMoKQogICAgIC8vIGNvbXBsZXRlbHkgb3ZlcndyaXRlIGl0cyBjb250ZW50cyB3 aXRoIHRoZSBpbWFnZSBiZWxvdy4KICAgICAvLyBUcnkgdG8gcmV1c2UgdGhlIGNvbG9yIHNwYWNl IGZyb20gdGhlIGltYWdlIHRvIHByZXNlcnZlIGl0cyBjb2xvcnMuCiAgICAgLy8gU29tZSBpbWFn ZXMgdXNlIGEgY29sb3Igc3BhY2UgKHN1Y2ggYXMgaW5kZXhlZCkgdW5zdXBwb3J0ZWQgYnkgdGhl IGJpdG1hcCBjb250ZXh0LgotICAgIFJldGFpblB0cjxDR0NvbG9yU3BhY2VSZWY+IGNvbG9yU3Bh Y2UoQWRvcHRDRiwgQ0dJbWFnZUdldENvbG9yU3BhY2UoY2dJbWFnZSkpOwotICAgIENHQ29sb3JT cGFjZU1vZGVsIGNvbG9yU3BhY2VNb2RlbCA9IENHQ29sb3JTcGFjZUdldE1vZGVsKGNvbG9yU3Bh Y2UuZ2V0KCkpOworICAgIFJldGFpblB0cjxDR0NvbG9yU3BhY2VSZWY+IGNvbG9yU3BhY2VSZWxl YXNlcjsKKyAgICBDR0NvbG9yU3BhY2VSZWYgY29sb3JTcGFjZSA9IENHSW1hZ2VHZXRDb2xvclNw YWNlKGNnSW1hZ2UpOworICAgIENHQ29sb3JTcGFjZU1vZGVsIGNvbG9yU3BhY2VNb2RlbCA9IENH Q29sb3JTcGFjZUdldE1vZGVsKGNvbG9yU3BhY2UpOwogICAgIHN3aXRjaCAoY29sb3JTcGFjZU1v ZGVsKSB7CiAgICAgY2FzZSBrQ0dDb2xvclNwYWNlTW9kZWxNb25vY2hyb21lOgogICAgIGNhc2Ug a0NHQ29sb3JTcGFjZU1vZGVsUkdCOgpAQCAtMTE4LDEyICsxMTksMTMgQEAgdm9pZCBJbWFnZUxh eWVyQ2hyb21pdW06OnVwZGF0ZUNvbnRlbnRzKCkKICAgICBjYXNlIGtDR0NvbG9yU3BhY2VNb2Rl bERldmljZU46CiAgICAgICAgIGJyZWFrOwogICAgIGRlZmF1bHQ6Ci0gICAgICAgIGNvbG9yU3Bh Y2UuYWRvcHRDRihDR0NvbG9yU3BhY2VDcmVhdGVEZXZpY2VSR0IoKSk7CisgICAgICAgIGNvbG9y U3BhY2VSZWxlYXNlci5hZG9wdENGKENHQ29sb3JTcGFjZUNyZWF0ZURldmljZVJHQigpKTsKKyAg ICAgICAgY29sb3JTcGFjZSA9IGNvbG9yU3BhY2VSZWxlYXNlci5nZXQoKTsKICAgICAgICAgYnJl YWs7CiAgICAgfQogICAgIFJldGFpblB0cjxDR0NvbnRleHRSZWY+IHRlbXBDb250ZXh0KEFkb3B0 Q0YsIENHQml0bWFwQ29udGV4dENyZWF0ZSh0ZW1wVmVjdG9yLmRhdGEoKSwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgd2lkdGgsIGhlaWdodCwgOCwgdGVtcFJvd0J5dGVzLAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb2xvclNw YWNlLmdldCgpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBjb2xvclNwYWNlLAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBrQ0dJ bWFnZUFscGhhUHJlbXVsdGlwbGllZExhc3QpKTsKICAgICBDR0NvbnRleHRTZXRCbGVuZE1vZGUo dGVtcENvbnRleHQuZ2V0KCksIGtDR0JsZW5kTW9kZUNvcHkpOwogICAgIENHQ29udGV4dERyYXdJ bWFnZSh0ZW1wQ29udGV4dC5nZXQoKSwK