45359 2010-09-07 19:35:25 -0700 Rename poorly-named POD* classes 2010-09-08 11:17:55 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All ASSIGNED P2 Normal --- 44729 1 kbr kbr abarth cmarrin darin fishd jamesr senorblanco simon.fraser oldest_to_newest 275551 0 kbr 2010-09-07 19:35:25 -0700 The PODArena, PODRedBlackTree and PODIntervalTree classes recently added for https://bugs.webkit.org/show_bug.cgi?id=44729 are poorly named; they do not strictly allocate and operate upon only Plain Old Data. It has been pointed out that the naming convention does not add any value; the classes should be renamed. 275828 1 cmarrin 2010-09-08 07:37:07 -0700 I want to put in my vote for either getting rid of the prefix entirely. If it's unsavory to have a simple Arena class (because of the Arena.h file elsewhere) then perhaps it can be called RBTreeArena or something like that. Just some thoughts. 275888 2 fishd 2010-09-08 09:41:43 -0700 Another suggestion: PODArena -> ObjectArena (since it only knows how to allocate objects of a fixed type) PODRedBlackTree -> RedBlackTree PODIntervalTree -> IntervalTree One question is what to do with PODInterval. We could rename that Interval, but then it seems like we might be taking over a name that is quite generic sounding for this specific use. Interval cannot be an inner class of IntervalTree since it is a template argument to IntervalTree. Thoughts? 275919 3 cmarrin 2010-09-08 10:30:57 -0700 (In reply to comment #2) > Another suggestion: > > PODArena -> ObjectArena (since it only knows how to allocate objects of a fixed type) > PODRedBlackTree -> RedBlackTree > PODIntervalTree -> IntervalTree > > One question is what to do with PODInterval. We could rename that Interval, but then it seems like we might be taking over a name that is quite generic sounding for this specific use. Interval cannot be an inner class of IntervalTree since it is a template argument to IntervalTree. Thoughts? Currently these classes have a specific use. They are used for an accelerated 2D tesselator, right? Perhaps we could identify them as such, e.g., TessArena, TessRBTree, TessIntervalTree. Or is that too specific for their ultimate purpose? BTW, I think renaming RedBlackTree to RBTree is reasonable. It seems to be a common shorthand. 275954 4 fishd 2010-09-08 11:17:55 -0700 That suggestion sounds pretty good to me, but I defer to Ken in case I'm overlooking some intended use cases. Giving them a "namespace" like that means that we would also not need to prematurely add code to call destructors since we would very clearly be making these data structures domain specific (minimizing the risk of misuse).