45357 2010-09-07 19:01:40 -0700 new-run-webkit-tests - fix regression of unit tests on non-Mac platforms 2010-09-08 09:29:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke ojan tkent tony oldest_to_newest 275534 0 dpranke 2010-09-07 19:01:40 -0700 new-run-webkit-tests - fix regression of unit tests on non-Mac platforms 275536 1 66829 dpranke 2010-09-07 19:03:38 -0700 Created attachment 66829 Patch 275539 2 dpranke 2010-09-07 19:05:24 -0700 bug 45090 caused test-webkitpy to fail on non-mac platforms. This should fix things. 275540 3 66829 tkent 2010-09-07 19:08:13 -0700 Comment on attachment 66829 Patch Looks OK. 275544 4 dpranke 2010-09-07 19:23:29 -0700 Committed r66945: <http://trac.webkit.org/changeset/66945> 275545 5 dpranke 2010-09-07 19:24:24 -0700 landed w/ one additional change to not try to run the check_image_diff() unit test if the image diff executable is not available; for some reason, it doesn't seem to be available on the SnowLeopard Leaks bot. 275571 6 66834 dpranke 2010-09-07 19:57:42 -0700 Created attachment 66834 Patch 275575 7 dpranke 2010-09-07 20:01:26 -0700 Committed r66947: <http://trac.webkit.org/changeset/66947> 275876 8 66834 tony 2010-09-08 09:29:07 -0700 Comment on attachment 66834 Patch Only the last method counts in python. Clearing from the review queue. 66829 2010-09-07 19:03:38 -0700 2010-09-07 19:57:39 -0700 Patch bug-45357-20100907190337.patch text/plain 4352 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhZTQ5ZGZjNzkwZGQ2ZjVkYjExODQwZGE0M2RkODU2ZmJhNWIyMWVjLi5iMjQ1OWRh YjQ4ZjFlNGE4NzVmZDA4Y2MzM2YxMjE4YmE1YzM3NWI0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTAtMDktMDcgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHJlZ3Jlc3Npb24g aW50cm9kdWNlZCBpbiBwcmV2aW91cyBjaGFuZ2UgdG8gbmV3LXJ1bi13ZWJraXQtdGVzdHMKKyAg ICAgICAgKGJ1ZyA0NTA5MCkgdG8gbm90IHRyeSB0byBydW4gdW5pdHRlc3RzIGZvciB0aGUgTWFj IGltcGxlbWVudGF0aW9uCisgICAgICAgIG9mIHRoZSBQb3J0IGludGVyZmFjZSBpZiB3ZSBhcmVu J3QgcnVubmluZyBvbiBhIE1hYy4KKworICAgICAgICBBbHNvIGZpeCB0aGUgb3ZlcnJpZGVzIGlt cGxlbWVudGF0aW9uIG1vY2sgaW4gdGhlIGNocm9taXVtIHVuaXR0ZXN0cworICAgICAgICB0byBm aXggdGhlIGNhc2Ugd2hlcmUgdGhlcmUgYXJlIG92ZXJyaWRlcyBjaGVja2VkIGluIHRoYXQgY2F1 c2UKKyAgICAgICAgcHJvYmxlbXMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQ1MzU3CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2Nocm9taXVtX3VuaXR0ZXN0LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjX3VuaXR0ZXN0LnB5OgorICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcG9ydF90ZXN0Y2FzZS5weToKKwogMjAxMC0w OS0wMSAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBPamFuIFZhZmFpLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV91bml0dGVzdC5weSBiL1dlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fdW5pdHRlc3QucHkK aW5kZXggOTM5YjE1YjllYmI4NDQ5NzA1Y2QwOTViZWI0MTFiMjk0NDY5MjJjOC4uN2EwMDViMTcw NGU1OTYzM2E3MWI4YjU2NzUwOWJhMjQ0ZGQwOTk2YiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV91bml0dGVzdC5weQor KysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9t aXVtX3VuaXR0ZXN0LnB5CkBAIC0xMDgsNSArMTA4LDEwIEBAIGNsYXNzIENocm9taXVtRHJpdmVy VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAKICAgICAgICAgcG9ydC50ZXN0X2V4cGVjdGF0aW9u cyA9IGxhbWJkYTogIiIiQlVHX1RFU1QgU0tJUCA6IGZhc3QvanMvbm90LWdvb2QuanMgPSBURVhU CiBERUZFUiBMSU5VWCBXSU4gOiBmYXN0L2pzL3ZlcnktZ29vZC5qcyA9IFRJTUVPVVQgUEFTUyIi IgorICAgICAgICBwb3J0LnRlc3RfZXhwZWN0YXRpb25zX292ZXJyaWRlcyA9IGxhbWJkYTogJycK KwogICAgICAgICBza2lwcGVkX3Rlc3RzID0gcG9ydC5za2lwcGVkX2xheW91dF90ZXN0cyhleHRy YV90ZXN0X2ZpbGVzPVtmYWtlX3Rlc3QsIF0pCiAgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZSgiZmFz dC9qcy9ub3QtZ29vZC5qcyIgaW4gc2tpcHBlZF90ZXN0cykKKworaWYgX19uYW1lX18gPT0gJ19f bWFpbl9fJzoKKyAgICB1bml0dGVzdC5tYWluKCkKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjX3VuaXR0ZXN0LnB5IGIvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWNfdW5pdHRlc3QucHkK aW5kZXggYjU3OTcwMzlhNGI1M2RkZjc0ZDdkN2Q2OWQxZTY0NjY1YjY2OTk2ZS4uMTZjODdkMzRm MDUxMjhkNzUzOWU5YzBhMjc2MzllZWM2MmI0NmEwZiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWNfdW5pdHRlc3QucHkKKysrIGIv V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWNfdW5pdHRl c3QucHkKQEAgLTI3LDYgKzI3LDcgQEAKICMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJ U0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KIAogaW1wb3J0IFN0cmluZ0lP CitpbXBvcnQgc3lzCiBpbXBvcnQgdW5pdHRlc3QKIAogaW1wb3J0IG1hYwpAQCAtMzUsNiArMzYs OCBAQCBpbXBvcnQgcG9ydF90ZXN0Y2FzZQogCiBjbGFzcyBNYWNUZXN0KHBvcnRfdGVzdGNhc2Uu UG9ydFRlc3RDYXNlKToKICAgICBkZWYgbWFrZV9wb3J0KHNlbGYsIG9wdGlvbnM9cG9ydF90ZXN0 Y2FzZS5Nb2NrT3B0aW9ucygpKToKKyAgICAgICAgaWYgc3lzLnBsYXRmb3JtICE9ICdkYXJ3aW4n OgorICAgICAgICAgICAgcmV0dXJuIE5vbmUKICAgICAgICAgcG9ydF9vYmogPSBtYWMuTWFjUG9y dChvcHRpb25zPW9wdGlvbnMpCiAgICAgICAgIHBvcnRfb2JqLl9vcHRpb25zLnJlc3VsdHNfZGly ZWN0b3J5ID0gcG9ydF9vYmoucmVzdWx0c19kaXJlY3RvcnkoKQogICAgICAgICBwb3J0X29iai5f b3B0aW9ucy5jb25maWd1cmF0aW9uID0gJ1JlbGVhc2UnCkBAIC00Miw2ICs0NSw4IEBAIGNsYXNz IE1hY1Rlc3QocG9ydF90ZXN0Y2FzZS5Qb3J0VGVzdENhc2UpOgogCiAgICAgZGVmIHRlc3Rfc2tp cHBlZF9maWxlX3BhdGhzKHNlbGYpOgogICAgICAgICBwb3J0ID0gc2VsZi5tYWtlX3BvcnQoKQor ICAgICAgICBpZiBub3QgcG9ydDoKKyAgICAgICAgICAgIHJldHVybgogICAgICAgICBza2lwcGVk X3BhdGhzID0gcG9ydC5fc2tpcHBlZF9maWxlX3BhdGhzKCkKICAgICAgICAgIyBGSVhNRTogX3Nr aXBwZWRfZmlsZV9wYXRocyBzaG91bGQgcmV0dXJuIFdlYktpdC1yZWxhdGl2ZSBwYXRocy4KICAg ICAgICAgIyBTbyB0byBtYWtlIGl0IHVuaXQgdGVzdGFibGUsIHdlIHN0cmlwIHRoZSBXZWJLaXQg ZGlyZWN0b3J5IGZyb20gdGhlIHBhdGguCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3BvcnRfdGVzdGNhc2UucHkgYi9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3BvcnRfdGVzdGNhc2UucHkKaW5k ZXggN2E5NzkxNmMzNWFkMjEzMGQxZjBkMmU2ZGFjYzNhNTMyNTdhZWM2MC4uMDJkYTdiZDQyOGUz MTFmODg4ZDk1MDg2NmJiNjg5Y2NiN2I4YjA5NyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9wb3J0X3Rlc3RjYXNlLnB5CisrKyBiL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcG9ydF90ZXN0Y2Fz ZS5weQpAQCAtNTEsMTEgKzUxLDE2IEBAIGNsYXNzIFBvcnRUZXN0Q2FzZSh1bml0dGVzdC5UZXN0 Q2FzZSk6CiAKICAgICBkZWYgdGVzdF9odHRwX3NlcnZlcihzZWxmKToKICAgICAgICAgcG9ydCA9 IHNlbGYubWFrZV9wb3J0KCkKKyAgICAgICAgaWYgbm90IHBvcnQ6CisgICAgICAgICAgICByZXR1 cm4KICAgICAgICAgcG9ydC5zdGFydF9odHRwX3NlcnZlcigpCiAgICAgICAgIHBvcnQuc3RvcF9o dHRwX3NlcnZlcigpCiAKICAgICBkZWYgdGVzdF9pbWFnZV9kaWZmKHNlbGYpOgogICAgICAgICBw b3J0ID0gc2VsZi5tYWtlX3BvcnQoKQorICAgICAgICBpZiBub3QgcG9ydDoKKyAgICAgICAgICAg IHJldHVybgorCiAgICAgICAgIGRpciA9IHBvcnQubGF5b3V0X3Rlc3RzX2RpcigpCiAgICAgICAg IGZpbGUxID0gb3MucGF0aC5qb2luKGRpciwgJ2Zhc3QnLCAnY3NzJywgJ2J1dHRvbl9jZW50ZXIu cG5nJykKICAgICAgICAgZmlsZTIgPSBvcy5wYXRoLmpvaW4oZGlyLCAnZmFzdCcsICdjc3MnLApA QCAtNzIsNSArNzcsNyBAQCBjbGFzcyBQb3J0VGVzdENhc2UodW5pdHRlc3QuVGVzdENhc2UpOgog CiAgICAgZGVmIHRlc3Rfd2Vic29ja2V0X3NlcnZlcihzZWxmKToKICAgICAgICAgcG9ydCA9IHNl bGYubWFrZV9wb3J0KCkKKyAgICAgICAgaWYgbm90IHBvcnQ6CisgICAgICAgICAgICByZXR1cm4K ICAgICAgICAgcG9ydC5zdGFydF93ZWJzb2NrZXRfc2VydmVyKCkKICAgICAgICAgcG9ydC5zdG9w X3dlYnNvY2tldF9zZXJ2ZXIoKQo= 66834 2010-09-07 19:57:42 -0700 2010-09-08 09:29:07 -0700 Patch bug-45357-20100907195740.patch text/plain 1525 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkNzA5ZmQxMjJkZGI1OGQxYjkyOTNlN2MyY2IwZTU5MWNkYjE3NGYwLi5iOTdhOTgx M2Y0NThhM2M2ZmJkNjcxYWJkMDAxYjEwNmI1ZDFkZGUxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAK IDIwMTAtMDktMDcgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKKyAgICAg ICAgVW5yZXZpZXdlZCwgYnVpbGQgZml4CisKKyAgICAgICAgTWlzc2VkIG9uZSB0ZXN0IGluIG1h Y191bml0dGVzdC5weSBpbiBwcmV2aW91cyBjaGFuZ2U7IGZvciBzb21lCisgICAgICAgIHJlYXNv biB0aGUgbWV0aG9kIGlzIGxpc3RlZCB0d2ljZS4gSSB3aWxsIGZpeCBib3RoIGZvciBub3csIGJ1 dCB3aWxsCisgICAgICAgIGZpZ3VyZSB0aGlzIG91dCBpbiBhIGxhdGVyLCBub3QtdGltZS1zZW5z aXRpdmUgcGF0Y2guCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQ1MzU3CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L21hY191bml0dGVzdC5weToKKworMjAxMC0wOS0wNyAgRGlyayBQcmFua2UgIDxkcHJhbmtl QGNocm9taXVtLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4KIAogICAg ICAgICBGaXggcmVncmVzc2lvbiBpbnRyb2R1Y2VkIGluIHByZXZpb3VzIGNoYW5nZSB0byBuZXct cnVuLXdlYmtpdC10ZXN0cwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9tYWNfdW5pdHRlc3QucHkgYi9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21hY191bml0dGVzdC5weQppbmRleCAxNmM4N2Qz NGYwNTEyOGQ3NTM5ZTljMGEyNzYzOWVlYzYyYjQ2YTBmLi4zMjdiMTllZTVmYTU0NTAzYjRhZmMy OWI3MWUwMGU3OWJkYTU2ZjFiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L21hY191bml0dGVzdC5weQorKysgYi9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21hY191bml0dGVzdC5weQpAQCAtNzEs NiArNzEsOCBAQCBzdmcvYmF0aWsvdGV4dC9zbWFsbEZvbnRzLnN2ZwogCiAgICAgZGVmIHRlc3Rf c2tpcHBlZF9maWxlX3BhdGhzKHNlbGYpOgogICAgICAgICBwb3J0ID0gc2VsZi5tYWtlX3BvcnQo KQorICAgICAgICBpZiBub3QgcG9ydDoKKyAgICAgICAgICAgIHJldHVybgogICAgICAgICBza2lw cGVkX2ZpbGUgPSBTdHJpbmdJTy5TdHJpbmdJTyhzZWxmLmV4YW1wbGVfc2tpcHBlZF9maWxlKQog ICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHBvcnQuX3Rlc3RzX2Zyb21fc2tpcHBlZF9maWxlKHNr aXBwZWRfZmlsZSksIHNlbGYuZXhhbXBsZV9za2lwcGVkX3Rlc3RzKQogCg==