45356 2010-09-07 18:54:34 -0700 test-webkitpy: Fix load error of webkitpy/layout_tests/port/factory_unittest.py on Win32 Python 2010-09-08 07:54:30 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other Windows 7 RESOLVED FIXED P2 Normal --- 45342 1 tkent webkit-unassigned abarth cjerdonek dglazkov dpranke eric tony webkit.review.bot oldest_to_newest 275531 0 tkent 2010-09-07 18:54:34 -0700 test-webkitpy: INFO Suppressing most webkitpy logging while running unit tests. test-webkitpy: WARNING You are testing webkitpy with a Python version (2.6.2) higher than the minimum version (2.5) it was meant to support. webkitpy.test.main: INFO Excluding: webkitpy.common.checkout.scm_unittest (use --all to include) Traceback (most recent call last): File "./WebKitTools/Scripts/test-webkitpy", line 240, in <module> Tester().run_tests(sys.argv) File "D:\google-windows-2\chromium-win-release-tests\build\WebKitTools\Scripts\webkitpy\test\main.py", line 129, in run_tests unittest.main(argv=sys_argv, module=None) File "c:\depot_tools\python_bin\lib\unittest.py", line 816, in __init__ self.parseArgs(argv) File "c:\depot_tools\python_bin\lib\unittest.py", line 843, in parseArgs self.createTests() File "c:\depot_tools\python_bin\lib\unittest.py", line 849, in createTests self.module) File "c:\depot_tools\python_bin\lib\unittest.py", line 613, in loadTestsFromNames suites = [self.loadTestsFromName(name, module) for name in names] File "c:\depot_tools\python_bin\lib\unittest.py", line 584, in loadTestsFromName parent, obj = obj, getattr(obj, part) AttributeError: 'module' object has no attribute 'factory_unittest' 275533 1 66827 tkent 2010-09-07 18:58:32 -0700 Created attachment 66827 Patch 275541 2 dpranke 2010-09-07 19:17:29 -0700 Patch LGTM, but I'm not a reviewer. We need a better way of figuring out which unittests should run on a given platform. 275567 3 66827 tkent 2010-09-07 19:56:55 -0700 Comment on attachment 66827 Patch Clearing flags on attachment: 66827 Committed r66946: <http://trac.webkit.org/changeset/66946> 275568 4 tkent 2010-09-07 19:57:03 -0700 All reviewed patches have been landed. Closing bug. 275838 5 webkit.review.bot 2010-09-08 07:54:30 -0700 http://trac.webkit.org/changeset/66946 might have broken Leopard Intel Debug (Tests) 66827 2010-09-07 18:58:32 -0700 2010-09-07 19:56:55 -0700 Patch bug-45356-20100908105830.patch text/plain 1568 tkent ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2ZjNjYWNiODhiM2NmMjBmNTQ4ZGIxMjc0ZDQ0Njg4MGUxM2E1ZDRjLi5mZGJhNzlh NmRiMTNlZDQ3NzFmMTYyNjBkODU1YjdhN2Q0MmVlNWRjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMDktMDcgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHRlc3Qtd2Via2l0cHk6IEZp eCBsb2FkIGVycm9yIG9mCisgICAgICAgIHdlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2ZhY3Rv cnlfdW5pdHRlc3QucHkgb24gV2luMzIgUHl0aG9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTM1NiBOZWVkIGEgc2hvcnQKKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvc2VydmVyX3Byb2Nlc3MucHk6CisgICAg ICAgICAgQXZvaWQgdG8gaW1wb3J0IGZjbnRsIG9uIHdpbjMyLiBXaW4zMiBQeXRob24gZG9lc24n dCBoYXZlIGZjbnRsCisgICAgICAgICAgYW5kIHdlIGRvbid0IHVzZSBzZXJ2ZXJfcHJvY2Vzcy5w eSBvbiBXaW4zMiBQeXRob24uIEhvd2V2ZXIKKyAgICAgICAgICB1bml0dGVzdC5weSB0cmllcyB0 byBsb2FkIGV2ZXJ5dGhpbmcgaW4gYSBtb2R1bGUuCisKIDIwMTAtMDktMDcgIEpvc2VwaCBQZWNv cmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBB ZGxlci4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvc2VydmVyX3Byb2Nlc3MucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L3NlcnZlcl9wcm9jZXNzLnB5CmluZGV4IDYyY2E2OTMxMmFiMDdh ZTNhYjU5ZmYzZTVjOTRiNjc1MjUzOGRlYmIuLmMxODk5OWFmMzExMTVkYTE1MWYzZjNkZTM1YWU0 OWVlOTM5YjYxZGUgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvc2VydmVyX3Byb2Nlc3MucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQpAQCAtMjksNyAr MjksNiBAQAogCiAiIiJQYWNrYWdlIHRoYXQgaW1wbGVtZW50cyB0aGUgU2VydmVyUHJvY2VzcyB3 cmFwcGVyIGNsYXNzIiIiCiAKLWltcG9ydCBmY250bAogaW1wb3J0IGxvZ2dpbmcKIGltcG9ydCBv cwogaW1wb3J0IHNlbGVjdApAQCAtMzcsNiArMzYsOCBAQCBpbXBvcnQgc2lnbmFsCiBpbXBvcnQg c3VicHJvY2VzcwogaW1wb3J0IHN5cwogaW1wb3J0IHRpbWUKK2lmIHN5cy5wbGF0Zm9ybSAhPSAn d2luMzInOgorICAgIGltcG9ydCBmY250bAogCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0u ZXhlY3V0aXZlIGltcG9ydCBFeGVjdXRpdmUKIAo=