45353 2010-09-07 18:33:40 -0700 [GTK] Get ImageDiff building on Win32 2010-09-09 07:44:24 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson webkit-unassigned oldest_to_newest 275512 0 mrobinson 2010-09-07 18:33:40 -0700 By switching from strtok to g_strsplit, we can get this tool building on Win32. 275513 1 66819 mrobinson 2010-09-07 18:34:54 -0700 Created attachment 66819 Patch for this issue 275955 2 66819 xan.lopez 2010-09-08 11:18:00 -0700 Comment on attachment 66819 Patch for this issue OK. 276449 3 66819 mrobinson 2010-09-09 07:44:21 -0700 Comment on attachment 66819 Patch for this issue Clearing flags on attachment: 66819 Committed r67083: <http://trac.webkit.org/changeset/67083> 276450 4 mrobinson 2010-09-09 07:44:24 -0700 All reviewed patches have been landed. Closing bug. 66819 2010-09-07 18:34:54 -0700 2010-09-09 07:44:20 -0700 Patch for this issue bug-45353-20100907183451.patch text/plain 1738 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmN2VmN2ZlOTM1OTc4YWI0ZDM0Zjc2MmIyNjA1YWNiMTU0ZDJkYmU4Li45MDE2Nzkz OWNlZmI4NGJhYmE0YWI0ZDdlNjE5NDE5NDA0MmU2NDhlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDktMDcgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEdldCBJ bWFnZURpZmYgYnVpbGRpbmcgb24gV2luMzIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ1MzUzCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsv SW1hZ2VEaWZmLmNwcDoKKyAgICAgICAgKG1haW4pOiBTd2l0Y2ggZnJvbSB1c2luZyBzdHJ0b2sg dG8gZ19zdHJzcGxpdC4KKwogMjAxMC0wOS0wNyAgSmVzc2llIEJlcmxpbiAgPGpiZXJsaW5AYXBw bGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIE1hYyBidWlsZCBmaXguCmRpZmYgLS1naXQg YS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvSW1hZ2VEaWZmLmNwcCBiL1dlYktpdFRv b2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9JbWFnZURpZmYuY3BwCmluZGV4IGM0MGIyMzJlY2Q2Y2Rm ZGJjNTNmYjIxZjdiM2EzMTcyYTMwMGZlYjQuLjdlMjc0NGEwNWUxNjMzMzM1MTg2MGRhNzQyYzNi Y2YyNmVlZDEwMzkgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9J bWFnZURpZmYuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9JbWFnZURp ZmYuY3BwCkBAIC0xOTksMTAgKzE5OSwxNSBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciogYXJn dltdKQogICAgICAgICAgICAgKm5ld0xpbmVDaGFyYWN0ZXIgPSAnXDAnOwogCiAgICAgICAgIGlm ICghc3RybmNtcCgiQ29udGVudC1MZW5ndGg6ICIsIGJ1ZmZlciwgMTYpKSB7Ci0gICAgICAgICAg ICBjaGFyKiBjb250ZXh0OwotICAgICAgICAgICAgc3RydG9rX3IoYnVmZmVyLCAiICIsICZjb250 ZXh0KTsKLSAgICAgICAgICAgIGxvbmcgaW1hZ2VTaXplID0gc3RydG9sKHN0cnRva19yKDAsICIg IiwgJmNvbnRleHQpLCAwLCAxMCk7CisgICAgICAgICAgICBnY2hhcioqIHRva2VucyA9IGdfc3Ry c3BsaXQoYnVmZmVyLCAiICIsIDApOworICAgICAgICAgICAgaWYgKCF0b2tlbnNbMV0pIHsKKyAg ICAgICAgICAgICAgICBnX3N0cmZyZWV2KHRva2Vucyk7CisgICAgICAgICAgICAgICAgcHJpbnRm KCJFcnJvciwgaW1hZ2Ugc2l6ZSBtdXN0IGJlIHNwZWNpZmllZC4uXG4iKTsKKyAgICAgICAgICAg ICAgICByZXR1cm4gMTsKKyAgICAgICAgICAgIH0KIAorICAgICAgICAgICAgbG9uZyBpbWFnZVNp emUgPSBzdHJ0b2wodG9rZW5zWzFdLCAwLCAxMCk7CisgICAgICAgICAgICBnX3N0cmZyZWV2KHRv a2Vucyk7CiAgICAgICAgICAgICBpZiAoaW1hZ2VTaXplID4gMCAmJiAhYWN0dWFsSW1hZ2UpIHsK ICAgICAgICAgICAgICAgICBpZiAoIShhY3R1YWxJbWFnZSA9IHJlYWRQaXhidWZGcm9tU3RkaW4o aW1hZ2VTaXplKSkpIHsKICAgICAgICAgICAgICAgICAgICAgcHJpbnRmKCJFcnJvciwgY291bGQg bm90IHJlYWQgYWN0dWFsIGltYWdlLlxuIik7Cg==