<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>45352</bug_id>
          
          <creation_ts>2010-09-07 18:28:35 -0700</creation_ts>
          <short_desc>Missing EOL in expected test results</short_desc>
          <delta_ts>2010-09-13 07:23:49 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>44836</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Yael">yael</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ademar</cc>
    
    <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>275509</commentid>
    <comment_count>0</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2010-09-07 18:28:35 -0700</bug_when>
    <thetext>EOL are missing from the expected results of the new test fast/notifications/notifications-click-event.html. This was not found until now because of https://bugs.webkit.org/show_bug.cgi?id=36983.
I am about to submit a patch for https://bugs.webkit.org/show_bug.cgi?id=44836, so I need the results to be corrected.

A patch is coming.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>275514</commentid>
    <comment_count>1</comment_count>
      <attachid>66820</attachid>
    <who name="Yael">yael</who>
    <bug_when>2010-09-07 18:35:26 -0700</bug_when>
    <thetext>Created attachment 66820
Patch

Added missing EOL from test result.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>275516</commentid>
    <comment_count>2</comment_count>
      <attachid>66820</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-09-07 18:36:50 -0700</bug_when>
    <thetext>Comment on attachment 66820
Patch

sr=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>275773</commentid>
    <comment_count>3</comment_count>
      <attachid>66820</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-09-08 05:38:30 -0700</bug_when>
    <thetext>Comment on attachment 66820
Patch

Clearing flags on attachment: 66820

Committed r66974: &lt;http://trac.webkit.org/changeset/66974&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>275774</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-09-08 05:38:35 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>278198</commentid>
    <comment_count>5</comment_count>
    <who name="Ademar Reis">ademar</who>
    <bug_when>2010-09-13 07:23:49 -0700</bug_when>
    <thetext>Revision r66974 cherry-picked into qtwebkit-2.1 with commit 82ccd13f2c6b19cc8f276668db45dd5f928705fd</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>66820</attachid>
            <date>2010-09-07 18:35:26 -0700</date>
            <delta_ts>2010-09-08 05:38:30 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>45352.patch</filename>
            <type>text/plain</type>
            <size>1088</size>
            <attacher name="Yael">yael</attacher>
            
              <data encoding="base64">SW5kZXg6IExheW91dFRlc3RzL2Zhc3Qvbm90aWZpY2F0aW9ucy9ub3RpZmljYXRpb25zLWNsaWNr
LWV2ZW50LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L25vdGlm
aWNhdGlvbnMvbm90aWZpY2F0aW9ucy1jbGljay1ldmVudC1leHBlY3RlZC50eHQJKHJldmlzaW9u
IDY2ODg3KQorKysgTGF5b3V0VGVzdHMvZmFzdC9ub3RpZmljYXRpb25zL25vdGlmaWNhdGlvbnMt
Y2xpY2stZXZlbnQtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC01LDMgKzUsNCBAQAog
VG8gZXhlcmNpc2UgbWFudWFsbHksIGdyYW50IG5vdGlmaWNhdGlvbiBwZXJtaXNzaW9ucyBhbmQg
bG9hZCB0aGlzIHBhZ2UsIHRoZW4gY2xpY2sgb24gdGhlIG5vdGlmaWNhdGlvbi4gWW91IHNob3Vs
ZCBzZWUgYSAiUEFTUyIgbWVzc2FnZS4KIAogUEFTUzogY2xpY2sgZXZlbnQgZmlyZWQuCisKSW5k
ZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFu
Z2VMb2cJKHJldmlzaW9uIDY2OTQ0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5n
IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDktMDcgIFlhZWwgQWhhcm9uICA8eWFlbC5h
aGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIE1pc3NpbmcgRU9MIGluIGV4cGVjdGVkIHRlc3QgcmVzdWx0cworICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDUzNTIKKworICAgICAgICBB
ZGQgdGhlIG1pc3NpbmcgRU9MLgorCisgICAgICAgICogZmFzdC9ub3RpZmljYXRpb25zL25vdGlm
aWNhdGlvbnMtY2xpY2stZXZlbnQtZXhwZWN0ZWQudHh0OgorCiAyMDEwLTA5LTA3ICBPamFuIFZh
ZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11
cmEuCgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>