45351 2010-09-07 18:27:33 -0700 pushstate-clears-forward-history.html crashes with Chromium DRT 2010-09-08 22:18:58 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mihaip mihaip commit-queue dglazkov fishd oldest_to_newest 275507 0 mihaip 2010-09-07 18:27:33 -0700 pushstate-clears-forward-history.html crashes with Chromium DRT 275515 1 66821 mihaip 2010-09-07 18:35:44 -0700 Created attachment 66821 Patch 275518 2 mihaip 2010-09-07 18:37:47 -0700 Dimitri, since you suggested that I look at this, perhaps you can review too :) Darin, this is mostly a FYI, in case I'm misunderstanding something about popstate firing synchronously and bad things that happen because of that. 275607 3 66821 fishd 2010-09-07 22:33:48 -0700 Comment on attachment 66821 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66821&action=prettypatch > LayoutTests/fast/loader/stateobjects/popstate-fires-with-page-cache.html:50 > + setTimeout(function() { testWindow.close(); finishJSTest(); }, 0); readability nit: setTimeout(function() { testWindow.close(); finishJSTest(); }, 0); That way it is easy to set breakpoints too in the JS debugger. 275863 4 66902 mihaip 2010-09-08 08:56:53 -0700 Created attachment 66902 Patch 275864 5 mihaip 2010-09-08 08:57:17 -0700 (In reply to comment #3) > readability nit: > setTimeout(function() { > testWindow.close(); > finishJSTest(); > }, 0); Fixed in new version of the patch. 275869 6 66902 dglazkov 2010-09-08 09:10:46 -0700 Comment on attachment 66902 Patch k. 276310 7 66902 commit-queue 2010-09-08 22:18:54 -0700 Comment on attachment 66902 Patch Clearing flags on attachment: 66902 Committed r67060: <http://trac.webkit.org/changeset/67060> 276311 8 commit-queue 2010-09-08 22:18:58 -0700 All reviewed patches have been landed. Closing bug. 66821 2010-09-07 18:35:44 -0700 2010-09-08 08:56:49 -0700 Patch bug-45351-20100907183543.patch text/plain 3246 mihaip ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkYWVkYjdjM2FjNzJiNDMzOGQxYjEzMmMzYTI1YmFmYmQxNTE2MzczLi43OGI3MjQx NDMxNzU1NGNkYWJiOTYyYTA3M2ViZTUyZTBlNmE1YzhhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAK KzIwMTAtMDktMDcgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcHVzaHN0YXRlLWNs ZWFycy1mb3J3YXJkLWhpc3RvcnkuaHRtbCBjcmFzaGVzIHdpdGggQ2hyb21pdW0gRFJUCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTM1MQorCisgICAg ICAgIHB1c2hzdGF0ZS1jbGVhcnMtZm9yd2FyZC1oaXN0b3J5Lmh0bWwgd291bGQgYXBwZWFyIHRv IGNyYXNoIHdpdGggdGhlCisgICAgICAgIENocm9taXVtIERSVC4gVGhlIGNyYXNoIHdhcyBhY3R1 YWxseSBjYXVzZWQgYnkgdGhlIHRlc3QgdGhhdCBwcmVjZWRlZAorICAgICAgICBpdCwgcG9wc3Rh dGUtZmlyZXMtd2l0aC1wYWdlLWNhY2hlLmh0bWwsIGFkZGVkIHdpdGggcjY2NjI4LiBUaGF0IHRl c3QKKyAgICAgICAgd291bGQgY2xvc2UgYSBwb3B1cCB3aW5kb3cgZHVyaW5nIGEgcG9wc3RhdGUg ZXZlbnQgaGFuZGxlciwgdHJpZ2dlcmluZworICAgICAgICBidWcgMzYyMDIgKHBvcHN0YXRlIGZp cmVzIHN5Y2hyb25vdXNseSBpbnN0ZWFkIG9mIGFzeW5jaHJvbm91c2x5KSwgCisgICAgICAgIGxl YWRpbmcgdG8gYXNzZXJ0cyBmaXJpbmcuCisgICAgICAgIAorICAgICAgICBUaGUgd29ya2Fyb3Vu ZCBpcyB0byBzaW11bGF0ZSBwb3BzdGF0ZSBiZWluZyBhc3luYyBieSB3cmFwcGluZyB0aGUKKyAg ICAgICAgY2xlYW51cCBjb2RlIGluIGEgdGltZW91dCAoZml4aW5nIDM2MjAyIGl0c2VsZiBpcyBh bHNvIG9uIG15IHJhZGFyKS4KKworICAgICAgICAqIGZhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9w b3BzdGF0ZS1maXJlcy13aXRoLXBhZ2UtY2FjaGUuaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9j aHJvbWl1bS9kcnRfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMC0wOS0wNyAgT2phbiBWYWZhaSAg PG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvc3RhdGVvYmplY3RzL3BvcHN0YXRl LWZpcmVzLXdpdGgtcGFnZS1jYWNoZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvc3Rh dGVvYmplY3RzL3BvcHN0YXRlLWZpcmVzLXdpdGgtcGFnZS1jYWNoZS5odG1sCmluZGV4IDY0OTJj ZjRjOTEyYjdmYjI5MDFjMjAwNDAxNjBiOTFkNmJhMjNmYzIuLjY2ZjMxZjlmOWIzYTc3YzE3NDIw ZDJlMjUxNzExZDNmN2FmNDI1NTIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVy L3N0YXRlb2JqZWN0cy9wb3BzdGF0ZS1maXJlcy13aXRoLXBhZ2UtY2FjaGUuaHRtbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2xvYWRlci9zdGF0ZW9iamVjdHMvcG9wc3RhdGUtZmlyZXMtd2l0aC1w YWdlLWNhY2hlLmh0bWwKQEAgLTQ1LDggKzQ1LDkgQEAgZnVuY3Rpb24gb25UZXN0V2luZG93UG9w U3RhdGUoZXZlbnQpCiAgICAgICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkge3Rlc3RXaW5k b3cuaGlzdG9yeS5iYWNrKCk7fSwgMCk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2Fz ZSA0OgotICAgICAgICAgICAgdGVzdFdpbmRvdy5jbG9zZSgpOwotICAgICAgICAgICAgZmluaXNo SlNUZXN0KCk7ICAgICAgICAKKyAgICAgICAgICAgIC8vIENsb3NlIHRoZSB3aW5kb3cgaW4gYSB0 aW1lb3V0IHRvIHNpbXVsYXRlIHBvcHN0YXRlIGZpcmluZyBhc3luY2hyb25vdXNseSwgb3RoZXJ3 aXNlIGNsb3NpbmcgdGhlIHdpbmRvdyBpbiBhIHBvcHN0YXRlIGhhbmRsZXIgcmVzdWx0cyBpbiBh IGNyYXNoLgorICAgICAgICAgICAgLy8gRklYTUU6IHJlbW92ZSB0aGlzIHdoZW4gaHR0cDovL3dl YmtpdC5vcmcvYi8zNjIwMiBpcyBmaXhlZC4KKyAgICAgICAgICAgIHNldFRpbWVvdXQoZnVuY3Rp b24oKSB7IHRlc3RXaW5kb3cuY2xvc2UoKTsgZmluaXNoSlNUZXN0KCk7IH0sIDApOwogICAgICAg ICAgICAgYnJlYWs7CiAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICB0ZXN0RmFpbGVkKCd1 bmV4cGVjdGVkIHBvcCBzdGF0ZSBldmVudCBzdGF0ZScpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vY2hyb21pdW0vZHJ0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9jaHJvbWl1bS9kcnRfZXhwZWN0YXRpb25zLnR4dAppbmRleCA3ZGE4MTU3NGIxM2U4 MTNhMDQ2MWNmOTY0OGQ4YmUyN2NjYzZlMmIwLi42MGJhZmM2ZTBmZWZlZjRkZTk1YzQyYzkzYjRl NDFkNTUwYzRkZDAxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9k cnRfZXhwZWN0YXRpb25zLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9k cnRfZXhwZWN0YXRpb25zLnR4dApAQCAtMTQxLDcgKzE0MSw2IEBAIEJVR19EUlQgOiBwbGF0Zm9y bS9jaHJvbWl1bS9hY2Nlc3NpYmlsaXR5L2NoaWxkcmVuLWNoYW5nZWQtbm90aWZpY2F0aW9uLmh0 bWwgPSBQCiBCVUdfRFJUIExJTlVYIDogZmFzdC90ZXh0L2ludGVybmF0aW9uYWwvdGhhaS1saW5l LWJyZWFrcy5odG1sID0gSU1BR0UKIEJVR19EUlQgV0lOIDogc3ZnL2JhdGlrL3RleHQvdGV4dEZl YXR1cmVzLnN2ZyA9IElNQUdFCiBCVUdfRFJUIFdJTiBNQUMgTElOVVggOiBtZWRpYS9tZWRpYS1j YW4tcGxheS1tcGVnNC12aWRlby5odG1sID0gVEVYVAotQlVHX0RSVCBXSU4gTUFDIExJTlVYIDog ZmFzdC9sb2FkZXIvc3RhdGVvYmplY3RzL3B1c2hzdGF0ZS1jbGVhcnMtZm9yd2FyZC1oaXN0b3J5 Lmh0bWwgPSBDUkFTSAogQlVHX0RSVCBXSU4gOiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3Jl ZGlyZWN0LWNyb3NzLW9yaWdpbi10cmlwbWluZS5odG1sID0gQ1JBU0gKIEJVR19EUlQgV0lOIE1B QyBMSU5VWCA6IHN0b3JhZ2UvaW5kZXhlZGRiL29iamVjdHN0b3JlLWJhc2ljcy5odG1sID0gVEVY VAogQlVHX0RSVCBXSU4gOiBmYXN0L2Zvcm1zL3NlYXJjaC1zdHlsZWQuaHRtbCA9IFRFWFQK 66902 2010-09-08 08:56:53 -0700 2010-09-08 22:18:54 -0700 Patch bug-45351-20100908085651.patch text/plain 3294 mihaip ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkYWVkYjdjM2FjNzJiNDMzOGQxYjEzMmMzYTI1YmFmYmQxNTE2MzczLi43OGI3MjQx NDMxNzU1NGNkYWJiOTYyYTA3M2ViZTUyZTBlNmE1YzhhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAK KzIwMTAtMDktMDcgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcHVzaHN0YXRlLWNs ZWFycy1mb3J3YXJkLWhpc3RvcnkuaHRtbCBjcmFzaGVzIHdpdGggQ2hyb21pdW0gRFJUCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTM1MQorCisgICAg ICAgIHB1c2hzdGF0ZS1jbGVhcnMtZm9yd2FyZC1oaXN0b3J5Lmh0bWwgd291bGQgYXBwZWFyIHRv IGNyYXNoIHdpdGggdGhlCisgICAgICAgIENocm9taXVtIERSVC4gVGhlIGNyYXNoIHdhcyBhY3R1 YWxseSBjYXVzZWQgYnkgdGhlIHRlc3QgdGhhdCBwcmVjZWRlZAorICAgICAgICBpdCwgcG9wc3Rh dGUtZmlyZXMtd2l0aC1wYWdlLWNhY2hlLmh0bWwsIGFkZGVkIHdpdGggcjY2NjI4LiBUaGF0IHRl c3QKKyAgICAgICAgd291bGQgY2xvc2UgYSBwb3B1cCB3aW5kb3cgZHVyaW5nIGEgcG9wc3RhdGUg ZXZlbnQgaGFuZGxlciwgdHJpZ2dlcmluZworICAgICAgICBidWcgMzYyMDIgKHBvcHN0YXRlIGZp cmVzIHN5Y2hyb25vdXNseSBpbnN0ZWFkIG9mIGFzeW5jaHJvbm91c2x5KSwgCisgICAgICAgIGxl YWRpbmcgdG8gYXNzZXJ0cyBmaXJpbmcuCisgICAgICAgIAorICAgICAgICBUaGUgd29ya2Fyb3Vu ZCBpcyB0byBzaW11bGF0ZSBwb3BzdGF0ZSBiZWluZyBhc3luYyBieSB3cmFwcGluZyB0aGUKKyAg ICAgICAgY2xlYW51cCBjb2RlIGluIGEgdGltZW91dCAoZml4aW5nIDM2MjAyIGl0c2VsZiBpcyBh bHNvIG9uIG15IHJhZGFyKS4KKworICAgICAgICAqIGZhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9w b3BzdGF0ZS1maXJlcy13aXRoLXBhZ2UtY2FjaGUuaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9j aHJvbWl1bS9kcnRfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMC0wOS0wNyAgT2phbiBWYWZhaSAg PG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvc3RhdGVvYmplY3RzL3BvcHN0YXRl LWZpcmVzLXdpdGgtcGFnZS1jYWNoZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvc3Rh dGVvYmplY3RzL3BvcHN0YXRlLWZpcmVzLXdpdGgtcGFnZS1jYWNoZS5odG1sCmluZGV4IDY0OTJj ZjRjOTEyYjdmYjI5MDFjMjAwNDAxNjBiOTFkNmJhMjNmYzIuLjE4OGNkYzA3OGYyNGFkZTRiZjcy MGY2MzI5MGIyYzIzN2E5NjliYzkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVy L3N0YXRlb2JqZWN0cy9wb3BzdGF0ZS1maXJlcy13aXRoLXBhZ2UtY2FjaGUuaHRtbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2xvYWRlci9zdGF0ZW9iamVjdHMvcG9wc3RhdGUtZmlyZXMtd2l0aC1w YWdlLWNhY2hlLmh0bWwKQEAgLTQ1LDggKzQ1LDEyIEBAIGZ1bmN0aW9uIG9uVGVzdFdpbmRvd1Bv cFN0YXRlKGV2ZW50KQogICAgICAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHt0ZXN0V2lu ZG93Lmhpc3RvcnkuYmFjaygpO30sIDApOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNh c2UgNDoKLSAgICAgICAgICAgIHRlc3RXaW5kb3cuY2xvc2UoKTsKLSAgICAgICAgICAgIGZpbmlz aEpTVGVzdCgpOyAgICAgICAgCisgICAgICAgICAgICAvLyBDbG9zZSB0aGUgd2luZG93IGluIGEg dGltZW91dCB0byBzaW11bGF0ZSBwb3BzdGF0ZSBmaXJpbmcgYXN5bmNocm9ub3VzbHksIG90aGVy d2lzZSBjbG9zaW5nIHRoZSB3aW5kb3cgaW4gYSBwb3BzdGF0ZSBoYW5kbGVyIHJlc3VsdHMgaW4g YSBjcmFzaC4KKyAgICAgICAgICAgIC8vIEZJWE1FOiByZW1vdmUgdGhpcyB3aGVuIGh0dHA6Ly93 ZWJraXQub3JnL2IvMzYyMDIgaXMgZml4ZWQuCisgICAgICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0 aW9uKCkgeworICAgICAgICAgICAgICAgIHRlc3RXaW5kb3cuY2xvc2UoKTsKKyAgICAgICAgICAg ICAgICBmaW5pc2hKU1Rlc3QoKTsKKyAgICAgICAgICAgIH0sIDApOwogICAgICAgICAgICAgYnJl YWs7CiAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICB0ZXN0RmFpbGVkKCd1bmV4cGVjdGVk IHBvcCBzdGF0ZSBldmVudCBzdGF0ZScpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vY2hyb21pdW0vZHJ0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9j aHJvbWl1bS9kcnRfZXhwZWN0YXRpb25zLnR4dAppbmRleCA3ZGE4MTU3NGIxM2U4MTNhMDQ2MWNm OTY0OGQ4YmUyN2NjYzZlMmIwLi42MGJhZmM2ZTBmZWZlZjRkZTk1YzQyYzkzYjRlNDFkNTUwYzRk ZDAxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9kcnRfZXhwZWN0 YXRpb25zLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9kcnRfZXhwZWN0 YXRpb25zLnR4dApAQCAtMTQxLDcgKzE0MSw2IEBAIEJVR19EUlQgOiBwbGF0Zm9ybS9jaHJvbWl1 bS9hY2Nlc3NpYmlsaXR5L2NoaWxkcmVuLWNoYW5nZWQtbm90aWZpY2F0aW9uLmh0bWwgPSBQCiBC VUdfRFJUIExJTlVYIDogZmFzdC90ZXh0L2ludGVybmF0aW9uYWwvdGhhaS1saW5lLWJyZWFrcy5o dG1sID0gSU1BR0UKIEJVR19EUlQgV0lOIDogc3ZnL2JhdGlrL3RleHQvdGV4dEZlYXR1cmVzLnN2 ZyA9IElNQUdFCiBCVUdfRFJUIFdJTiBNQUMgTElOVVggOiBtZWRpYS9tZWRpYS1jYW4tcGxheS1t cGVnNC12aWRlby5odG1sID0gVEVYVAotQlVHX0RSVCBXSU4gTUFDIExJTlVYIDogZmFzdC9sb2Fk ZXIvc3RhdGVvYmplY3RzL3B1c2hzdGF0ZS1jbGVhcnMtZm9yd2FyZC1oaXN0b3J5Lmh0bWwgPSBD UkFTSAogQlVHX0RSVCBXSU4gOiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3JlZGlyZWN0LWNy b3NzLW9yaWdpbi10cmlwbWluZS5odG1sID0gQ1JBU0gKIEJVR19EUlQgV0lOIE1BQyBMSU5VWCA6 IHN0b3JhZ2UvaW5kZXhlZGRiL29iamVjdHN0b3JlLWJhc2ljcy5odG1sID0gVEVYVAogQlVHX0RS VCBXSU4gOiBmYXN0L2Zvcm1zL3NlYXJjaC1zdHlsZWQuaHRtbCA9IFRFWFQK