<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>45349</bug_id>
          
          <creation_ts>2010-09-07 17:58:19 -0700</creation_ts>
          <short_desc>[GTK] testmimehandling falsely succeeds testing Ogg mime type</short_desc>
          <delta_ts>2010-09-09 08:04:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk</keywords>
          <priority>P3</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Martin Robinson">mrobinson</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>gustavo</cc>
    
    <cc>pnormand</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>275475</commentid>
    <comment_count>0</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-09-07 17:58:19 -0700</bug_when>
    <thetext>At least on my machine (Ubuntu 9.10), testmimehandling falsely succeeds when testing the Ogg file mime type. test_mime_ogg is actually testing the PDF mime type. When I switch the argument it passes from &quot;pdf&quot; to &quot;ogg,&quot; the test fails. I uncovered this bug while writing a test for https://bugs.webkit.org/show_bug.cgi?id=31066.

The failure is:
ERROR:../../WebKit/gtk/tests/testmimehandling.c:128:mime_type_policy_decision_requested_cb: assertion failed (mime_type == &quot;audio/ogg&quot;): (&quot;audio/x-vorbis+ogg&quot; == &quot;audio/ogg&quot;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>275683</commentid>
    <comment_count>1</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-09-08 02:00:19 -0700</bug_when>
    <thetext>&quot;audio/x-vorbis+ogg&quot; is returned by libsoup&apos;s content-sniffer (which uses g_content_type_guess and xdgmime underneath). So I think the ResourceHandleSoup should probably handle this case, when &quot;audio/x-vorbis+ogg&quot; is sniffed, it should return &quot;audio/ogg&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>275702</commentid>
    <comment_count>2</comment_count>
      <attachid>66862</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-09-08 02:42:53 -0700</bug_when>
    <thetext>Created attachment 66862
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>275846</commentid>
    <comment_count>3</comment_count>
      <attachid>66862</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-09-08 08:17:35 -0700</bug_when>
    <thetext>Comment on attachment 66862
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66862&amp;action=prettypatch

I&apos;m not sure this is the best way to tackle this problem. It doesn&apos;t handle the local case. Isn&apos;t it possible to fix MediaPlayerGstreamerPrivate to handle this mime type?

&gt; WebCore/platform/network/soup/ResourceHandleSoup.cpp:256
&gt; +    GOwnPtr&lt;gchar&gt; mimeType;
It&apos;s better to use CString in these cases.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>275881</commentid>
    <comment_count>4</comment_count>
      <attachid>66905</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-09-08 09:31:58 -0700</bug_when>
    <thetext>Created attachment 66905
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>275903</commentid>
    <comment_count>5</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-09-08 09:54:50 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; Created an attachment (id=66905) [details]
&gt; proposed patch

Sorry, I still don&apos;t understand the change to ResourceHandleSoup? If we now support audio/x-vorbis+ogg, why do we have to fake the audio/vorbis mime type there? Can&apos;t we just change the expected mime type in the test?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>276354</commentid>
    <comment_count>6</comment_count>
      <attachid>67005</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-09-09 01:04:26 -0700</bug_when>
    <thetext>Created attachment 67005
updated patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>276444</commentid>
    <comment_count>7</comment_count>
      <attachid>67005</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-09-09 07:29:28 -0700</bug_when>
    <thetext>Comment on attachment 67005
updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67005&amp;action=prettypatch

Excellent!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>276462</commentid>
    <comment_count>8</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-09-09 08:04:26 -0700</bug_when>
    <thetext>Committed r67086: &lt;http://trac.webkit.org/changeset/67086&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>66862</attachid>
            <date>2010-09-08 02:42:53 -0700</date>
            <delta_ts>2010-09-08 09:31:58 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>proposed-patch.patch</filename>
            <type>text/plain</type>
            <size>3571</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSA1ZDZhYmNjNzFlNTI2NDJjYjRlMDg0MTZjMWYwM2RhNDE0NWM4OThiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBXZWQsIDggU2VwIDIwMTAgMTE6NDM6MTYgKzAyMDAKU3ViamVjdDogW1BBVENIXSBw
cm9wb3NlZCBwYXRjaAoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICB8ICAgMTYgKysrKysrKysrKysrKysrKwogLi4uL3BsYXRmb3JtL25ldHdv
cmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwICAgfCAgIDEyICsrKysrKysrKy0tLQogV2Vi
S2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDExICsr
KysrKysrKysrCiBXZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RtaW1laGFuZGxpbmcuYyAgICAgICAgICAg
ICAgICB8ICAgIDIgKy0KIDQgZmlsZXMgY2hhbmdlZCwgMzcgaW5zZXJ0aW9ucygrKSwgNCBkZWxl
dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdl
TG9nCmluZGV4IGU1OGMyYmIuLjEwMmMzOTkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9n
CisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDktMDggIFBo
aWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIHRlc3RtaW1laGFuZGxpbmcgZmFs
c2VseSBzdWNjZWVkcyB0ZXN0aW5nIE9nZyBtaW1lIHR5cGUKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1MzQ5CisKKyAgICAgICAgV2hlbiBsaWJzb3Vw
J3MgY29udGVudC1zbmlmZmVyIHJldHVybnMgdGhlIGF1ZGlvL3gtdm9yYmlzK29nZworICAgICAg
ICBtaW1lLXR5cGUsIGhhbmRsZSBpdCBhcyBhdWRpby9vZ2cgd2hpY2ggaXMgcHJlZmVycmVkIGZv
ciB0aGUgSFRNTDUKKyAgICAgICAgbWVkaWEgZWxlbWVudHMuCisKKyAgICAgICAgQ292ZXJlZCBi
eSBBUEkgdGVzdG1pbWVoYW5kbGluZy4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291
cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y29udGVudFNuaWZm
ZWRDYWxsYmFjayk6CisKIDIwMTAtMDktMDcgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K
IAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEvV2ViQ29y
ZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcCBiL1dlYkNvcmUv
cGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKaW5kZXggOTZhMmYy
NS4uY2VlMWJiZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVz
b3VyY2VIYW5kbGVTb3VwLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9S
ZXNvdXJjZUhhbmRsZVNvdXAuY3BwCkBAIC0yNTMsMTEgKzI1MywxNyBAQCBzdGF0aWMgdm9pZCBn
b3RIZWFkZXJzQ2FsbGJhY2soU291cE1lc3NhZ2UqIG1zZywgZ3BvaW50ZXIgZGF0YSkKIC8vIFRo
aXMgY2FsbGJhY2sgd2lsbCBub3QgYmUgY2FsbGVkIGlmIHRoZSBjb250ZW50IHNuaWZmZXIgaXMg
ZGlzYWJsZWQgaW4gc3RhcnRIdHRwLgogc3RhdGljIHZvaWQgY29udGVudFNuaWZmZWRDYWxsYmFj
ayhTb3VwTWVzc2FnZSogbXNnLCBjb25zdCBjaGFyKiBzbmlmZmVkVHlwZSwgR0hhc2hUYWJsZSAq
cGFyYW1zLCBncG9pbnRlciBkYXRhKQogewotICAgIGlmIChzbmlmZmVkVHlwZSkgeworICAgIEdP
d25QdHI8Z2NoYXI+IG1pbWVUeXBlOworICAgIG1pbWVUeXBlLnNldChnX3N0cmR1cChzbmlmZmVk
VHlwZSkpOworCisgICAgaWYgKG1pbWVUeXBlKSB7CisgICAgICAgIGlmIChnX3N0cl9lcXVhbCht
aW1lVHlwZS5nZXQoKSwgImF1ZGlvL3gtdm9yYmlzK29nZyIpKQorICAgICAgICAgICAgbWltZVR5
cGUuc2V0KGdfc3RyZHVwKCJhdWRpby9vZ2ciKSk7CisKICAgICAgICAgY29uc3QgY2hhciogb2Zm
aWNpYWxUeXBlID0gc291cF9tZXNzYWdlX2hlYWRlcnNfZ2V0X29uZShtc2ctPnJlc3BvbnNlX2hl
YWRlcnMsICJDb250ZW50LVR5cGUiKTsKIAotICAgICAgICBpZiAoIW9mZmljaWFsVHlwZSB8fCBz
dHJjbXAob2ZmaWNpYWxUeXBlLCBzbmlmZmVkVHlwZSkpCi0gICAgICAgICAgICBzb3VwX21lc3Nh
Z2VfaGVhZGVyc19zZXRfY29udGVudF90eXBlKG1zZy0+cmVzcG9uc2VfaGVhZGVycywgc25pZmZl
ZFR5cGUsIHBhcmFtcyk7CisgICAgICAgIGlmICghb2ZmaWNpYWxUeXBlIHx8IHN0cmNtcChvZmZp
Y2lhbFR5cGUsIG1pbWVUeXBlLmdldCgpKSkKKyAgICAgICAgICAgIHNvdXBfbWVzc2FnZV9oZWFk
ZXJzX3NldF9jb250ZW50X3R5cGUobXNnLT5yZXNwb25zZV9oZWFkZXJzLCBtaW1lVHlwZS5nZXQo
KSwgcGFyYW1zKTsKICAgICB9CiAKICAgICBpZiAoc3RhdHVzV2lsbEJlSGFuZGxlZEJ5U291cCht
c2ctPnN0YXR1c19jb2RlKSkKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2Vi
S2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggZDgxNjE0ZC4uYTkzOTIwOCAxMDA2NDQKLS0tIGEvV2Vi
S2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx
NCBAQAorMjAxMC0wOS0wOCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10g
dGVzdG1pbWVoYW5kbGluZyBmYWxzZWx5IHN1Y2NlZWRzIHRlc3RpbmcgT2dnIG1pbWUgdHlwZQor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDUzNDkKKwor
ICAgICAgICAqIHRlc3RzL3Rlc3RtaW1laGFuZGxpbmcuYzoKKyAgICAgICAgKHRlc3RfbWltZV9v
Z2cpOiBNYWtlIHRoaXMgYWN0dWFsbHkgdGVzdCBhbiBvZ2cgZmlsZSByZXF1ZXN0CisgICAgICAg
IGluc3RlYWQgb2YgcGRmLgorCiAyMDEwLTA5LTA3ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5z
b25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCmRpZmYgLS1n
aXQgYS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RtaW1laGFuZGxpbmcuYyBiL1dlYktpdC9ndGsvdGVz
dHMvdGVzdG1pbWVoYW5kbGluZy5jCmluZGV4IDJhYjAyNTcuLjcyNWNlYWQgMTAwNjQ0Ci0tLSBh
L1dlYktpdC9ndGsvdGVzdHMvdGVzdG1pbWVoYW5kbGluZy5jCisrKyBiL1dlYktpdC9ndGsvdGVz
dHMvdGVzdG1pbWVoYW5kbGluZy5jCkBAIC0xNzIsNyArMTcyLDcgQEAgc3RhdGljIHZvaWQgdGVz
dF9taW1lX3RleHQoKQogCiBzdGF0aWMgdm9pZCB0ZXN0X21pbWVfb2dnKCkKIHsKLSAgICB0ZXN0
X21pbWVfdHlwZSgicGRmIik7CisgICAgdGVzdF9taW1lX3R5cGUoIm9nZyIpOwogfQogCiBpbnQg
bWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCi0tIAoxLjcuMQ==
</data>
<flag name="review"
          id="55990"
          type_id="1"
          status="-"
          setter="mrobinson"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>66905</attachid>
            <date>2010-09-08 09:31:58 -0700</date>
            <delta_ts>2010-09-09 01:04:26 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>proposed-patch.patch</filename>
            <type>text/plain</type>
            <size>4514</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSAyNDdmYTgzZjVmMDE3YTA0OTk2NzMzN2E2ODQwNDY3MjUxODI2M2RmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBXZWQsIDggU2VwIDIwMTAgMTE6NDM6MTYgKzAyMDAKU3ViamVjdDogW1BBVENIXSBw
cm9wb3NlZCBwYXRjaAoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICB8ICAgMTkgKysrKysrKysrKysrKysrKysrKwogLi4uL2dzdHJlYW1lci9N
ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwICAgICAgfCAgICAxICsKIC4uLi9wbGF0Zm9y
bS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcCAgIHwgICAxMSArKysrKysrKy0t
LQogV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAg
IDExICsrKysrKysrKysrCiBXZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RtaW1laGFuZGxpbmcuYyAgICAg
ICAgICAgICAgICB8ICAgIDIgKy0KIDUgZmlsZXMgY2hhbmdlZCwgNDAgaW5zZXJ0aW9ucygrKSwg
NCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUv
Q2hhbmdlTG9nCmluZGV4IDNkMDBhMzUuLmI0YWE1NjkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hh
bmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQgQEAKIDIwMTAtMDkt
MDggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIHRlc3RtaW1laGFuZGxp
bmcgZmFsc2VseSBzdWNjZWVkcyB0ZXN0aW5nIE9nZyBtaW1lIHR5cGUKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1MzQ5CisKKyAgICAgICAgV2hlbiBs
aWJzb3VwJ3MgY29udGVudC1zbmlmZmVyIHJldHVybnMgdGhlIGF1ZGlvL3gtdm9yYmlzK29nZwor
ICAgICAgICBtaW1lLXR5cGUsIGhhbmRsZSBpdCBhcyBhdWRpby9vZ2cgd2hpY2ggaXMgcHJlZmVy
cmVkIGZvciB0aGUgSFRNTDUKKyAgICAgICAgbWVkaWEgZWxlbWVudHMuCisKKyAgICAgICAgQ292
ZXJlZCBieSBBUEkgdGVzdG1pbWVoYW5kbGluZy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo
aWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAo
V2ViQ29yZTo6bWltZVR5cGVDYWNoZSk6IEFkdmVydGl6ZSBhdWRpby94LXZvcmJpcytvZ2cgc28K
KyAgICAgICAgTWVkaWFEb2N1bWVudHMgbG9hZGluZyBsb2NhbCBvZ2cgZmlsZXMgd29yayBhcyB3
ZWxsLgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAu
Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Y29udGVudFNuaWZmZWRDYWxsYmFjayk6CisKKzIwMTAt
MDktMDggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCiAgICAgICAg
IFJldmlld2VkIGJ5IEVyaWMgQ2FybHNvbi4KIAogICAgICAgICBbR1N0cmVhbWVyXSBjYWNoZSBt
ZWRpYSBkdXJhdGlvbiBpbiBSRUFEWSBpbnN0ZWFkIG9mIFBMQVlJTkcKZGlmZiAtLWdpdCBhL1dl
YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJl
YW1lci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXll
clByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDUxM2YzYzIuLjQ3OTFiNGMgMTAwNjQ0Ci0tLSBh
L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdT
dHJlYW1lci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVk
aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAtMTI2Nyw2ICsxMjY3LDcgQEAgc3RhdGlj
IEhhc2hTZXQ8U3RyaW5nPiBtaW1lVHlwZUNhY2hlKCkKIAogICAgICAgICAgICAgICAgIGlmIChn
X3N0cl9lcXVhbChuYW1lLCAiYXVkaW8veC12b3JiaXMiKSkgewogICAgICAgICAgICAgICAgICAg
ICBjYWNoZS5hZGQoU3RyaW5nKCJhdWRpby9vZ2ciKSk7CisgICAgICAgICAgICAgICAgICAgIGNh
Y2hlLmFkZChTdHJpbmcoImF1ZGlvL3gtdm9yYmlzK29nZyIpKTsKICAgICAgICAgICAgICAgICAg
ICAgY2FjaGVkID0gdHJ1ZTsKICAgICAgICAgICAgICAgICB9CiAKZGlmZiAtLWdpdCBhL1dlYkNv
cmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAgYi9XZWJDb3Jl
L3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCmluZGV4IGRhZGJk
MjIuLmI2NTIxYzIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jl
c291cmNlSGFuZGxlU291cC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAv
UmVzb3VyY2VIYW5kbGVTb3VwLmNwcApAQCAtMjUzLDExICsyNTMsMTYgQEAgc3RhdGljIHZvaWQg
Z290SGVhZGVyc0NhbGxiYWNrKFNvdXBNZXNzYWdlKiBtc2csIGdwb2ludGVyIGRhdGEpCiAvLyBU
aGlzIGNhbGxiYWNrIHdpbGwgbm90IGJlIGNhbGxlZCBpZiB0aGUgY29udGVudCBzbmlmZmVyIGlz
IGRpc2FibGVkIGluIHN0YXJ0SHR0cC4KIHN0YXRpYyB2b2lkIGNvbnRlbnRTbmlmZmVkQ2FsbGJh
Y2soU291cE1lc3NhZ2UqIG1zZywgY29uc3QgY2hhciogc25pZmZlZFR5cGUsIEdIYXNoVGFibGUg
KnBhcmFtcywgZ3BvaW50ZXIgZGF0YSkKIHsKLSAgICBpZiAoc25pZmZlZFR5cGUpIHsKKyAgICBD
U3RyaW5nIG1pbWVUeXBlKHNuaWZmZWRUeXBlKTsKKworICAgIGlmICghbWltZVR5cGUuaXNOdWxs
KCkpIHsKKyAgICAgICAgaWYgKGdfc3RyX2VxdWFsKG1pbWVUeXBlLmRhdGEoKSwgImF1ZGlvL3gt
dm9yYmlzK29nZyIpKQorICAgICAgICAgICAgbWltZVR5cGUgPSAiYXVkaW8vb2dnIjsKKwogICAg
ICAgICBjb25zdCBjaGFyKiBvZmZpY2lhbFR5cGUgPSBzb3VwX21lc3NhZ2VfaGVhZGVyc19nZXRf
b25lKG1zZy0+cmVzcG9uc2VfaGVhZGVycywgIkNvbnRlbnQtVHlwZSIpOwogCi0gICAgICAgIGlm
ICghb2ZmaWNpYWxUeXBlIHx8IHN0cmNtcChvZmZpY2lhbFR5cGUsIHNuaWZmZWRUeXBlKSkKLSAg
ICAgICAgICAgIHNvdXBfbWVzc2FnZV9oZWFkZXJzX3NldF9jb250ZW50X3R5cGUobXNnLT5yZXNw
b25zZV9oZWFkZXJzLCBzbmlmZmVkVHlwZSwgcGFyYW1zKTsKKyAgICAgICAgaWYgKCFvZmZpY2lh
bFR5cGUgfHwgc3RyY21wKG9mZmljaWFsVHlwZSwgbWltZVR5cGUuZGF0YSgpKSkKKyAgICAgICAg
ICAgIHNvdXBfbWVzc2FnZV9oZWFkZXJzX3NldF9jb250ZW50X3R5cGUobXNnLT5yZXNwb25zZV9o
ZWFkZXJzLCBtaW1lVHlwZS5kYXRhKCksIHBhcmFtcyk7CiAgICAgfQogCiAgICAgaWYgKHN0YXR1
c1dpbGxCZUhhbmRsZWRCeVNvdXAobXNnLT5zdGF0dXNfY29kZSkpCmRpZmYgLS1naXQgYS9XZWJL
aXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IGM3OThiMDIuLjkz
YjVjZDMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9ndGsv
Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDktMDggIFBoaWxpcHBlIE5vcm1hbmQg
IDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgIFtHVEtdIHRlc3RtaW1laGFuZGxpbmcgZmFsc2VseSBzdWNjZWVkcyB0
ZXN0aW5nIE9nZyBtaW1lIHR5cGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTQ1MzQ5CisKKyAgICAgICAgKiB0ZXN0cy90ZXN0bWltZWhhbmRsaW5nLmM6
CisgICAgICAgICh0ZXN0X21pbWVfb2dnKTogTWFrZSB0aGlzIGFjdHVhbGx5IHRlc3QgYW4gb2dn
IGZpbGUgcmVxdWVzdAorICAgICAgICBpbnN0ZWFkIG9mIHBkZi4KKwogMjAxMC0wOS0wOCAgTWFy
aW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3
ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay90ZXN0cy90ZXN0
bWltZWhhbmRsaW5nLmMgYi9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RtaW1laGFuZGxpbmcuYwppbmRl
eCAyYWIwMjU3Li43MjVjZWFkIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RtaW1l
aGFuZGxpbmcuYworKysgYi9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RtaW1laGFuZGxpbmcuYwpAQCAt
MTcyLDcgKzE3Miw3IEBAIHN0YXRpYyB2b2lkIHRlc3RfbWltZV90ZXh0KCkKIAogc3RhdGljIHZv
aWQgdGVzdF9taW1lX29nZygpCiB7Ci0gICAgdGVzdF9taW1lX3R5cGUoInBkZiIpOworICAgIHRl
c3RfbWltZV90eXBlKCJvZ2ciKTsKIH0KIAogaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2
KQotLSAKMS43LjE=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>67005</attachid>
            <date>2010-09-09 01:04:26 -0700</date>
            <delta_ts>2010-09-09 07:29:28 -0700</delta_ts>
            <desc>updated patch</desc>
            <filename>updated-patch.patch</filename>
            <type>text/plain</type>
            <size>3443</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSA4M2VhNjc4MjVmMjQyYjFhYjk4MDA0ZTk2NDU2ZTM3OGJmNDhhNmI2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBUaHUsIDkgU2VwIDIwMTAgMTA6MDQ6NTggKzAyMDAKU3ViamVjdDogW1BBVENIXSB1
cGRhdGVkIHBhdGNoCgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiAuLi4vZ3N0cmVhbWVyL01lZGlhUGxh
eWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgICAgICB8ICAgIDEgKwogV2ViS2l0L2d0ay9DaGFuZ2VM
b2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE1ICsrKysrKysrKysrKysrKwog
V2ViS2l0L2d0ay90ZXN0cy90ZXN0bWltZWhhbmRsaW5nLmMgICAgICAgICAgICAgICAgfCAgICA0
ICsrLS0KIDQgZmlsZXMgY2hhbmdlZCwgMzEgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkK
CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4
IDZmYTM2MzIuLjEyODEyMGQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dl
YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDktMDkgIFBoaWxpcHBlIE5v
cm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIHRlc3RtaW1laGFuZGxpbmcgZmFsc2VseSBzdWNj
ZWVkcyB0ZXN0aW5nIE9nZyBtaW1lIHR5cGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTQ1MzQ5CisKKyAgICAgICAgQWR2ZXJ0aXplIGF1ZGlvL3gtdm9y
YmlzK29nZyBzbyBNZWRpYURvY3VtZW50cyBsb2FkaW5nIGxvY2FsIG9nZworICAgICAgICBmaWxl
cyB3b3JrIGFzIHdlbGwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv
TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om1pbWVU
eXBlQ2FjaGUpOgorCiAyMDEwLTA5LTA4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3Jn
PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCmRpZmYgLS1naXQgYS9XZWJDb3Jl
L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIu
Y3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2
YXRlR1N0cmVhbWVyLmNwcAppbmRleCA1MTNmM2MyLi40NzkxYjRjIDEwMDY0NAotLS0gYS9XZWJD
b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt
ZXIuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxh
eWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKQEAgLTEyNjcsNiArMTI2Nyw3IEBAIHN0YXRpYyBIYXNo
U2V0PFN0cmluZz4gbWltZVR5cGVDYWNoZSgpCiAKICAgICAgICAgICAgICAgICBpZiAoZ19zdHJf
ZXF1YWwobmFtZSwgImF1ZGlvL3gtdm9yYmlzIikpIHsKICAgICAgICAgICAgICAgICAgICAgY2Fj
aGUuYWRkKFN0cmluZygiYXVkaW8vb2dnIikpOworICAgICAgICAgICAgICAgICAgICBjYWNoZS5h
ZGQoU3RyaW5nKCJhdWRpby94LXZvcmJpcytvZ2ciKSk7CiAgICAgICAgICAgICAgICAgICAgIGNh
Y2hlZCA9IHRydWU7CiAgICAgICAgICAgICAgICAgfQogCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3Rr
L0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IGM3OThiMDIuLjVmMDQ2YTYg
MTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdl
TG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDktMDkgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9y
bWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIFtHVEtdIHRlc3RtaW1laGFuZGxpbmcgZmFsc2VseSBzdWNjZWVkcyB0ZXN0aW5n
IE9nZyBtaW1lIHR5cGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTQ1MzQ5CisKKyAgICAgICAgTWFrZSB0aGlzIGFjdHVhbGx5IHRlc3QgYW4gb2dnIGZp
bGUgcmVxdWVzdCBpbnN0ZWFkIG9mIHBkZiBhbmQKKyAgICAgICAgY2hhbmdlZCB0aGUgZXhwZWN0
ZWQgcmVzdWx0IHRvIG1hdGNoIGxpYnNvdXAgY29udGVudC1zbmlmZmluZworICAgICAgICByZXN1
bHQgaW4gdGhlIGNhc2Ugb2Ygb2dnL3ZvcmJpcyBmaWxlLgorCisgICAgICAgICogdGVzdHMvdGVz
dG1pbWVoYW5kbGluZy5jOgorICAgICAgICAobWltZV90eXBlX3BvbGljeV9kZWNpc2lvbl9yZXF1
ZXN0ZWRfY2IpOgorICAgICAgICAodGVzdF9taW1lX29nZyk6CisKIDIwMTAtMDktMDggIE1hcmlv
IFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2Vk
IGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvdGVzdHMvdGVzdG1p
bWVoYW5kbGluZy5jIGIvV2ViS2l0L2d0ay90ZXN0cy90ZXN0bWltZWhhbmRsaW5nLmMKaW5kZXgg
MmFiMDI1Ny4uM2EwZWRlZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay90ZXN0cy90ZXN0bWltZWhh
bmRsaW5nLmMKKysrIGIvV2ViS2l0L2d0ay90ZXN0cy90ZXN0bWltZWhhbmRsaW5nLmMKQEAgLTEy
NSw3ICsxMjUsNyBAQCBzdGF0aWMgZ2Jvb2xlYW4gbWltZV90eXBlX3BvbGljeV9kZWNpc2lvbl9y
ZXF1ZXN0ZWRfY2IoV2ViS2l0V2ViVmlldyogdmlldywgV2ViSwogICAgICAgICBnX2Fzc2VydF9j
bXBzdHIobWltZV90eXBlLCA9PSwgInRleHQvcGxhaW4iKTsKICAgICAgICAgZ19hc3NlcnQod2Vi
a2l0X3dlYl92aWV3X2Nhbl9zaG93X21pbWVfdHlwZSh2aWV3LCBtaW1lX3R5cGUpKTsKICAgICB9
IGVsc2UgaWYgKGdfc3RyX2VxdWFsKHR5cGUsICJvZ2ciKSkgewotICAgICAgICBnX2Fzc2VydF9j
bXBzdHIobWltZV90eXBlLCA9PSwgImF1ZGlvL29nZyIpOworICAgICAgICBnX2Fzc2VydF9jbXBz
dHIobWltZV90eXBlLCA9PSwgImF1ZGlvL3gtdm9yYmlzK29nZyIpOwogICAgICAgICBnX2Fzc2Vy
dCh3ZWJraXRfd2ViX3ZpZXdfY2FuX3Nob3dfbWltZV90eXBlKHZpZXcsIG1pbWVfdHlwZSkpOwog
ICAgIH0KIApAQCAtMTcyLDcgKzE3Miw3IEBAIHN0YXRpYyB2b2lkIHRlc3RfbWltZV90ZXh0KCkK
IAogc3RhdGljIHZvaWQgdGVzdF9taW1lX29nZygpCiB7Ci0gICAgdGVzdF9taW1lX3R5cGUoInBk
ZiIpOworICAgIHRlc3RfbWltZV90eXBlKCJvZ2ciKTsKIH0KIAogaW50IG1haW4oaW50IGFyZ2Ms
IGNoYXIqKiBhcmd2KQotLSAKMS43LjE=
</data>
<flag name="review"
          id="56177"
          type_id="1"
          status="+"
          setter="mrobinson"
    />
          </attachment>
      

    </bug>

</bugzilla>