<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>45345</bug_id>
          
          <creation_ts>2010-09-07 17:35:16 -0700</creation_ts>
          <short_desc>NULL deref when use target is reset, then set to display:none</short_desc>
          <delta_ts>2010-09-08 05:09:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>SVG</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://www.croczilla.com/bits_and_pieces/svg/samples/invaders/invaders.svg</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Justin Schuh">jschuh</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>jschuh</cc>
    
    <cc>zimmermann</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>275443</commentid>
    <comment_count>0</comment_count>
    <who name="Justin Schuh">jschuh</who>
    <bug_when>2010-09-07 17:35:16 -0700</bug_when>
    <thetext>This can be triggered when you lose the SVG space invaders game in the linked URL. It&apos;s a clean NULL deref, and I&apos;ll have a patch shortly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>275461</commentid>
    <comment_count>1</comment_count>
      <attachid>66807</attachid>
    <who name="Justin Schuh">jschuh</who>
    <bug_when>2010-09-07 17:47:54 -0700</bug_when>
    <thetext>Created attachment 66807
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>275644</commentid>
    <comment_count>2</comment_count>
      <attachid>66807</attachid>
    <who name="Nikolas Zimmermann">zimmermann</who>
    <bug_when>2010-09-07 23:55:37 -0700</bug_when>
    <thetext>Comment on attachment 66807
Patch

Good catch, r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>275762</commentid>
    <comment_count>3</comment_count>
      <attachid>66807</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-09-08 05:09:21 -0700</bug_when>
    <thetext>Comment on attachment 66807
Patch

Clearing flags on attachment: 66807

Committed r66973: &lt;http://trac.webkit.org/changeset/66973&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>275763</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-09-08 05:09:26 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>66807</attachid>
            <date>2010-09-07 17:47:54 -0700</date>
            <delta_ts>2010-09-08 05:09:21 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-45345-20100907174753.patch</filename>
            <type>text/plain</type>
            <size>3434</size>
            <attacher name="Justin Schuh">jschuh</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA2NjkzNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDktMDcgIEp1c3RpbiBTY2h1aCAgPGpzY2h1aEBjaHJvbWl1
bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
TlVMTCBkZXJlZiB3aGVuIHVzZSB0YXJnZXQgaXMgcmVzZXQsIHRoZW4gc2V0IHRvIGRpc3BsYXk6
bm9uZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDUz
NDUKKworICAgICAgICBNb3ZlIHRoZSBOVUxMIGNoZWNrIG9uIHNoYWRvd1Jvb3QgZWFybGllciBp
biBTVkdVc2VFbGVtZW50OjpyZWNhbGNTdHlsZQorCisgICAgICAgIFRlc3Q6IHN2Zy9jdXN0b20v
dXNlLWRpc3BsYXktbm9uZS5zdmcKKworICAgICAgICAqIHN2Zy9TVkdVc2VFbGVtZW50LmNwcDoK
KyAgICAgICAgKFdlYkNvcmU6OlNWR1VzZUVsZW1lbnQ6OnJlY2FsY1N0eWxlKToKKwogMjAxMC0w
OS0wNyAgTWloYWkgUGFycGFyaXRhICA8bWloYWlwQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS
ZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IFdlYkNvcmUvc3ZnL1NWR1VzZUVsZW1lbnQu
Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvc3ZnL1NWR1VzZUVsZW1lbnQuY3BwCShyZXZpc2lv
biA2NjkzMikKKysrIFdlYkNvcmUvc3ZnL1NWR1VzZUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkp
CkBAIC0zMjYsMTYgKzMyNiwxNiBAQCB2b2lkIFNWR1VzZUVsZW1lbnQ6OnJlY2FsY1N0eWxlKFN0
eWxlQ2hhCiAgICAgaWYgKG1fdXBkYXRlc0Jsb2NrZWQpCiAgICAgICAgIEFTU0VSVCghbV9uZWVk
c1NoYWRvd1RyZWVSZWNyZWF0aW9uKTsKIAorICAgIFJlbmRlclNWR1NoYWRvd1RyZWVSb290Q29u
dGFpbmVyKiBzaGFkb3dSb290ID0gc3RhdGljX2Nhc3Q8UmVuZGVyU1ZHU2hhZG93VHJlZVJvb3RD
b250YWluZXIqPihyZW5kZXJlcigpKTsKKyAgICBpZiAoIXNoYWRvd1Jvb3QpCisgICAgICAgIHJl
dHVybjsKKyAgICAKICAgICBib29sIG5lZWRzU3R5bGVVcGRhdGUgPSAhbV9uZWVkc1NoYWRvd1Ry
ZWVSZWNyZWF0aW9uOwogICAgIGlmIChtX25lZWRzU2hhZG93VHJlZVJlY3JlYXRpb24pIHsKLSAg
ICAgICAgc3RhdGljX2Nhc3Q8UmVuZGVyU1ZHU2hhZG93VHJlZVJvb3RDb250YWluZXIqPihyZW5k
ZXJlcigpKS0+bWFya1NoYWRvd1RyZWVGb3JSZWNyZWF0aW9uKCk7CisgICAgICAgIHNoYWRvd1Jv
b3QtPm1hcmtTaGFkb3dUcmVlRm9yUmVjcmVhdGlvbigpOwogICAgICAgICBtX25lZWRzU2hhZG93
VHJlZVJlY3JlYXRpb24gPSBmYWxzZTsKICAgICB9CiAKLSAgICBSZW5kZXJTVkdTaGFkb3dUcmVl
Um9vdENvbnRhaW5lciogc2hhZG93Um9vdCA9IHN0YXRpY19jYXN0PFJlbmRlclNWR1NoYWRvd1Ry
ZWVSb290Q29udGFpbmVyKj4ocmVuZGVyZXIoKSk7Ci0gICAgaWYgKCFzaGFkb3dSb290KQotICAg
ICAgICByZXR1cm47Ci0KICAgICBzaGFkb3dSb290LT51cGRhdGVGcm9tRWxlbWVudCgpOwogCiAg
ICAgaWYgKCFuZWVkc1N0eWxlVXBkYXRlKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNjY5MzYpCisrKyBM
YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAx
MC0wOS0wNyAgSnVzdGluIFNjaHVoICA8anNjaHVoQGNocm9taXVtLm9yZz4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOVUxMIGRlcmVmIHdoZW4gdXNl
IHRhcmdldCBpcyByZXNldCwgdGhlbiBzZXQgdG8gZGlzcGxheTpub25lCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTM0NQorCisgICAgICAgICogc3Zn
L2N1c3RvbS91c2UtZGlzcGxheS1ub25lLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog
c3ZnL2N1c3RvbS91c2UtZGlzcGxheS1ub25lLnN2ZzogQWRkZWQuCisKIDIwMTAtMDktMDcgIE1p
aGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg
YnkgT2xpdmVyIEh1bnQuCkluZGV4OiBMYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3VzZS1kaXNwbGF5
LW5vbmUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3N2Zy9jdXN0b20v
dXNlLWRpc3BsYXktbm9uZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0
cy9zdmcvY3VzdG9tL3VzZS1kaXNwbGF5LW5vbmUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpA
QCAtMCwwICsxIEBACitQQVNTOiBUaGUgdGV4dCBpcyBkaXNwbGF5ZWQgYW5kIHRoZSBmaWxlIGRp
ZCBub3QgdHJpZ2dlciBhIGNyYXNoLgpJbmRleDogTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS91c2Ut
ZGlzcGxheS1ub25lLnN2Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3Vz
ZS1kaXNwbGF5LW5vbmUuc3ZnCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvc3ZnL2N1c3Rv
bS91c2UtZGlzcGxheS1ub25lLnN2ZwkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMiBAQAorPHN2
ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8v
d3d3LnczLm9yZy8xOTk5L3hsaW5rIj4KKyAgICA8c3ltYm9sIGlkPSJhIi8+CisgICAgPHVzZSBp
ZD0iYiIgeGxpbms6aHJlZj0iI2EiLz4KKyAgICA8c2NyaXB0PgorICAgICAgICBpZiAod2luZG93
LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIu
ZHVtcEFzVGV4dCgpOworICAgICAgICBiPWRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdiJyk7Cisg
ICAgICAgIGIuaHJlZi5iYXNlVmFsPSIjYSI7CisgICAgICAgIGIuc2V0QXR0cmlidXRlKCJkaXNw
bGF5Iiwibm9uZSIpOworICAgIDwvc2NyaXB0PgorICAgIDx0ZXh0IHk9IjIwIj5QQVNTOiBUaGUg
dGV4dCBpcyBkaXNwbGF5ZWQgYW5kIHRoZSBmaWxlIGRpZCBub3QgdHJpZ2dlciBhIGNyYXNoLjwv
dGV4dD4KKzwvc3ZnPgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>