45344 2010-09-07 17:32:51 -0700 Null deref in InlineBox::height() 2010-09-25 10:34:37 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 cdn webkit-unassigned cdn eric jamesr mitz rniwa oldest_to_newest 275437 0 66801 cdn 2010-09-07 17:32:51 -0700 Created attachment 66801 repro When firstline is true the renderers style() method may return null and then be derefed. I hav been hitting this a lot with a fuzzer I am working on and will submit a patch shortly. the attached repro will trigger this. 275481 1 66812 cdn 2010-09-07 18:04:09 -0700 Created attachment 66812 Patch 275484 2 cdn 2010-09-07 18:06:06 -0700 +jamesr James can you review this when you get a chance. Thanks! 275505 3 66812 jamesr 2010-09-07 18:26:29 -0700 Comment on attachment 66812 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66812&action=prettypatch > WebCore/rendering/InlineBox.cpp:99 > + if (!renderer()->style(m_firstLine)) > + return 0; > if (renderer()->isText()) > return m_isText ? renderer()->style(m_firstLine)->font().height() : 0; > if (renderer()->isBox() && parent()) There's one very slight behavior change here - if renderer()->isBox() && parent() == true, old code wouldn't call renderer()->style(m_firstLine) at all whereas this patch will. Can you reoranize this so that's still true? I think moving the isBox() && ... branch above the NULL check will suffice. 275947 4 66917 cdn 2010-09-08 11:10:24 -0700 Created attachment 66917 Patch 275948 5 cdn 2010-09-08 11:11:30 -0700 Good catch. Thank you! 279419 6 66917 eric 2010-09-15 00:01:36 -0700 Comment on attachment 66917 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66917&action=prettypatch > WebCore/rendering/InlineBox.cpp:-97 > + if (!renderer()->style(m_firstLine)) > + return 0; > if (renderer()->isText()) > return m_isText ? renderer()->style(m_firstLine)->font().height() : 0; > - if (renderer()->isBox() && parent()) I believe style(m_firstLine) is non-trivial. Shouldn't we cache it in a local variable? RenderStyle* firstLineStyle() const { return document()->usesFirstLineRules() ? firstLineStyleSlowCase() : style(); } RenderStyle* style(bool firstLine) const { return firstLine ? firstLineStyle() : style(); } 279426 7 mitz 2010-09-15 00:14:22 -0700 Does this still happen with the fix for bug 45574 (r67255 or later)? style() should never return null and if it is, then that should be fixed, not papered over. 284575 8 rniwa 2010-09-24 11:32:51 -0700 The repro now causes a crash at the line 96 of InlineBox.cpp: if (renderer()->isText()) return m_isText ? renderer()->style(m_firstLine)->font().height() : 0; font() is 0 and crashes inside RefPtr. 284591 9 mitz 2010-09-24 11:52:40 -0700 (In reply to comment #8) > The repro now causes a crash at the line 96 of InlineBox.cpp: > > if (renderer()->isText()) > return m_isText ? renderer()->style(m_firstLine)->font().height() : 0; > > font() is 0 and crashes inside RefPtr. Seems like style(true) is still null. 284603 10 mitz 2010-09-24 12:10:16 -0700 I think the issue is that RenderObject::firstLineStyleSlowCase() calls setHasPseudoStyle() on the wrong RenderStyle, namely the RenderText’s instead of its parent’s. 284964 11 mitz 2010-09-25 00:12:12 -0700 <rdar://problem/8478160> 284965 12 68814 mitz 2010-09-25 00:22:03 -0700 Created attachment 68814 Set the pseudo style bit on the RenderStyle which is going to supply the first-line style 285037 13 mitz 2010-09-25 10:34:37 -0700 Fixed in <http://trac.webkit.org/projects/webkit/changeset/68335>. 66801 2010-09-07 17:32:51 -0700 2010-09-07 17:32:51 -0700 repro inlinebox-null-style.html text/html 449 cdn PHNjcmlwdD4KaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKICAgIGxheW91dFRlc3RD b250cm9sbGVyLmR1bXBBc1RleHQoKTsKCmZ1bmN0aW9uIGNvbW1hbmRzKCl7CiAgICBnZXRTZWxl Y3Rpb24oKS5hZGRSYW5nZShkb2N1bWVudC5jcmVhdGVSYW5nZSgpKTsKICAgIGRvY3VtZW50LmV4 ZWNDb21tYW5kKCdpbnNlcnRQYXJhZ3JhcGgnLCBudWxsLCAndHJ1ZScpOwogICAgZG9jdW1lbnQu ZXhlY0NvbW1hbmQoJ2luc2VydFVub3JkZXJlZExpc3QnLCBudWxsLCAndHJ1ZScpOwp9Cjwvc2Ny aXB0Pgo8c3R5bGU+KjpudGgtY2hpbGQoMSk6Zmlyc3QtbGluZSB7IGN1cnNvcjogdXJsKGFueSk7 IH08L3N0eWxlPgo8Ym9keSBvbmxvYWQ9ImNvbW1hbmRzKCkiPgo8ZGl2IGNvbnRlbnRFZGl0YWJs ZT4KPHNwYW4+ClRoaXMgdGV4dCBzaG91bGQgcmVuZGVyIHdpdGhvdXQgY3Jhc2hpbmc= 66812 2010-09-07 18:04:09 -0700 2010-09-08 11:10:21 -0700 Patch bug-45344-20100907180407.patch text/plain 2818 cdn SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Njk0MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDktMDcgIENyaXMgTmVja2FyICA8Y2RuQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOdWxs IGRlcmVmIGluIElubGluZUJveDo6aGVpZ2h0KCkuIEFkZGVkIGNoZWNrIGZvciBudWxsIHN0eWxl LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDUzNDQK KworICAgICAgICBUZXN0OiBmYXN0L2lubGluZS9pbmxpbmUtaW5zZXJ0LWNyYXNoLmh0bWwKKwor ICAgICAgICAqIHJlbmRlcmluZy9JbmxpbmVCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5s aW5lQm94OjpoZWlnaHQpOgorCiAyMDEwLTA5LTA3ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1A d2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZCBmaXgsIG5vIHJldmlldy4KSW5kZXg6IFdlYkNv cmUvcmVuZGVyaW5nL0lubGluZUJveC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJp bmcvSW5saW5lQm94LmNwcAkocmV2aXNpb24gNjY5MzYpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9J bmxpbmVCb3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05Miw2ICs5Miw4IEBAIGludCBJbmxpbmVC b3g6OmhlaWdodCgpIGNvbnN0CiAgICAgICAgIHJldHVybiB2aXJ0dWFsSGVpZ2h0KCk7CiAjZW5k aWYKICAgICAKKyAgICBpZiAoIXJlbmRlcmVyKCktPnN0eWxlKG1fZmlyc3RMaW5lKSkKKyAgICAg ICAgcmV0dXJuIDA7CiAgICAgaWYgKHJlbmRlcmVyKCktPmlzVGV4dCgpKQogICAgICAgICByZXR1 cm4gbV9pc1RleHQgPyByZW5kZXJlcigpLT5zdHlsZShtX2ZpcnN0TGluZSktPmZvbnQoKS5oZWln aHQoKSA6IDA7CiAgICAgaWYgKHJlbmRlcmVyKCktPmlzQm94KCkgJiYgcGFyZW50KCkpCkluZGV4 OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCShyZXZpc2lvbiA2Njk0MCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA5LTA3ICBDcmlzIE5lY2thciAgPGNkbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVHJpZ2dlcnMgbnVsbCBkZXJlZiBpbiBJbmxpbmVCb3g6OmhlaWdodCgpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTM0NAorCisgICAgICAgICog ZmFzdC9pbmxpbmUvaW5saW5lLWluc2VydC1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAg ICAgICAqIGZhc3QvaW5saW5lL2lubGluZS1pbnNlcnQtY3Jhc2guaHRtbDogQWRkZWQuCisKIDIw MTAtMDktMDcgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2lubGlu ZS9pbmxpbmUtaW5zZXJ0LWNyYXNoLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L2lubGluZS9pbmxpbmUtaW5zZXJ0LWNyYXNoLWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvaW5saW5lL2lubGluZS1pbnNlcnQtY3Jhc2gtZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIgQEAKKworVGhpcyB0ZXh0IHNob3Vs ZCByZW5kZXIgd2l0aG91dCBjcmFzaGluZwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9pbmxpbmUv aW5saW5lLWluc2VydC1jcmFzaC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qv aW5saW5lL2lubGluZS1pbnNlcnQtY3Jhc2guaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL2Zhc3QvaW5saW5lL2lubGluZS1pbnNlcnQtY3Jhc2guaHRtbAkocmV2aXNpb24gMCkKQEAg LTAsMCArMSwxNiBAQAorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIp CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCitmdW5jdGlvbiBjb21t YW5kcygpeworICAgIGdldFNlbGVjdGlvbigpLmFkZFJhbmdlKGRvY3VtZW50LmNyZWF0ZVJhbmdl KCkpOworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCdpbnNlcnRQYXJhZ3JhcGgnLCBudWxsLCAn dHJ1ZScpOworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCdpbnNlcnRVbm9yZGVyZWRMaXN0Jywg bnVsbCwgJ3RydWUnKTsKK30KKzwvc2NyaXB0PgorPHN0eWxlPio6bnRoLWNoaWxkKDEpOmZpcnN0 LWxpbmUgeyBjdXJzb3I6IHVybChhbnkpOyB9PC9zdHlsZT4KKzxib2R5IG9ubG9hZD0iY29tbWFu ZHMoKSI+Cis8ZGl2IGNvbnRlbnRFZGl0YWJsZT4KKzxzcGFuPgorVGhpcyB0ZXh0IHNob3VsZCBy ZW5kZXIgd2l0aG91dCBjcmFzaGluZworCg== 66917 2010-09-08 11:10:24 -0700 2010-09-15 00:01:36 -0700 Patch bug-45344-20100908111023.patch text/plain 3087 cdn SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Njk5NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDktMDggIENyaXMgTmVja2FyICA8Y2RuQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOdWxs IGRlcmVmIGluIElubGluZUJveDo6aGVpZ2h0KCkuIEFkZGVkIGNoZWNrIGZvciBudWxsIHN0eWxl LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDUzNDQK KworICAgICAgICBUZXN0OiBmYXN0L2lubGluZS9pbmxpbmUtaW5zZXJ0LWNyYXNoLmh0bWwKKwor ICAgICAgICAqIHJlbmRlcmluZy9JbmxpbmVCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5s aW5lQm94OjpoZWlnaHQpOgorCiAyMDEwLTA5LTA3ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpJbmRleDogV2Vi Q29yZS9yZW5kZXJpbmcvSW5saW5lQm94LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRl cmluZy9JbmxpbmVCb3guY3BwCShyZXZpc2lvbiA2Njk5MykKKysrIFdlYkNvcmUvcmVuZGVyaW5n L0lubGluZUJveC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkxLDExICs5MSwxMyBAQCBpbnQgSW5s aW5lQm94OjpoZWlnaHQoKSBjb25zdAogICAgIGlmIChoYXNWaXJ0dWFsSGVpZ2h0KCkpCiAgICAg ICAgIHJldHVybiB2aXJ0dWFsSGVpZ2h0KCk7CiAjZW5kaWYKLSAgICAKKworICAgIGlmIChyZW5k ZXJlcigpLT5pc0JveCgpICYmIHBhcmVudCgpKQorICAgICAgICByZXR1cm4gdG9SZW5kZXJCb3go bV9yZW5kZXJlciktPmhlaWdodCgpOyAgICAKKyAgICBpZiAoIXJlbmRlcmVyKCktPnN0eWxlKG1f Zmlyc3RMaW5lKSkKKyAgICAgICAgcmV0dXJuIDA7CiAgICAgaWYgKHJlbmRlcmVyKCktPmlzVGV4 dCgpKQogICAgICAgICByZXR1cm4gbV9pc1RleHQgPyByZW5kZXJlcigpLT5zdHlsZShtX2ZpcnN0 TGluZSktPmZvbnQoKS5oZWlnaHQoKSA6IDA7Ci0gICAgaWYgKHJlbmRlcmVyKCktPmlzQm94KCkg JiYgcGFyZW50KCkpCi0gICAgICAgIHJldHVybiB0b1JlbmRlckJveChtX3JlbmRlcmVyKS0+aGVp Z2h0KCk7CiAKICAgICBBU1NFUlQoaXNJbmxpbmVGbG93Qm94KCkpOwogICAgIFJlbmRlckJveE1v ZGVsT2JqZWN0KiBmbG93T2JqZWN0ID0gYm94TW9kZWxPYmplY3QoKTsKSW5kZXg6IExheW91dFRl c3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlz aW9uIDY2OTk1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTAtMDktMDggIENyaXMgTmVja2FyICA8Y2RuQGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUcmlnZ2Vy cyBudWxsIGRlcmVmIGluIElubGluZUJveDo6aGVpZ2h0KCkuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTM0NAorCisgICAgICAgICogZmFzdC9pbmxp bmUvaW5saW5lLWluc2VydC1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZh c3QvaW5saW5lL2lubGluZS1pbnNlcnQtY3Jhc2guaHRtbDogQWRkZWQuCisKIDIwMTAtMDktMDgg IEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVy aWMgQ2FybHNvbi4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvaW5saW5lL2lubGluZS1pbnNlcnQt Y3Jhc2gtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvaW5saW5l L2lubGluZS1pbnNlcnQtY3Jhc2gtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0 VGVzdHMvZmFzdC9pbmxpbmUvaW5saW5lLWluc2VydC1jcmFzaC1leHBlY3RlZC50eHQJKHJldmlz aW9uIDApCkBAIC0wLDAgKzEsMiBAQAorCitUaGlzIHRleHQgc2hvdWxkIHJlbmRlciB3aXRob3V0 IGNyYXNoaW5nCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2lubGluZS9pbmxpbmUtaW5zZXJ0LWNy YXNoLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9pbmxpbmUvaW5saW5lLWlu c2VydC1jcmFzaC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9pbmxpbmUv aW5saW5lLWluc2VydC1jcmFzaC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE2IEBACis8 c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0 Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKK2Z1bmN0aW9uIGNvbW1hbmRzKCl7CisgICAgZ2V0 U2VsZWN0aW9uKCkuYWRkUmFuZ2UoZG9jdW1lbnQuY3JlYXRlUmFuZ2UoKSk7CisgICAgZG9jdW1l bnQuZXhlY0NvbW1hbmQoJ2luc2VydFBhcmFncmFwaCcsIG51bGwsICd0cnVlJyk7CisgICAgZG9j dW1lbnQuZXhlY0NvbW1hbmQoJ2luc2VydFVub3JkZXJlZExpc3QnLCBudWxsLCAndHJ1ZScpOwor fQorPC9zY3JpcHQ+Cis8c3R5bGU+KjpudGgtY2hpbGQoMSk6Zmlyc3QtbGluZSB7IGN1cnNvcjog dXJsKGFueSk7IH08L3N0eWxlPgorPGJvZHkgb25sb2FkPSJjb21tYW5kcygpIj4KKzxkaXYgY29u dGVudEVkaXRhYmxlPgorPHNwYW4+CitUaGlzIHRleHQgc2hvdWxkIHJlbmRlciB3aXRob3V0IGNy YXNoaW5nCisK 68814 2010-09-25 00:22:03 -0700 2010-09-25 06:22:06 -0700 Set the pseudo style bit on the RenderStyle which is going to supply the first-line style 8478160_r1.diff text/plain 3616 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODMyOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDktMjUgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICA8cmRh cjovL3Byb2JsZW0vODQ3ODE2MD4gTnVsbCBkZXJlZiBpbiBJbmxpbmVCb3g6OmhlaWdodCgpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTM0NAorCisg ICAgICAgIFRlc3Q6IGZhc3QvY3NzL2ZpcnN0LWxpbmUtcGFyZW50LXN0eWxlLWRpZmZlcmVudC5o dG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlck9iamVjdDo6Zmlyc3RMaW5lU3R5bGVTbG93Q2FzZSk6IFNldCB0aGUgcHNl dWRvIHN0eWxlIGJpdCBvbiB0aGUgUmVuZGVyU3R5bGUKKyAgICAgICAgd2hpY2ggaXMgZ29pbmcg dG8gc3VwcGx5IHRoZSBmaXJzdC1saW5lIHN0eWxlIHJhdGhlciB0aGFuIG9uIHRoaXMgb2JqZWN0 4oCZcyBSZW5kZXJTdHlsZS4gVGhlCisgICAgICAgIHN0eWxlcyBtYXkgZGlmZmVyLgorCiAyMDEw LTA5LTI0ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUnViYmVyLXN0 YW1wZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9i amVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNw cAkocmV2aXNpb24gNjgzMjYpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0yMzQyLDcgKzIzNDIsNyBAQCBSZW5kZXJTdHlsZSogUmVuZGVy T2JqZWN0OjpmaXJzdExpbmVTdHlsCiAgICAgICAgIFJlbmRlclN0eWxlKiBwYXJlbnRTdHlsZSA9 IHJlbmRlcmVyLT5wYXJlbnQoKS0+Zmlyc3RMaW5lU3R5bGUoKTsKICAgICAgICAgaWYgKHBhcmVu dFN0eWxlICE9IHJlbmRlcmVyLT5wYXJlbnQoKS0+c3R5bGUoKSkgewogICAgICAgICAgICAgLy8g QSBmaXJzdC1saW5lIHN0eWxlIGlzIGluIGVmZmVjdC4gQ2FjaGUgYSBmaXJzdC1saW5lIHN0eWxl IGZvciBvdXJzZWx2ZXMuCi0gICAgICAgICAgICBzdHlsZS0+c2V0SGFzUHNldWRvU3R5bGUoRklS U1RfTElORV9JTkhFUklURUQpOworICAgICAgICAgICAgcmVuZGVyZXItPnN0eWxlKCktPnNldEhh c1BzZXVkb1N0eWxlKEZJUlNUX0xJTkVfSU5IRVJJVEVEKTsKICAgICAgICAgICAgIHN0eWxlID0g cmVuZGVyZXItPmdldENhY2hlZFBzZXVkb1N0eWxlKEZJUlNUX0xJTkVfSU5IRVJJVEVELCBwYXJl bnRTdHlsZSk7CiAgICAgICAgIH0KICAgICB9CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2ODMyOCkKKysr IExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisy MDEwLTA5LTI1ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg0Nzgx NjA+IE51bGwgZGVyZWYgaW4gSW5saW5lQm94OjpoZWlnaHQoKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDUzNDQKKworICAgICAgICAqIGZhc3QvY3Nz L2ZpcnN0LWxpbmUtcGFyZW50LXN0eWxlLWRpZmZlcmVudC1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIGZhc3QvY3NzL2ZpcnN0LWxpbmUtcGFyZW50LXN0eWxlLWRpZmZlcmVudC5odG1s OiBBZGRlZC4KKwogMjAxMC0wOS0yNCAgTWloYWkgUGFycGFyaXRhICA8bWloYWlwQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIENocm9taXVtIHRlc3RfZXhwZWN0YXRpb25zLnR4 dCBhbmQgZHJ0X2V4cGVjdGF0aW9ucy50eHQgdXBkYXRlLgpJbmRleDogTGF5b3V0VGVzdHMvZmFz dC9jc3MvZmlyc3QtbGluZS1wYXJlbnQtc3R5bGUtZGlmZmVyZW50LWV4cGVjdGVkLnR4dAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9maXJzdC1saW5lLXBhcmVudC1zdHlsZS1k aWZmZXJlbnQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9j c3MvZmlyc3QtbGluZS1wYXJlbnQtc3R5bGUtZGlmZmVyZW50LWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSw3IEBACitUZXN0IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDUzNDQgTnVsbCBkZXJlZiBpbiBJbmxpbmVCb3g6OmhlaWdodCgpLgor CitUaGlzIHRlc3Qgc2hvdWxkIG5vdCBjcmFzaC4KKworCisKKwpJbmRleDogTGF5b3V0VGVzdHMv ZmFzdC9jc3MvZmlyc3QtbGluZS1wYXJlbnQtc3R5bGUtZGlmZmVyZW50Lmh0bWwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jc3MvZmlyc3QtbGluZS1wYXJlbnQtc3R5bGUtZGlmZmVy ZW50Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9maXJzdC1saW5l LXBhcmVudC1zdHlsZS1kaWZmZXJlbnQuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyMCBA QAorPHN0eWxlPgorICAgICNkdW1teTpudGgtY2hpbGQoMykgeyB9CisgICAgI2NvbnRhaW5lcjpm aXJzdC1saW5lIHsgY29sb3I6IGJsdWU7IH0KKzwvc3R5bGU+Cis8cD4KKyAgICBUZXN0IGZvciA8 aT48YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDUzNDQi Pmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTM0NDwvYT4KKyAgICBO dWxsIGRlcmVmIGluIElubGluZUJveDo6aGVpZ2h0KCk8L2k+LgorPC9wPgorPHA+CisgICAgVGhp cyB0ZXN0IHNob3VsZCBub3QgY3Jhc2guCis8L3A+Cis8ZGl2IGNvbnRlbnRFZGl0YWJsZT4KKyAg ICA8aW1nIGlkPSJkdW1teSI+CisgICAgPGRpdiBpZD0iY29udGFpbmVyIj48c3BhbiBpZD0idGFy Z2V0Ij48YnI+PC9zcGFuPjwvZGl2PgorPC9kaXY+Cis8c2NyaXB0PgorICAgIGlmICh3aW5kb3cu bGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBB c1RleHQoKTsKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29udGFpbmVyIikucGFyZW50 Tm9kZS5mb2N1cygpOworPC9zY3JpcHQ+Cg==