45336 2010-09-07 16:45:09 -0700 Fix OpenGL error reporting in WebGL layout test utilities 2010-09-07 16:56:45 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 45332 1 kbr kbr cmarrin dglazkov zmo oldest_to_newest 275394 0 kbr 2010-09-07 16:45:09 -0700 There is a bug in getGLErrorAsString (LayoutTests/fast/canvas/webgl/resources/webgl-test.js) where if for some reason the error code is not found in the context object, the error code is not properly output. This is affecting the error reporting for https://bugs.webkit.org/show_bug.cgi?id=45332 . 275398 1 66788 kbr 2010-09-07 16:48:44 -0700 Created attachment 66788 Patch 275399 2 66788 jamesr 2010-09-07 16:51:37 -0700 Comment on attachment 66788 Patch Looks good! 275404 3 kbr 2010-09-07 16:56:45 -0700 Committed r66934: <http://trac.webkit.org/changeset/66934> 66788 2010-09-07 16:48:44 -0700 2010-09-07 16:51:36 -0700 Patch gl-error-reporting.patch text/plain 1100 kbr SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY2OTMyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDktMDcgIEtlbm5ldGggUnVzc2VsbCAg PGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZpeCBPcGVuR0wgZXJyb3IgcmVwb3J0aW5nIGluIFdlYkdMIGxheW91dCB0ZXN0 IHV0aWxpdGllcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDUzMzYKKworICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL3Jlc291cmNlcy93ZWJnbC10 ZXN0LmpzOgorICAgICAgICAoZ2V0R0xFcnJvckFzU3RyaW5nKToKKwogMjAxMC0wOS0wNyAgVG9u eSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHVwZGF0 aW5nIGNocm9taXVtIGxpbnV4IHRlc3QgZXhwZWN0YXRpb25zLgpJbmRleDogTGF5b3V0VGVzdHMv ZmFzdC9jYW52YXMvd2ViZ2wvcmVzb3VyY2VzL3dlYmdsLXRlc3QuanMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvcmVzb3VyY2VzL3dlYmdsLXRlc3QuanMJKHJl dmlzaW9uIDY2OTMwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvcmVzb3VyY2Vz L3dlYmdsLXRlc3QuanMJKHdvcmtpbmcgY29weSkKQEAgLTEwOSw3ICsxMDksNyBAQCBmdW5jdGlv biBnZXRHTEVycm9yQXNTdHJpbmcoY3R4LCBlcnIpIHsKICAgICAgIHJldHVybiBuYW1lOwogICAg IH0KICAgfQotICByZXR1cm4gZXJyLnRvU3RyaW5nKCk7CisgIHJldHVybiAiMHgiICsgZXJyLnRv U3RyaW5nKDE2KTsKIH0KIAogZnVuY3Rpb24gc2hvdWxkR2VuZXJhdGVHTEVycm9yKGN0eCwgZ2xF cnJvciwgZXZhbFN0cikgewo=