45315 2010-09-07 11:58:38 -0700 Enable incremental results.json generation for non-layout tests. 2010-09-07 22:54:56 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 kinuko webkit-unassigned ojan victorw oldest_to_newest 275199 0 kinuko 2010-09-07 11:58:38 -0700 Enable incremental results.json generation for non-layout tests. Also need to add a functionality to upload the results to the app-engine's test results server. 275207 1 66748 kinuko 2010-09-07 12:26:19 -0700 Created attachment 66748 Patch 275414 2 66748 victorw 2010-09-07 17:05:58 -0700 Comment on attachment 66748 Patch > + json_files = ["incremental_results.json"] replace "incremental_results.json" with INCREMENTAL_RESULTS_FILENAME 275415 3 66748 ojan 2010-09-07 17:07:33 -0700 Comment on attachment 66748 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66748&action=prettypatch Just a few nits. > WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:296 > + print results_file_url Did you mean to include this? > WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:532 > + self._builder_name, self._test_results_server) Indentation is off. Have a couple extra spaces. > WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:595 > + # Generate the JSON with incrementa flag enabled. Typo: incrementa 275615 4 kinuko 2010-09-07 22:54:56 -0700 Committed r66953: <http://trac.webkit.org/changeset/66953> 66748 2010-09-07 12:26:19 -0700 2010-09-07 17:07:33 -0700 Patch bug-45315-20100907122617.patch text/plain 6903 kinuko ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAxMmJlNWU1N2I3ZDM5OTVjMTI5MjAwMWU4MjRhZDdiYmI5MmYyMmRmLi4xOTcxNWI0 NWY0YjAzYWM5NjU2YjM2M2E5MzgxNzc5ZjAyNWE1ODVhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDktMDcgIEtpbnVrbyBZYXN1ZGEgIDxraW51a29AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuYWJsZSBpbmNyZW1l bnRhbCByZXN1bHRzLmpzb24gZ2VuZXJhdGlvbiBmb3Igbm9uLWxheW91dCB0ZXN0cy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1MzE1CisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jl c3VsdHNfZ2VuZXJhdG9yLnB5OiBFbmFibGUgZ2VuZXJhdGVfaW5jcmVtZW50YWxfcmVzdWx0cz1U cnVlIGJ5IGRlZmF1bHQuIChUaGlzIHN0aWxsIGtlZXBzIHRvIGdlbmVyYXRlIHJlc3VsdHMuanNv bi4pICBBbHNvIGFkZCBhIGNvZGUgdG8gdXBsb2FkIHJlc3VsdHMganNvbiBmaWxlcyB0byB0aGUg YXBwLWVuZ2luZSBzZXJ2ZXIuICBOZWVkIGEgY2hyb21pdW0gY2hhbmdlIHRvIGFjdHVhbGx5IHN0 YXJ0IHRoZSB1cGxvYWRpbmcuCisKKyAgICAgICAgKiBUZXN0UmVzdWx0U2VydmVyL21vZGVsL2pz b25yZXN1bHRzLnB5OiBNYWtlIHN1cmUgd2Ugc2F2ZSB0aGUgZmlsZSB3aXRoIHRlc3RfdHlwZSBm b3IgaW5jcmVtZW50YWwgY2FzZXMgdG9vLgorCisKIDIwMTAtMDktMDMgIFNpbW9uIEZyYXNlciAg PHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBSb2Jl bi4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L2xheW91dF9wYWNrYWdlL2pzb25fcmVzdWx0c19nZW5lcmF0b3IucHkgYi9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jlc3VsdHNf Z2VuZXJhdG9yLnB5CmluZGV4IDE1ZWNlZWViYTEwMmE1ODdlZDk5N2JiYTc5Y2IzMjI3ZGQzODc5 MWMuLmIyZTQwYmJiMzNlMGRhZjUxMWNhMTQyMTg4MGYwMTI1MWRiYTUyYjUgMTAwNjQ0Ci0tLSBh L1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdl L2pzb25fcmVzdWx0c19nZW5lcmF0b3IucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvanNvbl9yZXN1bHRzX2dlbmVyYXRvci5w eQpAQCAtMzcsNiArMzcsOCBAQCBpbXBvcnQgdGltZQogaW1wb3J0IHVybGxpYjIKIGltcG9ydCB4 bWwuZG9tLm1pbmlkb20KIAorZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMubGF5b3V0X3BhY2th Z2UgaW1wb3J0IHRlc3RfcmVzdWx0c191cGxvYWRlcgorCiBpbXBvcnQgd2Via2l0cHkudGhpcmRw YXJ0eS5zaW1wbGVqc29uIGFzIHNpbXBsZWpzb24KIAogIyBBIEpTT04gcmVzdWx0cyBnZW5lcmF0 b3IgZm9yIGdlbmVyaWMgdGVzdHMuCkBAIC04NSwxMyArODcsMTQgQEAgY2xhc3MgSlNPTlJlc3Vs dHNHZW5lcmF0b3JCYXNlKG9iamVjdCk6CiAgICAgSU5DUkVNRU5UQUxfUkVTVUxUU19GSUxFTkFN RSA9ICJpbmNyZW1lbnRhbF9yZXN1bHRzLmpzb24iCiAKICAgICBVUkxfRk9SX1RFU1RfTElTVF9K U09OID0gXAotICAgICAgICAiaHR0cDovLyVzL3Rlc3RmaWxlP2J1aWxkZXI9JXMmbmFtZT0lcyZ0 ZXN0bGlzdGpzb249MSIKKyAgICAgICAgImh0dHA6Ly8lcy90ZXN0ZmlsZT9idWlsZGVyPSVzJm5h bWU9JXMmdGVzdGxpc3Rqc29uPTEmdGVzdHR5cGU9JXMiCiAKICAgICBkZWYgX19pbml0X18oc2Vs ZiwgYnVpbGRlcl9uYW1lLCBidWlsZF9uYW1lLCBidWlsZF9udW1iZXIsCiAgICAgICAgIHJlc3Vs dHNfZmlsZV9iYXNlX3BhdGgsIGJ1aWxkZXJfYmFzZV91cmwsCiAgICAgICAgIHRlc3RfcmVzdWx0 c19tYXAsIHN2bl9yZXBvc2l0b3JpZXM9Tm9uZSwKICAgICAgICAgZ2VuZXJhdGVfaW5jcmVtZW50 YWxfcmVzdWx0cz1GYWxzZSwKLSAgICAgICAgdGVzdF9yZXN1bHRzX3NlcnZlcj1Ob25lKToKKyAg ICAgICAgdGVzdF9yZXN1bHRzX3NlcnZlcj1Ob25lLAorICAgICAgICB0ZXN0X3R5cGU9IiIpOgog ICAgICAgICAiIiJNb2RpZmllcyB0aGUgcmVzdWx0cy5qc29uIGZpbGUuIEdyYWJzIGl0IG9mZiB0 aGUgYXJjaGl2ZSBkaXJlY3RvcnkKICAgICAgICAgaWYgaXQgaXMgbm90IGZvdW5kIGxvY2FsbHku CiAKQEAgLTEyOSw2ICsxMzIsNyBAQCBjbGFzcyBKU09OUmVzdWx0c0dlbmVyYXRvckJhc2Uob2Jq ZWN0KToKICAgICAgICAgICAgIHNlbGYuX3N2bl9yZXBvc2l0b3JpZXMgPSB7fQogCiAgICAgICAg IHNlbGYuX3Rlc3RfcmVzdWx0c19zZXJ2ZXIgPSB0ZXN0X3Jlc3VsdHNfc2VydmVyCisgICAgICAg IHNlbGYuX3Rlc3RfdHlwZSA9IHRlc3RfdHlwZQogCiAgICAgICAgIHNlbGYuX2pzb24gPSBOb25l CiAgICAgICAgIHNlbGYuX2FyY2hpdmVkX3Jlc3VsdHMgPSBOb25lCkBAIC0yODcsNyArMjkxLDkg QEAgY2xhc3MgSlNPTlJlc3VsdHNHZW5lcmF0b3JCYXNlKG9iamVjdCk6CiAgICAgICAgICAgICAg ICAgcmVzdWx0c19maWxlX3VybCA9IChzZWxmLlVSTF9GT1JfVEVTVF9MSVNUX0pTT04gJQogICAg ICAgICAgICAgICAgICAgICAodXJsbGliMi5xdW90ZShzZWxmLl90ZXN0X3Jlc3VsdHNfc2VydmVy KSwKICAgICAgICAgICAgICAgICAgICAgIHVybGxpYjIucXVvdGUoc2VsZi5fYnVpbGRlcl9uYW1l KSwKLSAgICAgICAgICAgICAgICAgICAgIHNlbGYuUkVTVUxUU19GSUxFTkFNRSkpCisgICAgICAg ICAgICAgICAgICAgICBzZWxmLlJFU1VMVFNfRklMRU5BTUUsCisgICAgICAgICAgICAgICAgICAg ICB1cmxsaWIyLnF1b3RlKHNlbGYuX3Rlc3RfdHlwZSkpKQorICAgICAgICAgICAgICAgIHByaW50 IHJlc3VsdHNfZmlsZV91cmwKICAgICAgICAgICAgIGVsc2U6CiAgICAgICAgICAgICAgICAgIyBD aGVjayBpZiB3ZSBoYXZlIHRoZSBhcmNoaXZlZCBKU09OIGZpbGUgb24gdGhlIGJ1aWxkYm90CiAg ICAgICAgICAgICAgICAgIyBzZXJ2ZXIuCkBAIC01MTgsOSArNTI0LDMzIEBAIGNsYXNzIEpTT05S ZXN1bHRzR2VuZXJhdG9yKEpTT05SZXN1bHRzR2VuZXJhdG9yQmFzZSk6CiAgICAgIyBUaGUgZmxh ZyBpcyBmb3IgYmFja3dhcmQgY29tcGF0aWJpbGl0eS4KICAgICBvdXRwdXRfanNvbl9pbl9pbml0 ID0gVHJ1ZQogCisgICAgZGVmIF91cGxvYWRfanNvbl9maWxlcyhzZWxmKToKKyAgICAgICAgaWYg bm90IHNlbGYuX3Rlc3RfcmVzdWx0c19zZXJ2ZXIgb3Igbm90IHNlbGYuX3Rlc3RfdHlwZToKKyAg ICAgICAgICAgIHJldHVybgorCisgICAgICAgIF9sb2cuaW5mbygiVXBsb2FkaW5nIEpTT04gZmls ZXMgZm9yICVzIHRvIHRoZSBzZXJ2ZXI6ICVzIiwKKyAgICAgICAgICAgICAgICAgICAgc2VsZi5f YnVpbGRlcl9uYW1lLCBzZWxmLl90ZXN0X3Jlc3VsdHNfc2VydmVyKQorICAgICAgICBhdHRycyA9 IFsoImJ1aWxkZXIiLCBzZWxmLl9idWlsZGVyX25hbWUpLCAoInRlc3R0eXBlIiwgc2VsZi5fdGVz dF90eXBlKV0KKyAgICAgICAganNvbl9maWxlcyA9IFsiaW5jcmVtZW50YWxfcmVzdWx0cy5qc29u Il0KKworICAgICAgICBmaWxlcyA9IFsoZmlsZSwgb3MucGF0aC5qb2luKHNlbGYuX3Jlc3VsdHNf ZGlyZWN0b3J5LCBmaWxlKSkKKyAgICAgICAgICAgIGZvciBmaWxlIGluIGpzb25fZmlsZXNdCisg ICAgICAgIHVwbG9hZGVyID0gdGVzdF9yZXN1bHRzX3VwbG9hZGVyLlRlc3RSZXN1bHRzVXBsb2Fk ZXIoCisgICAgICAgICAgICBzZWxmLl90ZXN0X3Jlc3VsdHNfc2VydmVyKQorICAgICAgICB0cnk6 CisgICAgICAgICAgICAjIFNldCB1cGxvYWRpbmcgdGltZW91dCBpbiBjYXNlIGFwcGVuZ2luZSBz ZXJ2ZXIgaXMgaGF2aW5nIHByb2JsZW0uCisgICAgICAgICAgICAjIDEyMCBzZWNvbmRzIGFyZSBt b3JlIHRoYW4gZW5vdWdoIHRvIHVwbG9hZCB0ZXN0IHJlc3VsdHMuCisgICAgICAgICAgICB1cGxv YWRlci51cGxvYWQoYXR0cnMsIGZpbGVzLCAxMjApCisgICAgICAgIGV4Y2VwdCBFeGNlcHRpb24s IGVycjoKKyAgICAgICAgICAgIF9sb2cuZXJyb3IoIlVwbG9hZCBmYWlsZWQ6ICVzIiAlIGVycikK KyAgICAgICAgICAgIHJldHVybgorCisgICAgICAgIF9sb2cuaW5mbygiSlNPTiBmaWxlcyB1cGxv YWRlZC4iKQorCiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIHBvcnQsIGJ1aWxkZXJfbmFtZSwgYnVp bGRfbmFtZSwgYnVpbGRfbnVtYmVyLAogICAgICAgICByZXN1bHRzX2ZpbGVfYmFzZV9wYXRoLCBi dWlsZGVyX2Jhc2VfdXJsLAotICAgICAgICB0ZXN0X3RpbWluZ3MsIGZhaWx1cmVzLCBwYXNzZWRf dGVzdHMsIHNraXBwZWRfdGVzdHMsIGFsbF90ZXN0cyk6CisgICAgICAgIHRlc3RfdGltaW5ncywg ZmFpbHVyZXMsIHBhc3NlZF90ZXN0cywgc2tpcHBlZF90ZXN0cywgYWxsX3Rlc3RzLAorICAgICAg ICB0ZXN0X3Jlc3VsdHNfc2VydmVyPU5vbmUsIHRlc3RfdHlwZT1Ob25lKToKICAgICAgICAgIiIi R2VuZXJhdGVzIGEgSlNPTiByZXN1bHRzIGZpbGUuCiAKICAgICAgICAgQXJncwpAQCAtNTM2LDgg KzU2NiwxMyBAQCBjbGFzcyBKU09OUmVzdWx0c0dlbmVyYXRvcihKU09OUmVzdWx0c0dlbmVyYXRv ckJhc2UpOgogICAgICAgICAgIHNraXBwZWRfdGVzdHM6IEEgc2V0IGNvbnRhaW5pbmcgYWxsIHRo ZSBza2lwcGVkIHRlc3RzLgogICAgICAgICAgIGFsbF90ZXN0czogTGlzdCBvZiBhbGwgdGhlIHRl c3RzIHRoYXQgd2VyZSBydW4uICBUaGlzIHNob3VsZCBub3QKICAgICAgICAgICAgICAgaW5jbHVk ZSBza2lwcGVkIHRlc3RzLgorICAgICAgICAgIHRlc3RfcmVzdWx0c19zZXJ2ZXI6IHNlcnZlciB0 aGF0IGhvc3RzIHRlc3QgcmVzdWx0cyBqc29uLgorICAgICAgICAgIHRlc3RfdHlwZTogdGhlIHRl c3QgdHlwZS4KICAgICAgICAgIiIiCiAKKyAgICAgICAgc2VsZi5fdGVzdF90eXBlID0gdGVzdF90 eXBlCisgICAgICAgIHNlbGYuX3Jlc3VsdHNfZGlyZWN0b3J5ID0gcmVzdWx0c19maWxlX2Jhc2Vf cGF0aAorCiAgICAgICAgICMgQ3JlYXRlIGEgbWFwIG9mIChuYW1lLCBUZXN0UmVzdWx0KS4KICAg ICAgICAgdGVzdF9yZXN1bHRzX21hcCA9IGRpY3QoKQogICAgICAgICBnZXQgPSB0ZXN0X3Jlc3Vs dHNfbWFwLmdldApAQCAtNTU3LDEwICs1OTIsMTYgQEAgY2xhc3MgSlNPTlJlc3VsdHNHZW5lcmF0 b3IoSlNPTlJlc3VsdHNHZW5lcmF0b3JCYXNlKToKICAgICAgICAgICAgIGlmIHRlc3Qgbm90IGlu IHRlc3RfcmVzdWx0c19tYXA6CiAgICAgICAgICAgICAgICAgdGVzdF9yZXN1bHRzX21hcFt0ZXN0 XSA9IFRlc3RSZXN1bHQodGVzdCkKIAorICAgICAgICAjIEdlbmVyYXRlIHRoZSBKU09OIHdpdGgg aW5jcmVtZW50YSBmbGFnIGVuYWJsZWQuCisgICAgICAgICMgKFRoaXMgc2hvdWxkIGFsc28gb3V0 cHV0IHRoZSBmdWxsIHJlc3VsdCBmb3Igbm93LikKICAgICAgICAgc3VwZXIoSlNPTlJlc3VsdHNH ZW5lcmF0b3IsIHNlbGYpLl9faW5pdF9fKAogICAgICAgICAgICAgYnVpbGRlcl9uYW1lLCBidWls ZF9uYW1lLCBidWlsZF9udW1iZXIsCiAgICAgICAgICAgICByZXN1bHRzX2ZpbGVfYmFzZV9wYXRo LCBidWlsZGVyX2Jhc2VfdXJsLCB0ZXN0X3Jlc3VsdHNfbWFwLAotICAgICAgICAgICAgc3ZuX3Jl cG9zaXRvcmllcz1wb3J0LnRlc3RfcmVwb3NpdG9yeV9wYXRocygpKQorICAgICAgICAgICAgc3Zu X3JlcG9zaXRvcmllcz1wb3J0LnRlc3RfcmVwb3NpdG9yeV9wYXRocygpLAorICAgICAgICAgICAg Z2VuZXJhdGVfaW5jcmVtZW50YWxfcmVzdWx0cz1UcnVlLAorICAgICAgICAgICAgdGVzdF9yZXN1 bHRzX3NlcnZlcj10ZXN0X3Jlc3VsdHNfc2VydmVyLAorICAgICAgICAgICAgdGVzdF90eXBlPXRl c3RfdHlwZSkKIAogICAgICAgICBpZiBzZWxmLl9fY2xhc3NfXy5vdXRwdXRfanNvbl9pbl9pbml0 OgogICAgICAgICAgICAgc2VsZi5nZW5lcmF0ZV9qc29uX291dHB1dCgpCisgICAgICAgICAgICBz ZWxmLl91cGxvYWRfanNvbl9maWxlcygpCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9UZXN0UmVz dWx0U2VydmVyL21vZGVsL2pzb25yZXN1bHRzLnB5IGIvV2ViS2l0VG9vbHMvVGVzdFJlc3VsdFNl cnZlci9tb2RlbC9qc29ucmVzdWx0cy5weQppbmRleCBlNWViN2Y3OTM4NGZlNWUxODc5MTAyNTNl NTdhMDJkZDJjODgyZmEyLi40NTIwZTk2NzU2M2U3NjJjNDFiMmM4YWE0ZTU5YTJmMjJhNTU0Y2Vj IDEwMDc1NQotLS0gYS9XZWJLaXRUb29scy9UZXN0UmVzdWx0U2VydmVyL21vZGVsL2pzb25yZXN1 bHRzLnB5CisrKyBiL1dlYktpdFRvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvbW9kZWwvanNvbnJlc3Vs dHMucHkKQEAgLTQxMyw2ICs0MTMsNyBAQCBjbGFzcyBKc29uUmVzdWx0cyhvYmplY3QpOgogICAg ICAgICAgICAgIyBVc2UgdGhlIGluY3JlbWVudGFsIGRhdGEgaWYgdGhlcmUgaXMgbm8gYWdncmVn YXRlZCBmaWxlIHRvIG1lcmdlLgogICAgICAgICAgICAgZmlsZSA9IFRlc3RGaWxlKCkKICAgICAg ICAgICAgIGZpbGUuYnVpbGRlciA9IGJ1aWxkZXIKKyAgICAgICAgICAgIGZpbGUudGVzdF90eXBl ID0gdGVzdF90eXBlCiAgICAgICAgICAgICBmaWxlLm5hbWUgPSBKU09OX1JFU1VMVFNfRklMRQog ICAgICAgICAgICAgbmV3X3Jlc3VsdHMgPSBpbmNyZW1lbnRhbAogICAgICAgICAgICAgbG9nZ2lu Zy5pbmZvKCJObyBleGlzdGluZyBqc29uIHJlc3VsdHMsIGluY3JlbWVudGFsIGpzb24gaXMgc2F2 ZWQuIikK