45314 2010-09-07 11:44:37 -0700 Remove some unnecessary duplicate calls to string functions 2010-09-08 13:58:15 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 45240 1 robert webkit-unassigned commit-queue oldest_to_newest 275193 0 robert 2010-09-07 11:44:37 -0700 Replace calls of the sort : StringImpl::create(buffer.toUtf8().constData(), buffer.toUtf8().length()) with QByteArray ba = buffer.toUtf8(); return StringImpl::create(ba.constData(), ba.length()); 275196 1 66747 robert 2010-09-07 11:48:13 -0700 Created attachment 66747 Patch 275197 2 66747 tonikitoo 2010-09-07 11:51:37 -0700 Comment on attachment 66747 Patch ba? :) 276043 3 66747 commit-queue 2010-09-08 13:58:09 -0700 Comment on attachment 66747 Patch Clearing flags on attachment: 66747 Committed r67012: <http://trac.webkit.org/changeset/67012> 276044 4 commit-queue 2010-09-08 13:58:15 -0700 All reviewed patches have been landed. Closing bug. 66747 2010-09-07 11:48:13 -0700 2010-09-08 13:58:09 -0700 Patch bug-45314-20100907194811.patch text/plain 3463 robert ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBhN2E1MjQxZDkzODVhYjQ0NDY0ZmUzYWJhZWQ1NTNmMTNkMzUzNTkxLi4y NjczODJmYTA4OTU2M2Q0MWY4NWVjOWRiNmM0OTU4ZGNmNjRhNDJkIDEwMDY0NAotLS0gYS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTAtMDktMDcgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92 ZSBzb21lIHVubmVjZXNzYXJ5IGR1cGxpY2F0ZSBjYWxscyB0byBzdHJpbmcgZnVuY3Rpb25zCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1MzE0CisK KyAgICAgICAgKiB3dGYvdGV4dC9XVEZTdHJpbmcuY3BwOgorICAgICAgICAoV1RGOjpTdHJpbmc6 OmZvcm1hdCk6CisKIDIwMTAtMDktMDcgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9KYXZh U2NyaXB0Q29yZS93dGYvdGV4dC9XVEZTdHJpbmcuY3BwIGIvSmF2YVNjcmlwdENvcmUvd3RmL3Rl eHQvV1RGU3RyaW5nLmNwcAppbmRleCA4NTNlMWI1OWIxZDQyMGI5NWYyMWU0OGVmMjY1YTMxNTU5 YzllMzY2Li45YjUzZTgxY2NkMjA0NTg2YzU0YzJmMWQ0NTE2MzVlMTZlMzdiNzNmIDEwMDY0NAot LS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9XVEZTdHJpbmcuY3BwCisrKyBiL0phdmFTY3Jp cHRDb3JlL3d0Zi90ZXh0L1dURlN0cmluZy5jcHAKQEAgLTMzNSw3ICszMzUsOCBAQCBTdHJpbmcg U3RyaW5nOjpmb3JtYXQoY29uc3QgY2hhciAqZm9ybWF0LCAuLi4pCiAKICAgICB2YV9lbmQoYXJn cyk7CiAKLSAgICByZXR1cm4gU3RyaW5nSW1wbDo6Y3JlYXRlKGJ1ZmZlci50b1V0ZjgoKS5jb25z dERhdGEoKSwgYnVmZmVyLnRvVXRmOCgpLmxlbmd0aCgpKTsKKyAgICBRQnl0ZUFycmF5IGJhID0g YnVmZmVyLnRvVXRmOCgpOworICAgIHJldHVybiBTdHJpbmdJbXBsOjpjcmVhdGUoYmEuY29uc3RE YXRhKCksIGJhLmxlbmd0aCgpKTsKIAogI2VsaWYgT1MoV0lOQ0UpCiAgICAgdmFfbGlzdCBhcmdz OwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCA3N2UzYWE0ODk0ZjlmOGJiMmMxODUyNGJiZmNkYWNmNWVlNWFjZjQ2Li40NWRmZjEyMTkyZTQ5 MDQ0YWYxZDI1NjlmYTFiY2ViODk4NTk4YjdjIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTA5LTA3ICBS b2JlcnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgc29tZSB1bm5lY2Vzc2FyeSBkdXBsaWNh dGUgY2FsbHMgdG8gc3RyaW5nIGZ1bmN0aW9ucworCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTMxNAorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29y ay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpwYXJz ZURhdGFVcmwpOgorICAgICAgICAqIHdlYnNvY2tldHMvV2ViU29ja2V0Q2hhbm5lbC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpXZWJTb2NrZXRDaGFubmVsOjpzZW5kKToKKwogMjAxMC0wOS0wNyAg RGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIHJvbGxpbmcgb3V0IHI2Njg4Ni4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAgYi9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCmluZGV4IGJhNjgzNTE1M2Y4 MzZiZTBlMTRhYzU1N2M0YWQ5Y2FiZTU1MzJjMWYuLjhkMmExYmZlZmQwZDA2ZTVjOTY5MzE4ZWFk NTk0NzIyMjdiYzE5YTMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJs L1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcApAQCAtNjEyLDcgKzYxMiw4IEBAIHN0YXRp YyB2b2lkIHBhcnNlRGF0YVVybChSZXNvdXJjZUhhbmRsZSogaGFuZGxlKQogCiAgICAgICAgIC8v IFdlYkNvcmUncyBkZWNvZGVyIGZhaWxzIG9uIEFjaWQzIHRlc3QgOTcgKHdoaXRlc3BhY2UpLgog ICAgICAgICBWZWN0b3I8Y2hhcj4gb3V0OwotICAgICAgICBpZiAoYmFzZTY0RGVjb2RlKGRhdGEu bGF0aW4xKCkuZGF0YSgpLCBkYXRhLmxhdGluMSgpLmxlbmd0aCgpLCBvdXQpICYmIG91dC5zaXpl KCkgPiAwKQorICAgICAgICBDU3RyaW5nIGxhdGluMSA9IGRhdGEubGF0aW4xKCk7CisgICAgICAg IGlmIChiYXNlNjREZWNvZGUobGF0aW4xLmRhdGEoKSwgbGF0aW4xLmxlbmd0aCgpLCBvdXQpICYm IG91dC5zaXplKCkgPiAwKQogICAgICAgICAgICAgY2xpZW50LT5kaWRSZWNlaXZlRGF0YShoYW5k bGUsIG91dC5kYXRhKCksIG91dC5zaXplKCksIDApOwogICAgIH0gZWxzZSB7CiAgICAgICAgIC8v IFdlIGhhdmUgdG8gY29udmVydCB0byBVVEYtMTYgZWFybHkgZHVlIHRvIGxpbWl0YXRpb25zIGlu IEtVUkwKZGlmZiAtLWdpdCBhL1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXRDaGFubmVsLmNw cCBiL1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXRDaGFubmVsLmNwcAppbmRleCA1NGJlMTZh NDk1YmUxYThjMzIyNGNhMzYzZDYyN2RjZjNkYzBjYzkyLi5hMDkyMjRkYTY1YTRkZWRiYTJmMTI5 YzI0Yjg0MmQxMWZjMWRiOTdhIDEwMDY0NAotLS0gYS9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29j a2V0Q2hhbm5lbC5jcHAKKysrIGIvV2ViQ29yZS93ZWJzb2NrZXRzL1dlYlNvY2tldENoYW5uZWwu Y3BwCkBAIC04OCw3ICs4OCw4IEBAIGJvb2wgV2ViU29ja2V0Q2hhbm5lbDo6c2VuZChjb25zdCBT dHJpbmcmIG1zZykKICAgICBBU1NFUlQoIW1fc3VzcGVuZGVkKTsKICAgICBWZWN0b3I8Y2hhcj4g YnVmOwogICAgIGJ1Zi5hcHBlbmQoJ1wwJyk7ICAvLyBmcmFtZSB0eXBlCi0gICAgYnVmLmFwcGVu ZChtc2cudXRmOCgpLmRhdGEoKSwgbXNnLnV0ZjgoKS5sZW5ndGgoKSk7CisgICAgQ1N0cmluZyB1 dGY4ID0gbXNnLnV0ZjgoKTsKKyAgICBidWYuYXBwZW5kKHV0ZjguZGF0YSgpLCB1dGY4Lmxlbmd0 aCgpKTsKICAgICBidWYuYXBwZW5kKCdceGZmJyk7ICAvLyBmcmFtZSBlbmQKICAgICByZXR1cm4g bV9oYW5kbGUtPnNlbmQoYnVmLmRhdGEoKSwgYnVmLnNpemUoKSk7CiB9Cg==