45301 2010-09-07 09:16:26 -0700 Fix increases required alignment of target type warnings on ARM 2010-10-13 08:51:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other Linux RESOLVED FIXED P3 Minor --- 43191 1 ossy loki commit-queue loki yong.li.webkit oldest_to_newest 275075 0 ossy 2010-09-07 09:16:26 -0700 ../../../WebCore/bindings/js/SerializedScriptValue.cpp:871: warning: cast from 'const uint8_t*' to 'const UChar*' increases required alignment of target type ../../../WebCore/bindings/js/SerializedScriptValue.cpp:783: warning: cast from 'const uint8_t*' to 'const uint32_t*' increases required alignment of target type ../../../WebCore/bindings/js/SerializedScriptValue.cpp:783: warning: cast from 'const uint8_t*' to 'const short unsigned int*' increases required alignment of target type ../../../WebCore/bindings/js/SerializedScriptValue.cpp:783: warning: cast from 'const uint8_t*' to 'const long long unsigned int*' increases required alignment of target type ../../../WebCore/plugins/PluginDatabase.cpp:510: warning: cast from 'char*' to 'time_t*' increases required alignment of target type SerializedScriptValue.cpp: --------------------------- static bool readString(const uint8_t*& ptr, const uint8_t* end, UString& str, unsigned length) { ... str = UString(reinterpret_cast<const UChar*>(ptr), length); // <-- line 871 ... } template <typename T> static bool readLittleEndian(const uint8_t*& ptr, const uint8_t* end, T& value) { ... value = *reinterpret_cast<const T*>(ptr); // <-- line 783 ... } PluginDatabase.cpp: -------------------- static bool readTime(time_t& resultTime, char*& start, const char* end) { ... resultTime = *reinterpret_cast<time_t*>(start); // <-- line 510 ... } 275696 1 66860 loki 2010-09-08 02:19:56 -0700 Created attachment 66860 Fix increases required alignment of target type warning on ARM 275885 2 66860 kling 2010-09-08 09:34:20 -0700 Comment on attachment 66860 Fix increases required alignment of target type warning on ARM LGTM 276125 3 66860 commit-queue 2010-09-08 15:44:01 -0700 Comment on attachment 66860 Fix increases required alignment of target type warning on ARM Clearing flags on attachment: 66860 Committed r67028: <http://trac.webkit.org/changeset/67028> 276126 4 commit-queue 2010-09-08 15:44:05 -0700 All reviewed patches have been landed. Closing bug. 293444 5 yong.li.webkit 2010-10-13 08:51:01 -0700 Removing the warning doesn't fix the real problem: data in the buffer is not guaranteed to be aligned, so it can cause misaligned memory access on ARM (<v6). Bug 47594 is created for this 66860 2010-09-08 02:19:56 -0700 2010-09-08 15:44:00 -0700 Fix increases required alignment of target type warning on ARM 0001-Fix-increases-required-alignment-of-target-type-warn.patch text/plain 2581 loki RnJvbSAzZDllYjQ3N2RmNzA0NWE2NmQ1MGVlNmI5ODZiNmNhZTgwNDIzZTMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHYWJvciBMb2tpIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KRGF0 ZTogV2VkLCA4IFNlcCAyMDEwIDExOjE4OjM1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gRml4IGlu Y3JlYXNlcyByZXF1aXJlZCBhbGlnbm1lbnQgb2YgdGFyZ2V0IHR5cGUgd2FybmluZyBvbiBBUk0K ClNpZ25lZC1vZmYtYnk6IEdhYm9yIExva2kgPGxva2lAaW5mLnUtc3plZ2VkLmh1PgotLS0KIFdl YkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTUgKysrKysr KysrKysrKysrCiBXZWJDb3JlL2JpbmRpbmdzL2pzL1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAg fCAgICA0ICsrLS0KIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5EYXRhYmFzZS5jcHAgICAgICAgICAg ICB8ICAgIDIgKy0KIDMgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9n CmluZGV4IGM2N2IxZjkuLjNjZWM4ZDIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisr KyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDktMDggIEdhYm9y IExva2kgIDxsb2tpQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRml4IGluY3JlYXNlcyByZXF1aXJlZCBhbGlnbm1lbnQgb2YgdGFy Z2V0IHR5cGUgd2FybmluZyBvbiBBUk0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQ1MzAxCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKwor ICAgICAgICAqIGJpbmRpbmdzL2pzL1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpDbG9uZURlc2VyaWFsaXplcjo6cmVhZExpdHRsZUVuZGlhbik6CisgICAgICAg IChXZWJDb3JlOjpDbG9uZURlc2VyaWFsaXplcjo6cmVhZFN0cmluZyk6CisgICAgICAgICogcGx1 Z2lucy9QbHVnaW5EYXRhYmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyZWFkVGltZSk6CisK IDIwMTAtMDktMDggIFpvbHRhbiBIZXJjemVnICA8emhlcmN6ZWdAd2Via2l0Lm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBEaXJrIFNjaHVsemUuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRp bmdzL2pzL1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL2pzL1Nl cmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAKaW5kZXggZjIyOTA4OC4uZmNkMzMxNCAxMDA2NDQKLS0t IGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9TZXJpYWxpemVkU2NyaXB0VmFsdWUuY3BwCisrKyBiL1dl YkNvcmUvYmluZGluZ3MvanMvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcApAQCAtODAwLDcgKzgw MCw3IEBAIHByaXZhdGU6CiAgICAgICAgIGlmIChzaXplb2YoVCkgPT0gMSkKICAgICAgICAgICAg IHZhbHVlID0gKnB0cisrOwogICAgICAgICBlbHNlIHsKLSAgICAgICAgICAgIHZhbHVlID0gKnJl aW50ZXJwcmV0X2Nhc3Q8Y29uc3QgVCo+KHB0cik7CisgICAgICAgICAgICB2YWx1ZSA9ICpyZWlu dGVycHJldF9jYXN0X3B0cjxjb25zdCBUKj4ocHRyKTsKICAgICAgICAgICAgIHB0ciArPSBzaXpl b2YoVCk7CiAgICAgICAgIH0KICAgICAgICAgcmV0dXJuIHRydWU7CkBAIC04ODgsNyArODg4LDcg QEAgcHJpdmF0ZToKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIAogI2lmIEFTU1VNRV9MSVRU TEVfRU5ESUFOCi0gICAgICAgIHN0ciA9IFVTdHJpbmcocmVpbnRlcnByZXRfY2FzdDxjb25zdCBV Q2hhcio+KHB0ciksIGxlbmd0aCk7CisgICAgICAgIHN0ciA9IFVTdHJpbmcocmVpbnRlcnByZXRf Y2FzdF9wdHI8Y29uc3QgVUNoYXIqPihwdHIpLCBsZW5ndGgpOwogICAgICAgICBwdHIgKz0gbGVu Z3RoICogc2l6ZW9mKFVDaGFyKTsKICNlbHNlCiAgICAgICAgIFZlY3RvcjxVQ2hhcj4gYnVmZmVy OwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVnaW5zL1BsdWdpbkRhdGFiYXNlLmNwcCBiL1dlYkNv cmUvcGx1Z2lucy9QbHVnaW5EYXRhYmFzZS5jcHAKaW5kZXggNDZjN2RmNy4uZDNlOTIyYSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9wbHVnaW5zL1BsdWdpbkRhdGFiYXNlLmNwcAorKysgYi9XZWJDb3Jl L3BsdWdpbnMvUGx1Z2luRGF0YWJhc2UuY3BwCkBAIC01MDcsNyArNTA3LDcgQEAgc3RhdGljIGJv b2wgcmVhZFRpbWUodGltZV90JiByZXN1bHRUaW1lLCBjaGFyKiYgc3RhcnQsIGNvbnN0IGNoYXIq IGVuZCkKICAgICBpZiAoc3RhcnQgKyBzaXplb2YodGltZV90KSA+PSBlbmQpCiAgICAgICAgIHJl dHVybiBmYWxzZTsKIAotICAgIHJlc3VsdFRpbWUgPSAqcmVpbnRlcnByZXRfY2FzdDx0aW1lX3Qq PihzdGFydCk7CisgICAgcmVzdWx0VGltZSA9ICpyZWludGVycHJldF9jYXN0X3B0cjx0aW1lX3Qq PihzdGFydCk7CiAgICAgc3RhcnQgKz0gc2l6ZW9mKHRpbWVfdCk7CiAKICAgICByZXR1cm4gdHJ1 ZTsKLS0gCjEuNy4wLjQKCg==