45287 2010-09-07 03:39:41 -0700 [chromium] Leak in RenderViewTest::SimulateElementClick() 2010-09-10 04:37:11 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 hbono webkit-unassigned commit-queue darin jcivelli oldest_to_newest 274948 0 hbono 2010-09-07 03:39:41 -0700 (Copied from <http://crbug.com/54654>). From: http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20(valgrind)(1)/builds/5806/steps/memory%20test:%20unit/logs/stdio 22:45:43 memcheck_analyze.py [ERROR] Command: src/sconsbuild/Release/unit_tests --gtest_filter=-RenderViewTest.FLAKY_OnHandleKeyboardEvent:VisitedLinkEventsTest.Coalescense:PredictorTest.FLAKY_MassiveConcurrentLookupTest:VisitedLinkEventsTest.FAILS_Coalescense:PredictorTest.MassiveConcurrentLookupTest:RenderViewTest.FAILS_OnHandleKeyboardEvent:RenderViewTest.FAILS_ImeComposition:VisitedLinkRelayTest.FAILS_Basics:VisitedLinkRelayTest.FLAKY_Basics:PredictorTest.FAILS_MassiveConcurrentLookupTest:ConnectionTesterTest.RunAllTests:VisitedLinkRelayTest.Basics:ConnectionTesterTest.FLAKY_RunAllTests:VisitedLinkEventsTest.FLAKY_Coalescense:ConnectionTesterTest.FAILS_RunAllTests:RenderViewTest.FLAKY_ImeComposition:URLFetcherBadHTTPSTest.FAILS_BadHTTPSTest:RenderViewTest.OnHandleKeyboardEvent:URLFetcherBadHTTPSTest.FLAKY_BadHTTPSTest:RenderViewTest.ImeComposition:URLFetcherBadHTTPSTest.BadHTTPSTest --gtest_print_time Leak_DefinitelyLost 120 bytes in 1 blocks are definitely lost in loss record 43,384 of 46,252 malloc (sr/local/google/valgrind-for-chromium-client/valgrind/scripts/valgrind-memcheck/coregrind/m_replacemalloc/vg_replace_malloc.c:241) WTF::fastMalloc(unsigned int) (uilder/build/src/third_party/WebKit/JavaScriptCore/wtf/FastMalloc.cpp:250) WTF::FastAllocBase::operator new(unsigned int) (uilder/build/src/third_party/WebKit/JavaScriptCore/wtf/FastAllocBase.h:96) WebCore::MouseEvent::create(WTF::AtomicString const&, bool, bool, WTF::PassRefPtr<WebCore::DOMWindow>, int, int, int, int, int, bool, bool, bool, bool, unsigned short, WTF::PassRefPtr<WebCore::EventTarget>, WTF::PassRefPtr<WebCore::Clipboard>, bool) (uilder/build/src/third_party/WebKit/WebCore/dom/MouseEvent.h:45) WebCore::Node::dispatchMouseEvent(WTF::AtomicString const&, int, int, int, int, int, int, bool, bool, bool, bool, bool, WebCore::Node*, WTF::PassRefPtr<WebCore::Event>) (uilder/build/src/third_party/WebKit/WebCore/dom/Node.cpp:2881) WebCore::Node::dispatchMouseEvent(WebCore::PlatformMouseEvent const&, WTF::AtomicString const&, int, WebCore::Node*) (uilder/build/src/third_party/WebKit/WebCore/dom/Node.cpp:2794) WebCore::EventHandler::dispatchMouseEvent(WTF::AtomicString const&, WebCore::Node*, bool, int, WebCore::PlatformMouseEvent const&, bool) (uilder/build/src/third_party/WebKit/WebCore/page/EventHandler.cpp:1849) WebCore::EventHandler::handleMousePressEvent(WebCore::PlatformMouseEvent const&) (uilder/build/src/third_party/WebKit/WebCore/page/EventHandler.cpp:1309) WebKit::WebViewImpl::mouseDown(WebKit::WebMouseEvent const&) (uilder/build/src/third_party/WebKit/WebKit/chromium/src/WebViewImpl.cpp:402) WebKit::WebViewImpl::handleInputEvent(WebKit::WebInputEvent const&) (uilder/build/src/third_party/WebKit/WebKit/chromium/src/WebViewImpl.cpp:1050) RenderWidget::OnHandleInputEvent(IPC::Message const&) (uilder/build/src/chrome/renderer/render_widget.cc:345) RenderViewTest::SimulateElementClick(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (uilder/build/src/chrome/test/render_view_test.cc:328) RenderViewTest_PageClickTracker_Test::TestBody() (uilder/build/src/chrome/renderer/page_click_tracker_unittest.cc:70) testing::Test::Run() (uilder/build/src/testing/gtest/src/gtest.cc:2095) Suppression (error hash=#FFFFFFFFF0F8F49A#): { <insert_a_suppression_name_here> Memcheck:Leak fun:malloc fun:_ZN3WTF10fastMallocEj fun:_ZN3WTF13FastAllocBasenwEj fun:_ZN7WebCore10MouseEvent6createERKN3WTF12AtomicStringEbbNS1_10PassRefPtrINS_9DOMWindowEEEiiiiibbbbtNS5_INS_11EventTargetEEENS5_INS_9ClipboardEEEb fun:_ZN7WebCore4Node18dispatchMouseEventERKN3WTF12AtomicStringEiiiiiibbbbbPS0_NS1_10PassRefPtrINS_5EventEEE fun:_ZN7WebCore4Node18dispatchMouseEventERKNS_18PlatformMouseEventERKN3WTF12AtomicStringEiPS0_ fun:_ZN7WebCore12EventHandler18dispatchMouseEventERKN3WTF12AtomicStringEPNS_4NodeEbiRKNS_18PlatformMouseEventEb fun:_ZN7WebCore12EventHandler21handleMousePressEventERKNS_18PlatformMouseEventE fun:_ZN6WebKit11WebViewImpl9mouseDownERKNS_13WebMouseEventE fun:_ZN6WebKit11WebViewImpl16handleInputEventERKNS_13WebInputEventE fun:_ZN12RenderWidget18OnHandleInputEventERKN3IPC7MessageE fun:_ZN14RenderViewTest20SimulateElementClickERKSs fun:_ZN36RenderViewTest_PageClickTracker_Test8TestBodyEv } It seems Chromium change r58597 <http://crrev.com/58597> unveils a leak in WebKit. It seems WebDOMEvent::assign() increases the reference count of a MouseEvent object without decreasing it. So, we cannot delete the MouseEvent object. 274949 1 66701 hbono 2010-09-07 03:44:38 -0700 Created attachment 66701 A quick fix Even though I'm not sure if this is a good fix, I would like to post it for your information. Regards, Hironori Bono 275396 2 66787 jcivelli 2010-09-07 16:46:29 -0700 Created attachment 66787 Shorter patch 275397 3 jcivelli 2010-09-07 16:47:42 -0700 @Hironori Thanks for looking at this! I uploaded a shorter patch inspired on WebNode. Let me know what you think. Thanks. Jay 275560 4 hbono 2010-09-07 19:48:21 -0700 (In reply to comment #3) > @Hironori > Thanks for looking at this! > I uploaded a shorter patch inspired on WebNode. > Let me know what you think. Thank you for your quick work. I think it's better than mine. (I forgot making the destructor to a virtual function.) Regards, Hironori Bono 276327 5 66787 fishd 2010-09-08 23:30:25 -0700 Comment on attachment 66787 Shorter patch View in context: https://bugs.webkit.org/attachment.cgi?id=66787&action=prettypatch > WebKit/chromium/public/WebDOMEvent.h:55 > + virtual ~WebDOMEvent() { reset(); } nit: please list the destructor first w/ a new line between it and WebDOMEvent (as is done in WebNode.h). I'm also not sure why this destructor needs to be virtual. This adds a virtual table to this class. I notice that WebNode also has a virtual destructor, but I can't figure out why it should need one either. R=me, but please consider making the above changes before committing. 276583 6 67061 jcivelli 2010-09-09 10:57:39 -0700 Created attachment 67061 Patch for landing 277116 7 67061 commit-queue 2010-09-10 04:37:06 -0700 Comment on attachment 67061 Patch for landing Clearing flags on attachment: 67061 Committed r67188: <http://trac.webkit.org/changeset/67188> 277117 8 commit-queue 2010-09-10 04:37:11 -0700 All reviewed patches have been landed. Closing bug. 66701 2010-09-07 03:44:38 -0700 2010-09-07 19:48:44 -0700 A quick fix issue45287-patch0.txt text/plain 1447 hbono SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjY4NzQpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDktMDcgIEhpcm9u b3JpIEJvbm8gIDxoYm9ub0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHRoZSBkZXN0cnVjdG9yIHRvIFdlYkRPTUV2ZW50 IHRvIHByZXZlbnQgYSBsZWFrLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDUyODcKKworICAgICAgICAqIHB1YmxpYy9XZWJET01FdmVudC5oOgorICAg ICAgICAqIHNyYy9XZWJET01FdmVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkRPTUV2ZW50 Ojp+V2ViRE9NRXZlbnQpOgorCiAyMDEwLTA5LTA2ICBKb25hdGhhbiBEaXhvbiAgPGpvdGhAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxvdy4KSW5kZXg6IFdl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRE9NRXZlbnQuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkRPTUV2ZW50LmgJKHJldmlzaW9uIDY2ODA2KQorKysgV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJET01FdmVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC01OCw2ICs1 OCw4IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuICp0aGlzOwogICAgIH0KIAorICAgIH5XZWJE T01FdmVudCgpOworCiAgICAgV0VCS0lUX0FQSSB2b2lkIHJlc2V0KCk7CiAgICAgV0VCS0lUX0FQ SSB2b2lkIGFzc2lnbihjb25zdCBXZWJET01FdmVudCYpOwogCkluZGV4OiBXZWJLaXQvY2hyb21p dW0vc3JjL1dlYkRPTUV2ZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3Jj L1dlYkRPTUV2ZW50LmNwcAkocmV2aXNpb24gNjY4MDYpCisrKyBXZWJLaXQvY2hyb21pdW0vc3Jj L1dlYkRPTUV2ZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjYsNiArNjYsMTIgQEAgV2ViRE9N RXZlbnQ6OldlYkRPTUV2ZW50KGNvbnN0IFdURjo6UGFzcwogewogfQogCitXZWJET01FdmVudDo6 fldlYkRPTUV2ZW50KCkKK3sKKyAgICBpZiAobV9wcml2YXRlKQorICAgICAgICBtX3ByaXZhdGUt PmRlcmVmKCk7Cit9CisKIFdlYlN0cmluZyBXZWJET01FdmVudDo6dHlwZSgpIGNvbnN0CiB7CiAg ICAgQVNTRVJUKG1fcHJpdmF0ZSk7Cg== 66787 2010-09-07 16:46:29 -0700 2010-09-09 10:57:25 -0700 Shorter patch webdomevent_leak.patch text/plain 1066 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA2NjkzMSkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wOS0wNyAgSmF5 IENpdmVsbGkgIDxqY2l2ZWxsaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHRoZSBkZXN0cnVjdG9yIHRvIFdlYkRPTUV2 ZW50IHRvIHByZXZlbnQgYSBsZWFrLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDUyODcKKworICAgICAgICAqIHB1YmxpYy9XZWJET01FdmVudC5oOgor ICAgICAgICAoV2ViS2l0OjpXZWJET01FdmVudDo6fldlYkRPTUV2ZW50KToKKwogMjAxMC0wOS0w NyAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhcmluIEZpc2hlci4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRE9NRXZlbnQu aA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRE9NRXZlbnQuaAko cmV2aXNpb24gNjY5MTEpCisrKyBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRPTUV2ZW50LmgJ KHdvcmtpbmcgY29weSkKQEAgLTUyLDYgKzUyLDcgQEAgcHVibGljOgogCiAgICAgV2ViRE9NRXZl bnQoKSA6IG1fcHJpdmF0ZSgwKSB7IH0KICAgICBXZWJET01FdmVudChjb25zdCBXZWJET01FdmVu dCYgZSkgOiBtX3ByaXZhdGUoMCkgeyBhc3NpZ24oZSk7IH0KKyAgICB2aXJ0dWFsIH5XZWJET01F dmVudCgpIHsgcmVzZXQoKTsgfQogICAgIFdlYkRPTUV2ZW50JiBvcGVyYXRvcj0oY29uc3QgV2Vi RE9NRXZlbnQmIGUpCiAgICAgewogICAgICAgICBhc3NpZ24oZSk7Cg== 67061 2010-09-09 10:57:39 -0700 2010-09-10 04:37:06 -0700 Patch for landing bug-45287-20100909105738.patch text/plain 1298 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjcwOTApCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDEwICsxLDE5IEBACisyMDEwLTA5LTA3ICBKYXkg Q2l2ZWxsaSAgPGpjaXZlbGxpQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBE YXJpbiBGaXNoZXIuCisKKyAgICAgICAgQWRkIHRoZSBkZXN0cnVjdG9yIHRvIFdlYkRPTUV2ZW50 IHRvIHByZXZlbnQgYSBsZWFrLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDUyODcKKworICAgICAgICAqIHB1YmxpYy9XZWJET01FdmVudC5oOgorICAg ICAgICAoV2ViS2l0OjpXZWJET01FdmVudDo6fldlYkRPTUV2ZW50KToKKwogMjAxMC0wOS0wOSAg Q2hyaXMgR3VpbGxvcnkgIDxjaHJpcy5ndWlsbG9yeUBnb29nbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IENocmlzIEZsZWl6YWNoLgogCiAgICAgICAgIEFkZCBtZXRob2RzIHVzZWQgdG8g ZGV0ZXJtaW5lIGFjY2Vzc2liaWxpdHkgc3RhdGUuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTQzNAotICAgICAgICAKIAogICAgICAgICAqIHB1Ymxp Yy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0Lmg6CiAgICAgICAgICogc3JjL1dlYkFjY2Vzc2liaWxp dHlPYmplY3QuY3BwOgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJET01FdmVudC5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRE9NRXZlbnQuaAkocmV2 aXNpb24gNjcwOTApCisrKyBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRPTUV2ZW50LmgJKHdv cmtpbmcgY29weSkKQEAgLTUwLDYgKzUwLDggQEAgcHVibGljOgogICAgICAgICBCdWJibGluZ1Bo YXNlICAgICAgPSAzCiAgICAgfTsKIAorICAgIH5XZWJET01FdmVudCgpIHsgcmVzZXQoKTsgfQor CiAgICAgV2ViRE9NRXZlbnQoKSA6IG1fcHJpdmF0ZSgwKSB7IH0KICAgICBXZWJET01FdmVudChj b25zdCBXZWJET01FdmVudCYgZSkgOiBtX3ByaXZhdGUoMCkgeyBhc3NpZ24oZSk7IH0KICAgICBX ZWJET01FdmVudCYgb3BlcmF0b3I9KGNvbnN0IFdlYkRPTUV2ZW50JiBlKQo=