45261 2010-09-06 06:10:14 -0700 [NRWT] Add temp directory to all running drivers 2010-09-08 05:15:45 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 rgabor webkit-unassigned abecsi cjerdonek commit-queue dbates dpranke eric ojan ossy oldest_to_newest 274578 0 rgabor 2010-09-06 06:10:14 -0700 NRWT doesn't give temp directory to DRT. See this bug for details: https://bugs.webkit.org/show_bug.cgi?id=36899 274580 1 66632 rgabor 2010-09-06 06:16:08 -0700 Created attachment 66632 proposed patch 274762 2 66632 eric 2010-09-06 13:23:10 -0700 Comment on attachment 66632 proposed patch OK. I assume this makes Qt's DRT work better when running multiple copies? I see the ORWT has similar code. 274785 3 ossy 2010-09-06 14:53:43 -0700 (In reply to comment #2) > (From update of attachment 66632 [details]) > OK. I assume this makes Qt's DRT work better when running multiple copies? I see the ORWT has similar code. Yes, you're right. It is important when we run multiple run-webkit-tests. If we didn't separate temp directories, the local storage and icon database could be damage because of concurent file accesses. This method works correctly for a long time with ORWT. 274865 4 66632 commit-queue 2010-09-07 00:30:55 -0700 Comment on attachment 66632 proposed patch Clearing flags on attachment: 66632 Committed r66863: <http://trac.webkit.org/changeset/66863> 274866 5 commit-queue 2010-09-07 00:31:01 -0700 All reviewed patches have been landed. Closing bug. 275340 6 dpranke 2010-09-07 15:28:46 -0700 Hmm. It's not great that we're doing this work in the constructor and destructor; I've found that can lead to indeterminate results in general (although it's fine in this case). There's actually a port.setup_test_run() method that would be the appropriate place to create the temp dir - it's called only when we're sure we actually want to start running tests, but before DumpRenderTree is ever launched. Unfortunately, there isn't a cleanup_test_run() method to match it. I'll add both of those and refactor this (in a separate bug/change), unless there's an objection ... 275765 7 rgabor 2010-09-08 05:15:45 -0700 (In reply to comment #6) > Hmm. It's not great that we're doing this work in the constructor and destructor; I've found that can lead to indeterminate results in general (although it's fine in this case). > > There's actually a port.setup_test_run() method that would be the appropriate place to create the temp dir - it's called only when we're sure we actually want to start running tests, but before DumpRenderTree is ever launched. Unfortunately, there isn't a cleanup_test_run() method to match it. > > I'll add both of those and refactor this (in a separate bug/change), unless there's an objection ... Ok, you're right. We don't know when the gc delete this temp directory, so maybe a better way is your idea. 66632 2010-09-06 06:16:08 -0700 2010-09-07 00:30:55 -0700 proposed patch drt_tmp.patch text/plain 1795 rgabor SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY2ODIwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDktMDYgIEdhYm9yIFJhcGNzYW55aSAg PHJnYWJvckBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW05SV1RdIEFkZCB0ZW1wIGRpcmVjdG9yeSB0byBhbGwgcnVubmlu ZyBkcml2ZXJzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDUyNjEKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv d2Via2l0LnB5OgorCiAyMDEwLTA5LTA1ICBQZXRlciBLYXN0aW5nICA8cGthc3RpbmdAZ29vZ2xl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHkKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJr aXQucHkJKHJldmlzaW9uIDY2ODIwKQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHkJKHdvcmtpbmcgY29weSkKQEAgLTQzLDYgKzQzLDgg QEAgaW1wb3J0IHN5cwogaW1wb3J0IHRpbWUKIGltcG9ydCB3ZWJicm93c2VyCiBpbXBvcnQgb3Bl cmF0b3IKK2ltcG9ydCB0ZW1wZmlsZQoraW1wb3J0IHNodXRpbAogCiBmcm9tIHdlYmtpdHB5LmNv bW1vbi5zeXN0ZW0uZXhlY3V0aXZlIGltcG9ydCBFeGVjdXRpdmUKIApAQCAtNDA0LDYgKzQwNiwx MCBAQCBjbGFzcyBXZWJLaXREcml2ZXIoYmFzZS5Ecml2ZXIpOgogICAgICAgICBzZWxmLl9wb3J0 ID0gcG9ydAogICAgICAgICAjIEZJWE1FOiBkcml2ZXJfb3B0aW9ucyBpcyBuZXZlciB1c2VkLgog ICAgICAgICBzZWxmLl9pbWFnZV9wYXRoID0gaW1hZ2VfcGF0aAorICAgICAgICBzZWxmLl9kcml2 ZXJfdGVtcGRpciA9IHRlbXBmaWxlLm1rZHRlbXAocHJlZml4PSdEdW1wUmVuZGVyVHJlZS0nKQor CisgICAgZGVmIF9fZGVsX18oc2VsZik6CisgICAgICAgIHNodXRpbC5ybXRyZWUoc2VsZi5fZHJp dmVyX3RlbXBkaXIpCiAKICAgICBkZWYgc3RhcnQoc2VsZik6CiAgICAgICAgIGNvbW1hbmQgPSBb XQpAQCAtNDE0LDYgKzQyMCw3IEBAIGNsYXNzIFdlYktpdERyaXZlcihiYXNlLkRyaXZlcik6CiAg ICAgICAgICAgICBjb21tYW5kLmFwcGVuZCgnLS1waXhlbC10ZXN0cycpCiAgICAgICAgIGVudmly b25tZW50ID0gc2VsZi5fcG9ydC5zZXR1cF9lbnZpcm9uX2Zvcl9zZXJ2ZXIoKQogICAgICAgICBl bnZpcm9ubWVudFsnRFlMRF9GUkFNRVdPUktfUEFUSCddID0gc2VsZi5fcG9ydC5fYnVpbGRfcGF0 aCgpCisgICAgICAgIGVudmlyb25tZW50WydEVU1QUkVOREVSVFJFRV9URU1QJ10gPSBzZWxmLl9k cml2ZXJfdGVtcGRpcgogICAgICAgICBzZWxmLl9zZXJ2ZXJfcHJvY2VzcyA9IHNlcnZlcl9wcm9j ZXNzLlNlcnZlclByb2Nlc3Moc2VsZi5fcG9ydCwKICAgICAgICAgICAgICJEdW1wUmVuZGVyVHJl ZSIsIGNvbW1hbmQsIGVudmlyb25tZW50KQogCg==