45257 2010-09-06 04:28:17 -0700 Add new API required for bug 45112 2010-09-06 10:10:28 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 joth joth bulach commit-queue jorlow steveblock webkit.review.bot oldest_to_newest 274547 0 joth 2010-09-06 04:28:17 -0700 Before the fix for https://bugs.webkit.org/show_bug.cgi?id=45112 can be landed, http://codereview.chromium.org/3338008/show must be landed on the chromium side. This in turn relies on the new WebGeolocationServiceBridge::onWebGeolocationServiceDestroyed() API existing on the webkit side -- this bug is for tracking that item. 274548 1 66623 joth 2010-09-06 04:30:49 -0700 Created attachment 66623 Add the API 274549 2 webkit.review.bot 2010-09-06 04:31:34 -0700 Attachment 66623 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/chromium/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 274550 3 66624 joth 2010-09-06 04:32:59 -0700 Created attachment 66624 Remove \t char 274554 4 66624 jorlow 2010-09-06 04:41:33 -0700 Comment on attachment 66624 Remove \t char r=me Joth please wait until Marcus has signed off on this though. 274569 5 bulach 2010-09-06 05:43:31 -0700 LGTM thanks joth and jeremy! (In reply to comment #4) > (From update of attachment 66624 [details]) > r=me > > Joth please wait until Marcus has signed off on this though. 274614 6 joth 2010-09-06 07:30:33 -0700 Thanks for the reviews. Could one of you commit queue it please? Cheers 274682 7 66624 commit-queue 2010-09-06 10:10:23 -0700 Comment on attachment 66624 Remove \t char Clearing flags on attachment: 66624 Committed r66837: <http://trac.webkit.org/changeset/66837> 274683 8 commit-queue 2010-09-06 10:10:28 -0700 All reviewed patches have been landed. Closing bug. 66623 2010-09-06 04:30:49 -0700 2010-09-06 04:32:59 -0700 Add the API bug45257.txt text/plain 2675 joth ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGJiNjI4OTMuLmRjZjhkMDQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDEwLTA5LTA2ICBKb25hdGhhbiBEaXhvbiAgPGpvdGhAY2hyb21pdW0ub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBuZXcg aW50ZXJmYWNlIGFuZCBlbXB0eSBpbXBsLiBhcyBwcmVjdXJzb3IgdG8gYnVnIDQ1MTEyCisJaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1MjU3CisKKyAgICAgICAgKiBw dWJsaWMvV2ViR2VvbG9jYXRpb25TZXJ2aWNlQnJpZGdlLmg6CisgICAgICAgIChXZWJLaXQ6Oldl Ykdlb2xvY2F0aW9uU2VydmljZUJyaWRnZTo6fldlYkdlb2xvY2F0aW9uU2VydmljZUJyaWRnZSk6 CisgICAgICAgICogc3JjL1dlYkdlb2xvY2F0aW9uU2VydmljZUJyaWRnZUltcGwuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJHZW9sb2NhdGlvblNlcnZpY2VCcmlkZ2VJbXBsOjpvbldlYkdlb2xv Y2F0aW9uU2VydmljZURlc3Ryb3llZCk6CisKIDIwMTAtMDktMDMgIEplc3VzIFNhbmNoZXotUGFs ZW5jaWEgIDxqZXN1cy5wYWxlbmNpYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJH ZW9sb2NhdGlvblNlcnZpY2VCcmlkZ2UuaCBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViR2Vv bG9jYXRpb25TZXJ2aWNlQnJpZGdlLmgKaW5kZXggOWYwZmZkNC4uNDIyYjMyYiAxMDA2NDQKLS0t IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJHZW9sb2NhdGlvblNlcnZpY2VCcmlkZ2UuaAor KysgYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkdlb2xvY2F0aW9uU2VydmljZUJyaWRnZS5o CkBAIC00Nyw2ICs0NywxMCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNldElzQWxsb3dl ZChib29sIGFsbG93ZWQpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0TGFzdFBvc2l0aW9uKGRv dWJsZSBsYXRpdHVkZSwgZG91YmxlIGxvbmdpdHVkZSwgYm9vbCBwcm92aWRlc0FsdGl0dWRlLCBk b3VibGUgYWx0aXR1ZGUsIGRvdWJsZSBhY2N1cmFjeSwgYm9vbCBwcm92aWRlc0FsdGl0dWRlQWNj dXJhY3ksIGRvdWJsZSBhbHRpdHVkZUFjY3VyYWN5LCBib29sIHByb3ZpZGVzSGVhZGluZywgZG91 YmxlIGhlYWRpbmcsIGJvb2wgcHJvdmlkZXNTcGVlZCwgZG91YmxlIHNwZWVkLCBsb25nIGxvbmcg dGltZXN0YW1wKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHNldExhc3RFcnJvcihpbnQgZXJyb3JD b2RlLCBjb25zdCBXZWJTdHJpbmcmIG1lc3NhZ2UpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgb25X ZWJHZW9sb2NhdGlvblNlcnZpY2VEZXN0cm95ZWQoKSA9IDA7CisKK3Byb3RlY3RlZDoKKyAgICB2 aXJ0dWFsIH5XZWJHZW9sb2NhdGlvblNlcnZpY2VCcmlkZ2UoKSB7fQogfTsKIAogfSAvLyBuYW1l c3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkdlb2xvY2F0 aW9uU2VydmljZUJyaWRnZUltcGwuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJHZW9sb2Nh dGlvblNlcnZpY2VCcmlkZ2VJbXBsLmNwcAppbmRleCAzYzNhMWRiLi5iYmI3MTYyIDEwMDY0NAot LS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkdlb2xvY2F0aW9uU2VydmljZUJyaWRnZUltcGwu Y3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViR2VvbG9jYXRpb25TZXJ2aWNlQnJpZGdl SW1wbC5jcHAKQEAgLTc5LDYgKzc5LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXRJ c0FsbG93ZWQoYm9vbCBhbGxvd2VkKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0TGFzdFBvc2l0aW9u KGRvdWJsZSBsYXRpdHVkZSwgZG91YmxlIGxvbmdpdHVkZSwgYm9vbCBwcm92aWRlc0FsdGl0dWRl LCBkb3VibGUgYWx0aXR1ZGUsIGRvdWJsZSBhY2N1cmFjeSwgYm9vbCBwcm92aWRlc0FsdGl0dWRl QWNjdXJhY3ksIGRvdWJsZSBhbHRpdHVkZUFjY3VyYWN5LCBib29sIHByb3ZpZGVzSGVhZGluZywg ZG91YmxlIGhlYWRpbmcsIGJvb2wgcHJvdmlkZXNTcGVlZCwgZG91YmxlIHNwZWVkLCBsb25nIGxv bmcgdGltZXN0YW1wKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0TGFzdEVycm9yKGludCBlcnJvckNv ZGUsIGNvbnN0IFdlYlN0cmluZyYgbWVzc2FnZSk7CisgICAgdmlydHVhbCB2b2lkIG9uV2ViR2Vv bG9jYXRpb25TZXJ2aWNlRGVzdHJveWVkKCk7CiAKIHByaXZhdGU6CiAgICAgV2ViVmlld0NsaWVu dCogZ2V0V2ViVmlld0NsaWVudCgpOwpAQCAtMTc2LDYgKzE3NywxMCBAQCBXZWJWaWV3Q2xpZW50 KiBXZWJHZW9sb2NhdGlvblNlcnZpY2VCcmlkZ2VJbXBsOjpnZXRXZWJWaWV3Q2xpZW50KCkKICAg ICByZXR1cm4gd2ViVmlld0NsaWVudDsKIH0KIAordm9pZCBXZWJHZW9sb2NhdGlvblNlcnZpY2VC cmlkZ2VJbXBsOjpvbldlYkdlb2xvY2F0aW9uU2VydmljZURlc3Ryb3llZCgpCit7Cit9CisKIH0g Ly8gbmFtZXNwYWNlIFdlYktpdAogCiAjZW5kaWYgLy8gRU5BQkxFKEdFT0xPQ0FUSU9OKQo= 66624 2010-09-06 04:32:59 -0700 2010-09-06 10:10:23 -0700 Remove \t char bug45257.txt text/plain 2682 joth ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGJiNjI4OTMuLjA0MWZmY2IgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDEwLTA5LTA2ICBKb25hdGhhbiBEaXhvbiAgPGpvdGhAY2hyb21pdW0ub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBuZXcg aW50ZXJmYWNlIGFuZCBlbXB0eSBpbXBsLiBhcyBwcmVjdXJzb3IgdG8gYnVnIDQ1MTEyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTI1NworCisgICAg ICAgICogcHVibGljL1dlYkdlb2xvY2F0aW9uU2VydmljZUJyaWRnZS5oOgorICAgICAgICAoV2Vi S2l0OjpXZWJHZW9sb2NhdGlvblNlcnZpY2VCcmlkZ2U6On5XZWJHZW9sb2NhdGlvblNlcnZpY2VC cmlkZ2UpOgorICAgICAgICAqIHNyYy9XZWJHZW9sb2NhdGlvblNlcnZpY2VCcmlkZ2VJbXBsLmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViR2VvbG9jYXRpb25TZXJ2aWNlQnJpZGdlSW1wbDo6b25X ZWJHZW9sb2NhdGlvblNlcnZpY2VEZXN0cm95ZWQpOgorCiAyMDEwLTA5LTAzICBKZXN1cyBTYW5j aGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViR2VvbG9jYXRpb25TZXJ2aWNlQnJpZGdlLmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYkdlb2xvY2F0aW9uU2VydmljZUJyaWRnZS5oCmluZGV4IDlmMGZmZDQuLjQyMmIzMmIgMTAw NjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViR2VvbG9jYXRpb25TZXJ2aWNlQnJp ZGdlLmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJHZW9sb2NhdGlvblNlcnZpY2VC cmlkZ2UuaApAQCAtNDcsNiArNDcsMTAgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXRJ c0FsbG93ZWQoYm9vbCBhbGxvd2VkKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHNldExhc3RQb3Np dGlvbihkb3VibGUgbGF0aXR1ZGUsIGRvdWJsZSBsb25naXR1ZGUsIGJvb2wgcHJvdmlkZXNBbHRp dHVkZSwgZG91YmxlIGFsdGl0dWRlLCBkb3VibGUgYWNjdXJhY3ksIGJvb2wgcHJvdmlkZXNBbHRp dHVkZUFjY3VyYWN5LCBkb3VibGUgYWx0aXR1ZGVBY2N1cmFjeSwgYm9vbCBwcm92aWRlc0hlYWRp bmcsIGRvdWJsZSBoZWFkaW5nLCBib29sIHByb3ZpZGVzU3BlZWQsIGRvdWJsZSBzcGVlZCwgbG9u ZyBsb25nIHRpbWVzdGFtcCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRMYXN0RXJyb3IoaW50 IGVycm9yQ29kZSwgY29uc3QgV2ViU3RyaW5nJiBtZXNzYWdlKSA9IDA7CisgICAgdmlydHVhbCB2 b2lkIG9uV2ViR2VvbG9jYXRpb25TZXJ2aWNlRGVzdHJveWVkKCkgPSAwOworCitwcm90ZWN0ZWQ6 CisgICAgdmlydHVhbCB+V2ViR2VvbG9jYXRpb25TZXJ2aWNlQnJpZGdlKCkge30KIH07CiAKIH0g Ly8gbmFtZXNwYWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJH ZW9sb2NhdGlvblNlcnZpY2VCcmlkZ2VJbXBsLmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi R2VvbG9jYXRpb25TZXJ2aWNlQnJpZGdlSW1wbC5jcHAKaW5kZXggM2MzYTFkYi4uYmJiNzE2MiAx MDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJHZW9sb2NhdGlvblNlcnZpY2VCcmlk Z2VJbXBsLmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkdlb2xvY2F0aW9uU2Vydmlj ZUJyaWRnZUltcGwuY3BwCkBAIC03OSw2ICs3OSw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZv aWQgc2V0SXNBbGxvd2VkKGJvb2wgYWxsb3dlZCk7CiAgICAgdmlydHVhbCB2b2lkIHNldExhc3RQ b3NpdGlvbihkb3VibGUgbGF0aXR1ZGUsIGRvdWJsZSBsb25naXR1ZGUsIGJvb2wgcHJvdmlkZXNB bHRpdHVkZSwgZG91YmxlIGFsdGl0dWRlLCBkb3VibGUgYWNjdXJhY3ksIGJvb2wgcHJvdmlkZXNB bHRpdHVkZUFjY3VyYWN5LCBkb3VibGUgYWx0aXR1ZGVBY2N1cmFjeSwgYm9vbCBwcm92aWRlc0hl YWRpbmcsIGRvdWJsZSBoZWFkaW5nLCBib29sIHByb3ZpZGVzU3BlZWQsIGRvdWJsZSBzcGVlZCwg bG9uZyBsb25nIHRpbWVzdGFtcCk7CiAgICAgdmlydHVhbCB2b2lkIHNldExhc3RFcnJvcihpbnQg ZXJyb3JDb2RlLCBjb25zdCBXZWJTdHJpbmcmIG1lc3NhZ2UpOworICAgIHZpcnR1YWwgdm9pZCBv bldlYkdlb2xvY2F0aW9uU2VydmljZURlc3Ryb3llZCgpOwogCiBwcml2YXRlOgogICAgIFdlYlZp ZXdDbGllbnQqIGdldFdlYlZpZXdDbGllbnQoKTsKQEAgLTE3Niw2ICsxNzcsMTAgQEAgV2ViVmll d0NsaWVudCogV2ViR2VvbG9jYXRpb25TZXJ2aWNlQnJpZGdlSW1wbDo6Z2V0V2ViVmlld0NsaWVu dCgpCiAgICAgcmV0dXJuIHdlYlZpZXdDbGllbnQ7CiB9CiAKK3ZvaWQgV2ViR2VvbG9jYXRpb25T ZXJ2aWNlQnJpZGdlSW1wbDo6b25XZWJHZW9sb2NhdGlvblNlcnZpY2VEZXN0cm95ZWQoKQorewor fQorCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKIAogI2VuZGlmIC8vIEVOQUJMRShHRU9MT0NBVElP TikK