45255 2010-09-06 03:51:48 -0700 [reviewtool] Add an "ok" button that collapses review comments 2010-09-06 10:23:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth abarth commit-queue eric fishd webkit.review.bot oldest_to_newest 274534 0 abarth 2010-09-06 03:51:48 -0700 [reviewtool] Add an "ok" button that collapses review comments 274536 1 66619 abarth 2010-09-06 03:55:33 -0700 Created attachment 66619 Patch 274568 2 66619 eric 2010-09-06 05:37:39 -0700 Comment on attachment 66619 Patch Yay! 274574 3 66619 commit-queue 2010-09-06 06:00:14 -0700 Comment on attachment 66619 Patch Clearing flags on attachment: 66619 Committed r66821: <http://trac.webkit.org/changeset/66821> 274575 4 commit-queue 2010-09-06 06:00:18 -0700 All reviewed patches have been landed. Closing bug. 274587 5 webkit.review.bot 2010-09-06 06:31:01 -0700 http://trac.webkit.org/changeset/66821 might have broken Qt Linux Release 274695 6 abarth 2010-09-06 10:23:48 -0700 I landed a follow up patch to handle an edge case better. http://trac.webkit.org/changeset/66838 66619 2010-09-06 03:55:33 -0700 2010-09-06 06:00:13 -0700 Patch bug-45255-20100906035532.patch text/plain 2915 abarth SW5kZXg6IEJ1Z3NTaXRlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDY2ODIwKQorKysgQnVnc1NpdGUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDktMDYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb cmV2aWV3dG9vbF0gQWRkIGFuICJvayIgYnV0dG9uIHRoYXQgY29sbGFwc2VzIHJldmlldyBjb21t ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDUy NTUKKworICAgICAgICBNYW55IGZvbGtzIChpbmNsdWRpbmcgbXlzZWxmKSBhcmUgdG9vIHRyaWdn ZXItaGFwcHkgd2l0aCB0aGUgImRlbGV0ZSIKKyAgICAgICAgYnV0dG9uIHRoYXQgd2UgZW5kIHVw IGRlbGV0aW5nIHBlcmZlY3RseSBnb29kIHJldmlldyBjb21tZW50cy4gIFRoaXMKKyAgICAgICAg cGF0Y2ggYWRkcyBhbiAib2siIGJ1dHRvbiB0byBhYnNvcmIgdGhlc2UgY2xpY2tzIChhbmQgcmVu YW1lcyAiZGVsZXRlIgorICAgICAgICB0byAiY2FuY2VsIikuICBXaGVuIHlvdSBjbGljayB0aGUg b2sgYnV0dG9uLCB0aGUgY29tbWVudCBiZWNvbWVzCisgICAgICAgIG5vbi1lZGl0YWJsZSBhbmQg dGhlIGJveCBzaHJpbmtzIHRvIGZpdCB0aGUgdGV4dC4gIFlvdSBjYW4gY2xpY2sgdGhlCisgICAg ICAgIHRleHQgdG8gZ2V0IGJhY2sgdG8gdGhlIGVkaXRhYmxlIHZlcnNpb24uCisKKyAgICAgICAg KiBjb2RlLXJldmlldy5qczoKKwogMjAxMC0wOC0zMSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJr aXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogQnVnc1Np dGUvY29kZS1yZXZpZXcuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gQnVnc1NpdGUvY29kZS1yZXZpZXcuanMJ KHJldmlzaW9uIDY2ODE5KQorKysgQnVnc1NpdGUvY29kZS1yZXZpZXcuanMJKHdvcmtpbmcgY29w eSkKQEAgLTY3LDcgKzY3LDcgQEAKICAgICBsaW5lLmF0dHIoJ2RhdGEtaGFzLWNvbW1lbnQnLCAn dHJ1ZScpOwogICAgIGxpbmUuYWRkQ2xhc3MoJ2NvbW1lbnRDb250ZXh0Jyk7CiAKLSAgICB2YXIg Y29tbWVudF9ibG9jayA9ICQoJzxkaXYgY2xhc3M9ImNvbW1lbnQiPjx0ZXh0YXJlYSBkYXRhLWNv bW1lbnQtZm9yPSInICsgbGluZS5hdHRyKCdpZCcpICsgJyI+PC90ZXh0YXJlYT48ZGl2IGNsYXNz PSJhY3Rpb25zIj48YnV0dG9uIGNsYXNzPSJkZWxldGUiPkRlbGV0ZTwvYnV0dG9uPjwvZGl2Pjwv ZGl2PicpOworICAgIHZhciBjb21tZW50X2Jsb2NrID0gJCgnPGRpdiBjbGFzcz0iY29tbWVudCI+ PHRleHRhcmVhIGRhdGEtY29tbWVudC1mb3I9IicgKyBsaW5lLmF0dHIoJ2lkJykgKyAnIj48L3Rl eHRhcmVhPjxkaXYgY2xhc3M9ImFjdGlvbnMiPjxidXR0b24gY2xhc3M9Im9rIj5PazwvYnV0dG9u PjxidXR0b24gY2xhc3M9ImNhbmNlbCI+Q2FuY2VsPC9idXR0b24+PC9kaXY+PC9kaXY+Jyk7CiAg ICAgaW5zZXJ0Q29tbWVudEZvcihsaW5lLCBjb21tZW50X2Jsb2NrKTsKICAgICBjb21tZW50X2Js b2NrLmNoaWxkcmVuKCd0ZXh0YXJlYScpLmZvY3VzKCk7CiAgIH0KQEAgLTE4NCw3ICsxODQsNyBA QAogICAgICQoZG9jdW1lbnQuYm9keSkucHJlcGVuZCgnPGRpdiBpZD0iY29tbWVudF9mb3JtIiBj bGFzcz0iaW5hY3RpdmUiPjxkaXYgY2xhc3M9IndpbnRlciI+PC9kaXY+PGRpdiBjbGFzcz0ibGln aHRib3giPjxpZnJhbWUgc3JjPSJhdHRhY2htZW50LmNnaT9pZD0nICsgYXR0YWNobWVudF9pZCAr ICcmYWN0aW9uPXJldmlld2Zvcm0iPjwvaWZyYW1lPjwvZGl2PjwvZGl2PicpOwogICB9KTsKIAot ICAkKCcuY29tbWVudCAuZGVsZXRlJykubGl2ZSgnY2xpY2snLCBmdW5jdGlvbigpIHsKKyAgJCgn LmNvbW1lbnQgLmNhbmNlbCcpLmxpdmUoJ2NsaWNrJywgZnVuY3Rpb24oKSB7CiAgICAgdmFyIGxp bmVfaWQgPSAkKHRoaXMpLnBhcmVudHNVbnRpbCgnLmNvbW1lbnQnKS5wYXJlbnQoKS5maW5kKCd0 ZXh0YXJlYScpLmF0dHIoJ2RhdGEtY29tbWVudC1mb3InKTsKICAgICB2YXIgbGluZSA9ICQoJyMn ICsgbGluZV9pZCkKICAgICBmaW5kQ29tbWVudEJsb2NrRm9yKGxpbmUpLnJlbW92ZSgpOwpAQCAt MTkyLDYgKzE5MiwxOCBAQAogICAgIHRyaW1Db21tZW50Q29udGV4dFRvQmVmb3JlKGxpbmUpOwog ICB9KTsKIAorICAkKCcuY29tbWVudCAub2snKS5saXZlKCdjbGljaycsIGZ1bmN0aW9uKCkgewor ICAgIHZhciBjb21tZW50X3RleHRhcmVhID0gJCh0aGlzKS5wYXJlbnRzVW50aWwoJy5jb21tZW50 JykucGFyZW50KCkuZmluZCgndGV4dGFyZWEnKTsKKyAgICB2YXIgbGluZV9pZCA9IGNvbW1lbnRf dGV4dGFyZWEuYXR0cignZGF0YS1jb21tZW50LWZvcicpOworICAgIHZhciBsaW5lID0gJCgnIycg KyBsaW5lX2lkKQorICAgIGZpbmRDb21tZW50QmxvY2tGb3IobGluZSkuaGlkZSgpLmFmdGVyKCQo JzxkaXYgY2xhc3M9ImZyb3plbi1jb21tZW50Ij48L2Rpdj4nKS50ZXh0KGNvbW1lbnRfdGV4dGFy ZWEudmFsKCkpKTsKKyAgfSk7CisKKyAgJCgnLmZyb3plbi1jb21tZW50JykubGl2ZSgnY2xpY2sn LCBmdW5jdGlvbigpIHsKKyAgICAkKHRoaXMpLnByZXYoKS5zaG93KCk7CisgICAgJCh0aGlzKS5y ZW1vdmUoKTsKKyAgfSk7CisKICAgZnVuY3Rpb24gZm9jdXNPbihjb21tZW50KSB7CiAgICAgJCgn LmZvY3VzZWQnKS5yZW1vdmVDbGFzcygnZm9jdXNlZCcpOwogICAgIGlmIChjb21tZW50Lmxlbmd0 aCA9PSAwKQo=