45246 2010-09-05 15:05:21 -0700 REGRESSION(66741): Undefined pthread macros 2010-09-07 10:46:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 43191 1 ossy webkit-unassigned abarth ap commit-queue darin eric webkit.review.bot zoltan oldest_to_newest 274452 0 ossy 2010-09-05 15:05:21 -0700 warning on Qt Linux Release bot: ../../../JavaScriptCore/wtf/FastMalloc.cpp:1496:5: warning: "PTHREAD_MUTEX_NORMAL" is not defined ../../../JavaScriptCore/wtf/FastMalloc.cpp:1496:29: warning: "PTHREAD_MUTEX_DEFAULT" is not defined 274459 1 ap 2010-09-05 17:29:13 -0700 Is Qt even using FastMalloc? FWIW, we've been already using these macros in ThreadingPthreads.cpp. 274540 2 ossy 2010-09-06 04:01:35 -0700 I cc-ed our memory expert. Zoltan, could you check it, please? 274573 3 zoltan 2010-09-06 05:53:37 -0700 (In reply to comment #1) > Is Qt even using FastMalloc? Yes, it is. > FWIW, we've been already using these macros in ThreadingPthreads.cpp. QtWebKit doesn't set PTHREADS macro, so we don't compile ThreadingPthreads.cpp. Why do we need this #if PTHREAD_MUTEX_NORMAL == PTHREAD_MUTEX_DEFAULT condition? As I see these are defined as the same on mac and on linux as well (if it is even defined). 274653 4 darin 2010-09-06 08:47:27 -0700 (In reply to comment #3) > Why do we need this > > #if PTHREAD_MUTEX_NORMAL == PTHREAD_MUTEX_DEFAULT > > condition? See bug 39893 for the reason. 274864 5 66687 zoltan 2010-09-07 00:26:18 -0700 Created attachment 66687 proposed patch Proposed patch for now. It's making the build happy. 275044 6 66687 commit-queue 2010-09-07 08:16:40 -0700 Comment on attachment 66687 proposed patch Clearing flags on attachment: 66687 Committed r66883: <http://trac.webkit.org/changeset/66883> 275045 7 commit-queue 2010-09-07 08:16:45 -0700 All reviewed patches have been landed. Closing bug. 275131 8 webkit.review.bot 2010-09-07 10:26:34 -0700 http://trac.webkit.org/changeset/66883 might have broken Leopard Intel Debug (Tests) 275149 9 ossy 2010-09-07 10:46:07 -0700 (In reply to comment #8) > http://trac.webkit.org/changeset/66883 might have broken Leopard Intel Debug (Tests) false positive alarm, it was a flakey test 66687 2010-09-07 00:26:18 -0700 2010-09-07 08:16:40 -0700 proposed patch warningfix.patch text/plain 1271 zoltan ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA5YTM1N2I1Li5jYjY1ODcyIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTAtMDktMDcgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTig2 Njc0MSk6IFVuZGVmaW5lZCBwdGhyZWFkIG1hY3JvcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDUyNDYKKworICAgICAgICBQVEhSRUFEX01VVEVYX05P Uk1BTCBhbmQgUFRIUkVBRF9NVVRFWF9ERUZBVUxUIChpbnRyb2R1Y2VkIGluIHI2MDQ4NykgYXJl IG5vdCBkZWZpbmVkIG9uIExpbnV4LCAKKyAgICAgICAgYnV0IHVzZWQgaW4gYSBzdGF0ZW1lbnQu IEFkZCBhbiBhZGRpdGlvbmFsIGNoZWNrIHRvIHRlc3QgdGhpcy4KKworICAgICAgICAqIHd0Zi9G YXN0TWFsbG9jLmNwcDoKKyAgICAgICAgKFdURjo6VENNYWxsb2NfUGFnZUhlYXA6OmluaXRpYWxp emVTY2F2ZW5nZXIpOgorCiAyMDEwLTA5LTA2ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5j b20+CiAKICAgICAgICAgV2luZG93cyBidWlsZCBmaXgKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRD b3JlL3d0Zi9GYXN0TWFsbG9jLmNwcCBiL0phdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9jLmNw cAppbmRleCBjZDBmMTdlLi4wZjI0MGZmIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYv RmFzdE1hbGxvYy5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2MuY3BwCkBA IC0xNDkzLDcgKzE0OTMsNyBAQCB2b2lkIFRDTWFsbG9jX1BhZ2VIZWFwOjppbml0KCkKIHZvaWQg VENNYWxsb2NfUGFnZUhlYXA6OmluaXRpYWxpemVTY2F2ZW5nZXIoKQogewogICAgIC8vIENyZWF0 ZSBhIG5vbi1yZWN1cnNpdmUgbXV0ZXguCi0jaWYgUFRIUkVBRF9NVVRFWF9OT1JNQUwgPT0gUFRI UkVBRF9NVVRFWF9ERUZBVUxUCisjaWYgIWRlZmluZWQoUFRIUkVBRF9NVVRFWF9OT1JNQUwpIHx8 IFBUSFJFQURfTVVURVhfTk9STUFMID09IFBUSFJFQURfTVVURVhfREVGQVVMVAogICAgIHB0aHJl YWRfbXV0ZXhfaW5pdCgmbV9zY2F2ZW5nZU11dGV4LCAwKTsKICNlbHNlCiAgICAgcHRocmVhZF9t dXRleGF0dHJfdCBhdHRyOwo=