45240 2010-09-05 05:16:45 -0700 [Qt] utf8 encoding of console() messages 2010-09-08 14:09:35 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC OS X 10.5 CLOSED FIXED Qt, QtTriaged P2 Normal --- 45242 45314 1 robert robert abarth commit-queue eric tonikitoo webkit.review.bot oldest_to_newest 274423 0 robert 2010-09-05 05:16:45 -0700 http/tests/security/xssAuditor/embed-tag-null-char.html http/tests/security/xssAuditor/object-embed-tag-null-char.html both fail because ChromeClientQt::addMessageToConsole() is casting String to QString rather than String::utf8().data(). 274424 1 66596 robert 2010-09-05 05:24:05 -0700 Created attachment 66596 Patch 274427 2 66596 tonikitoo 2010-09-05 06:10:43 -0700 Comment on attachment 66596 Patch What about bug 35263 ? 274428 3 robert 2010-09-05 07:12:17 -0700 (In reply to comment #2) > (From update of attachment 66596 [details]) > What about bug 35263 ? That ref in the Skipped list is misleading - bugs are unrelated. I think it was me who added that misleading reference! 274429 4 66596 commit-queue 2010-09-05 07:28:46 -0700 Comment on attachment 66596 Patch Clearing flags on attachment: 66596 Committed r66801: <http://trac.webkit.org/changeset/66801> 274430 5 commit-queue 2010-09-05 07:28:51 -0700 All reviewed patches have been landed. Closing bug. 274431 6 webkit.review.bot 2010-09-05 08:00:57 -0700 http://trac.webkit.org/changeset/66801 might have broken Qt Linux Release 274442 7 tonikitoo 2010-09-05 10:19:38 -0700 it was rolled out. reopenning 274445 8 66599 robert 2010-09-05 10:38:39 -0700 Created attachment 66599 Patch 274446 9 robert 2010-09-05 10:41:32 -0700 (In reply to comment #7) > it was rolled out. reopenning I think I understand the problem now. However the solution involves creating a QString, casting to a QByteArray, then char*, then String, then back to QString, then a QByteArray, then const *char - at which point something finally gets printed out! 274456 10 66599 kling 2010-09-05 16:42:17 -0700 Comment on attachment 66599 Patch > + return StringImpl::create(buffer.toUtf8().constData(), buffer.toUtf8().length()); This will cause the UTF-8 conversion to be done twice. r=me, but please fix that before landing. 274736 11 robert 2010-09-06 11:43:18 -0700 (In reply to comment #10) > (From update of attachment 66599 [details]) > > + return StringImpl::create(buffer.toUtf8().constData(), buffer.toUtf8().length()); > > This will cause the UTF-8 conversion to be done twice. > > r=me, but please fix that before landing. heh, right enough. i think i get it now! 274742 12 robert 2010-09-06 12:11:33 -0700 Committed r66843: <http://trac.webkit.org/changeset/66843> 274745 13 webkit.review.bot 2010-09-06 12:17:21 -0700 http://trac.webkit.org/changeset/66843 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Linux ARMv7 Release 274754 14 robert 2010-09-06 12:46:55 -0700 (In reply to comment #10) > (From update of attachment 66599 [details]) > > + return StringImpl::create(buffer.toUtf8().constData(), buffer.toUtf8().length()); > > This will cause the UTF-8 conversion to be done twice. > > r=me, but please fix that before landing. I thought I had followed your advice but made the change during a compile and mistakenly thought it had been caught - but it hadn't. I don't see a way of fixing this without using toUtf8().constData(). 274776 15 tonikitoo 2010-09-06 14:10:30 -0700 (In reply to comment #14) > (In reply to comment #10) > > (From update of attachment 66599 [details] [details]) > > > + return StringImpl::create(buffer.toUtf8().constData(), buffer.toUtf8().length()); > > > > This will cause the UTF-8 conversion to be done twice. > > > > r=me, but please fix that before landing. > > I thought I had followed your advice but made the change during a compile and mistakenly thought it had been caught - but it hadn't. > > I don't see a way of fixing this without using toUtf8().constData(). maybe he was referring you called buffer.toUtf8() twice? 66596 2010-09-05 05:24:05 -0700 2010-09-05 10:38:32 -0700 Patch bug-45240-20100905132400.patch text/plain 3073 robert ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhYzU4Y2U4ZTNiZmY5NWZhNjQyOTM3OGNmN2U0YzgwYjUzNTVhODdjLi5mZTBmMGVm ZGVhNWY0Njg5ODIxZDI2OTFiOWQ0NjM1MTQ2MWFiMDRmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTAtMDktMDUgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gdXRmOCBlbmNvZGlu ZyBvZiBjb25zb2xlKCkgbWVzc2FnZXMKKworICAgICAgICBVbnNraXA6CisgICAgICAgIGh0dHAv dGVzdHMvc2VjdXJpdHkveHNzQXVkaXRvci9lbWJlZC10YWctbnVsbC1jaGFyLmh0bWwKKyAgICAg ICAgaHR0cC90ZXN0cy9zZWN1cml0eS94c3NBdWRpdG9yL29iamVjdC1lbWJlZC10YWctbnVsbC1j aGFyLmh0bWwKKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDUyNDAKKworICAgICAgICAqIHBsYXRmb3JtL3F0L1NraXBwZWQ6CisKIDIwMTAtMDktMDQg IFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0 L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCmluZGV4IDljOTIxMGI5 MzY0N2RhNTU4ZTYxZWNiNDFkYWNkNzExYjkzNzgzY2YuLmIzNTAzYzg4OTQ1ODZkMWUyNGNmMDhj NWE4OGM5NmYwZWFhMGM3YjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1Nr aXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZApAQCAtMTgxLDExICsx ODEsNiBAQCBodHRwL3Rlc3RzL3NlY3VyaXR5L2ZyYW1lTmF2aWdhdGlvbi9ub3Qtb3BlbmVyLmh0 bWwKICMgbWlzc2luZyBvcmlnaW4gaGVhZGVyCiBodHRwL3Rlc3RzL3NlY3VyaXR5L29yaWdpbkhl YWRlci9vcmlnaW4taGVhZGVyLWZvci1lbXB0eS5odG1sCiAKLSMgUG9zc2libHkgcmVsYXRlZCB0 byBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUyNjMKLSMgYXJlIHdl IHV0Zi1lbmNvZGluZyBhIHN0cmluZyB0d2ljZSBvdmVyPwotaHR0cC90ZXN0cy9zZWN1cml0eS94 c3NBdWRpdG9yL2VtYmVkLXRhZy1udWxsLWNoYXIuaHRtbAotaHR0cC90ZXN0cy9zZWN1cml0eS94 c3NBdWRpdG9yL29iamVjdC1lbWJlZC10YWctbnVsbC1jaGFyLmh0bWwKLQogIyBEaXNhYmxlZCBI VFRQIHN1YmRpcnMgZm9yIG5vdywgbmVlZHMgaW52ZXN0aWdhdGlvbi4KIGh0dHAvdGVzdHMvbWVk aWEKIGh0dHAvdGVzdHMvd21sCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvV2Vi S2l0L3F0L0NoYW5nZUxvZwppbmRleCA4ZjAyNmEyMDAxMmJjYjc1ZjNmZWYzZGZkMzg5Zjc0NGM2 MmJiY2Q4Li4xZWI5MjAyNTM2ZmUwZDcyNWUxODNlMDgzNjRkYjEyYTkwZWM3MGRiIDEwMDY0NAot LS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxMC0wOS0wNSAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSB1 dGY4IGVuY29kaW5nIG9mIGNvbnNvbGUoKSBtZXNzYWdlcworCisgICAgICAgIGh0dHAvdGVzdHMv c2VjdXJpdHkveHNzQXVkaXRvci9lbWJlZC10YWctbnVsbC1jaGFyLmh0bWwKKyAgICAgICAgaHR0 cC90ZXN0cy9zZWN1cml0eS94c3NBdWRpdG9yL29iamVjdC1lbWJlZC10YWctbnVsbC1jaGFyLmh0 bWwKKworICAgICAgICBib3RoIGZhaWwgYmVjYXVzZSBDaHJvbWVDbGllbnRRdDo6YWRkTWVzc2Fn ZVRvQ29uc29sZSgpIGlzCisgICAgICAgIGNhc3RpbmcgU3RyaW5nIHRvIFFTdHJpbmcgcmF0aGVy IHRoYW4gU3RyaW5nOjp1dGY4KCkuZGF0YSgpCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1MjQwCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9D aHJvbWVDbGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWVDbGllbnRRdDo6YWRk TWVzc2FnZVRvQ29uc29sZSk6CisKIDIwMTAtMDktMDMgIEplc3VzIFNhbmNoZXotUGFsZW5jaWEg IDxqZXN1cy5wYWxlbmNpYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh cmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNs aWVudFF0LmNwcCBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRRdC5jcHAK aW5kZXggOGIwMWQ0ZDRkNTVmN2JlOGM2OTEyOTZlZTU3MmJmYWQxNTg1MDg4MS4uMjU4NWY2YWU3 ZjEwOTgwODIyNGQ5YjJjMDRiNmJlNThiMTJjMDY5YiAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L1dl YkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudFF0LmNwcAorKysgYi9XZWJLaXQvcXQvV2ViQ29yZVN1 cHBvcnQvQ2hyb21lQ2xpZW50UXQuY3BwCkBAIC0yNjUsNyArMjY1LDcgQEAgdm9pZCBDaHJvbWVD bGllbnRRdDo6c2V0UmVzaXphYmxlKGJvb2wpCiB2b2lkIENocm9tZUNsaWVudFF0OjphZGRNZXNz YWdlVG9Db25zb2xlKE1lc3NhZ2VTb3VyY2UsIE1lc3NhZ2VUeXBlLCBNZXNzYWdlTGV2ZWwsIGNv bnN0IFN0cmluZyYgbWVzc2FnZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgdW5zaWduZWQgaW50IGxpbmVOdW1iZXIsIGNvbnN0IFN0cmluZyYgc291cmNlSUQpCiB7 Ci0gICAgUVN0cmluZyB4ID0gbWVzc2FnZTsKKyAgICBRU3RyaW5nIHggPSBRU3RyaW5nKG1lc3Nh Z2UudXRmOCgpLmRhdGEoKSk7CiAgICAgUVN0cmluZyB5ID0gc291cmNlSUQ7CiAgICAgbV93ZWJQ YWdlLT5qYXZhU2NyaXB0Q29uc29sZU1lc3NhZ2UoeCwgbGluZU51bWJlciwgeSk7CiB9Cg== 66599 2010-09-05 10:38:39 -0700 2010-09-05 16:42:17 -0700 Patch bug-45240-20100905183832.patch text/plain 3410 robert ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBkZjBlMmNlNGFjMmM2OGQwZTUwNjJiOTY3ODU3YjU3ZTM5NTg3MmIwLi41 Nzg5NGIwMzEwNmNkNDc1NDVhODcxMTBkODllZDBkMzNiNTc1NTM1IDEwMDY0NAotLS0gYS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjQgQEAKKzIwMTAtMDktMDUgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0g dXRmOCBlbmNvZGluZyBvZiBjb25zb2xlKCkgbWVzc2FnZXMKKworICAgICAgICBVbnNraXA6Cisg ICAgICAgIGh0dHAvdGVzdHMvc2VjdXJpdHkveHNzQXVkaXRvci9lbWJlZC10YWctbnVsbC1jaGFy Lmh0bWwKKyAgICAgICAgaHR0cC90ZXN0cy9zZWN1cml0eS94c3NBdWRpdG9yL29iamVjdC1lbWJl ZC10YWctbnVsbC1jaGFyLmh0bWwKKworICAgICAgICBCb3RoIHRlc3RzIGZhaWxlZCBiZWNhdXNl IFF0J3MgaW1wbGVtZW50YXRpb24gb2YgU3RyaW5nOjpmb3JtYXQoKQorICAgICAgICBpcyBjYXN0 aW5nIGEgdXRmOCByZXN1bHQgdG8gU3RyaW5nLCB3aGljaCBhc3N1bWVzIGxhdGluMSBpbgorICAg ICAgICBpdHMgY29uc3RydWN0b3IuIFNvIGluc3RlYWQgb2YgY2FzdGluZyBhIFFTdHJpbmcgdG8g YSBTdHJpbmcsIHVzZQorICAgICAgICBTdHJpbmdJbXBsOjpjcmVhdGUoKSBpbnN0ZWFkLiBVbmZv cnR1bmF0ZWx5LCB0aGlzIGludm9sdmVzIGEgbG90CisgICAgICAgIG9mIGV4dHJhIGNhc3RzIGJ1 dCB0aGUgZW5kIHJlc3VsdCBpcyBjb3JyZWN0LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTI0MAorCisgICAgICAgICogd3RmL3RleHQvV1RGU3Ry aW5nLmNwcDoKKyAgICAgICAgKFdURjo6U3RyaW5nOjpmb3JtYXQpOgorCiAyMDEwLTA5LTAzICBB bGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvV1RGU3Ry aW5nLmNwcCBiL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1dURlN0cmluZy5jcHAKaW5kZXggYTgz ZGJiYWU5NWU0ZmZlMDM5MjRlNGY0MTRjZGVlODUzM2QyNjBkZi4uODUzZTFiNTliMWQ0MjBiOTVm MjFlNDhlZjI2NWEzMTU1OWM5ZTM2NiAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL3Rl eHQvV1RGU3RyaW5nLmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9XVEZTdHJpbmcu Y3BwCkBAIC0zMzUsNyArMzM1LDcgQEAgU3RyaW5nIFN0cmluZzo6Zm9ybWF0KGNvbnN0IGNoYXIg KmZvcm1hdCwgLi4uKQogCiAgICAgdmFfZW5kKGFyZ3MpOwogCi0gICAgcmV0dXJuIGJ1ZmZlcjsK KyAgICByZXR1cm4gU3RyaW5nSW1wbDo6Y3JlYXRlKGJ1ZmZlci50b1V0ZjgoKS5jb25zdERhdGEo KSwgYnVmZmVyLnRvVXRmOCgpLmxlbmd0aCgpKTsKIAogI2VsaWYgT1MoV0lOQ0UpCiAgICAgdmFf bGlzdCBhcmdzOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCmluZGV4IDU4ZTU2MGE0Yjc5MGI5ZjA1NTU5NTViNzZkZTg5M2E1ZWE1MWYy YzAuLjBjMzI3ZjA3MjAwZWYyNWNiMTZhMDE5YzAyYTIyM2Y4MzY1MDUwMTUgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxMC0wOS0wNSAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSB1 dGY4IGVuY29kaW5nIG9mIGNvbnNvbGUoKSBtZXNzYWdlcworCisgICAgICAgIFVuc2tpcDoKKyAg ICAgICAgaHR0cC90ZXN0cy9zZWN1cml0eS94c3NBdWRpdG9yL2VtYmVkLXRhZy1udWxsLWNoYXIu aHRtbAorICAgICAgICBodHRwL3Rlc3RzL3NlY3VyaXR5L3hzc0F1ZGl0b3Ivb2JqZWN0LWVtYmVk LXRhZy1udWxsLWNoYXIuaHRtbAorCisgICAgICAgIEJvdGggdGVzdHMgZmFpbGVkIGJlY2F1c2Ug UXQncyBpbXBsZW1lbnRhdGlvbiBvZiBTdHJpbmc6OmZvcm1hdCgpCisgICAgICAgIGlzIGNhc3Rp bmcgYSB1dGY4IHJlc3VsdCB0byBTdHJpbmcsIHdoaWNoIGFzc3VtZXMgbGF0aW4xIGluCisgICAg ICAgIGl0cyBjb25zdHJ1Y3Rvci4gU28gaW5zdGVhZCBvZiBjYXN0aW5nIGEgUVN0cmluZyB0byBh IFN0cmluZywgdXNlCisgICAgICAgIFN0cmluZ0ltcGw6OmNyZWF0ZSgpIGluc3RlYWQuIFVuZm9y dHVuYXRlbHksIHRoaXMgaW52b2x2ZXMgYSBsb3QKKyAgICAgICAgb2YgZXh0cmEgY2FzdHMgYnV0 IHRoZSBlbmQgcmVzdWx0IGlzIGNvcnJlY3QuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1MjQwCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lw cGVkOgorCiAyMDEwLTA5LTA1ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWls LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNjY4MDEuCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vcXQvU2tpcHBlZAppbmRleCA5YzkyMTBiOTM2NDdkYTU1OGU2MWVjYjQxZGFjZDcxMWI5Mzc4 M2NmLi5iMzUwM2M4ODk0NTg2ZDFlMjRjZjA4YzVhODhjOTZmMGVhYTBjN2I2IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL3F0L1NraXBwZWQKQEAgLTE4MSwxMSArMTgxLDYgQEAgaHR0cC90ZXN0cy9zZWN1cml0eS9m cmFtZU5hdmlnYXRpb24vbm90LW9wZW5lci5odG1sCiAjIG1pc3Npbmcgb3JpZ2luIGhlYWRlcgog aHR0cC90ZXN0cy9zZWN1cml0eS9vcmlnaW5IZWFkZXIvb3JpZ2luLWhlYWRlci1mb3ItZW1wdHku aHRtbAogCi0jIFBvc3NpYmx5IHJlbGF0ZWQgdG8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM1MjYzCi0jIGFyZSB3ZSB1dGYtZW5jb2RpbmcgYSBzdHJpbmcgdHdpY2Ug b3Zlcj8KLWh0dHAvdGVzdHMvc2VjdXJpdHkveHNzQXVkaXRvci9lbWJlZC10YWctbnVsbC1jaGFy Lmh0bWwKLWh0dHAvdGVzdHMvc2VjdXJpdHkveHNzQXVkaXRvci9vYmplY3QtZW1iZWQtdGFnLW51 bGwtY2hhci5odG1sCi0KICMgRGlzYWJsZWQgSFRUUCBzdWJkaXJzIGZvciBub3csIG5lZWRzIGlu dmVzdGlnYXRpb24uCiBodHRwL3Rlc3RzL21lZGlhCiBodHRwL3Rlc3RzL3dtbAo=