45235 2010-09-04 15:46:03 -0700 [GTK] EventSender should support modifier keys with mouseDown and mouseUp events 2010-09-06 08:17:24 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 45233 38656 1 mrobinson webkit-unassigned abarth eric gustavo ojan tonikitoo webkit.review.bot xan.lopez oldest_to_newest 274396 0 mrobinson 2010-09-04 15:46:03 -0700 The EventSender currently ignores modifier key arguments to these methods. 274397 1 66592 mrobinson 2010-09-04 15:51:17 -0700 Created attachment 66592 Add modifier support to mouseDown and mouseUp 274418 2 66592 xan.lopez 2010-09-04 23:42:13 -0700 Comment on attachment 66592 Add modifier support to mouseDown and mouseUp You sir are a gentleman and a scholar. 274627 3 66592 mrobinson 2010-09-06 07:44:50 -0700 Comment on attachment 66592 Add modifier support to mouseDown and mouseUp Clearing flags on attachment: 66592 Committed r66829: <http://trac.webkit.org/changeset/66829> 274628 4 mrobinson 2010-09-06 07:44:55 -0700 All reviewed patches have been landed. Closing bug. 274642 5 webkit.review.bot 2010-09-06 08:17:24 -0700 http://trac.webkit.org/changeset/66829 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/66827 http://trac.webkit.org/changeset/66828 http://trac.webkit.org/changeset/66829 66592 2010-09-04 15:51:17 -0700 2010-09-06 07:44:50 -0700 Add modifier support to mouseDown and mouseUp bug-45235-20100904155118.patch text/plain 7206 mrobinson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhYjI4ZTdjZWMzMmYwMTkzZmEwN2UzMWNmZTA4YTk4NTUyZTBmZGFkLi43ZGVjNzY1 MGRmNTgwZTNjY2Q5MWZkMjkzM2EzMDQyYmFiMDdjN2Q1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTUgQEAK IAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBbR1RLXSBF dmVudFNlbmRlciBzaG91bGQgc3VwcG9ydCBtb2RpZmllciBrZXlzIHdpdGggbW91c2VEb3duIGFu ZCBtb3VzZVVwIGV2ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDUyMzUKKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lwcGVkOiBVbnNraXAg YSB0ZXN0IHdoaWNoIGlzIG5vdyBwYXNzaW5nLgorCisyMDEwLTA5LTA0ICBNYXJ0aW4gUm9iaW5z b24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKwogICAgICAgICBDb252ZXJ0IGVkaXRpbmcvc2VsZWN0aW9uL3NoaWZ0LWNsaWNr Lmh0bWwgdG8gdXNlIHNldEVkaXRpbmdCZWhhdmlvcgogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDUyMzMKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ3RrL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZApp bmRleCA4N2VmZTJmZWZhODkxZmUwZjgwZGM4NzIwNzYyNDQ3NGZjNmZlNDdmLi5lODdmMDBkMzQw M2NlMGRhMDgyZTQyMDViZGQ2NWJiMmJhZjNmNWQ4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9ndGsvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBl ZApAQCAtNTU2OCw5ICs1NTY4LDYgQEAgaW5zcGVjdG9yL3RpbWVsaW5lLXBhcnNlLWh0bWwuaHRt bAogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg1NjkKIGh0dHAv dGVzdHMvd29ya2Vycy90ZXh0LWVuY29kaW5nLmh0bWwKIAotIyBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg2NTYKLWVkaXRpbmcvc2VsZWN0aW9uL3NoaWZ0LWNsaWNr Lmh0bWwKLQogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzEzMDIK IGZhc3QvY3NzL2ZvbnQtZmFjZS13b2ZmLmh0bWwgCiAKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xz L0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCAxMmJlNWU1N2I3ZDM5OTVj MTI5MjAwMWU4MjRhZDdiYmI5MmYyMmRmLi5mOGQyZDIxMDJmMWYxZmE4MDk5OTM0NTU5MTBkNDlj NzhhOWVhYWQyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0 VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDktMDQgIE1hcnRpbiBSb2Jp bnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEV2ZW50U2VuZGVyIHNob3VsZCBzdXBwb3J0IG1v ZGlmaWVyIGtleXMgd2l0aCBtb3VzZURvd24gYW5kIG1vdXNlVXAgZXZlbnRzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTIzNQorCisgICAgICAgIEFk ZCBzdXBwb3J0IGZvciBpbnRlcnByZXRpbmcgdGhlIG1vZGlmaWVyIGtleSBhcmd1bWVudHMgdG8g dGhlIG1vdXNlRG93biBhbmQgbW91c2VVcAorICAgICAgICBtZXRob2RzIG9mIHRoZSBFdmVudFNl bmRlci4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHA6Cisg ICAgICAgIChwcmVwYXJlTW91c2VCdXR0b25FdmVudCk6IEFsbG93IHBhc3NpbmcgaW4gYSBtb2Rp ZmllciBiaXRtYXNrLCB3aGljaCB3aWxsIGJlIE9SJ2QKKyAgICAgICAgd2l0aCB0aGUgY3VycmVu dCBtb2RpZmllcnMuCisgICAgICAgIChjb250ZXh0Q2xpY2tDYWxsYmFjayk6IEFsd2F5cyBzZW5k IG5vIG1vZGlmaWVycyB3aGVuIHByZXBhcmluZyB0aGUgbW91c2UgZXZlbnQuCisgICAgICAgIChn ZGtNb2RpZmVyc0Zyb21KU1ZhbHVlKTogQWRkZWQsIGNvbnZlcnRzIGEgSlNWYWx1ZSBhcnJheSBp bnRvIGEgR0RLIG1vZGlmaWVyIGJpdG1hc2suCisgICAgICAgIChtb3VzZURvd25DYWxsYmFjayk6 IFNlbmQgaW4gdGhlIHJlcXVlc3RlZCBtb2RpZmllcnMgdG8gcHJlcGFyZU1vdXNlQnV0dG9uRXZl bnQuCisgICAgICAgIChtb3VzZVVwQ2FsbGJhY2spOiBEaXR0by4KKwogMjAxMC0wOS0wMyAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBZGFtIFJvYmVuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3Rr L0V2ZW50U2VuZGVyLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNl bmRlci5jcHAKaW5kZXggNjNhNGI4MWNkM2IwNDI1YTUzZjkwZThiZWYzNDM3NDQ5YjcyMWIxMy4u ZmMxMThiY2FjN2NhMjMzZDQ3YjczODczOGYzYmRjMDJiYzA5ZThkNSAxMDA2NDQKLS0tIGEvV2Vi S2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcAorKysgYi9XZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwCkBAIC0xMTAsNyArMTEwLDcg QEAgc3RhdGljIEpTVmFsdWVSZWYgbGVhcEZvcndhcmRDYWxsYmFjayhKU0NvbnRleHRSZWYgY29u dGV4dCwgSlNPYmplY3RSZWYgZnVuY3Rpb24KICAgICByZXR1cm4gSlNWYWx1ZU1ha2VVbmRlZmlu ZWQoY29udGV4dCk7CiB9CiAKLWJvb2wgcHJlcGFyZU1vdXNlQnV0dG9uRXZlbnQoR2RrRXZlbnQq IGV2ZW50LCBpbnQgZXZlbnRTZW5kZXJCdXR0b25OdW1iZXIpCitib29sIHByZXBhcmVNb3VzZUJ1 dHRvbkV2ZW50KEdka0V2ZW50KiBldmVudCwgaW50IGV2ZW50U2VuZGVyQnV0dG9uTnVtYmVyLCBn dWludCBtb2RpZmllcnMpCiB7CiAgICAgV2ViS2l0V2ViVmlldyogdmlldyA9IHdlYmtpdF93ZWJf ZnJhbWVfZ2V0X3dlYl92aWV3KG1haW5GcmFtZSk7CiAgICAgaWYgKCF2aWV3KQpAQCAtMTMzLDcg KzEzMyw3IEBAIGJvb2wgcHJlcGFyZU1vdXNlQnV0dG9uRXZlbnQoR2RrRXZlbnQqIGV2ZW50LCBp bnQgZXZlbnRTZW5kZXJCdXR0b25OdW1iZXIpCiAgICAgZXZlbnQtPmJ1dHRvbi53aW5kb3cgPSBn dGtfd2lkZ2V0X2dldF93aW5kb3coR1RLX1dJREdFVCh2aWV3KSk7CiAgICAgZ19vYmplY3RfcmVm KGV2ZW50LT5idXR0b24ud2luZG93KTsKICAgICBldmVudC0+YnV0dG9uLmRldmljZSA9IGdldERl ZmF1bHRHREtQb2ludGVyRGV2aWNlKGV2ZW50LT5idXR0b24ud2luZG93KTsKLSAgICBldmVudC0+ YnV0dG9uLnN0YXRlID0gZ2V0U3RhdGVGbGFncygpOworICAgIGV2ZW50LT5idXR0b24uc3RhdGUg PSBtb2RpZmllcnMgfCBnZXRTdGF0ZUZsYWdzKCk7CiAgICAgZXZlbnQtPmJ1dHRvbi50aW1lID0g R0RLX0NVUlJFTlRfVElNRTsKICAgICBldmVudC0+YnV0dG9uLmF4ZXMgPSAwOwogCkBAIC0xNDgs NyArMTQ4LDcgQEAgYm9vbCBwcmVwYXJlTW91c2VCdXR0b25FdmVudChHZGtFdmVudCogZXZlbnQs IGludCBldmVudFNlbmRlckJ1dHRvbk51bWJlcikKIHN0YXRpYyBKU1ZhbHVlUmVmIGNvbnRleHRD bGlja0NhbGxiYWNrKEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU09iamVjdFJlZiBmdW5jdGlvbiwg SlNPYmplY3RSZWYgdGhpc09iamVjdCwgc2l6ZV90IGFyZ3VtZW50Q291bnQsIGNvbnN0IEpTVmFs dWVSZWYgYXJndW1lbnRzW10sIEpTVmFsdWVSZWYqIGV4Y2VwdGlvbikKIHsKICAgICBHZGtFdmVu dCogcHJlc3NFdmVudCA9IGdka19ldmVudF9uZXcoR0RLX0JVVFRPTl9QUkVTUyk7Ci0gICAgaWYg KCFwcmVwYXJlTW91c2VCdXR0b25FdmVudChwcmVzc0V2ZW50LCAyKSkKKyAgICBpZiAoIXByZXBh cmVNb3VzZUJ1dHRvbkV2ZW50KHByZXNzRXZlbnQsIDIsIDApKQogICAgICAgICByZXR1cm4gSlNW YWx1ZU1ha2VVbmRlZmluZWQoY29udGV4dCk7CiAKICAgICBHZGtFdmVudCogcmVsZWFzZUV2ZW50 ID0gZ2RrX2V2ZW50X2NvcHkocHJlc3NFdmVudCk7CkBAIC0xNzAsNiArMTcwLDM2IEBAIHN0YXRp YyB2b2lkIHVwZGF0ZUNsaWNrQ291bnQoaW50IGJ1dHRvbikKICAgICAgICAgY2xpY2tDb3VudCsr OwogfQogCitzdGF0aWMgZ3VpbnQgZ2RrTW9kaWZlcnNGcm9tSlNWYWx1ZShKU0NvbnRleHRSZWYg Y29udGV4dCwgY29uc3QgSlNWYWx1ZVJlZiBtb2RpZmllcnMpCit7CisgICAgSlNPYmplY3RSZWYg bW9kaWZpZXJzQXJyYXkgPSBKU1ZhbHVlVG9PYmplY3QoY29udGV4dCwgbW9kaWZpZXJzLCAwKTsK KyAgICBpZiAoIW1vZGlmaWVyc0FycmF5KQorICAgICAgICByZXR1cm4gMDsKKworICAgIGd1aW50 IGdka01vZGlmaWVycyA9IDA7CisgICAgaW50IG1vZGlmaWVyc0NvdW50ID0gSlNWYWx1ZVRvTnVt YmVyKGNvbnRleHQsIEpTT2JqZWN0R2V0UHJvcGVydHkoY29udGV4dCwgbW9kaWZpZXJzQXJyYXks IEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJsZW5ndGgiKSwgMCksIDApOworICAgIGZv ciAoaW50IGkgPSAwOyBpIDwgbW9kaWZpZXJzQ291bnQ7ICsraSkgeworICAgICAgICBKU1ZhbHVl UmVmIHZhbHVlID0gSlNPYmplY3RHZXRQcm9wZXJ0eUF0SW5kZXgoY29udGV4dCwgbW9kaWZpZXJz QXJyYXksIGksIDApOworICAgICAgICBKU1N0cmluZ1JlZiBzdHJpbmcgPSBKU1ZhbHVlVG9TdHJp bmdDb3B5KGNvbnRleHQsIHZhbHVlLCAwKTsKKyAgICAgICAgaWYgKEpTU3RyaW5nSXNFcXVhbFRv VVRGOENTdHJpbmcoc3RyaW5nLCAiY3RybEtleSIpCisgICAgICAgICAgICB8fCBKU1N0cmluZ0lz RXF1YWxUb1VURjhDU3RyaW5nKHN0cmluZywgImFkZFNlbGVjdGlvbktleSIpKQorICAgICAgICAg ICAgZ2RrTW9kaWZpZXJzIHw9IEdES19DT05UUk9MX01BU0s7CisgICAgICAgIGVsc2UgaWYgKEpT U3RyaW5nSXNFcXVhbFRvVVRGOENTdHJpbmcoc3RyaW5nLCAic2hpZnRLZXkiKQorICAgICAgICAg ICAgICAgICB8fCBKU1N0cmluZ0lzRXF1YWxUb1VURjhDU3RyaW5nKHN0cmluZywgInJhbmdlU2Vs ZWN0aW9uS2V5IikpCisgICAgICAgICAgICBnZGtNb2RpZmllcnMgfD0gR0RLX1NISUZUX01BU0s7 CisgICAgICAgIGVsc2UgaWYgKEpTU3RyaW5nSXNFcXVhbFRvVVRGOENTdHJpbmcoc3RyaW5nLCAi YWx0S2V5IikpCisgICAgICAgICAgICBnZGtNb2RpZmllcnMgfD0gR0RLX01PRDFfTUFTSzsKKwor ICAgICAgICAvLyBDdXJyZW50bHkgdGhlIG1ldGFLZXkgYXMgZGVmaW5lZCBpbiBXZWJDb3JlL3Bs YXRmb3JtL2d0ay9Nb3VzZUV2ZW50R3RrLmNwcAorICAgICAgICAvLyBpcyBHREtfTU9EMl9NQVNL LiBUaGlzIGNvZGUgbXVzdCBiZSBrZXB0IGluIHN5bmMgd2l0aCB0aGF0IGZpbGUuCisgICAgICAg IGVsc2UgaWYgKEpTU3RyaW5nSXNFcXVhbFRvVVRGOENTdHJpbmcoc3RyaW5nLCAibWV0YUtleSIp KQorICAgICAgICAgICAgZ2RrTW9kaWZpZXJzIHw9IEdES19NT0QyX01BU0s7CisKKyAgICAgICAg SlNTdHJpbmdSZWxlYXNlKHN0cmluZyk7CisgICAgfQorICAgIHJldHVybiBnZGtNb2RpZmllcnM7 Cit9CisKIHN0YXRpYyBKU1ZhbHVlUmVmIG1vdXNlRG93bkNhbGxiYWNrKEpTQ29udGV4dFJlZiBj b250ZXh0LCBKU09iamVjdFJlZiBmdW5jdGlvbiwgSlNPYmplY3RSZWYgdGhpc09iamVjdCwgc2l6 ZV90IGFyZ3VtZW50Q291bnQsIGNvbnN0IEpTVmFsdWVSZWYgYXJndW1lbnRzW10sIEpTVmFsdWVS ZWYqIGV4Y2VwdGlvbikKIHsKICAgICBpbnQgYnV0dG9uID0gMDsKQEAgLTE3Nyw5ICsyMDcsMTAg QEAgc3RhdGljIEpTVmFsdWVSZWYgbW91c2VEb3duQ2FsbGJhY2soSlNDb250ZXh0UmVmIGNvbnRl eHQsIEpTT2JqZWN0UmVmIGZ1bmN0aW9uLAogICAgICAgICBidXR0b24gPSBzdGF0aWNfY2FzdDxp bnQ+KEpTVmFsdWVUb051bWJlcihjb250ZXh0LCBhcmd1bWVudHNbMF0sIGV4Y2VwdGlvbikpOwog ICAgICAgICBnX3JldHVybl92YWxfaWZfZmFpbCgoIWV4Y2VwdGlvbiB8fCAhKmV4Y2VwdGlvbiks IEpTVmFsdWVNYWtlVW5kZWZpbmVkKGNvbnRleHQpKTsKICAgICB9CisgICAgZ3VpbnQgbW9kaWZp ZXJzID0gYXJndW1lbnRDb3VudCA+PSAyID8gZ2RrTW9kaWZlcnNGcm9tSlNWYWx1ZShjb250ZXh0 LCBhcmd1bWVudHNbMV0pIDogMDsKIAogICAgIEdka0V2ZW50KiBldmVudCA9IGdka19ldmVudF9u ZXcoR0RLX0JVVFRPTl9QUkVTUyk7Ci0gICAgaWYgKCFwcmVwYXJlTW91c2VCdXR0b25FdmVudChl dmVudCwgYnV0dG9uKSkKKyAgICBpZiAoIXByZXBhcmVNb3VzZUJ1dHRvbkV2ZW50KGV2ZW50LCBi dXR0b24sIG1vZGlmaWVycykpCiAgICAgICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVmaW5lZChj b250ZXh0KTsKIAogICAgIGJ1dHRvbkN1cnJlbnRseURvd24gPSBldmVudC0+YnV0dG9uLmJ1dHRv bjsKQEAgLTIyMCw5ICsyNTEsMTAgQEAgc3RhdGljIEpTVmFsdWVSZWYgbW91c2VVcENhbGxiYWNr KEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU09iamVjdFJlZiBmdW5jdGlvbiwgSlMKICAgICAgICAg YnV0dG9uID0gc3RhdGljX2Nhc3Q8aW50PihKU1ZhbHVlVG9OdW1iZXIoY29udGV4dCwgYXJndW1l bnRzWzBdLCBleGNlcHRpb24pKTsKICAgICAgICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwoKCFleGNl cHRpb24gfHwgISpleGNlcHRpb24pLCBKU1ZhbHVlTWFrZVVuZGVmaW5lZChjb250ZXh0KSk7CiAg ICAgfQorICAgIGd1aW50IG1vZGlmaWVycyA9IGFyZ3VtZW50Q291bnQgPj0gMiA/IGdka01vZGlm ZXJzRnJvbUpTVmFsdWUoY29udGV4dCwgYXJndW1lbnRzWzFdKSA6IDA7CiAKICAgICBHZGtFdmVu dCogZXZlbnQgPSBnZGtfZXZlbnRfbmV3KEdES19CVVRUT05fUkVMRUFTRSk7Ci0gICAgaWYgKCFw cmVwYXJlTW91c2VCdXR0b25FdmVudChldmVudCwgYnV0dG9uKSkKKyAgICBpZiAoIXByZXBhcmVN b3VzZUJ1dHRvbkV2ZW50KGV2ZW50LCBidXR0b24sIG1vZGlmaWVycykpCiAgICAgICAgIHJldHVy biBKU1ZhbHVlTWFrZVVuZGVmaW5lZChjb250ZXh0KTsKIAogICAgIGxhc3RDbGlja1Bvc2l0aW9u WCA9IGxhc3RNb3VzZVBvc2l0aW9uWDsK