45233 2010-09-04 15:36:51 -0700 Convert editing/selection/shift-click.html to use setEditingBehavior 2010-09-06 08:17:18 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Normal --- 38656 45235 1 mrobinson webkit-unassigned abarth eric ojan tonikitoo webkit.review.bot oldest_to_newest 274392 0 mrobinson 2010-09-04 15:36:51 -0700 This test currently looks at the user-agent to figure out what the editing behavior should be. This patch tracks converting the test to test all editing styles and remove platform specific expected results. 274393 1 66590 mrobinson 2010-09-04 15:39:59 -0700 Created attachment 66590 Test conversion 274444 2 66590 tonikitoo 2010-09-05 10:33:52 -0700 Comment on attachment 66590 Test conversion Perfect! 274624 3 66590 mrobinson 2010-09-06 07:42:45 -0700 Comment on attachment 66590 Test conversion Clearing flags on attachment: 66590 Committed r66828: <http://trac.webkit.org/changeset/66828> 274625 4 mrobinson 2010-09-06 07:42:50 -0700 All reviewed patches have been landed. Closing bug. 274641 5 webkit.review.bot 2010-09-06 08:17:18 -0700 http://trac.webkit.org/changeset/66828 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/66827 http://trac.webkit.org/changeset/66828 http://trac.webkit.org/changeset/66829 66590 2010-09-04 15:39:59 -0700 2010-09-06 07:42:45 -0700 Test conversion bug-45233-20100904154000.patch text/plain 7096 mrobinson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhZGFkOWU4NjIxOWU5YTQ3OTk4MjcwMWZlYTY1OWU1M2NhMTZlMWNmLi5hYjI4ZTdj ZWMzMmYwMTkzZmEwN2UzMWNmZTA4YTk4NTUyZTBmZGFkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTAtMDktMDQgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbnZlcnQgZWRp dGluZy9zZWxlY3Rpb24vc2hpZnQtY2xpY2suaHRtbCB0byB1c2Ugc2V0RWRpdGluZ0JlaGF2aW9y CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTIzMwor CisgICAgICAgICogZWRpdGluZy9zZWxlY3Rpb24vc2NyaXB0LXRlc3RzL3NoaWZ0LWNsaWNrLmpz OgorICAgICAgICAoc2hpZnRDbGljayk6IFRha2Ugb25seSBvbmUgZXhwZWN0ZWQgc3RyaW5nLgor ICAgICAgICAoYXNzZXJ0U2VsZWN0aW9uU3RyaW5nKTogVGFrZSBvbmx5IG9uZSBleHBlY3RlZCBz dHJpbmcuCisgICAgICAgIChydW5TaGlmdENsaWNrVGVzdCk6IEFkZGVkLiBSdW5zIHRoZSB0ZXN0 IHdpdGggYSBwYXJ0aWN1bGFyIGVkaXRpbmcgYmVoYXZpb3IuCisgICAgICAgICogZWRpdGluZy9z ZWxlY3Rpb24vc2hpZnQtY2xpY2stZXhwZWN0ZWQudHh0OiBVcGRhdGVkIHRvIHJlZmxlY3QgbmV3 IHJlc3VsdHMuCisgICAgICAgICogcGxhdGZvcm0vd2luL2VkaXRpbmcvc2VsZWN0aW9uL3NoaWZ0 LWNsaWNrLWV4cGVjdGVkLnR4dDogUmVtb3ZlZC4KKwogMjAxMC0wOS0wNCAgSnVzdGluIFNjaHVo ICA8anNjaHVoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLiBCdWlsZCBmaXgu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9zY3JpcHQtdGVzdHMv c2hpZnQtY2xpY2suanMgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9zY3JpcHQtdGVz dHMvc2hpZnQtY2xpY2suanMKaW5kZXggY2RlMjg1ZmFlYTA2Nzc3NWM5ZDdiOTQ1Y2NjYTcxNGI3 NDExOTMyYS4uY2E0OTgxNDkzOWE0OWQ4YTZmN2IzMGI4M2YwYjhmZWI2NzQ4MmJhOSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vc2NyaXB0LXRlc3RzL3NoaWZ0LWNs aWNrLmpzCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL3NjcmlwdC10ZXN0cy9z aGlmdC1jbGljay5qcwpAQCAtMTEsMTkgKzExLDE2IEBAIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hp bGQoc2Vjb25kKTsKIHZhciBzdGFydCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdzdGFydCcp OwogdmFyIGVuZCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdlbmQnKTsKIAotZnVuY3Rpb24g c2hpZnRDbGljayh4LCB5LCBtYWNFeHBlY3RlZCwgb3RoZXJFeHBlY3RlZCkKK2Z1bmN0aW9uIHNo aWZ0Q2xpY2soeCwgeSwgZXhwZWN0ZWQpCiB7CiAgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8o eCwgeSk7CiAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKDAsIFsnc2hpZnRLZXknXSk7CiAgICAg ZXZlbnRTZW5kZXIubW91c2VVcCgwLCBbJ3NoaWZ0S2V5J10pOwotICAgIGFzc2VydFNlbGVjdGlv blN0cmluZyhtYWNFeHBlY3RlZCwgb3RoZXJFeHBlY3RlZCk7CisgICAgYXNzZXJ0U2VsZWN0aW9u U3RyaW5nKGV4cGVjdGVkKTsKIH0KIAotdmFyIG9uTWFjID0gbmF2aWdhdG9yLnVzZXJBZ2VudC5z ZWFyY2goL1xiTWFjIE9TIFhcYi8pICE9IC0xOwotCi1mdW5jdGlvbiBhc3NlcnRTZWxlY3Rpb25T dHJpbmcobWFjRXhwZWN0ZWQsIG90aGVyRXhwZWN0ZWQpCitmdW5jdGlvbiBhc3NlcnRTZWxlY3Rp b25TdHJpbmcoZXhwZWN0ZWQpCiB7Ci0gICAgdmFyIGV4cGVjdGVkID0gb25NYWMgPyBtYWNFeHBl Y3RlZCA6IG90aGVyRXhwZWN0ZWQ7CiAgICAgaWYgKHdpbmRvdy5nZXRTZWxlY3Rpb24oKS50b1N0 cmluZygpID09IGV4cGVjdGVkKQogICAgICAgICB0ZXN0UGFzc2VkKCd3aW5kb3cuZ2V0U2VsZWN0 aW9uKCkudG9TdHJpbmcoKSBpcyBjb3JyZWN0Jyk7CiAgICAgZWxzZQpAQCAtNDUsOSArNDIsMTIg QEAgZnVuY3Rpb24gYXNzZXJ0U2VsZWN0aW9uT3JkZXIoZGlyZWN0aW9uKQogICAgICAgICB0ZXN0 RmFpbGVkKCJTZWxlY3Rpb24gZGlyZWN0aW9uIGlzIG5vdCBjb3JyZWN0LiBFeHBlY3RlZCBhICIg KyBkaXJlY3Rpb24gKyAiIHNlbGVjdGlvbi4iICsgc2VsZWN0aW9uQXNTdHJpbmcoc2VsKSk7CiB9 CiAKLS8vIERvdWJsZS1jbGljayBzZWxlY3QgdG8gZ2V0IGFyb3VuZCBldmVudFNlbmRlciBidWcg d2hlcmUgaXQgd29uJ3Qgc2VsZWN0Ci0vLyB0ZXh0IGp1c3QgdXNpbmcgc2luZ2xlLWNsaWNrLgot aWYgKHdpbmRvdy5ldmVudFNlbmRlcikgeworZnVuY3Rpb24gcnVuU2hpZnRDbGlja1Rlc3QoZWRp dGluZ0JlaGF2aW9yKQoreworICAgIGxheW91dFRlc3RDb250cm9sbGVyLnNldEVkaXRpbmdCZWhh dmlvcihlZGl0aW5nQmVoYXZpb3IpOworCisgICAgLy8gRG91YmxlLWNsaWNrIHNlbGVjdCB0byBn ZXQgYXJvdW5kIGV2ZW50U2VuZGVyIGJ1ZyB3aGVyZSBpdCB3b24ndCBzZWxlY3QKKyAgICAvLyB0 ZXh0IGp1c3QgdXNpbmcgc2luZ2xlLWNsaWNrLgogICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRv KHN0YXJ0Lm9mZnNldExlZnQsIHN0YXJ0Lm9mZnNldFRvcCk7CiAgICAgZXZlbnRTZW5kZXIubW91 c2VEb3duKCk7CiAgICAgZXZlbnRTZW5kZXIubW91c2VVcCgpOwpAQCAtNTYsMjQgKzU2LDM2IEBA IGlmICh3aW5kb3cuZXZlbnRTZW5kZXIpIHsKICAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhl bmQub2Zmc2V0TGVmdCwgZW5kLm9mZnNldFRvcCk7CiAgICAgZXZlbnRTZW5kZXIubW91c2VVcCgp OwogCi0gICAgYXNzZXJ0U2VsZWN0aW9uU3RyaW5nKCd0d28gdGhyZWVcbmZvdXIgZml2ZScsICd0 d28gdGhyZWVcbmZvdXIgZml2ZScpCisgICAgYXNzZXJ0U2VsZWN0aW9uU3RyaW5nKCd0d28gdGhy ZWVcbmZvdXIgZml2ZScpOwogICAgIGFzc2VydFNlbGVjdGlvbk9yZGVyKCdmb3J3YXJkJyk7CiAK LSAgICBzaGlmdENsaWNrKHNlY29uZC5vZmZzZXRMZWZ0ICsgc2Vjb25kLm9mZnNldFdpZHRoLCBz ZWNvbmQub2Zmc2V0VG9wLCAndHdvIHRocmVlXG5mb3VyIGZpdmUgc2l4JywgJ3R3byB0aHJlZVxu Zm91ciBmaXZlIHNpeCcpOworICAgIHNoaWZ0Q2xpY2soc2Vjb25kLm9mZnNldExlZnQgKyBzZWNv bmQub2Zmc2V0V2lkdGgsIHNlY29uZC5vZmZzZXRUb3AsICd0d28gdGhyZWVcbmZvdXIgZml2ZSBz aXgnKTsKICAgICBhc3NlcnRTZWxlY3Rpb25PcmRlcignZm9yd2FyZCcpOwotICAgICAgICAKLSAg ICBzaGlmdENsaWNrKGVuZC5vZmZzZXRMZWZ0LCBlbmQub2Zmc2V0VG9wLCAndHdvIHRocmVlXG5m b3VyIGZpdmUnLCAndHdvIHRocmVlXG5mb3VyIGZpdmUnKTsKKworICAgIHNoaWZ0Q2xpY2soZW5k Lm9mZnNldExlZnQsIGVuZC5vZmZzZXRUb3AsICd0d28gdGhyZWVcbmZvdXIgZml2ZScpOwogICAg IGFzc2VydFNlbGVjdGlvbk9yZGVyKCdmb3J3YXJkJyk7CiAKICAgICAvLyBUaGVzZSB0d28gZmFp bCBvbiBNYWMgZHVlIHRvIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z NjI1Ni4KICAgICAvLyBJbiB0aGUgZmlyc3Qgc2hpZnRDbGljayBjYWxsLCB0aGUgc3BhY2UgYWZ0 ZXIgZml2ZSBpcyBzZWxlY3RlZCBhbmQgc2hvdWxkbid0IGJlLgogICAgIC8vIEluIHRoZSBzZWNv bmQgc2hpZnRDbGljayBjYWxsLCAic2l4IiBpcyBzZWxlY3RlZCBhbmQgc2hvdWxkbid0IGJlLgot ICAgIHNoaWZ0Q2xpY2soZmlyc3Qub2Zmc2V0TGVmdCwgZmlyc3Qub2Zmc2V0VG9wLCAnb25lIHR3 byB0aHJlZVxuZm91ciBmaXZlJywgJ29uZSB0d28nKTsKKyAgICBpZiAoZWRpdGluZ0JlaGF2aW9y ID09ICJtYWMiKQorICAgICAgICBzaGlmdENsaWNrKGZpcnN0Lm9mZnNldExlZnQsIGZpcnN0Lm9m ZnNldFRvcCwgJ29uZSB0d28gdGhyZWVcbmZvdXIgZml2ZScpOworICAgIGVsc2UKKyAgICAgICAg c2hpZnRDbGljayhmaXJzdC5vZmZzZXRMZWZ0LCBmaXJzdC5vZmZzZXRUb3AsICdvbmUgdHdvJyk7 CiAgICAgYXNzZXJ0U2VsZWN0aW9uT3JkZXIoJ2JhY2t3YXJkJyk7CiAKLSAgICBzaGlmdENsaWNr KHN0YXJ0Lm9mZnNldExlZnQsIHN0YXJ0Lm9mZnNldFRvcCwgJ3R3byB0aHJlZVxuZm91ciBmaXZl JywgJ3R3bycpOworICAgIGlmIChlZGl0aW5nQmVoYXZpb3IgPT0gIm1hYyIpCisgICAgICAgIHNo aWZ0Q2xpY2soc3RhcnQub2Zmc2V0TGVmdCwgc3RhcnQub2Zmc2V0VG9wLCAndHdvIHRocmVlXG5m b3VyIGZpdmUnKTsKKyAgICBlbHNlCisgICAgICAgIHNoaWZ0Q2xpY2soc3RhcnQub2Zmc2V0TGVm dCwgc3RhcnQub2Zmc2V0VG9wLCAndHdvJyk7CisKICAgICAvLyBGSVhNRTogVGhlIHNlbGVjdGlv biBkaXJlY3Rpb24gaXMgaW5jb3JyZWN0IG9uIFdpbi9MaW51eCBoZXJlLiBJdCBzaG91bGQgYmUg YmFja3dhcmQuCiAgICAgYXNzZXJ0U2VsZWN0aW9uT3JkZXIoJ2JhY2t3YXJkJyk7CiB9CiAKK2lm ICh3aW5kb3cuZXZlbnRTZW5kZXIpIHsKKyAgICBydW5TaGlmdENsaWNrVGVzdCgibWFjIik7Cisg ICAgcnVuU2hpZnRDbGlja1Rlc3QoIndpbiIpOworfQorCiB2YXIgc3VjY2Vzc2Z1bGx5UGFyc2Vk ID0gdHJ1ZTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL3NoaWZ0 LWNsaWNrLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL3NoaWZ0 LWNsaWNrLWV4cGVjdGVkLnR4dAppbmRleCBhYTE0YzZkYjYyOTMxOGNjY2M1YjMyNWI4MzY2Yjg4 OGU3NTJlNWE2Li4zYWE4ZmM0YTQxYTk1MzU1ODE1NjVjMjY0OGU3ZGJiMDhjOWViY2E1IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9zaGlmdC1jbGljay1leHBlY3Rl ZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vc2hpZnQtY2xpY2stZXhw ZWN0ZWQudHh0CkBAIC0xNyw2ICsxNywxNiBAQCBGQUlMIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS50 b1N0cmluZygpIGlzICJ0d28gdGhyZWUKIGZvdXIgZml2ZSBzaXgiIGFuZCBzaG91bGQgYmUgInR3 byB0aHJlZQogZm91ciBmaXZlIgogUEFTUyBTZWxlY3Rpb24gZGlyZWN0aW9uIGlzIGNvcnJlY3Qu CitQQVNTIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS50b1N0cmluZygpIGlzIGNvcnJlY3QKK1BBU1Mg U2VsZWN0aW9uIGRpcmVjdGlvbiBpcyBjb3JyZWN0LgorUEFTUyB3aW5kb3cuZ2V0U2VsZWN0aW9u KCkudG9TdHJpbmcoKSBpcyBjb3JyZWN0CitQQVNTIFNlbGVjdGlvbiBkaXJlY3Rpb24gaXMgY29y cmVjdC4KK1BBU1Mgd2luZG93LmdldFNlbGVjdGlvbigpLnRvU3RyaW5nKCkgaXMgY29ycmVjdAor UEFTUyBTZWxlY3Rpb24gZGlyZWN0aW9uIGlzIGNvcnJlY3QuCitQQVNTIHdpbmRvdy5nZXRTZWxl Y3Rpb24oKS50b1N0cmluZygpIGlzIGNvcnJlY3QKK1BBU1MgU2VsZWN0aW9uIGRpcmVjdGlvbiBp cyBjb3JyZWN0LgorUEFTUyB3aW5kb3cuZ2V0U2VsZWN0aW9uKCkudG9TdHJpbmcoKSBpcyBjb3Jy ZWN0CitGQUlMIFNlbGVjdGlvbiBkaXJlY3Rpb24gaXMgbm90IGNvcnJlY3QuIEV4cGVjdGVkIGEg YmFja3dhcmQgc2VsZWN0aW9uLlthbmNob3JOb2RlOiBbb2JqZWN0IFRleHRdKHR3byB0aHJlZSkg YW5jaG9yT2Zmc2V0OiAwIGZvY3VzTm9kZTogW29iamVjdCBUZXh0XSh0d28gdGhyZWUpIGZvY3Vz T2Zmc2V0OiAzIGlzQ29sbGFwc2VkOiBmYWxzZV0KIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlz IHRydWUKIAogVEVTVCBDT01QTEVURQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v d2luL2VkaXRpbmcvc2VsZWN0aW9uL3NoaWZ0LWNsaWNrLWV4cGVjdGVkLnR4dCBiL0xheW91dFRl c3RzL3BsYXRmb3JtL3dpbi9lZGl0aW5nL3NlbGVjdGlvbi9zaGlmdC1jbGljay1leHBlY3RlZC50 eHQKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IGQxYzA4NTBlZWQ4ZTU0NjY5MWEzMzVh MjEzMjFmOTk5ZGViM2RlZjUuLjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2VkaXRpbmcvc2VsZWN0aW9uL3NoaWZ0 LWNsaWNrLWV4cGVjdGVkLnR4dAorKysgL2Rldi9udWxsCkBAIC0xLDIwICswLDAgQEAKLVRlc3Rz IHRoYXQgc2hpZnQrY2xpY2tpbmcgZG9lcyB0aGUgcGxhdGZvcm0gY29ycmVjdCBiZWhhdmlvci4K LQotT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywg Zm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgotCi0KLVBBU1Mgd2luZG93LmdldFNlbGVjdGlv bigpLnRvU3RyaW5nKCkgaXMgY29ycmVjdAotUEFTUyBTZWxlY3Rpb24gZGlyZWN0aW9uIGlzIGNv cnJlY3QuCi1QQVNTIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS50b1N0cmluZygpIGlzIGNvcnJlY3QK LVBBU1MgU2VsZWN0aW9uIGRpcmVjdGlvbiBpcyBjb3JyZWN0LgotUEFTUyB3aW5kb3cuZ2V0U2Vs ZWN0aW9uKCkudG9TdHJpbmcoKSBpcyBjb3JyZWN0Ci1QQVNTIFNlbGVjdGlvbiBkaXJlY3Rpb24g aXMgY29ycmVjdC4KLVBBU1Mgd2luZG93LmdldFNlbGVjdGlvbigpLnRvU3RyaW5nKCkgaXMgY29y cmVjdAotUEFTUyBTZWxlY3Rpb24gZGlyZWN0aW9uIGlzIGNvcnJlY3QuCi1QQVNTIHdpbmRvdy5n ZXRTZWxlY3Rpb24oKS50b1N0cmluZygpIGlzIGNvcnJlY3QKLUZBSUwgU2VsZWN0aW9uIGRpcmVj dGlvbiBpcyBub3QgY29ycmVjdC4gRXhwZWN0ZWQgYSBiYWNrd2FyZCBzZWxlY3Rpb24uW2FuY2hv ck5vZGU6IFtvYmplY3QgVGV4dF0odHdvIHRocmVlKSBhbmNob3JPZmZzZXQ6IDAgZm9jdXNOb2Rl OiBbb2JqZWN0IFRleHRdKHR3byB0aHJlZSkgZm9jdXNPZmZzZXQ6IDMgaXNDb2xsYXBzZWQ6IGZh bHNlXQotUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQotCi1URVNUIENPTVBMRVRFCi1v bmUgdHdvIHRocmVlCi1mb3VyIGZpdmUgc2l4Cg==