4523 2005-08-19 01:23:39 -0700 REGRESSION assertion failure in Window::getValueProperty accessing window.konqueror 2005-08-19 15:42:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore 420+ Mac OS X 10.4 VERIFIED FIXED javascript:window.konqueror P1 Normal --- 1 mitz darin oldest_to_newest 16993 0 mitz 2005-08-19 01:23:39 -0700 The 'konqueror' window property is not implemented in Window::getValueProperty, so it reaches the assert (0) at the end. 17002 1 3473 mitz 2005-08-19 13:03:08 -0700 Created attachment 3473 suggested patch Remove all traces of the konqueror property 17003 2 3473 darin 2005-08-19 13:14:10 -0700 Comment on attachment 3473 suggested patch Seems fine to do this. r=me 3473 2005-08-19 13:03:08 -0700 2005-08-19 13:14:10 -0700 suggested patch 4523_patch_r1.txt text/plain 4879 mitz SW5kZXg6IGtqc193aW5kb3cuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJD b3JlL2todG1sL2VjbWEva2pzX3dpbmRvdy5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTcy CmRpZmYgLXUgLXAgLXIxLjE3MiBranNfd2luZG93LmNwcAotLS0ga2pzX3dpbmRvdy5jcHAJMTYg QXVnIDIwMDUgMDQ6NDI6NDQgLTAwMDAJMS4xNzIKKysrIGtqc193aW5kb3cuY3BwCTE5IEF1ZyAy MDA1IDIwOjAwOjU0IC0wMDAwCkBAIC0xMzIsMTkgKzEzMiw2IEBAIG5hbWVzcGFjZSBLSlMgewog ICAgIFFHdWFyZGVkUHRyPEtIVE1MUGFydD4gcGFydDsKICAgfTsKIAotI2lmZGVmIFFfV1NfUVdT Ci0gIGNsYXNzIEtvbnF1ZXJvckZ1bmMgOiBwdWJsaWMgRE9NRnVuY3Rpb24gewotICBwdWJsaWM6 Ci0gICAgS29ucXVlcm9yRnVuYyhjb25zdCBLb25xdWVyb3IqIGssIGNvbnN0IGNoYXIqIG5hbWUp Ci0gICAgICA6IERPTUZ1bmN0aW9uKCksIGtvbnF1ZXJvcihrKSwgbV9uYW1lKG5hbWUpIHsgfQot ICAgIHZpcnR1YWwgVmFsdWVJbXAgKmNhbGxBc0Z1bmN0aW9uKEV4ZWNTdGF0ZSAqZXhlYywgT2Jq ZWN0SW1wICp0aGlzT2JqLCBjb25zdCBMaXN0ICZhcmdzKTsKLQotICBwcml2YXRlOgotICAgIGNv bnN0IEtvbnF1ZXJvcioga29ucXVlcm9yOwotICAgIFFDU3RyaW5nIG1fbmFtZTsKLSAgfTsKLSNl bmRpZgotCiB9CiAKICNpbmNsdWRlICJranNfd2luZG93Lmx1dC5oIgpAQCAtMjQ1LDcgKzIzMiw2 IEBAIGNvbnN0IENsYXNzSW5mbyBXaW5kb3c6OmluZm8gPSB7ICJXaW5kb3cKICAgbmFtZQkJV2lu ZG93OjpOYW1lCQlEb250RGVsZXRlCiAgIG5hdmlnYXRvcglXaW5kb3c6Ol9OYXZpZ2F0b3IJRG9u dERlbGV0ZXxSZWFkT25seQogICBjbGllbnRJbmZvcm1hdGlvbglXaW5kb3c6OkNsaWVudEluZm9y bWF0aW9uCURvbnREZWxldGV8UmVhZE9ubHkKLSAga29ucXVlcm9yCVdpbmRvdzo6X0tvbnF1ZXJv cglEb250RGVsZXRlfFJlYWRPbmx5CiAgIG1lbnViYXIJV2luZG93OjpNZW51YmFyCQlEb250RGVs ZXRlfFJlYWRPbmx5CiAgIG9mZnNjcmVlbkJ1ZmZlcmluZwlXaW5kb3c6Ok9mZnNjcmVlbkJ1ZmZl cmluZwlEb250RGVsZXRlfFJlYWRPbmx5CiAgIG9wZW5lcglXaW5kb3c6Ok9wZW5lcgkJRG9udERl bGV0ZXxSZWFkT25seQpAQCAtNzU3LDEwICs3NDMsNiBAQCBWYWx1ZUltcCAqV2luZG93OjpnZXRW YWx1ZVByb3BlcnR5KEV4ZWNTCiAgICAgICBjb25zdF9jYXN0PFdpbmRvdyAqPih0aGlzKS0+cHV0 RGlyZWN0KCJjbGllbnRJbmZvcm1hdGlvbiIsIG4sIERvbnREZWxldGV8UmVhZE9ubHkpOwogICAg ICAgcmV0dXJuIG47CiAgICAgfQotI2lmZGVmIFFfV1NfUVdTCi0gICAgY2FzZSBfS29ucXVlcm9y OgotICAgICAgcmV0dXJuIG5ldyBLb25xdWVyb3IobV9wYXJ0KTsKLSNlbmRpZgogICAgIGNhc2Ug TG9jYXRpb25iYXI6CiAgICAgICByZXR1cm4gbG9jYXRpb25iYXIoZXhlYyk7CiAgICAgY2FzZSBN ZW51YmFyOgpAQCAtMjgxNSw3MSArMjc5Nyw2IEBAIFZhbHVlSW1wICpIaXN0b3J5RnVuYzo6Y2Fs bEFzRnVuY3Rpb24oRXgKIAogLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KIAotI2lmZGVmIFFfV1NfUVdT Ci0KLWNvbnN0IENsYXNzSW5mbyBLb25xdWVyb3I6OmluZm8gPSB7ICJLb25xdWVyb3IiLCAwLCAw LCAwIH07Ci0KLWJvb2wgS29ucXVlcm9yOjpoYXNPd25Qcm9wZXJ0eShFeGVjU3RhdGUgKmV4ZWMs IGNvbnN0IElkZW50aWZpZXIgJnApIGNvbnN0Ci17Ci0gIGlmICggcC5xc3RyaW5nKCkuc3RhcnRz V2l0aCggImdvSGlzdG9yeSIgKSApIHJldHVybiBmYWxzZTsKLQotICByZXR1cm4gdHJ1ZTsKLX0K LQotVmFsdWVJbXAgKktvbnF1ZXJvcjo6Z2V0KEV4ZWNTdGF0ZSAqZXhlYywgY29uc3QgSWRlbnRp ZmllciAmcCkgY29uc3QKLXsKLSAgaWYgKCBwID09ICJnb0hpc3RvcnkiIHx8IHBhcnQtPnVybCgp LnByb3RvY29sKCkgIT0gImh0dHAiIHx8IHBhcnQtPnVybCgpLmhvc3QoKSAhPSAibG9jYWxob3N0 IiApCi0gICAgcmV0dXJuIFVuZGVmaW5lZCgpOwotCi0gIEtQYXJ0czo6QnJvd3NlckV4dGVuc2lv biAqZXh0ID0gcGFydC0+YnJvd3NlckV4dGVuc2lvbigpOwotICBpZiAoIGV4dCApIHsKLSAgICBL UGFydHM6OkJyb3dzZXJJbnRlcmZhY2UgKmlmYWNlID0gZXh0LT5icm93c2VySW50ZXJmYWNlKCk7 Ci0gICAgaWYgKCBpZmFjZSApIHsKLSAgICAgIFFWYXJpYW50IHByb3AgPSBpZmFjZS0+cHJvcGVy dHkoIHAucXN0cmluZygpLmxhdGluMSgpICk7Ci0KLSAgICAgIGlmICggcHJvcC5pc1ZhbGlkKCkg KSB7Ci0gICAgICAgIHN3aXRjaCggcHJvcC50eXBlKCkgKSB7Ci0gICAgICAgIGNhc2UgUVZhcmlh bnQ6OkludDoKLSAgICAgICAgICByZXR1cm4gTnVtYmVyKCBwcm9wLnRvSW50KCkgKTsKLSAgICAg ICAgY2FzZSBRVmFyaWFudDo6U3RyaW5nOgotICAgICAgICAgIHJldHVybiBTdHJpbmcoIHByb3At PnRvU3RyaW5nKCkgKTsKLSAgICAgICAgZGVmYXVsdDoKLSAgICAgICAgICBicmVhazsKLSAgICAg ICAgfQotICAgICAgfQotICAgIH0KLSAgfQotCi0gIHJldHVybiAvKkZ1bmN0aW9uKi8oIG5ldyBL b25xdWVyb3JGdW5jKHRoaXMsIHAucXN0cmluZygpLmxhdGluMSgpICkgKTsKLX0KLQotVmFsdWVJ bXAgKktvbnF1ZXJvckZ1bmM6OmNhbGxBc0Z1bmN0aW9uKEV4ZWNTdGF0ZSAqZXhlYywgT2JqZWN0 SW1wICosIGNvbnN0IExpc3QgJmFyZ3MpCi17Ci0gIEtQYXJ0czo6QnJvd3NlckV4dGVuc2lvbiAq ZXh0ID0ga29ucXVlcm9yLT5wYXJ0LT5icm93c2VyRXh0ZW5zaW9uKCk7Ci0KLSAgaWYoIWV4dCkK LSAgICByZXR1cm4gVW5kZWZpbmVkKCk7Ci0KLSAgS1BhcnRzOjpCcm93c2VySW50ZXJmYWNlICpp ZmFjZSA9IGV4dC0+YnJvd3NlckludGVyZmFjZSgpOwotCi0gIGlmICggIWlmYWNlICkKLSAgICBy ZXR1cm4gVW5kZWZpbmVkKCk7Ci0KLSAgUUNTdHJpbmcgbiA9IG1fbmFtZS5kYXRhKCk7Ci0gIG4g Kz0gIigpIjsKLSAgaWZhY2UtPmNhbGxNZXRob2QoIG4uZGF0YSgpLCBRVmFyaWFudCgpICk7Ci0K LSAgcmV0dXJuIFVuZGVmaW5lZCgpOwotfQotCi1VU3RyaW5nIEtvbnF1ZXJvcjo6dG9TdHJpbmco RXhlY1N0YXRlICopIGNvbnN0Ci17Ci0gIHJldHVybiBVU3RyaW5nKCJbb2JqZWN0IEtvbnF1ZXJv cl0iKTsKLX0KLQotI2VuZGlmCi0vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwotCiB9IC8vIG5hbWVzcGFj ZSBLSlMKIAogI2luY2x1ZGUgImtqc193aW5kb3cubW9jIgpJbmRleDoga2pzX3dpbmRvdy5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL2VjbWEva2pzX3dpbmRv dy5oLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjUwCmRpZmYgLXUgLXAgLXIxLjUwIGtqc193aW5k b3cuaAotLS0ga2pzX3dpbmRvdy5oCTggQXVnIDIwMDUgMDQ6MDc6NDIgLTAwMDAJMS41MAorKysg a2pzX3dpbmRvdy5oCTE5IEF1ZyAyMDA1IDIwOjAwOjU2IC0wMDAwCkBAIC0xMzksNyArMTM5LDcg QEAgbmFtZXNwYWNlIEtKUyB7CiAgICAgc3RhdGljIGNvbnN0IENsYXNzSW5mbyBpbmZvOwogICAg IGVudW0geyBDbG9zZWQsIENyeXB0bywgRGVmYXVsdFN0YXR1cywgU3RhdHVzLCBEb2N1bWVudCwg Tm9kZSwgRXZlbnRDdG9yLCBSYW5nZSwKICAgICAgICAgICAgTm9kZUZpbHRlciwgRE9NRXhjZXB0 aW9uLCBDU1NSdWxlLCBGcmFtZXMsIF9IaXN0b3J5LCBFdmVudCwgSW5uZXJIZWlnaHQsCi0gICAg ICAgICAgIElubmVyV2lkdGgsIExlbmd0aCwgX0xvY2F0aW9uLCBMb2NhdGlvbmJhciwgTmFtZSwg X05hdmlnYXRvciwgX0tvbnF1ZXJvciwgQ2xpZW50SW5mb3JtYXRpb24sCisgICAgICAgICAgIElu bmVyV2lkdGgsIExlbmd0aCwgX0xvY2F0aW9uLCBMb2NhdGlvbmJhciwgTmFtZSwgX05hdmlnYXRv ciwgQ2xpZW50SW5mb3JtYXRpb24sCiAgICAgICAgICAgIE1lbnViYXIsIE9mZnNjcmVlbkJ1ZmZl cmluZywgT3BlbmVyLCBPdXRlckhlaWdodCwgT3V0ZXJXaWR0aCwgUGFnZVhPZmZzZXQsIFBhZ2VZ T2Zmc2V0LAogICAgICAgICAgICBQYXJlbnQsIFBlcnNvbmFsYmFyLCBTY3JlZW5YLCBTY3JlZW5Z LCBTY3JvbGxiYXJzLCBTY3JvbGwsIFNjcm9sbEJ5LAogICAgICAgICAgICBTY3JlZW5Ub3AsIFNj cmVlbkxlZnQsCkBAIC0yNzYsMjAgKzI3Niw2IEBAIG5hbWVzcGFjZSBLSlMgewogICAgIFR5cGUg bV90eXBlOwogICB9OwogCi0jaWZkZWYgUV9XU19RV1MKLSAgY2xhc3MgS29ucXVlcm9yIDogcHVi bGljIE9iamVjdEltcCB7Ci0gICAgZnJpZW5kIGNsYXNzIEtvbnF1ZXJvckZ1bmM7Ci0gIHB1Ymxp YzoKLSAgICBLb25xdWVyb3IoS0hUTUxQYXJ0ICpwKSA6IHBhcnQocCkgeyB9Ci0gICAgdmlydHVh bCBib29sIGdldE93blByb3BlcnR5U2xvdChFeGVjU3RhdGUgKmV4ZWMsIGNvbnN0IElkZW50aWZp ZXImLCBQcm9wZXJ0eVNsb3QmIHNsb3QpIGNvbnN0OwotICAgIHZpcnR1YWwgVVN0cmluZyB0b1N0 cmluZyhFeGVjU3RhdGUgKmV4ZWMpIGNvbnN0OwotICAgIHZpcnR1YWwgY29uc3QgQ2xhc3NJbmZv KiBjbGFzc0luZm8oKSBjb25zdCB7IHJldHVybiAmaW5mbzsgfQotICAgIHN0YXRpYyBjb25zdCBD bGFzc0luZm8gaW5mbzsKLSAgcHJpdmF0ZToKLSAgICBLSFRNTFBhcnQgKnBhcnQ7Ci0gIH07Ci0j ZW5kaWYKLQogfSAvLyBuYW1lc3BhY2UKIAogI2VuZGlmCg==