45229 2010-09-04 11:20:11 -0700 GTK Skipped list should allow a directory to be listed when a feature is not supported 2010-09-04 17:20:52 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned abarth commit-queue eric jorlow webkit.review.bot zan oldest_to_newest 274369 0 steveblock 2010-09-04 11:20:11 -0700 Currently, the GTK Skipped list states that all tests should be listed explicitly, without grouping. We should make an exception for the case when an entire directory of tests is to be skipped due to the feature being unsupported. This eliminates the need to continually update the list when new tests for the feature are added. 274371 1 66585 steveblock 2010-09-04 11:22:34 -0700 Created attachment 66585 Patch 274388 2 66585 mrobinson 2010-09-04 14:11:16 -0700 Comment on attachment 66585 Patch LGTM. 274401 3 66585 commit-queue 2010-09-04 16:28:30 -0700 Comment on attachment 66585 Patch Clearing flags on attachment: 66585 Committed r66798: <http://trac.webkit.org/changeset/66798> 274402 4 commit-queue 2010-09-04 16:28:34 -0700 All reviewed patches have been landed. Closing bug. 274409 5 webkit.review.bot 2010-09-04 17:20:52 -0700 http://trac.webkit.org/changeset/66798 might have broken Qt Linux Release 66585 2010-09-04 11:22:34 -0700 2010-09-04 16:28:29 -0700 Patch bug-45229-20100904192232.patch text/plain 2242 steveblock SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY2Nzk2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDktMDQgIFN0ZXZlIEJsb2NrICA8c3Rl dmVibG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEdUSyBTa2lwcGVkIGxpc3Qgc2hvdWxkIGFsbG93IGEgZGlyZWN0b3J5IHRv IGJlIGxpc3RlZCB3aGVuIGEgZmVhdHVyZSBpcyBub3Qgc3VwcG9ydGVkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTIyOQorCisgICAgICAgIFRoaXMg Y2hhbmdlIHVwZGF0ZXMgdGhlIGNvbW1lbnQgaW4gdGhlIEdUSyBTa2lwcGVkIGxpc3QgdG8gbWFr ZSB0aGlzCisgICAgICAgIGNsZWFyIGFuZCBhcHBsaWVzIHRoZSBuZXcgcG9saWN5IGZvciB0aGUg RGV2aWNlT3JpZW50YXRpb24gYW5kCisgICAgICAgIERldmljZU1vdGlvbiB0ZXN0cy4KKworICAg ICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lwcGVkOgorCiAyMDEwLTA5LTA0ICBKdXN0aW4gU2NodWgg IDxqc2NodWhAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEJ1aWxkIGZpeC4K SW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCShyZXZpc2lvbiA2NjczNCkKKysrIExheW91 dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC0xLDcgKzEsOSBA QAogIyBXZSBzaG91bGQga2VlcCB0aGUgdGVzdHMgbGlzdGVkIGluIHRoZSBzYW1lIG9yZGVyIGFz IHRoZXkgYXBwZWFyIGluIHRoZSBvdXRwdXQuCiAjIFRoaXMgbWFrZXMgaXQgZWFzaWVyIHRvIGxv b2sgZm9yIGRpZmZlcmVuY2VzIG9uIHRoZSBhY3R1YWwgb3V0cHV0IGFuZAogIyB3aGF0IHRoZSBz a2lwIGxpc3QgY29udGFpbnMuCi0jIEFsc28sIG5vIGdyb3VwaW5nIHNob3VsZCBvY2N1ci4gRXZl cnkgdGVzdCBmb3IgaXRzZWxmLgorIyBBbHNvLCBubyBncm91cGluZyBzaG91bGQgb2NjdXIuIEV2 ZXJ5IHRlc3QgZm9yIGl0c2VsZi4gQW4gZXhjZXB0aW9uIGlzIHdoZW4KKyMgYW4gZW50aXJlIGRp cmVjdG9yeSBvZiB0ZXN0cyBpcyB0byBiZSBza2lwcGVkIGR1ZSB0byB0aGUgZmVhdHVyZSBiZWlu ZworIyB1bnN1cHBvcnRlZC4KICMKICMgWW91IGNhbiBnZXQgYSBsaXN0IG9mIGFjdHVhbCBmYWls ZWQvdGltZWQgb3V0L2NyYXNoZWQvbmV3IHRlc3RzIGJ5IHBpcGluZwogIyB0aGUgb3V0cHV0IG9m IHJ1bm5pbmcgdGhlIHRlc3RzIHRvIHRoaXMgY29tbWFuZDoKQEAgLTEwODUsMTMgKzEwODcsOCBA QCBmYXN0L2RvbS9jbGllbnQtd2lkdGgtaGVpZ2h0LXF1aXJrcy5odG1sCiBmYXN0L2RvbS9jbGll bnQtd2lkdGgtaGVpZ2h0Lmh0bWwKIGZhc3QvZG9tL2Nzc1RhcmdldC1jcmFzaC5odG1sCiBmYXN0 L2RvbS9mcmFtZS1sb2FkaW5nLXZpYS1kb2N1bWVudC13cml0ZS5odG1sCi1mYXN0L2RvbS9EZXZp Y2VNb3Rpb24vY3JlYXRlLWV2ZW50Lmh0bWwKLWZhc3QvZG9tL0RldmljZU1vdGlvbi9vcHRpb25h bC1ldmVudC1wcm9wZXJ0aWVzLmh0bWwKLWZhc3QvZG9tL0RldmljZU1vdGlvbi93aW5kb3ctcHJv cGVydHkuaHRtbAotZmFzdC9kb20vRGV2aWNlT3JpZW50YXRpb24vYmFzaWMtb3BlcmF0aW9uLmh0 bWwKLWZhc3QvZG9tL0RldmljZU9yaWVudGF0aW9uL2NyZWF0ZS1ldmVudC5odG1sCi1mYXN0L2Rv bS9EZXZpY2VPcmllbnRhdGlvbi9vcHRpb25hbC1ldmVudC1wcm9wZXJ0aWVzLmh0bWwKLWZhc3Qv ZG9tL0RldmljZU9yaWVudGF0aW9uL3dpbmRvdy1wcm9wZXJ0eS5odG1sCitmYXN0L2RvbS9EZXZp Y2VNb3Rpb24KK2Zhc3QvZG9tL0RldmljZU9yaWVudGF0aW9uCiBmYXN0L2RvbS9HZW9sb2NhdGlv bi9jYWxsYmFjay1leGNlcHRpb24uaHRtbAogZmFzdC9kb20vR2VvbG9jYXRpb24vZGVsYXllZC1w ZXJtaXNzaW9uLWFsbG93ZWQuaHRtbAogZmFzdC9kb20vR2VvbG9jYXRpb24vZGVsYXllZC1wZXJt aXNzaW9uLWRlbmllZC5odG1sCg==