45204 2010-09-03 14:49:28 -0700 Add AudioArray.h 2010-09-07 17:48:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 crogers webkit-unassigned cmarrin dglazkov eric.carlson japhet jer.noble kbr simon.fraser oldest_to_newest 274192 0 crogers 2010-09-03 14:49:28 -0700 Add AudioArray.h 274193 1 66547 crogers 2010-09-03 14:50:42 -0700 Created attachment 66547 Patch 275432 2 66547 kbr 2010-09-07 17:30:22 -0700 Comment on attachment 66547 Patch Looks good to me. One comment not necessarily requiring action. View in context: https://bugs.webkit.org/attachment.cgi?id=66547&action=prettypatch > WebCore/platform/audio/AudioArray.h:55 > + void copyToRange(T* sourceData, unsigned start, unsigned end) If you have situations elsewhere in your code where you would pass e.g. AudioFloatArray.data() as the first argument to copyToRange, then it would be good to add another overloaded version of copyToRange which can also verify that the source array has enough elements to cover the copy operation. 275462 3 66547 crogers 2010-09-07 17:48:37 -0700 Comment on attachment 66547 Patch Clearing flags on attachment: 66547 Committed r66938: <http://trac.webkit.org/changeset/66938> 275463 4 crogers 2010-09-07 17:48:43 -0700 All reviewed patches have been landed. Closing bug. 66547 2010-09-03 14:50:42 -0700 2010-09-07 17:48:37 -0700 Patch bug-45204-20100903145040.patch text/plain 3615 crogers SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Njc3MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDktMDMgIENocmlzIFJvZ2VycyAgPGNyb2dlcnNAZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgQXVkaW9BcnJheS5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NTIwNAorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSBhdWRpbyBBUEkgaXMg bm90IHlldCBpbXBsZW1lbnRlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2F1ZGlvL0F1ZGlvQXJy YXkuaDogQWRkZWQuCisgICAgICAgIChXZWJDb3JlOjpBdWRpb0FycmF5OjpBdWRpb0FycmF5KToK KyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvQXJyYXk6Onplcm8pOgorICAgICAgICAoV2ViQ29yZTo6 QXVkaW9BcnJheTo6emVyb1JhbmdlKToKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvQXJyYXk6OmNv cHlUb1JhbmdlKToKKwogMjAxMC0wOS0wMyAgRG9taW5pYyBDb29uZXkgIDxkb21pbmljY0Bnb29n bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBXZWJDb3Jl L3BsYXRmb3JtL2F1ZGlvL0F1ZGlvQXJyYXkuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRm b3JtL2F1ZGlvL0F1ZGlvQXJyYXkuaAkocmV2aXNpb24gMCkKKysrIFdlYkNvcmUvcGxhdGZvcm0v YXVkaW8vQXVkaW9BcnJheS5oCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDcxIEBACisvKgorICog Q29weXJpZ2h0IChDKSAyMDEwIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKgor ICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0 aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhh dCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6CisgKgorICogMS4gIFJlZGlz dHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0 CisgKiAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2lu ZyBkaXNjbGFpbWVyLgorICogMi4gIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0 IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICAgbm90aWNlLCB0aGlzIGxpc3Qg b2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQorICogICAg IGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBk aXN0cmlidXRpb24uCisgKiAzLiAgTmVpdGhlciB0aGUgbmFtZSBvZiBBcHBsZSBDb21wdXRlciwg SW5jLiAoIkFwcGxlIikgbm9yIHRoZSBuYW1lcyBvZgorICogICAgIGl0cyBjb250cmlidXRvcnMg bWF5IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQKKyAqICAg ICBmcm9tIHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1p c3Npb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBBTkQgSVRT IENPTlRSSUJVVE9SUyAiQVMgSVMiIEFORCBBTlkKKyAqIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJS QU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhFIElNUExJRUQKKyAqIFdB UlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIg UFVSUE9TRSBBUkUKKyAqIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIE9SIElU UyBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkKKyAqIERJUkVDVCwgSU5ESVJFQ1QsIElO Q0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTCisg KiAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRV VEUgR09PRFMgT1IgU0VSVklDRVM7CisgKiBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsg T1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQKKyAqIE9OIEFOWSBU SEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZ LCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5H IElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UgT0YKKyAqIFRISVMgU09GVFdBUkUsIEVWRU4gSUYg QURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKworI2lmbmRl ZiBBdWRpb0FycmF5X2gKKyNkZWZpbmUgQXVkaW9BcnJheV9oCisKKyNpbmNsdWRlIDxzdHJpbmcu aD4KKyNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CisKK25hbWVzcGFjZSBXZWJDb3JlIHsKKwordGVt cGxhdGU8dHlwZW5hbWUgVD4KK2NsYXNzIEF1ZGlvQXJyYXkgOiBwdWJsaWMgVmVjdG9yPFQ+IHsK K3B1YmxpYzoKKyAgICBBdWRpb0FycmF5KCkgOiBWZWN0b3I8VD4oMCkgeyB9CisgICAgZXhwbGlj aXQgQXVkaW9BcnJheShzaXplX3QgbikgOiBWZWN0b3I8VD4obiwgMCkgeyB9CisKKyAgICB2b2lk IHplcm8oKSB7IG1lbXNldCh0aGlzLT5kYXRhKCksIDAsIHNpemVvZihUKSAqIHRoaXMtPnNpemUo KSk7IH0KKworICAgIHZvaWQgemVyb1JhbmdlKHVuc2lnbmVkIHN0YXJ0LCB1bnNpZ25lZCBlbmQp CisgICAgeworICAgICAgICBib29sIGlzU2FmZSA9IChzdGFydCA8PSBlbmQpICYmIChlbmQgPD0g dGhpcy0+c2l6ZSgpKTsKKyAgICAgICAgQVNTRVJUKGlzU2FmZSk7CisgICAgICAgIGlmICghaXNT YWZlKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIG1lbXNldCh0aGlzLT5kYXRhKCkg KyBzdGFydCwgMCwgc2l6ZW9mKFQpICogKGVuZCAtIHN0YXJ0KSk7CisgICAgfQorCisgICAgdm9p ZCBjb3B5VG9SYW5nZShUKiBzb3VyY2VEYXRhLCB1bnNpZ25lZCBzdGFydCwgdW5zaWduZWQgZW5k KQorICAgIHsKKyAgICAgICAgYm9vbCBpc1NhZmUgPSAoc3RhcnQgPD0gZW5kKSAmJiAoZW5kIDw9 IHRoaXMtPnNpemUoKSk7CisgICAgICAgIEFTU0VSVChpc1NhZmUpOworICAgICAgICBpZiAoIWlz U2FmZSkKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICBtZW1jcHkodGhpcy0+ZGF0YSgp ICsgc3RhcnQsIHNvdXJjZURhdGEsIHNpemVvZihUKSAqIChlbmQgLSBzdGFydCkpOworICAgIH0K K307CisKK3R5cGVkZWYgQXVkaW9BcnJheTxmbG9hdD4gQXVkaW9GbG9hdEFycmF5OwordHlwZWRl ZiBBdWRpb0FycmF5PGRvdWJsZT4gQXVkaW9Eb3VibGVBcnJheTsKKworfSAvLyBXZWJDb3JlCisK KyNlbmRpZiAvLyBBdWRpb0FycmF5X2gK